Merge lp:~powersj/utah/remove_cdromupgrade into lp:utah

[Joshua Powers]

static validation: remove cdromupgrade

For releases in quantal and newer the cdromupgrade di file is not
present. Because we have gone around the alphabet this check
is no longer working and is no longer useful as no releases that
are tested even have it anymore. This removes the exclusion list
and removes cdromupgrade from the list of things to look for.

LP: #1686779

[Paul Larson (pwlars)]

Looks good, +1

review: Approve

=== modified file 'utah/isotest/data/file_list_di'
--- utah/isotest/data/file_list_di	2012-11-16 19:27:27 +0000
+++ utah/isotest/data/file_list_di	2017-04-27 16:25:23 +0000
@@ -1,5 +1,4 @@
 boot
-cdromupgrade
 .disk
 dists
 doc
 
=== modified file 'utah/isotest/iso_static_validation.py'
--- utah/isotest/iso_static_validation.py	2016-12-23 15:01:36 +0000
+++ utah/isotest/iso_static_validation.py	2017-04-27 16:25:23 +0000
@@ -354,18 +354,10 @@
         else:  # i386 or amd64
             files_list = open(os.path.join(DATA_PATH, 'file_list_di'))
 
-        exclude_files = []
-        if self.st_release >= 'q':
-            # cdromupgrade is not shipped in quantal
-            exclude_files.append('cdromupgrade')
-
         for list_server in files_list:
             logging.debug('check if important d-i files are present in iso')
             path = list_server.rstrip()
-            if path in exclude_files:
-                logging.debug('%s excluded based on release', path)
-            else:
-                self.assertIn(path, stdout)
+            self.assertIn(path, stdout)
 
     @unittest.skipIf(st_arch in ['powerpc', 'ppc64el'],
                          "vmlinuz is not present only for powerpc images")