Merge ~pieq/plainbox-provider-certification-client:fix1715592-touchpad-jobs into plainbox-provider-certification-client:master

Proposed by Pierre Equoy
Status: Merged
Approved by: Sylvain Pineau
Approved revision: c8e4bba6c3885fa57f84b0b666952a472c7101fd
Merged at revision: 4e376a2eec2ed3e59c95c161014d443c5c7bc821
Proposed branch: ~pieq/plainbox-provider-certification-client:fix1715592-touchpad-jobs
Merge into: plainbox-provider-certification-client:master
Diff against target: 116 lines (+104/-0)
2 files modified
launcher/checkbox-touchpad (+16/-0)
units/touchpad.pxu (+88/-0)
Reviewer Review Type Date Requested Status
Maciej Kisielewski Needs Information
Sylvain Pineau (community) Approve
Review via email: mp+330891@code.launchpad.net

Description of the change

Test plan and launcher for Touchpad-related tests.

To test, run the `checkbox-touchpad` launcher. It's an automatic one that will select and run the touchpad.pxu test plan and save the submission files on disk.

This MR requires the following changes in the Checkox provider:

https://code.launchpad.net/~pierre-equoy/plainbox-provider-checkbox/+git/plainbox-provider-checkbox/+merge/330890

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Looks good to me, +1

review: Approve
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

Why the resource-y jobs are in include instead of the boostrap_include?

review: Needs Information
Revision history for this message
Pierre Equoy (pieq) wrote :

Good question. This test plan is based off the Certification Client test plan. I was actually wondering whether or not to keep these jobs and decided to leave them there (instead of deleting them completely) in order to gather more information in the final submission file that could be useful for us to investigate issues when an OEM reports problems when testing touchpads using Checkbox and this test plan.

If you think a rework is needed for this, we should do it and also "backport" these changes into the Cert Client test plan.

Revision history for this message
Maciej Kisielewski (kissiel) wrote :

I don't think rework is necessary, I just wanted to understand why it's that way. Thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/launcher/checkbox-touchpad b/launcher/checkbox-touchpad
0new file mode 1007550new file mode 100755
index 0000000..01b70ce
--- /dev/null
+++ b/launcher/checkbox-touchpad
@@ -0,0 +1,16 @@
1#!/usr/bin/env checkbox-cli
2#
3# This Checkbox launcher automatically selects and run touchpad-related jobs
4# and saves the submission files for later analysis.
5
6[launcher]
7app_id = com.canonical.certification:touchpad
8launcher_version = 1
9stock_reports = text, submission_files
10
11[test plan]
12unit = com.canonical.certification::touchpad
13forced = yes
14
15[test selection]
16forced = yes
diff --git a/units/touchpad.pxu b/units/touchpad.pxu
0new file mode 10064417new file mode 100644
index 0000000..a3f362f
--- /dev/null
+++ b/units/touchpad.pxu
@@ -0,0 +1,88 @@
1id: touchpad
2_name: Touchpad Tests
3unit: test plan
4_description:
5 This test plan is used for customers and independent hardware vendors (IHV)
6 to test and verify the behavior of touchpads on tested devices.
7include:
8 # Resource Jobs (Not used by templates jobs)
9 block_device
10 cdimage
11 cpuinfo
12 dmi
13 dpkg
14 efi
15 environment
16 lsb
17 meminfo
18 module
19 package
20 rtc
21 sleep
22 uname
23 usb
24 xinput
25 # END Resource Jobs
26 touchpad/basic certification-status=blocker
27 touchpad/detected-as-mouse certification-status=blocker
28 touchpad/palm-rejection certification-status=non-blocker
29 touchpad/continuous-move certification-status=blocker
30 touchpad/horizontal certification-status=blocker
31 touchpad/vertical certification-status=blocker
32 touchpad/singletouch-automated certification-status=blocker
33 touchpad/singletouch-selection certification-status=blocker
34 touchpad/drag-and-drop certification-status=blocker
35 touchpad/multitouch-automated certification-status=blocker
36 touchpad/multitouch-manual certification-status=blocker
37 touchpad/multitouch-rightclick certification-status=blocker
38 touchpad/multitouch-horizontal certification-status=blocker
39 touchpad/multitouch-vertical certification-status=blocker
40 touchpad/multitouch-dash certification-status=non-blocker
41 # Touchpad tests after suspend
42 touchpad/basic-after-suspend certification-status=blocker
43 touchpad/detected-as-mouse-after-suspend certification-status=blocker
44 touchpad/palm-rejection-after-suspend certification-status=non-blocker
45 touchpad/continuous-move-after-suspend certification-status=blocker
46 touchpad/horizontal-after-suspend certification-status=blocker
47 touchpad/vertical-after-suspend certification-status=blocker
48 touchpad/singletouch-automated-after-suspend certification-status=blocker
49 touchpad/singletouch-selection-after-suspend certification-status=blocker
50 touchpad/drag-and-drop-after-suspend certification-status=blocker
51 touchpad/multitouch-automated-after-suspend certification-status=blocker
52 touchpad/multitouch-manual-after-suspend certification-status=blocker
53 touchpad/multitouch-rightclick-after-suspend certification-status=blocker
54 touchpad/multitouch-horizontal-after-suspend certification-status=blocker
55 touchpad/multitouch-vertical-after-suspend certification-status=blocker
56 touchpad/multitouch-dash-after-suspend certification-status=non-blocker
57 #Info attachment jobs
58 codecs_attachment
59 cpuinfo_attachment
60 dmesg_attachment
61 dmi_attachment
62 dmidecode_attachment
63 efi_attachment
64 lspci_attachment
65 lspci_standard_config_attachment
66 lsusb_attachment
67 kernel_cmdline_attachment
68 meminfo_attachment
69 modinfo_attachment
70 modprobe_attachment
71 modules_attachment
72 sysctl_attachment
73 sysfs_attachment
74 udev_attachment
75 recovery_info_attachment
76 dell_bto_xml_attachment
77 lsmod_attachment
78 dkms_info_attachment
79 acpi_sleep_attachment
80 info/hdparm_.*.txt
81 installer_debug.gz
82 info/touchpad_driver
83 info/disk_partitions
84bootstrap_include:
85 device
86mandatory_include:
87 # Meta-job to include required resources, don't remove.
88 miscellanea/submission-resources

Subscribers

People subscribed via source and target branches