Merge lp:~phablet-team/mtp/fix-upstart-handling into lp:mtp
Proposed by
Ricardo Salveti
Status: | Merged |
---|---|
Approved by: | Ricardo Salveti |
Approved revision: | 69 |
Merge reported by: | Mathieu Trudel-Lapierre |
Merged at revision: | not available |
Proposed branch: | lp:~phablet-team/mtp/fix-upstart-handling |
Merge into: | lp:mtp |
Diff against target: |
85 lines (+12/-30) 5 files modified
debian/changelog (+10/-0) debian/mtp-server.conf (+2/-3) debian/mtp-server.install (+0/-1) debian/mtp-server.mtp-state.upstart (+0/-18) debian/rules (+0/-8) |
To merge this branch: | bzr merge lp:~phablet-team/mtp/fix-upstart-handling |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ricardo Salveti (community) | Approve | ||
Mathieu Trudel-Lapierre | Pending | ||
PS Jenkins bot | continuous-integration | Pending | |
Review via email: mp+252658@code.launchpad.net |
This proposal supersedes a proposal from 2015-03-11.
Commit message
fix the upstart job of mtp-server to make it start again
drop all mtp-state handling, we start/stop the server directly from udev events via the usb-service shipped in lxc-android-config now
Description of the change
fix the upstart job of mtp-server to make it start again
drop all mtp-state handling, we start/stop the server directly from udev events via the usb-service shipped in lxc-android-config now
To post a comment you must log in.
I took a glance at the lxc-android-config and it seems like a neat approach.
And given that there are start and stop stanzas there, do we need upstart jobs at all here?
Also, since I can't review lxc-android-config; there seems to be no locking and wait_for_greeter blocks for mtp at least, so you might have a situation of multiple calls causing races. Should be lock/mutex the binary call?