Merge lp:~peter-pearse/ubuntu/natty/libxcb/prop001 into lp:ubuntu/natty/libxcb

Proposed by Peter Pearse
Status: Needs review
Proposed branch: lp:~peter-pearse/ubuntu/natty/libxcb/prop001
Merge into: lp:ubuntu/natty/libxcb
Diff against target: 31 lines (+11/-0)
2 files modified
debian/changelog (+6/-0)
debian/rules (+5/-0)
To merge this branch: bzr merge lp:~peter-pearse/ubuntu/natty/libxcb/prop001
Reviewer Review Type Date Requested Status
Steve Langasek Pending
Review via email: mp+56775@code.launchpad.net

Description of the change

Empty target rules will match pattern rules - make sure the rule here isn't empty.

To post a comment you must log in.

Unmerged revisions

26. By Peter Pearse

Prevent call to pattern rule when check target is empty.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2011-03-28 23:00:11 +0000
+++ debian/changelog 2011-04-07 14:00:11 +0000
@@ -1,3 +1,9 @@
1libxcb (1.7-2ubuntu3) natty; urgency=low
2
3 * Prevent call to pattern rule when check target is empty
4
5 -- Peter Pearse <peter.pearse@linaro.org> Thu, 07 Apr 2011 11:56:16 +0000
6
1libxcb (1.7-2ubuntu2) natty; urgency=low7libxcb (1.7-2ubuntu2) natty; urgency=low
28
3 * Install udeb contents to /usr/lib, not to the multiarch directory.9 * Install udeb contents to /usr/lib, not to the multiarch directory.
410
=== modified file 'debian/rules'
--- debian/rules 2011-03-22 08:18:22 +0000
+++ debian/rules 2011-04-07 14:00:11 +0000
@@ -23,8 +23,13 @@
23 dh_auto_configure -B$(DEB_BUILDDIR) -- CFLAGS="$(CFLAGS)"23 dh_auto_configure -B$(DEB_BUILDDIR) -- CFLAGS="$(CFLAGS)"
2424
25check:25check:
26 @echo "Get this one"
26ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))27ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
27 $(MAKE) -C $(DEB_BUILDDIR) check28 $(MAKE) -C $(DEB_BUILDDIR) check
29else
30 # In order to avoid calling the pattern rule below
31 # there needs to always be some action in this rule
32 @echo "DEB_BUILD_OPTIONS has nocheck"
28endif33endif
2934
30override_dh_auto_test: check35override_dh_auto_test: check

Subscribers

People subscribed via source and target branches

to all changes: