Merge lp:~percona-dev/percona-server/5.5.11-fix-bug-764152 into lp:~percona-dev/percona-server/5.5.11

Proposed by Oleg Tsarev
Status: Merged
Merge reported by: Alexey Kopytov
Merged at revision: not available
Proposed branch: lp:~percona-dev/percona-server/5.5.11-fix-bug-764152
Merge into: lp:~percona-dev/percona-server/5.5.11
Diff against target: 58 lines (+17/-6)
2 files modified
mysql-test.diff (+16/-5)
series (+1/-1)
To merge this branch: bzr merge lp:~percona-dev/percona-server/5.5.11-fix-bug-764152
Reviewer Review Type Date Requested Status
Percona developers Pending
Valentine Gostev Pending
Review via email: mp+58673@code.launchpad.net

Description of the change

The mysql-test-run.pl script introduce variable "MYSQL_LIBDIR" as "$basedir/lib"
Sometime we install libs to "/usr/lib64"
For this trouble fix our patch mysql-test.diff change string:
  --replace_result $MYSQL_LIBDIR MYSQL_LIBDIR /mysql/ /
to
  --replace_result $MYSQL_LIBDIR MYSQL_LIBDIR MYSQL_LIBDIR64 MYSQL_LIBDIR /mysql/ /
But this is not work. First sibstuation "$MYSQL_LIBDIR MYSQL_LIBDIR" replaces "/usr/lib64/..." to "MYSQL_LIBDIR64/...", but second sibstiation "MYSQL_LIBDIR64 MYSQL_LIBDIR" doesn't applies to result string.
In other word, "--replace_result" sibstuates string independ each from other.
I add variable "$MYSQL_LIBDIR64" and this work fine.

To post a comment you must log in.
112. By Oleg Tsarev

remove excess patch

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'mysql-test.diff'
--- mysql-test.diff 2011-04-09 15:20:23 +0000
+++ mysql-test.diff 2011-04-21 16:12:26 +0000
@@ -1276,6 +1276,17 @@
1276+++ b/mysql-test/suite/sys_vars/t/optimizer_fix_basic.test 2011-04-09 18:49:05.000000000 +04001276+++ b/mysql-test/suite/sys_vars/t/optimizer_fix_basic.test 2011-04-09 18:49:05.000000000 +0400
1277@@ -0,0 +1 @@1277@@ -0,0 +1 @@
1278+SELECT @@global.optimizer_fix;1278+SELECT @@global.optimizer_fix;
1279diff -ruN a/mysql-test/mysql-test-run.pl b/mysql-test/mysql-test-run.pl
1280--- a/mysql-test/mysql-test-run.pl 2011-03-31 16:36:18.000000000 +0300
1281+++ b/mysql-test/mysql-test-run.pl 2011-04-21 16:16:06.459164480 +0300
1282@@ -2181,6 +2181,7 @@
1283 $ENV{'DEFAULT_MASTER_PORT'}= $mysqld_variables{'port'};
1284 $ENV{'MYSQL_TMP_DIR'}= $opt_tmpdir;
1285 $ENV{'MYSQLTEST_VARDIR'}= $opt_vardir;
1286+ $ENV{'MYSQL_LIBDIR64'}= "$basedir/lib64";
1287 $ENV{'MYSQL_LIBDIR'}= "$basedir/lib";
1288 $ENV{'MYSQL_BINDIR'}= "$bindir";
1289 $ENV{'MYSQL_SHAREDIR'}= $path_language;
1279diff -ruN a/mysql-test/suite/sys_vars/t/plugin_dir_basic.test b/mysql-test/suite/sys_vars/t/plugin_dir_basic.test1290diff -ruN a/mysql-test/suite/sys_vars/t/plugin_dir_basic.test b/mysql-test/suite/sys_vars/t/plugin_dir_basic.test
1280--- a/mysql-test/suite/sys_vars/t/plugin_dir_basic.test 2011-04-09 18:48:03.000000000 +04001291--- a/mysql-test/suite/sys_vars/t/plugin_dir_basic.test 2011-04-09 18:48:03.000000000 +0400
1281+++ b/mysql-test/suite/sys_vars/t/plugin_dir_basic.test 2011-04-09 18:49:05.000000000 +04001292+++ b/mysql-test/suite/sys_vars/t/plugin_dir_basic.test 2011-04-09 18:49:05.000000000 +0400
@@ -1284,21 +1295,21 @@
1284 # on unix it's <basedir>/lib/mysql/plugin1295 # on unix it's <basedir>/lib/mysql/plugin
1285 #1296 #
1286---replace_result $MYSQL_LIBDIR MYSQL_LIBDIR /mysql/ /1297---replace_result $MYSQL_LIBDIR MYSQL_LIBDIR /mysql/ /
1287+--replace_result $MYSQL_LIBDIR MYSQL_LIBDIR MYSQL_LIBDIR64 MYSQL_LIBDIR /mysql/ /1298+--replace_result $MYSQL_LIBDIR64 MYSQL_LIBDIR $MYSQL_LIBDIR MYSQL_LIBDIR /mysql/ /
1288 select @@global.plugin_dir;1299 select @@global.plugin_dir;
1289 --error ER_INCORRECT_GLOBAL_LOCAL_VAR1300 --error ER_INCORRECT_GLOBAL_LOCAL_VAR
1290 select @@session.plugin_dir;1301 select @@session.plugin_dir;
1291---replace_result $MYSQL_LIBDIR MYSQL_LIBDIR /mysql/ /1302---replace_result $MYSQL_LIBDIR MYSQL_LIBDIR /mysql/ /
1292+--replace_result $MYSQL_LIBDIR MYSQL_LIBDIR MYSQL_LIBDIR64 MYSQL_LIBDIR /mysql/ /1303+--replace_result $MYSQL_LIBDIR64 MYSQL_LIBDIR $MYSQL_LIBDIR MYSQL_LIBDIR /mysql/ /
1293 show global variables like 'plugin_dir';1304 show global variables like 'plugin_dir';
1294---replace_result $MYSQL_LIBDIR MYSQL_LIBDIR /mysql/ /1305---replace_result $MYSQL_LIBDIR MYSQL_LIBDIR /mysql/ /
1295+--replace_result $MYSQL_LIBDIR MYSQL_LIBDIR MYSQL_LIBDIR64 MYSQL_LIBDIR /mysql/ /1306+--replace_result $MYSQL_LIBDIR64 MYSQL_LIBDIR $MYSQL_LIBDIR MYSQL_LIBDIR /mysql/ /
1296 show session variables like 'plugin_dir';1307 show session variables like 'plugin_dir';
1297---replace_result $MYSQL_LIBDIR MYSQL_LIBDIR /mysql/ /1308---replace_result $MYSQL_LIBDIR MYSQL_LIBDIR /mysql/ /
1298+--replace_result $MYSQL_LIBDIR MYSQL_LIBDIR MYSQL_LIBDIR64 MYSQL_LIBDIR /mysql/ /1309+--replace_result $MYSQL_LIBDIR64 MYSQL_LIBDIR $MYSQL_LIBDIR MYSQL_LIBDIR /mysql/ /
1299 select * from information_schema.global_variables where variable_name='plugin_dir';1310 select * from information_schema.global_variables where variable_name='plugin_dir';
1300---replace_result $MYSQL_LIBDIR MYSQL_LIBDIR /mysql/ /1311---replace_result $MYSQL_LIBDIR MYSQL_LIBDIR /mysql/ /
1301+--replace_result $MYSQL_LIBDIR MYSQL_LIBDIR MYSQL_LIBDIR64 MYSQL_LIBDIR /mysql/ /1312+--replace_result $MYSQL_LIBDIR64 MYSQL_LIBDIR $MYSQL_LIBDIR MYSQL_LIBDIR /mysql/ /
1302 select * from information_schema.session_variables where variable_name='plugin_dir';1313 select * from information_schema.session_variables where variable_name='plugin_dir';
1303 1314
1304 #1315 #
13051316
=== modified file 'series'
--- series 2011-04-20 08:51:02 +0000
+++ series 2011-04-21 16:12:26 +0000
@@ -47,4 +47,4 @@
47innodb_expand_fast_index_creation.patch47innodb_expand_fast_index_creation.patch
48mysql-test.diff48mysql-test.diff
49innodb_bug60788.patch49innodb_bug60788.patch
5050bug758934.patch

Subscribers

People subscribed via source and target branches