Merge lp:~paulliu/unity8/lp1378469_MessageMenu into lp:unity8
Proposed by
Ying-Chun Liu
Status: | Rejected |
---|---|
Rejected by: | Nick Dedekind |
Proposed branch: | lp:~paulliu/unity8/lp1378469_MessageMenu |
Merge into: | lp:unity8 |
Diff against target: |
96 lines (+20/-0) 4 files modified
qml/Panel/IndicatorPage.qml (+12/-0) qml/Panel/Indicators/MessageMenuItemFactory.qml (+2/-0) qml/Panel/IndicatorsMenu.qml (+1/-0) qml/Panel/MenuContent.qml (+5/-0) |
To merge this branch: | bzr merge lp:~paulliu/unity8/lp1378469_MessageMenu |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Nick Dedekind (community) | Needs Fixing | ||
Unity Team | Pending | ||
Review via email: mp+244164@code.launchpad.net |
Commit message
Auto hide the indicators menu when last message is replied. (LP: 1378469)
Description of the change
* Are there any related MPs required for this MP to build/function as expected? Please list.
No.
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes.
* Did you make sure that your branch does not contain spurious tags?
Yes.
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
To post a comment you must log in.
Unmerged revisions
- 1462. By Ying-Chun Liu
-
Use signal to handle the hide event.
- 1461. By Ying-Chun Liu
-
Fix bugs
- 1460. By Ying-Chun Liu
-
Message replied then auto-close.
Hm. i'd rather use a signal from the Factory to close the indicator rather than calling hide directly.
We used to have this feature when clicking buttons/etc in the indicator. Take a look at revision 585.