Merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba

Proposed by Paul J. Lucas
Status: Merged
Approved by: William Candillon
Approved revision: 11232
Merged at revision: 11488
Proposed branch: lp:~paul-lucas/zorba/pjl-misc
Merge into: lp:zorba
Diff against target: 68 lines (+7/-4)
4 files modified
src/diagnostics/dict.h (+4/-1)
src/runtime/full_text/ft_module_impl.cpp (+1/-1)
src/store/naive/item_vector.cpp (+1/-1)
src/util/uri_util.h (+1/-1)
To merge this branch: bzr merge lp:~paul-lucas/zorba/pjl-misc
Reviewer Review Type Date Requested Status
William Candillon Approve
Paul J. Lucas Approve
Review via email: mp+166601@code.launchpad.net

Commit message

Removed erroneous (?) ZORBA_ASSERT.
Other minor fixes.

Description of the change

Removed erroneous (?) ZORBA_ASSERT.
Other minor fixes.

To post a comment you must log in.
Revision history for this message
Paul J. Lucas (paul-lucas) :
review: Approve
lp:~paul-lucas/zorba/pjl-misc updated
11230. By Paul J. Lucas

Fixed incorrect use of +.

11231. By Paul J. Lucas

Added enable_if.

11232. By Paul J. Lucas

Merge from trunk.

Revision history for this message
William Candillon (wcandillon) :
review: Approve
Revision history for this message
William Candillon (wcandillon) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job pjl-misc-2013-06-02T11-59-56.725Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/diagnostics/dict.h'
--- src/diagnostics/dict.h 2013-02-07 17:24:36 +0000
+++ src/diagnostics/dict.h 2013-05-31 14:40:34 +0000
@@ -17,6 +17,8 @@
17#ifndef ZORBA_DIAGNOSTIC_DICT_H17#ifndef ZORBA_DIAGNOSTIC_DICT_H
18#define ZORBA_DIAGNOSTIC_DICT_H18#define ZORBA_DIAGNOSTIC_DICT_H
1919
20#include <zorba/internal/ztd.h>
21
20#include "diagnostics/dict_zed_keys.h"22#include "diagnostics/dict_zed_keys.h"
2123
22namespace zorba {24namespace zorba {
@@ -60,7 +62,8 @@
60 * @return Returns the value for the given key or \a key if not found.62 * @return Returns the value for the given key or \a key if not found.
61 */63 */
62template<class StringType> inline64template<class StringType> inline
63char const* lookup( StringType const &key ) {65typename std::enable_if<ZORBA_HAS_C_STR(StringType),char const*>::type
66lookup( StringType const &key ) {
64 return lookup( key.c_str() );67 return lookup( key.c_str() );
65}68}
6669
6770
=== modified file 'src/runtime/full_text/ft_module_impl.cpp'
--- src/runtime/full_text/ft_module_impl.cpp 2013-05-08 20:14:47 +0000
+++ src/runtime/full_text/ft_module_impl.cpp 2013-05-31 14:40:34 +0000
@@ -605,7 +605,6 @@
605 state->phrase_, state->relationship_, state->at_least_, state->at_most_605 state->phrase_, state->relationship_, state->at_least_, state->at_most_
606 )606 )
607 );607 );
608 ZORBA_ASSERT( state->tresult_.get() );
609}608}
610609
611#ifndef WIN32610#ifndef WIN32
@@ -617,6 +616,7 @@
617# pragma GCC diagnostic warning "-Wpragmas"616# pragma GCC diagnostic warning "-Wpragmas"
618#endif /* GCC_PRAGMA_DIAGNOSTIC_PUSH */617#endif /* GCC_PRAGMA_DIAGNOSTIC_PUSH */
619#endif /* WIN32 */618#endif /* WIN32 */
619
620///////////////////////////////////////////////////////////////////////////////620///////////////////////////////////////////////////////////////////////////////
621621
622bool TokenizeNodeIterator::nextImpl( store::Item_t &result,622bool TokenizeNodeIterator::nextImpl( store::Item_t &result,
623623
=== modified file 'src/store/naive/item_vector.cpp'
--- src/store/naive/item_vector.cpp 2013-02-07 17:24:36 +0000
+++ src/store/naive/item_vector.cpp 2013-05-31 14:40:34 +0000
@@ -103,7 +103,7 @@
103zstring ItemVector::show() const103zstring ItemVector::show() const
104{104{
105 std::ostringstream res;105 std::ostringstream res;
106 res << "ItemVector size: " << size() + " [";106 res << "ItemVector size: " << size() << " [";
107 for ( ulong i = 0; i < size(); i++)107 for ( ulong i = 0; i < size(); i++)
108 res << getItem(i)->show() << ", ";108 res << getItem(i)->show() << ", ";
109 res << "]";109 res << "]";
110110
=== modified file 'src/util/uri_util.h'
--- src/util/uri_util.h 2013-05-09 00:48:27 +0000
+++ src/util/uri_util.h 2013-05-31 14:40:34 +0000
@@ -31,7 +31,7 @@
31////////// Scheme /////////////////////////////////////////////////////////////31////////// Scheme /////////////////////////////////////////////////////////////
3232
33/**33/**
34 * A subset of official IANA-registere URI schemes.34 * A subset of official IANA-registered URI schemes.
35 */35 */
36enum scheme {36enum scheme {
37 none,37 none,

Subscribers

People subscribed via source and target branches