Merge ~paelzer/ubuntu/+source/open-vm-tools:bug-1844834-v11-bionic into ubuntu/+source/open-vm-tools:ubuntu/bionic-devel

Proposed by Christian Ehrhardt 
Status: Merged
Approved by: Christian Ehrhardt 
Approved revision: 2432b3f65bd26796acadcf2f112fa68930531dfd
Merged at revision: 2432b3f65bd26796acadcf2f112fa68930531dfd
Proposed branch: ~paelzer/ubuntu/+source/open-vm-tools:bug-1844834-v11-bionic
Merge into: ubuntu/+source/open-vm-tools:ubuntu/bionic-devel
Diff against target: 236126 lines (+33500/-40114) (has conflicts)
306 files modified
ReleaseNotes.md (+46/-25)
debian/.gitlab-ci.yml (+14/-0)
debian/changelog (+112/-0)
debian/control (+11/-6)
debian/copyright (+1/-1)
debian/open-vm-tools.lintian-overrides (+2/-0)
debian/open-vm-tools.vgauth.service (+1/-0)
debian/patches/89c0d4445_GitHub-Issue-367.-Remove-references-to-deprecated-G_INLINE_FUNC (+90/-0)
debian/patches/fix_zfs_fs_detection (+13/-0)
debian/patches/series (+5/-0)
debian/rules (+2/-3)
dev/null (+0/-62)
open-vm-tools/AUTHORS (+9/-0)
open-vm-tools/ChangeLog (+13979/-34669)
open-vm-tools/Makefile.am (+8/-13)
open-vm-tools/checkvm/checkvm.c (+6/-1)
open-vm-tools/configure.ac (+30/-118)
open-vm-tools/hgfsclient/hgfsclient.c (+7/-1)
open-vm-tools/hgfsmounter/hgfsmounter.c (+9/-5)
open-vm-tools/lib/appUtil/appUtilX11.c (+19/-9)
open-vm-tools/lib/asyncsocket/asyncsocket.c (+171/-11)
open-vm-tools/lib/auth/authPosix.c (+74/-16)
open-vm-tools/lib/file/file.c (+2/-1)
open-vm-tools/lib/file/fileIO.c (+5/-6)
open-vm-tools/lib/file/fileInt.h (+4/-3)
open-vm-tools/lib/file/fileLockPosix.c (+7/-12)
open-vm-tools/lib/file/filePosix.c (+146/-131)
open-vm-tools/lib/glibUtils/fileLogger.c (+9/-12)
open-vm-tools/lib/glibUtils/stdLogger.c (+6/-6)
open-vm-tools/lib/glibUtils/sysLogger.c (+6/-6)
open-vm-tools/lib/hgfsServer/hgfsServer.c (+17/-12)
open-vm-tools/lib/hgfsServer/hgfsServerLinux.c (+1/-1)
open-vm-tools/lib/hgfsServer/hgfsServerPacketUtil.c (+2/-8)
open-vm-tools/lib/hgfsServerManagerGuest/hgfsServerManagerGuest.c (+86/-18)
open-vm-tools/lib/hgfsServerPolicyGuest/hgfsServerPolicyGuest.c (+6/-1)
open-vm-tools/lib/include/appUtil.h (+3/-1)
open-vm-tools/lib/include/asyncsocket.h (+27/-2)
open-vm-tools/lib/include/auth.h (+3/-1)
open-vm-tools/lib/include/backdoor_def.h (+182/-15)
open-vm-tools/lib/include/backdoor_types.h (+3/-2)
open-vm-tools/lib/include/buildNumber.h (+6/-6)
open-vm-tools/lib/include/capsProvider.h (+2/-1)
open-vm-tools/lib/include/circList.h (+29/-1)
open-vm-tools/lib/include/conf.h (+106/-1)
open-vm-tools/lib/include/deployPkg/linuxDeployment.h (+28/-1)
open-vm-tools/lib/include/dynarray.h (+17/-1)
open-vm-tools/lib/include/dynbuf.h (+42/-1)
open-vm-tools/lib/include/err.h (+1/-1)
open-vm-tools/lib/include/file.h (+8/-4)
open-vm-tools/lib/include/ghIntegrationCommon.h (+130/-18)
open-vm-tools/lib/include/guestInfo.h (+17/-1)
open-vm-tools/lib/include/guest_os.h (+44/-12)
open-vm-tools/lib/include/guest_os_tables.h (+19/-201)
open-vm-tools/lib/include/hashTable.h (+2/-2)
open-vm-tools/lib/include/hgfsServer.h (+10/-5)
open-vm-tools/lib/include/hostinfo.h (+24/-10)
open-vm-tools/lib/include/includeCheck.h (+11/-28)
open-vm-tools/lib/include/ioplGet.h (+1/-1)
open-vm-tools/lib/include/log.h (+43/-2)
open-vm-tools/lib/include/logToHost.h (+32/-0)
open-vm-tools/lib/include/loglevel_user.h (+11/-4)
open-vm-tools/lib/include/mutexRankLib.h (+2/-1)
open-vm-tools/lib/include/posix.h (+1/-1)
open-vm-tools/lib/include/procMgr.h (+9/-1)
open-vm-tools/lib/include/product.h (+3/-4)
open-vm-tools/lib/include/productState.h (+5/-4)
open-vm-tools/lib/include/random.h (+3/-1)
open-vm-tools/lib/include/rpcin.h (+1/-1)
open-vm-tools/lib/include/rpcout.h (+1/-7)
open-vm-tools/lib/include/rpcvmx.h (+2/-13)
open-vm-tools/lib/include/rpcvmxext.h (+49/-0)
open-vm-tools/lib/include/sha1.h (+26/-1)
open-vm-tools/lib/include/unicodeBase.h (+1/-1)
open-vm-tools/lib/include/unicodeTypes.h (+3/-1)
open-vm-tools/lib/include/util.h (+6/-1)
open-vm-tools/lib/include/vixCommands.h (+1/-2)
open-vm-tools/lib/include/vmGuestAppMonitorLib.h (+187/-0)
open-vm-tools/lib/include/vmGuestLib.h (+10/-1)
open-vm-tools/lib/include/vm_assert.h (+2/-2)
open-vm-tools/lib/include/vm_atomic.h (+10/-7)
open-vm-tools/lib/include/vm_basic_asm.h (+132/-102)
open-vm-tools/lib/include/vm_basic_asm_x86.h (+20/-35)
open-vm-tools/lib/include/vm_basic_asm_x86_64.h (+44/-66)
open-vm-tools/lib/include/vm_basic_asm_x86_common.h (+403/-57)
open-vm-tools/lib/include/vm_basic_defs.h (+67/-61)
open-vm-tools/lib/include/vm_basic_types.h (+107/-206)
open-vm-tools/lib/include/vm_device_version.h (+21/-16)
open-vm-tools/lib/include/vm_product.h (+19/-20)
open-vm-tools/lib/include/vm_product_versions.h (+58/-61)
open-vm-tools/lib/include/vm_tools_version.h (+54/-4)
open-vm-tools/lib/include/vm_version.h (+3/-1)
open-vm-tools/lib/include/vmci_defs.h (+24/-2)
open-vm-tools/lib/include/vmci_sockets.h (+8/-1)
open-vm-tools/lib/include/vmstdio.h (+5/-1)
open-vm-tools/lib/include/vmware/guestrpc/deploypkg.h (+2/-1)
open-vm-tools/lib/include/vmware/guestrpc/guestcust-events.h (+42/-0)
open-vm-tools/lib/include/vmware/guestrpc/tclodefs.h (+16/-1)
open-vm-tools/lib/include/vmware/guestrpc/timesync.h (+3/-1)
open-vm-tools/lib/include/vmware/tools/desktopevents.h (+8/-1)
open-vm-tools/lib/include/vmware/tools/guestrpc.h (+25/-4)
open-vm-tools/lib/include/vmware/tools/log.h (+44/-2)
open-vm-tools/lib/include/vmware/tools/plugin.h (+10/-1)
open-vm-tools/lib/include/vmware/tools/threadPool.h (+5/-2)
open-vm-tools/lib/include/vmware/tools/utils.h (+1/-7)
open-vm-tools/lib/include/wiper.h (+9/-3)
open-vm-tools/lib/include/x86_basic_defs.h (+11/-2)
open-vm-tools/lib/include/x86cpuid.h (+923/-867)
open-vm-tools/lib/include/x86cpuid_asm.h (+35/-24)
open-vm-tools/lib/lock/ul.c (+6/-6)
open-vm-tools/lib/lock/ulBarrier.c (+3/-3)
open-vm-tools/lib/lock/ulExcl.c (+3/-3)
open-vm-tools/lib/lock/ulInt.h (+6/-8)
open-vm-tools/lib/lock/ulIntShared.h (+2/-2)
open-vm-tools/lib/lock/ulRW.c (+3/-3)
open-vm-tools/lib/lock/ulRec.c (+4/-4)
open-vm-tools/lib/lock/ulSema.c (+3/-3)
open-vm-tools/lib/lock/ulStats.c (+28/-92)
open-vm-tools/lib/misc/dynbuf.c (+61/-1)
open-vm-tools/lib/misc/hostinfo.c (+61/-54)
open-vm-tools/lib/misc/hostinfoHV.c (+2/-2)
open-vm-tools/lib/misc/hostinfoInt.h (+30/-8)
open-vm-tools/lib/misc/hostinfoPosix.c (+531/-220)
open-vm-tools/lib/misc/idLinux.c (+40/-12)
open-vm-tools/lib/misc/prng.c (+15/-1)
open-vm-tools/lib/misc/sha1.c (+1/-429)
open-vm-tools/lib/misc/timeutil.c (+2/-2)
open-vm-tools/lib/misc/utilMem.c (+34/-1)
open-vm-tools/lib/misc/util_misc.c (+3/-3)
open-vm-tools/lib/misc/vmstdio.c (+35/-1)
open-vm-tools/lib/misc/vthreadBase.c (+1/-1)
open-vm-tools/lib/nicInfo/nicInfoPosix.c (+41/-6)
open-vm-tools/lib/panic/panic.c (+11/-11)
open-vm-tools/lib/poll/poll.c (+299/-95)
open-vm-tools/lib/procMgr/procMgrPosix.c (+82/-16)
open-vm-tools/lib/rpcChannel/bdoorChannel.c (+3/-2)
open-vm-tools/lib/rpcChannel/glib_stubs.c (+43/-0)
open-vm-tools/lib/rpcChannel/rpcChannel.c (+253/-135)
open-vm-tools/lib/rpcChannel/rpcChannelInt.h (+2/-4)
open-vm-tools/lib/rpcChannel/vsockChannel.c (+4/-3)
open-vm-tools/lib/rpcIn/rpcin.c (+1/-1)
open-vm-tools/lib/rpcOut/rpcout.c (+4/-2)
open-vm-tools/lib/sslDirect/Makefile.am (+2/-9)
open-vm-tools/lib/sslDirect/sslDirect.c (+1/-1)
open-vm-tools/lib/stubs/stub-log.c (+57/-2)
open-vm-tools/lib/stubs/stub-panic.c (+2/-1)
open-vm-tools/lib/stubs/stub-warning.c (+3/-2)
open-vm-tools/lib/syncDriver/syncDriverPosix.c (+27/-5)
open-vm-tools/lib/system/systemLinux.c (+12/-2)
open-vm-tools/lib/unicode/unicodeICU.c (+17/-13)
open-vm-tools/lib/unicode/unicodeSimpleTypes.c (+36/-2)
open-vm-tools/lib/user/util.c (+46/-10)
open-vm-tools/lib/user/utilBacktrace.c (+3/-2)
open-vm-tools/lib/wiper/wiperCommon.c (+5/-1)
open-vm-tools/lib/wiper/wiperPosix.c (+50/-6)
open-vm-tools/libDeployPkg/Makefile.am (+2/-2)
open-vm-tools/libDeployPkg/deployPkgFormat.h (+22/-19)
open-vm-tools/libDeployPkg/linuxDeployment.c (+225/-111)
open-vm-tools/libDeployPkg/mspackWrapper.c (+3/-2)
open-vm-tools/libappmonitor/COPYING (+502/-0)
open-vm-tools/libappmonitor/Makefile.am (+74/-0)
open-vm-tools/libappmonitor/appmonitor.pc.in (+13/-0)
open-vm-tools/libappmonitor/stub-debug.c (+67/-0)
open-vm-tools/libappmonitor/vmGuestAppMonitorLib.c (+462/-0)
open-vm-tools/libappmonitor/vmGuestAppMonitorLibInt.h (+56/-0)
open-vm-tools/libappmonitor/vmguestappmonitorlib_version.h (+35/-0)
open-vm-tools/libguestlib/guestlibV3.x (+7/-2)
open-vm-tools/libguestlib/vmGuestLib.c (+43/-1)
open-vm-tools/libvmtools/Makefile.am (+1/-6)
open-vm-tools/libvmtools/i18n.c (+13/-11)
open-vm-tools/libvmtools/vmtoolsConfig.c (+7/-289)
open-vm-tools/libvmtools/vmtoolsLog.c (+1103/-94)
open-vm-tools/libvmtools/vmxLogger.c (+1/-12)
open-vm-tools/m4/vmtools.m4 (+14/-16)
open-vm-tools/modules/freebsd/vmmemctl/os.c (+37/-23)
open-vm-tools/modules/shared/vmmemctl/backdoor_balloon.c (+63/-26)
open-vm-tools/modules/shared/vmmemctl/backdoor_balloon.h (+6/-6)
open-vm-tools/modules/shared/vmmemctl/balloon_def.h (+3/-2)
open-vm-tools/modules/shared/vmmemctl/vmballoon.c (+17/-17)
open-vm-tools/modules/shared/vmmemctl/vmballoon.h (+7/-7)
open-vm-tools/modules/shared/vmxnet/eth_public.h (+10/-4)
open-vm-tools/modules/shared/vmxnet/net.h (+3/-1)
open-vm-tools/modules/shared/vmxnet/upt1_defs.h (+2/-2)
open-vm-tools/modules/shared/vmxnet/vmnet_def.h (+4/-3)
open-vm-tools/modules/shared/vmxnet/vmxnet3_defs.h (+107/-1)
open-vm-tools/modules/solaris/vmxnet3/vmxnet3_main.c (+4/-2)
open-vm-tools/modules/solaris/vmxnet3/vmxnet3_tx.c (+8/-5)
open-vm-tools/namespacetool/namespacetool.c (+8/-1)
open-vm-tools/rpctool/rpctool.c (+8/-1)
open-vm-tools/scripts/Makefile.am (+0/-3)
open-vm-tools/scripts/common/vm-support (+4/-2)
open-vm-tools/services/plugins/Makefile.am (+1/-4)
open-vm-tools/services/plugins/deployPkg/deployPkg.c (+38/-3)
open-vm-tools/services/plugins/deployPkg/deployPkgLog.c (+3/-0)
open-vm-tools/services/plugins/dndcp/Makefile.am (+19/-9)
open-vm-tools/services/plugins/dndcp/copyPasteCompatX11.c (+19/-26)
open-vm-tools/services/plugins/dndcp/copyPasteDnDX11.cpp (+2/-1)
open-vm-tools/services/plugins/dndcp/copyPasteUIX11.cpp (+24/-4)
open-vm-tools/services/plugins/dndcp/dnd/dnd.h (+32/-4)
open-vm-tools/services/plugins/dndcp/dnd/dndCPMsgV4.c (+24/-8)
open-vm-tools/services/plugins/dndcp/dnd/dndCPMsgV4.h (+14/-2)
open-vm-tools/services/plugins/dndcp/dnd/dndClipboard.c (+18/-7)
open-vm-tools/services/plugins/dndcp/dnd/dndClipboard.h (+9/-1)
open-vm-tools/services/plugins/dndcp/dnd/dndCommon.c (+152/-0)
open-vm-tools/services/plugins/dndcp/dnd/dndRpcV4.hh (+3/-1)
open-vm-tools/services/plugins/dndcp/dndGuest/dndRpcV4.cc (+14/-1)
open-vm-tools/services/plugins/dndcp/dndGuest/rpcV4Util.cpp (+35/-5)
open-vm-tools/services/plugins/dndcp/dndGuest/rpcV4Util.hpp (+4/-1)
open-vm-tools/services/plugins/dndcp/dndGuest/vmGuestDnDCPMgr.cc (+131/-0)
open-vm-tools/services/plugins/dndcp/dndGuest/vmGuestDnDCPMgr.hh (+56/-0)
open-vm-tools/services/plugins/dndcp/dndGuest/vmGuestDnDMgr.cc (+166/-0)
open-vm-tools/services/plugins/dndcp/dndGuest/vmGuestDnDMgr.hh (+53/-0)
open-vm-tools/services/plugins/dndcp/dndGuest/vmGuestDnDSrc.cc (+103/-0)
open-vm-tools/services/plugins/dndcp/dndGuest/vmGuestDnDSrc.hh (+41/-0)
open-vm-tools/services/plugins/dndcp/dndGuest/vmGuestFileTransfer.cc (+97/-0)
open-vm-tools/services/plugins/dndcp/dndGuest/vmGuestFileTransfer.hh (+51/-0)
open-vm-tools/services/plugins/dndcp/dndGuestBase/copyPasteDnDImpl.h (+55/-0)
open-vm-tools/services/plugins/dndcp/dndGuestBase/copyPasteDnDWrapper.cpp (+509/-0)
open-vm-tools/services/plugins/dndcp/dndGuestBase/copyPasteDnDWrapper.h (+88/-0)
open-vm-tools/services/plugins/dndcp/dndGuestBase/copyPasteDnDX11.h (+64/-0)
open-vm-tools/services/plugins/dndcp/dndGuestBase/dndFileList.cc (+715/-0)
open-vm-tools/services/plugins/dndcp/dndGuestBase/dndFileList.hh (+84/-0)
open-vm-tools/services/plugins/dndcp/dndGuestBase/dndPluginInt.h (+44/-0)
open-vm-tools/services/plugins/dndcp/dndGuestBase/dndRpcV3.cc (+693/-0)
open-vm-tools/services/plugins/dndcp/dndGuestBase/dndRpcV3.hh (+110/-0)
open-vm-tools/services/plugins/dndcp/dndGuestBase/dndUIX11.h (+240/-0)
open-vm-tools/services/plugins/dndcp/dndGuestBase/dragDetWndX11.h (+97/-0)
open-vm-tools/services/plugins/dndcp/dndGuestBase/guestCopyPaste.hh (+136/-0)
open-vm-tools/services/plugins/dndcp/dndGuestBase/guestDnD.hh (+205/-0)
open-vm-tools/services/plugins/dndcp/dndGuestBase/guestDnDCPMgr.cc (+141/-0)
open-vm-tools/services/plugins/dndcp/dndGuestBase/guestDnDCPMgr.hh (+66/-0)
open-vm-tools/services/plugins/dndcp/dndGuestBase/guestDnDDest.cc (+254/-0)
open-vm-tools/services/plugins/dndcp/dndGuestBase/guestDnDMgr.cc (+631/-0)
open-vm-tools/services/plugins/dndcp/dndGuestBase/guestDnDSrc.cc (+277/-0)
open-vm-tools/services/plugins/dndcp/dndGuestBase/guestFileTransfer.cc (+52/-0)
open-vm-tools/services/plugins/dndcp/dndGuestBase/guestFileTransfer.hh (+43/-0)
open-vm-tools/services/plugins/dndcp/dndUIX11.cpp (+126/-54)
open-vm-tools/services/plugins/dndcp/dndcp.cpp (+25/-1)
open-vm-tools/services/plugins/dndcp/dragDetWndX11.cpp (+50/-13)
open-vm-tools/services/plugins/dndcp/fakeMouseWayland/fakeMouseWayland.cpp (+3/-2)
open-vm-tools/services/plugins/dndcp/pointer.cpp (+1/-1)
open-vm-tools/services/plugins/dndcp/stringxx/string.cc (+2/-1)
open-vm-tools/services/plugins/dndcp/stringxx/string.hh (+3/-3)
open-vm-tools/services/plugins/dndcp/stringxx/ubstr_t.hh (+3/-3)
open-vm-tools/services/plugins/dndcp/vmCopyPasteDnDWrapper.cpp (+388/-0)
open-vm-tools/services/plugins/dndcp/vmCopyPasteDnDWrapper.h (+59/-0)
open-vm-tools/services/plugins/dndcp/xutils/xutils.cc (+89/-5)
open-vm-tools/services/plugins/dndcp/xutils/xutils.hh (+4/-2)
open-vm-tools/services/plugins/guestInfo/diskInfo.c (+823/-21)
open-vm-tools/services/plugins/guestInfo/diskInfoPosix.c (+17/-5)
open-vm-tools/services/plugins/guestInfo/guestInfoInt.h (+44/-6)
open-vm-tools/services/plugins/guestInfo/guestInfoServer.c (+588/-187)
open-vm-tools/services/plugins/guestInfo/perfMonLinux.c (+1/-1)
open-vm-tools/services/plugins/hgfsServer/hgfsPlugin.c (+1/-1)
open-vm-tools/services/plugins/powerOps/powerOps.c (+8/-3)
open-vm-tools/services/plugins/vix/foundryToolsDaemon.c (+1/-220)
open-vm-tools/services/plugins/vix/vixPlugin.c (+1/-3)
open-vm-tools/services/plugins/vix/vixPluginInt.h (+1/-4)
open-vm-tools/services/plugins/vix/vixTools.c (+289/-104)
open-vm-tools/services/plugins/vix/vixToolsInt.h (+4/-2)
open-vm-tools/services/plugins/vmbackup/scriptOps.c (+5/-2)
open-vm-tools/services/plugins/vmbackup/stateMachine.c (+10/-8)
open-vm-tools/services/plugins/vmbackup/vmBackupInt.h (+4/-4)
open-vm-tools/services/vmtoolsd/Makefile.am (+2/-1)
open-vm-tools/services/vmtoolsd/cmdLine.c (+1/-3)
open-vm-tools/services/vmtoolsd/mainLoop.c (+107/-5)
open-vm-tools/services/vmtoolsd/mainPosix.c (+11/-4)
open-vm-tools/services/vmtoolsd/serviceObj.c (+19/-9)
open-vm-tools/services/vmtoolsd/serviceObj.h (+2/-2)
open-vm-tools/services/vmtoolsd/threadPool.c (+26/-26)
open-vm-tools/services/vmtoolsd/toolsCoreInt.h (+3/-1)
open-vm-tools/services/vmtoolsd/toolsHangDetector.c (+534/-0)
open-vm-tools/services/vmtoolsd/toolsHangDetector.h (+31/-0)
open-vm-tools/services/vmtoolsd/toolsRpc.c (+1/-1)
open-vm-tools/tests/testVmblock/vmblocktest.c (+3/-2)
open-vm-tools/toolbox/toolbox-cmd.c (+51/-14)
open-vm-tools/toolbox/toolboxCmdInt.h (+17/-6)
open-vm-tools/toolbox/toolboxcmd-info.c (+2/-2)
open-vm-tools/toolbox/toolboxcmd-shrink.c (+10/-5)
open-vm-tools/toolbox/toolboxcmd-stat.c (+11/-8)
open-vm-tools/toolbox/toolboxcmd-time.c (+3/-4)
open-vm-tools/tools.conf (+256/-0)
open-vm-tools/vgauth/cli/main.c (+4/-1)
open-vm-tools/vgauth/common/certverify.c (+7/-3)
open-vm-tools/vgauth/common/i18n.c (+36/-24)
open-vm-tools/vgauth/common/prefs.h (+9/-1)
open-vm-tools/vgauth/common/vmxlog.c (+640/-0)
open-vm-tools/vgauth/common/vmxlog.h (+45/-0)
open-vm-tools/vgauth/lib/authPosix.c (+2/-2)
open-vm-tools/vgauth/service/Makefile.am (+2/-1)
open-vm-tools/vgauth/service/fileLogger.c (+1/-5)
open-vm-tools/vgauth/service/gio.c (+4/-1)
open-vm-tools/vgauth/service/main.c (+12/-1)
open-vm-tools/vgauth/service/service.h (+2/-1)
open-vm-tools/vgauth/serviceImpl/alias.c (+21/-1)
open-vm-tools/vgauth/serviceImpl/proto.c (+3/-1)
open-vm-tools/vgauth/serviceImpl/saml-xmlsec1.c (+44/-4)
open-vm-tools/vgauth/serviceImpl/service.c (+2/-1)
open-vm-tools/vgauth/serviceImpl/verify.c (+20/-9)
open-vm-tools/vmhgfs-fuse/cache.c (+50/-1)
open-vm-tools/vmhgfs-fuse/dir.c (+92/-83)
open-vm-tools/vmhgfs-fuse/file.c (+125/-92)
open-vm-tools/vmhgfs-fuse/filesystem.c (+31/-21)
open-vm-tools/vmhgfs-fuse/fsutil.c (+35/-21)
open-vm-tools/vmhgfs-fuse/link.c (+62/-63)
open-vm-tools/vmhgfs-fuse/vmhgfs_version.h (+4/-4)
open-vm-tools/xferlogs/xferlogs.c (+47/-9)
Conflict in debian/changelog
Conflict in debian/control
Conflict in debian/patches/series
Reviewer Review Type Date Requested Status
Rafael David Tinoco (community) Approve
Canonical Server packageset reviewers Pending
git-ubuntu developers Pending
Review via email: mp+374899@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Builds and checks now good, reopening for review.

Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

Just like the Eoan merge:

https://code.launchpad.net/~paelzer/ubuntu/+source/open-vm-tools/+git/open-vm-tools/+merge/374901

I'm +1 on this change, including removing the Wno-errors that were introduced to allow GCC upgrade.

Revision history for this message
Rafael David Tinoco (rafaeldtinoco) :
review: Approve
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Thanks for the review, Tags pushed and uploaded

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/ReleaseNotes.md b/ReleaseNotes.md
index 3f754e0..3912c83 100644
--- a/ReleaseNotes.md
+++ b/ReleaseNotes.md
@@ -1,9 +1,6 @@
1open-vm-tools 10.3.10 Release Notes1**Updated on: 17 OCT 2019**
2=================================
32
4**Updated on: 14 MAR 2019**3VMware Tools | 17 OCT 2019 | Build 14773994
5
6open-vm-tools | 14 MAR 2019 | Build 12406962
74
8Check for additions and updates to these release notes.5Check for additions and updates to these release notes.
96
@@ -15,32 +12,33 @@ The release notes cover the following topics:
15* [What's New](#whatsnew)12* [What's New](#whatsnew)
16* [Before You Begin](#beforeyoubegin)13* [Before You Begin](#beforeyoubegin)
17* [Internationalization](#i18n)14* [Internationalization](#i18n)
15* [Product Support Notice](#productsupport)
18* [End of Feature Support Notice](#endoffeaturesupport)16* [End of Feature Support Notice](#endoffeaturesupport)
17* [Compatibility Notes](#compatibility)
19* [Guest Operating System Customization Support](#guestop)18* [Guest Operating System Customization Support](#guestop)
20* [Interoperability Matrix](#interop)19* [Interoperability Matrix](#interop)
21* [Resolved Issues](#resolvedissues)
22* [Known Issues](#knownissues)20* [Known Issues](#knownissues)
2321
24What's New22What's New
25----------23----------
2624
27* **Resolved Issues: **There are some issues that are resolved in this release of open-vm-tools which are documented in the [Resolved Issues](#resolvedissues) section of this release notes.25* It is highly recommended to upgrade to this version of VMware Tools, if you are using the native service discovery feature in vRealize Operations Manager 8.0, or using the vRealize Operations Service Discovery Management Pack with previous releases of vRealize Operations Manager (7.x or before). For more details, refer [KB 75122](https://kb.vmware.com/s/article/75122).
2826
29Before You Begin27Before You Begin
30----------------28----------------
3129
32**Important note about upgrading to ESXi 5.5 Update 3b or later**30**Important note about upgrading to ESXi 6.0 or later**
3331
34Resolution on incompatibility and general guidelines: While upgrading ESXi hosts to ESXi 5.5 Update 3b or ESXi 6.0 Update 1 or later, and using older versions of Horizon View Agent, refer to the knowledge base articles:32Resolution on incompatibility and general guidelines: While upgrading ESXi hosts to ESXi 6.0 or later, and using older versions of Horizon View Agent, refer to the knowledge base articles:
3533
36* [Connecting to View desktops with Horizon View Agent 5.3.5 or earlier hosted on ESXi 5.5 Update 3b or later fails with a black screen.](http://kb.vmware.com/kb/2144438)34* [Connecting to View desktops with Horizon View Agent 5.3.5 or earlier hosted on ESXi 6.0 or later fails with a black screen.](http://kb.vmware.com/kb/2144438)
37* [Connecting to View desktops with Horizon View Agent 6.0.x or 6.1.x hosted on ESXi 5.5 Update 3b or later fails with a black screen.](http://kb.vmware.com/kb/2144518)35* [Connecting to View desktops with Horizon View Agent 6.0.x or 6.1.x hosted on ESXi 6.0 or later fails with a black screen.](http://kb.vmware.com/kb/2144518)
38* [Connecting to View desktops with Horizon View Agent 6.1.x hosted on ESXi 6.0 Update 1 or later fails with a black screen.](http://kb.vmware.com/kb/2144453)36* [Connecting to View desktops with Horizon View Agent 6.1.x hosted on ESXi 6.0 or later fails with a black screen.](http://kb.vmware.com/kb/2144453)
3937
40Internationalization38Internationalization
41--------------------39--------------------
4240
43open-vm-tools 10.3.10 is available in the following languages:41open-vm-tools 11.0.1 is available in the following languages:
4442
45* English43* English
46* French44* French
@@ -55,9 +53,12 @@ open-vm-tools 10.3.10 is available in the following languages:
55End of Feature Support Notice53End of Feature Support Notice
56-----------------------------54-----------------------------
5755
58* Support for Common Agent Framework (CAF) will be removed in the next major release of open-vm-tools.56* The tar tools (linux.iso) and OSPs shipped with VMware Tools 10.3.5 release will continue to be supported. However, releases after VMware Tools 10.3.5 will only include critical and security fixes and no new feature support in these types of VMware Tools (tar tools and OSP's). It is recommended that customers use open-vm-tools for those operating systems that support open-vm-tools. For more information on different types of VMware Tools, see [https://blogs.vmware.com/vsphere/2016/02/understanding-the-three-types-of-vm-tools.html](https://blogs.vmware.com/vsphere/2016/02/understanding-the-three-types-of-vm-tools.html)
59* VMware Tools 10.3.5 freezes feature support for tar tools and OSPs  57
60 The tar tools (linux.iso) and OSPs shipped with open-vm-tools 10.3.5 release will continue to be supported. However, releases after VMware Tools 10.3.5 will only include critical and security fixes and no new feature support in these types of open-vm-tools (tar tools and OSP's). It is recommended that customers use open-vm-tools for those operating systems that support open-vm-tools. For more information on different types of open-vm-tools, see [https://blogs.vmware.com/vsphere/2016/02/understanding-the-three-types-of-vm-tools.html](https://blogs.vmware.com/vsphere/2016/02/understanding-the-three-types-of-vm-tools.html)58Compatibility Notes
59-------------------
60
61* Starting with VMware Tools version 10.2.0, Perl script-based VMware Tools installation for FreeBSD has been discontinued. FreeBSD systems are supported only through the open-vm-tools packages directly available from FreeBSD package repositories. FreeBSD packages for open-vm-tools 10.1.0 and later are available from FreeBSD package repositories.
6162
62Guest Operating System Customization Support63Guest Operating System Customization Support
63--------------------------------------------64--------------------------------------------
@@ -72,35 +73,55 @@ The [VMware Product Interoperability Matrix](http://partnerweb.vmware.com/comp_
72Resolved Issues73Resolved Issues
73---------------74---------------
7475
75* **In certain cases, quiesced snapshots on Linux guests do not include backup manifests.**76* **Memory leak in vmtoolsd.**
7677
77 On a Linux guest, if VMware Tools 10.3.5 gets an error when notifying the ESXi host of a quiesced snapshot's backup manifest file, VMware Tools logs an error and does not notify the ESXi host of the backup manifest file on subsequent quiesced snapshots. As a result, some quiesced snapshots do not include the backup manifest file, that would otherwise be available on the ESXi host. Such snapshots are not identified as quiesced by vSphere clients.78 vmtoolsd leaks memory when the vSphere APIs ListGuestAliases and ListGuestMappedAliasers are used.
7879
79 This issue is fixed in this release.80 This issue is fixed in this release.
8081
81Known Issues82Known Issues
82------------83------------
8384
85* **Suspend Guest of Linux VM using any version of open-vm-tools may fail with some versions of SELinux.**
86
87 A "Suspend Guest" operation on a Linux guest running any version of open-vm-tools and with SELinux enabled may stall and ultimately fail.
88
89 The failure may appear as:
90   - a "Failed to suspend the virtual machine" message display.
91   - nothing happened and the "Suspend Guest" button is reactivated. IPv4 connections may be closed.
92   - a delayed suspend happens but the IPv4 addresses are lost when the VM is resumed.
93
94 Even an apparent "stall" which exceeds 30 seconds is an indication of the problem.
95
96 For more details, see [KB 74722](https://kb.vmware.com/s/article/74722).
97
98 Workaround:
99
100 Update the selinux-policy and selinux-policy-targeted packages to the latest version available from the Linux vendor.  If package updates are not available or if the issue persists, then consider the following workaround:
101
102 Create an exemption for the vmtools/NetworkManager denied access by using the audit2allow command to generate a local loadable SELinux policy module as outlined in [KB 74722](https://kb.vmware.com/s/article/74722).
103
84* **Drag functionality fails to work in Ubuntu.**104* **Drag functionality fails to work in Ubuntu.**
85 105
86 Drag functionality fails to work in Ubuntu 16.04.4 32-bit virtual machine installed using easy install. Also, failure of copy and paste functionality is observed in the same system.106 Drag functionality fails to work in Ubuntu 16.04.4 32-bit virtual machine installed using easy install. Also, failure of copy and paste functionality is observed in the same system.
87 107
108 Note: This issue is applicable for open-vm-tools running on Workstation and Fusion.
109
88 Workaround:110 Workaround:
89 111
90 * Add the modprobe.blacklist=vmwgfx linux kernel boot option.112 * Add the modprobe.blacklist=vmwgfx linux kernel boot option.
91 * To gain access to larger resolutions, remove svga.guestBackedPrimaryAware = "TRUE" option from the VMX file.113 * To gain access to larger resolutions, remove svga.guestBackedPrimaryAware = "TRUE" option from the VMX file.
92
93* **Shared Folders mount is unavailable on Linux VM.**114* **Shared Folders mount is unavailable on Linux VM.**
94 115
95 If the **Shared Folders** feature is enabled on a Linux VM while it is powered off, shared folders mount is not available on restart.116 If the **Shared Folders** feature is enabled on a Linux VM while it is powered off, shared folders mount is not available on restart.
96 117
97 Workaround:118 Note: This issue is applicable for open-vm-tools running on Workstation and Fusion.
98 119
99 If the VM is powered on, disable and enable the **Shared Folders** feature from the interface.120 Workaround:
100
101 For resolving the issue permanently, edit **/etc/fstab** and add an entry to mount the Shared Folders automatically on boot.
102
103 For example, add the line:
104 121
122 If the VM is powered on, disable and enable the **Shared Folders** feature from the interface.
123 For resolving the issue permanently, edit **/etc/fstab** and add an entry to mount the Shared Folders automatically on boot.
124 For example, add the line:
105 vmhgfs-fuse   /mnt/hgfs    fuse    defaults,allow\_other    0    0125 vmhgfs-fuse   /mnt/hgfs    fuse    defaults,allow\_other    0    0
106 126
127
diff --git a/debian/.gitlab-ci.yml b/debian/.gitlab-ci.yml
107new file mode 100644128new file mode 100644
index 0000000..62767c1
--- /dev/null
+++ b/debian/.gitlab-ci.yml
@@ -0,0 +1,14 @@
1include:
2 - https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/salsa-ci.yml
3 - https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/pipeline-jobs.yml
4
5variables:
6 RELEASE: 'unstable'
7 SALSA_CI_DISABLE_APTLY: 0
8 SALSA_CI_DISABLE_AUTOPKGTEST: 0
9 SALSA_CI_DISABLE_BLHC: 0
10 SALSA_CI_DISABLE_LINTIAN: 0
11 SALSA_CI_DISABLE_PIUPARTS: 0
12 SALSA_CI_DISABLE_REPROTEST: 0
13 SALSA_CI_DISABLE_BUILD_PACKAGE_ALL: 0
14 SALSA_CI_DISABLE_BUILD_PACKAGE_ANY: 0
diff --git a/debian/changelog b/debian/changelog
index f7e8a4f..1049416 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,4 @@
1<<<<<<< debian/changelog
1open-vm-tools (2:10.3.10-1~ubuntu0.18.04.2) bionic; urgency=medium2open-vm-tools (2:10.3.10-1~ubuntu0.18.04.2) bionic; urgency=medium
23
3 * Fix memory leaks in vix plugin (LP: #1847157)4 * Fix memory leaks in vix plugin (LP: #1847157)
@@ -12,6 +13,117 @@ open-vm-tools (2:10.3.10-1~ubuntu0.18.04.1) bionic; urgency=medium
12 * Backport recent open-vm-tools (LP: #1822204)13 * Backport recent open-vm-tools (LP: #1822204)
1314
14 -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Tue, 14 May 2019 09:07:32 +020015 -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Tue, 14 May 2019 09:07:32 +0200
16=======
17open-vm-tools (2:11.0.1-2ubuntu0.18.11.1) bionic; urgency=medium
18
19 * Update to latest release v11 (LP: #1844834)
20 - d/rules: Revert "Enable all compiler errors again" for the older
21 compiler
22
23 -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Wed, 30 Oct 2019 09:58:25 +0100
24
25open-vm-tools (2:11.0.1-2) unstable; urgency=medium
26
27 * [76c600f] Fix segfault for fs devices without /
28 See https://github.com/vmware/open-vm-tools/issues/378 for details.
29 Thanks to Mo Zhou (Closes: #942692)
30
31 -- Bernd Zeimetz <bzed@debian.org> Tue, 22 Oct 2019 15:48:48 +0200
32
33open-vm-tools (2:11.0.1-1) unstable; urgency=medium
34
35 * [bb36e10] Update upstream source from tag 'upstream/11.0.1'
36 Update to upstream version '11.0.1'
37 with Debian dir 60c0d512096774b9a2a7cc9e4e94556b2893ae8a
38
39 -- Bernd Zeimetz <bzed@debian.org> Tue, 22 Oct 2019 09:40:50 +0200
40
41open-vm-tools (2:11.0.0-2) unstable; urgency=medium
42
43 * [4cfe383] Update Vcs-Git/Browser to point to salsa.
44 * [bc253ad] Remove .travis.yml, add debian/.gitlab-ci.yml
45 * [c92ca3a] Add add_patch.sh script to add patches from upstream.
46 * [1d9b491] Add patch to remove deprecated inline functions
47 * [3e2e307] Rename lintian-override file properly
48
49 -- Bernd Zeimetz <bzed@debian.org> Tue, 15 Oct 2019 23:25:24 +0200
50
51open-vm-tools (2:11.0.0-1) unstable; urgency=medium
52
53 [ goldstar611 ]
54 * [c138871] Ensure VGAuthService starts after AppArmor
55 https://gitlab.com/apparmor/apparmor/issues/13
56
57 [ Bernd Zeimetz ]
58 * [28ef841] New upstream version 11.0.0~0
59 * [f78ed2d] New upstream version 11.0.0
60 Closes: #940853
61 * [19efc80] Revert "Revert "Removing libdumbnet-dev.""
62 This reverts commit 31177fab964d92687501ab81774440a9b8d09e39.
63 * [bc14a8b] snapshot changelog
64 * [1c5e9ea] Dropping patches that were picked from upstream
65
66 -- Bernd Zeimetz <bzed@debian.org> Mon, 30 Sep 2019 14:37:27 +0200
67
68open-vm-tools (2:10.3.10-3) unstable; urgency=medium
69
70 [ Bernd Zeimetz ]
71 * [19c646a] gcc9 compatibility.
72 Upstream commit c68172ef7f2d4f116078e2aba82986a8cab0b16e (Closes: #925794)
73
74 [ Christian Ehrhardt ]
75 * [865763e] Fix other ftbfs with GCC-9
76 * d/rules: disable address-of-packed-member gcc-9 warnings for pre 11.0 code
77 (LP: #1842301)
78 * d/rules: use modern syntax for disabling deprecated-declarations
79 * d/p/gcc9-Remove-GLib-2.32-deprecated-APIs-from-tools.patch: stop using outdated GLib features
80 Upstream commit a7c141fc
81 * d/p/gcc9-drop-obsolete-G_INLINE_FUNC.patch: stop using deprecated GLib Macro
82 * d/p/gcc9-GStaticRecMutex.patch: stop using deprecated GStaticRecMutex
83 Upstream commit 19ca3e36
84 * d/p/gcc9-build-error-in-vmblocktest.c.patch: avoid error due to stringop-truncation
85 Upstream commit 553d1283
86
87 [ Bernd Zeimetz ]
88 * [0ce2ba2] Policy 4.0.1: The extra priority has been deprecated
89 * [c8760c6] Bumping Standards-Version to 4.4.0
90 * [a6ed8ce] Don't override dh_builddeb.
91 debian-rules-should-not-use-custom-compression-settings
92 * [bdfd8b5] Remove add_patch script
93 * [be4d889] Update copyright years.
94 * [9ac710e] Remove autotools-dev dependency.
95 * [4296cf4] Fix permissions of udev rules file
96 * [ed11c19] A new lintian override
97
98 -- Bernd Zeimetz <bzed@debian.org> Tue, 03 Sep 2019 18:06:54 +0200
99
100open-vm-tools (2:10.3.10-2) unstable; urgency=medium
101
102 [ Christian Ehrhardt ]
103 * [d79cc9d] d/control: fix postinst missing lsmod/modprobe.
104 Upgrades on open-vm-desktop can trigger errors like the following:
105 /var/lib/dpkg/info/open-vm-tools-desktop.postinst: 5:
106 /var/lib/dpkg/info/open-vm-tools-desktop.postinst: lsmod: not found
107 /var/lib/dpkg/info/open-vm-tools-desktop.postinst: 6:
108 /var/lib/dpkg/info/open-vm-tools-desktop.postinst: modprobe: not found
109 The reason is that kmod isn't a dependency of open-vm-tools-desktop and
110 could be missing e.g. if you installed it in a system container.
111 Once might discuss how useful open-vm-tools-desktop is in that
112 environment but a n issue to fix none the less.
113 Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
114
115 [ Bernd Zeimetz ]
116 * [4d3f25f] Fix guest OS reporting for Debian/Buster.
117 Without this fix, open-vm-tools report other4xLinux64Guest instead of
118 Debian/Buster.
119 Reason is the output of lsb_release, which outputs:
120 $ lsb_release -sd
121 Debian GNU/Linux 10 (buster)
122 But the code in open-vm-tools expects '10.'.
123 Thanks to Oliver Kurth (Closes: #934005)
124
125 -- Bernd Zeimetz <bzed@debian.org> Wed, 07 Aug 2019 10:28:52 +0200
126>>>>>>> debian/changelog
15127
16open-vm-tools (2:10.3.10-1) unstable; urgency=high128open-vm-tools (2:10.3.10-1) unstable; urgency=high
17129
diff --git a/debian/control b/debian/control
index 9858935..a8964b2 100644
--- a/debian/control
+++ b/debian/control
@@ -1,11 +1,15 @@
1Source: open-vm-tools1Source: open-vm-tools
2Section: admin2Section: admin
3<<<<<<< debian/control
3Priority: extra4Priority: extra
5=======
6Priority: optional
7>>>>>>> debian/control
4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>8Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
5XSBC-Original-Maintainer: Bernd Zeimetz <bzed@debian.org>9XSBC-Original-Maintainer: Bernd Zeimetz <bzed@debian.org>
6Build-Depends:10Build-Depends:
7 debhelper (>= 11~), autotools-dev, doxygen, libcunit1-dev,11 debhelper (>= 11~), doxygen, libcunit1-dev,
8 libdumbnet-dev, libfuse-dev, libgtkmm-3.0-dev, libgtk-3-dev,12 libfuse-dev, libgtkmm-3.0-dev, libgtk-3-dev,
9 libicu-dev, libnotify-dev, libpam0g-dev, libprocps-dev, libx11-dev,13 libicu-dev, libnotify-dev, libpam0g-dev, libprocps-dev, libx11-dev,
10 libxinerama-dev, libxss-dev, libxtst-dev,14 libxinerama-dev, libxss-dev, libxtst-dev,
11 libmspack-dev,15 libmspack-dev,
@@ -13,10 +17,10 @@ Build-Depends:
13 libxmlsec1-dev,17 libxmlsec1-dev,
14 libudev-dev,18 libudev-dev,
15 libdrm-dev,19 libdrm-dev,
16Standards-Version: 3.9.620Standards-Version: 4.4.0
17Homepage: https://github.com/vmware/open-vm-tools21Homepage: https://github.com/vmware/open-vm-tools
18Vcs-Git: https://github.com/bzed/pkg-open-vm-tools.git22Vcs-Git: https://salsa.debian.org/vmware-packaging-team/pkg-open-vm-tools.git
19Vcs-Browser: https://github.com/bzed/pkg-open-vm-tools23Vcs-Browser: https://salsa.debian.org/vmware-packaging-team/pkg-open-vm-tools
2024
21Package: open-vm-tools25Package: open-vm-tools
22Architecture: amd64 i38626Architecture: amd64 i386
@@ -37,7 +41,8 @@ Package: open-vm-tools-desktop
37Architecture: amd64 i38641Architecture: amd64 i386
38Depends: ${misc:Depends}, ${shlibs:Depends},42Depends: ${misc:Depends}, ${shlibs:Depends},
39 open-vm-tools (= ${binary:Version}),43 open-vm-tools (= ${binary:Version}),
40 fuse44 fuse,
45 kmod,
41Breaks: open-vm-tools (<< 2:10.3.5-2~)46Breaks: open-vm-tools (<< 2:10.3.5-2~)
42Replaces: open-vm-tools (<< 2:10.3.5-2~)47Replaces: open-vm-tools (<< 2:10.3.5-2~)
43Recommends:48Recommends:
diff --git a/debian/copyright b/debian/copyright
index efa4e0d..47ec060 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -29,7 +29,7 @@ License: MIT(**)
2929
30Files: debian/*30Files: debian/*
31Copyright: 2007-2013 Daniel Baumann <mail@daniel-baumann.ch>31Copyright: 2007-2013 Daniel Baumann <mail@daniel-baumann.ch>
32 2014 Bernd Zeimetz <bzed@debian.org>32 2014-2019 Bernd Zeimetz <bzed@debian.org>
33License: GPL-2+33License: GPL-2+
3434
35License: BSD-335License: BSD-3
diff --git a/debian/open-vm-tools.lintian-overrides b/debian/open-vm-tools.lintian-overrides
36new file mode 10064436new file mode 100644
index 0000000..af41546
--- /dev/null
+++ b/debian/open-vm-tools.lintian-overrides
@@ -0,0 +1,2 @@
1# only kernel module source are under GPL.
2open-vm-tools: possible-gpl-code-linked-with-openssl
diff --git a/debian/open-vm-tools.vgauth.service b/debian/open-vm-tools.vgauth.service
index 86f03f2..1b00ca1 100644
--- a/debian/open-vm-tools.vgauth.service
+++ b/debian/open-vm-tools.vgauth.service
@@ -4,6 +4,7 @@ Documentation=http://github.com/vmware/open-vm-tools
4ConditionVirtualization=vmware4ConditionVirtualization=vmware
5DefaultDependencies=no5DefaultDependencies=no
6After=systemd-remount-fs.service systemd-tmpfiles-setup.service6After=systemd-remount-fs.service systemd-tmpfiles-setup.service
7After=apparmor.service
7PartOf=open-vm-tools.service8PartOf=open-vm-tools.service
89
9[Service]10[Service]
diff --git a/debian/patches/89c0d4445_GitHub-Issue-367.-Remove-references-to-deprecated-G_INLINE_FUNC b/debian/patches/89c0d4445_GitHub-Issue-367.-Remove-references-to-deprecated-G_INLINE_FUNC
10new file mode 10064411new file mode 100644
index 0000000..a28cf83
--- /dev/null
+++ b/debian/patches/89c0d4445_GitHub-Issue-367.-Remove-references-to-deprecated-G_INLINE_FUNC
@@ -0,0 +1,90 @@
1From 89c0d444567eb525e8d083fb564c46d68e96660c Mon Sep 17 00:00:00 2001
2From: Oliver Kurth <okurth@vmware.com>
3Date: Mon, 30 Sep 2019 16:24:27 -0700
4Subject: [PATCH] GitHub Issue #367. Remove references to deprecated
5 G_INLINE_FUNC.
6
7G_INLINE_FUNC was a work-around for compilers that didn't support
8static inline. Change uses of it to static inline.
9---
10 open-vm-tools/lib/include/vmware/tools/plugin.h | 2 +-
11 open-vm-tools/lib/include/vmware/tools/threadPool.h | 8 ++++----
12 open-vm-tools/lib/include/vmware/tools/utils.h | 9 ---------
13 3 files changed, 5 insertions(+), 14 deletions(-)
14
15diff --git a/open-vm-tools/lib/include/vmware/tools/plugin.h b/open-vm-tools/lib/include/vmware/tools/plugin.h
16index f9acc6a29..deefd1f3d 100644
17--- a/open-vm-tools/lib/include/vmware/tools/plugin.h
18+++ b/open-vm-tools/lib/include/vmware/tools/plugin.h
19@@ -290,7 +290,7 @@ typedef struct ToolsAppCtx {
20 *
21 * @return TRUE if COM is initialized when the function returns.
22 */
23-G_INLINE_FUNC gboolean
24+static inline gboolean
25 ToolsCore_InitializeCOM(ToolsAppCtx *ctx)
26 {
27 if (!ctx->comInitialized) {
28diff --git a/open-vm-tools/lib/include/vmware/tools/threadPool.h b/open-vm-tools/lib/include/vmware/tools/threadPool.h
29index 3f2082b3e..5880fbcff 100644
30--- a/open-vm-tools/lib/include/vmware/tools/threadPool.h
31+++ b/open-vm-tools/lib/include/vmware/tools/threadPool.h
32@@ -91,7 +91,7 @@ typedef struct ToolsCorePool {
33 *******************************************************************************
34 */
35
36-G_INLINE_FUNC ToolsCorePool *
37+static inline ToolsCorePool *
38 ToolsCorePool_GetPool(ToolsAppCtx *ctx)
39 {
40 ToolsCorePool *pool = NULL;
41@@ -123,7 +123,7 @@ ToolsCorePool_GetPool(ToolsAppCtx *ctx)
42 *******************************************************************************
43 */
44
45-G_INLINE_FUNC guint
46+static inline guint
47 ToolsCorePool_SubmitTask(ToolsAppCtx *ctx,
48 ToolsCorePoolCb cb,
49 gpointer data,
50@@ -153,7 +153,7 @@ ToolsCorePool_SubmitTask(ToolsAppCtx *ctx,
51 *******************************************************************************
52 */
53
54-G_INLINE_FUNC void
55+static inline void
56 ToolsCorePool_CancelTask(ToolsAppCtx *ctx,
57 guint taskId)
58 {
59@@ -197,7 +197,7 @@ ToolsCorePool_CancelTask(ToolsAppCtx *ctx,
60 *******************************************************************************
61 */
62
63-G_INLINE_FUNC gboolean
64+static inline gboolean
65 ToolsCorePool_StartThread(ToolsAppCtx *ctx,
66 const gchar *threadName,
67 ToolsCorePoolCb cb,
68diff --git a/open-vm-tools/lib/include/vmware/tools/utils.h b/open-vm-tools/lib/include/vmware/tools/utils.h
69index f65745906..a3292d5c0 100644
70--- a/open-vm-tools/lib/include/vmware/tools/utils.h
71+++ b/open-vm-tools/lib/include/vmware/tools/utils.h
72@@ -51,15 +51,6 @@
73 # include <sys/time.h>
74 #endif
75
76-
77-/* Work around a glib limitation: it doesn't set G_INLINE_FUNC on Win32. */
78-#if defined(G_PLATFORM_WIN32)
79-# if defined(G_INLINE_FUNC)
80-# undef G_INLINE_FUNC
81-# endif
82-# define G_INLINE_FUNC static __inline
83-#endif
84-
85 #ifndef ABS
86 # define ABS(x) (((x) >= 0) ? (x) : -(x))
87 #endif
88--
892.23.0
90
diff --git a/debian/patches/fix_zfs_fs_detection b/debian/patches/fix_zfs_fs_detection
0new file mode 10064491new file mode 100644
index 0000000..4fed620
--- /dev/null
+++ b/debian/patches/fix_zfs_fs_detection
@@ -0,0 +1,13 @@
1--- a/open-vm-tools/services/plugins/guestInfo/diskInfo.c
2+++ b/open-vm-tools/services/plugins/guestInfo/diskInfo.c
3@@ -826,8 +826,9 @@ GuestInfoGetDiskDevice(const char *fsNam
4 /* Not an LVM; check if a basic block device. */
5 char blockDevPath[PATH_MAX];
6
7+ char* x = strrchr(fsName, '/');
8 Str_Snprintf(blockDevPath, PATH_MAX, "%s/%s", LINUX_SYS_BLOCK_DIR,
9- strrchr(fsName, '/') + 1);
10+ x != NULL ? x+1 : "");
11 GuestInfoLinuxBlockDevice(blockDevPath, partEntry, 1 /* first and only*/);
12 }
13
diff --git a/debian/patches/series b/debian/patches/series
index 0950b30..5b3c1fc 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,6 +1,11 @@
1debian/pam-use-common-auth-account1debian/pam-use-common-auth-account
2debian/max_nic_count2debian/max_nic_count
3debian/scsi-udev-rule3debian/scsi-udev-rule
4<<<<<<< debian/patches/series
4lp-1847157-Fix-memory-leaks-in-vix-tools-plugin.patch5lp-1847157-Fix-memory-leaks-in-vix-tools-plugin.patch
5lp-1847157-End-VGAuth-impersonation-in-the-case-of-error.patch6lp-1847157-End-VGAuth-impersonation-in-the-case-of-error.patch
6lp-1847157-Fix-leaks-in-ListAliases-and-ListMappedAliases-9bc72.patch7lp-1847157-Fix-leaks-in-ListAliases-and-ListMappedAliases-9bc72.patch
8=======
989c0d4445_GitHub-Issue-367.-Remove-references-to-deprecated-G_INLINE_FUNC
10fix_zfs_fs_detection
11>>>>>>> debian/patches/series
diff --git a/debian/rules b/debian/rules
index 62a68ce..ab0cb9e 100755
--- a/debian/rules
+++ b/debian/rules
@@ -20,7 +20,7 @@ override_dh_auto_configure:
20 --with-pic \20 --with-pic \
21 --enable-xmlsec1 \21 --enable-xmlsec1 \
22 --with-gtk3 \22 --with-gtk3 \
23 CFLAGS="-fPIC -Wno-deprecated-declarations $(CFLAGS)" \23 CFLAGS="-fPIC $(CFLAGS)" \
24 CUSTOM_PROCPS_NAME=procps24 CUSTOM_PROCPS_NAME=procps
2525
26override_dh_auto_install:26override_dh_auto_install:
@@ -35,6 +35,7 @@ override_dh_auto_install:
35 # permissions35 # permissions
36 chmod 0644 debian/*/etc/pam.d/*36 chmod 0644 debian/*/etc/pam.d/*
37 chmod 4755 debian/*/usr/bin/vmware-user-suid-wrapper37 chmod 4755 debian/*/usr/bin/vmware-user-suid-wrapper
38 chmod 0644 debian/*/lib/udev/rules.d/99-vmware-scsi-udev.rules
3839
39 install -D -m 0644 debian/local/xautostart.conf debian/open-vm-tools-desktop/etc/vmware-tools/xautostart.conf40 install -D -m 0644 debian/local/xautostart.conf debian/open-vm-tools-desktop/etc/vmware-tools/xautostart.conf
40 install -D -m 0644 debian/local/tools.conf debian/open-vm-tools/etc/vmware-tools/tools.conf41 install -D -m 0644 debian/local/tools.conf debian/open-vm-tools/etc/vmware-tools/tools.conf
@@ -84,8 +85,6 @@ override_dh_gencontrol:
84 else \85 else \
85 dh_gencontrol; \86 dh_gencontrol; \
86 fi87 fi
87override_dh_builddeb:
88 dh_builddeb -- -Zxz
8988
90override_dh_fixperms:89override_dh_fixperms:
91 dh_testroot90 dh_testroot
diff --git a/open-vm-tools/AUTHORS b/open-vm-tools/AUTHORS
index ff87a57..08cc28e 100644
--- a/open-vm-tools/AUTHORS
+++ b/open-vm-tools/AUTHORS
@@ -37,6 +37,15 @@ Ed Schouten Use standard SYSCTL_ADD_OID() macro to access the
37Steve Wills Fix vmmemctl.ko driver build for supported FreeBSD releases.37Steve Wills Fix vmmemctl.ko driver build for supported FreeBSD releases.
38 - https://github.com/vmware/open-vm-tools/pull/14038 - https://github.com/vmware/open-vm-tools/pull/140
3939
40John Eismeier Propose fix some spelling.
41 - https://github.com/vmware/open-vm-tools/pull/264
42
43Josh Paetzel Additional changes to vmmemctl.ko for FreeBSD 12.0 API changes.
44 - https://github.com/vmware/open-vm-tools/pull/286
45
40[Code]Ai Highlighted a potential NULL pointer dereference and four46[Code]Ai Highlighted a potential NULL pointer dereference and four
41 pieces of dead code.47 pieces of dead code.
42 - https://github.com/vmware/open-vm-tools/pull/24748 - https://github.com/vmware/open-vm-tools/pull/247
49
50Haruki Tsurumoto Fix Asianux identification
51 - https://github.com/vmware/open-vm-tools/pull/325
diff --git a/open-vm-tools/ChangeLog b/open-vm-tools/ChangeLog
index 2e5317f..bcbdaeb 100644
--- a/open-vm-tools/ChangeLog
+++ b/open-vm-tools/ChangeLog
@@ -1,40768 +1,20078 @@
1commit 4826a76513b6f8254132f664e07fa70ed18f22c41commit 94abb05ae948eae31091a5bdcdd5d78e5e0192d1
2Author: Oliver Kurth <okurth@vmware.com>2Author: Oliver Kurth <okurth@vmware.com>
3Date: Sat Mar 16 10:40:23 2019 -07003Date: Wed Oct 2 17:48:35 2019 -0700
44
5 update version and build number5 Fix leaks in ListAliases and ListMappedAliases.
66
7commit 990cc40de10f257d1d3c01b69fe476c233afb9507 The 'record' for each alias was being leaked.
8
9commit 87589da5255d84efad0c50446246b2788eeab582
8Author: Oliver Kurth <okurth@vmware.com>10Author: Oliver Kurth <okurth@vmware.com>
9Date: Sat Mar 16 10:39:48 2019 -070011Date: Fri Sep 20 13:11:24 2019 -0700
1012
11 correct verson numbers13 release notes for 11.0.0
1214
13commit f6a274cf64eebfd574e8cf587b4ebaf1c579267f15commit 3c03fd5446ddd23979380fd2518f1f5c7c116dbd
14Author: Oliver Kurth <okurth@vmware.com>16Author: Oliver Kurth <okurth@vmware.com>
15Date: Sat Mar 16 10:27:03 2019 -070017Date: Fri Sep 20 11:08:35 2019 -0700
1618
17 Update release notes for 10.3.1019 update copyright header for lib/include/vmware/guestrpc/tclodefs.h
1820
19commit 640bd4f9c012b201ad1d45a131dad2e804f5376621commit 99145edb39cc1e08b0848ea464fd17dca2ef2541
20Author: Oliver Kurth <okurth@vmware.com>22Author: Oliver Kurth <okurth@vmware.com>
21Date: Wed Feb 6 16:47:22 2019 -080023Date: Fri Sep 20 11:07:16 2019 -0700
2224
23 sync deploypkg files25 update build number for release
2426
25commit 182eda3bc5f371339114241f0581f446e72def6d27commit 570ec94ccfc5bcf2a55d891ae8af2a24bb4e9caf
26Author: Oliver Kurth <okurth@vmware.com>28Author: Oliver Kurth <okurth@vmware.com>
27Date: Tue Feb 5 17:36:53 2019 -080029Date: Thu Aug 29 17:14:39 2019 -0700
2830
29 Update copyright year to 2019 for OVT 10.3.10 files.31 Due to a quirk the way patches were generated, the 'coomon-agent' directory was not removed as intended, but just contained empty files
30
31 * Few dnd related files have been modified since 10.3.5 OVT and
32 we just missed updating the copyright year to 2019.
33
34 * Updated the copyright year accordingly.
3532
36commit ba83c29fcd703ecb6a13a7767bad180033234aea33commit ae791f849d0e49d968a3ba068d6f421de936754d
37Author: Oliver Kurth <okurth@vmware.com>34Author: Oliver Kurth <okurth@vmware.com>
38Date: Tue Jan 29 17:24:44 2019 -080035Date: Fri Aug 23 13:33:55 2019 -0700
3936
40 Fix CentOS 7.6 detection37 tools.conf example: add vss.disableAppQuiescing
41
42 The version information in /etc/centos-release has 3 parts,
43 in particular for CentOS 7.6:
44
45 CentOS Linux release 7.6.1810 (Core)
46
47 This was misidentified as CentOS 6 because the substring "6."
48 was matched before matching "7.". This change fixes this by
49 requiring a space before the major version.
5038
51commit f4708f4b5a9d24b122237875ce6a542f267caab339commit 867f9cf4fd9903e1e10e4d7f70fef3b7fdb2a5d3
52Author: Oliver Kurth <okurth@vmware.com>40Author: Oliver Kurth <okurth@vmware.com>
53Date: Tue Jan 29 17:24:44 2019 -080041Date: Mon Aug 5 11:22:01 2019 -0700
5442
55 Include vmware/tools/log.h to define g_info.43 Enable the guest OS disk mapping feature as default.
56
57 A recent change added a call to g_info from syncManifest.c. This
58 in turn is causing open-vm-tools builds to fail because g_info is
59 not available on SLES 12sp1.
60 44
61 To fix the problem, include vmware/tools/log.h in syncManifest.c.45 Enabling the OS disk mapping feature in VMware Tools 11.0.0 for
62 log.h defines g_info as a macro.46 Windows and Linux guests.
6347
64commit 139a21cab79d971e9fe3ea5b8e993646b2e6cb4848commit 782b42a5248cd01d37f0002aa7e30df4cc787129
65Author: Oliver Kurth <okurth@vmware.com>49Author: Oliver Kurth <okurth@vmware.com>
66Date: Tue Jan 29 17:24:44 2019 -080050Date: Mon Aug 5 11:22:01 2019 -0700
6751
68 Always send VMBACKUP_EVENT_GENERIC_MANIFEST during quiesced snapshots.52 Fix broken command: vmtoolsd --cmd info-get | info-set
69
70 vSphere 6.7 added a host-side interface that allows VMTools to send
71 a "generic" backup manifest during a quiesced snapshot on Linux guests.
72 VMTools 10.2.0 or later tries to notify the host of the backup manifest
73 file through a vmbackup event message VMBACKUP_EVENT_GENERIC_MANIFEST.
74 If the host is unable to field the message, then VMTools logs the
75 failure and then continues with the quiesced snapshot in the older
76 fashion, without the backup manifest.
77
78 An earlier change attempted to reduce the amount of logging done when
79 running on older hosts that don't support VMBACKUP_EVENT_GENERIC_MANIFEST
80 by detecting when sending VMBACKUP_EVENT_GENERIC_MANIFEST fails and
81 not sending the message again for subsequent quiesced snapshots.
82 However, subsequent stress testing has uncovered problems with this
83 approach when running on newer hosts; specifically, errors may sometimes
84 be encountered on newer hosts when sending VMBACKUP_EVENT_GENERIC_MANIFEST.
85 Therefore this change backs out that earlier change.
86
87 Note that the need to solve the problem that that earlier change was
88 intended to solve has been reduced because support for
89 VMBACKUP_EVENT_GENERIC_MANIFEST has been backported to vSphere 6.5
90 P03, which is available, and vSphere 6.0 P08, which is scheduled for
91 release later this year. ESXi 5.5 is out of general support.
92
93 This change also addresses an issue that surfaced when testing on a
94 host without support for VMBACKUP_EVENT_GENERIC_MANIFEST.
95 If VMTools fails to send VMBACKUP_EVENT_GENERIC_MANIFEST, the quiesced
96 snapshot operation will be aborted rather than continuing as it should.
97 To address this, create a new function, VmBackup_SendEventNoAbort,
98 which does not abort the quiesced snapshot on failure, and call that
99 function rather than VmBackup_SendEvent when sending
100 VMBACKUP_EVENT_GENERIC_MANIFEST.
10153
102commit f9a93010ac532ab8eaaeba7f1de5c0c3e732554a54commit d4922cad5f627b1dd3315f59ed8a5ce2f4767e83
103Author: Oliver Kurth <okurth@vmware.com>55Author: Oliver Kurth <okurth@vmware.com>
104Date: Tue Jan 29 17:24:43 2019 -080056Date: Mon Aug 5 11:22:01 2019 -0700
10557
106 Update copyright year to 2019.58 [OVT] Update copyright year to 2019.
59
60 A new version of VMware Tools 11.0.0 will be released in 2019. All
61 applicable files need to stamped with 2019 copyright year.
10762
108commit 74d165bab17132b50d909b7f2e5cb19f3f140a0163commit 5cb75e0a93b9531875e9e29515a0ea912ca3aca7
109Author: Oliver Kurth <okurth@vmware.com>64Author: Oliver Kurth <okurth@vmware.com>
110Date: Tue Jan 29 14:03:19 2019 -080065Date: Mon Aug 5 11:22:00 2019 -0700
11166
112 Fix some bad derefs in primary NIC gather code67 Avoid freezing mount points for same device.
113 68
114 Found by user in https://github.com/vmware/open-vm-tools/issues/27269 Loopback device setup could cause a cyclic dependency
70 between 2 mount points. In order to break the cycle,
71 avoid freezing the mount points to the same device.
115 72
116 Debug code tries to access a struct field that may not be init'd.73 This change also skips some system mount points for 'tmpfs'
117 Pointer deref'd without a sanity check.74 and 'cgroup' etc as those share the same device/FS name.
75 This is fine because we can't quiese those mount points
76 anyway (system mount points don't support quiescing).
11877
119commit e88f91b00a715b79255de6576506d80ecfdb064c78commit 385dc97f645ccaa4a0550b53949715394a009fb6
120Author: Oliver Kurth <okurth@vmware.com>79Author: Oliver Kurth <okurth@vmware.com>
121Date: Tue Jan 29 14:03:19 2019 -080080Date: Mon Aug 5 11:21:59 2019 -0700
12281
123 Fix possible security issue with the permissions of the intermediate82 Add RpcChannel_SendOneRawPriv()
124 staging directory and path
125
126 /tmp/VMwareDnD is a staging directory used for DnD and CnP. It should be
127 a regular directory, but malicious code or user may create the /tmp/VMwareDnD
128 as a symbolic link which points elsewhere on the system. This may provide
129 user access to user B's files.
130 83
131 Do not set the permission of the root directory if the root directory84 Send privileged guest RPC "guestStore.connect" with it after the
132 already exists and has the wrong permission. The permission of the directory85 vmsvc RPC channel falls back to backdoor.
133 must be 1777 if it is created by the VMToolsi. If not, then the directory
134 has been created or modified by malicious code or user, so just cancel the
135 host to guest DnD or CnP operation.
13686
137commit bfa5e5d27a8a96a9c71fbe581f3fe32dcd2e55fd87commit e385c90808d527bce41259796badba094ad62a77
138Author: Oliver Kurth <okurth@vmware.com>88Author: Oliver Kurth <okurth@vmware.com>
139Date: Tue Jan 29 14:03:19 2019 -080089Date: Mon Aug 5 11:21:59 2019 -0700
14090
141 CONSTANT_EXPRESSION_RESULT in TimeUtil_StringToDate().91 Add an example configuration tools.conf file for tools
142 92
143 Red Hat ran coverity scan on open-vm-tools and found an occurrence93 This adds an example tools.conf file. Settings are shown in the
144 of CONSTANT_EXPRESSION_RESULT in TimeUtil_StringToDate().94 file with default values, but commented out with documentation.
14595
146commit 4bba1dcd28806eff0cb3795cbfeea32f91fb1c4096commit decb8769e31e88f23b16b7a6ff3a1545a6259abe
147Author: Oliver Kurth <okurth@vmware.com>97Author: Oliver Kurth <okurth@vmware.com>
148Date: Tue Jan 29 14:03:19 2019 -080098Date: Mon Aug 5 11:21:59 2019 -0700
14999
150 Bail out vmtoolsd early when there are RPC errors.100 [TOOLS] Fix dnd text from Linux guest
151 101
152 VMX state machine could give up quiescing operation for various102 Gtk::Widget::drag_dest_find_target() returns different values from GDK_NONE
153 reasons when vmtoolsd is busy performing necessary state transitions.103 on Gtk2 and Gtk3.
154 Once VMX gives up quiescing operation, there is no point in
155 vmtoolsd continuing with it. vmtoolsd should also give up the
156 operation asap. vmtoolsd can detect VMX state machine change
157 when it gets errors sending VMBACKUP_PROTOCOL_EVENT_SET RPC.
158 104
159 RPC errors are only used as a trigger to abort the operation.105 On Gtk2, it returns an empty string. It matches the existing code.
160 We ignore the RPC errors that might occur after aborting the106 On Gtk3, it returns "NONE". The current logic breaks.
161 operation.107
108 To overcome this issue, use Gdk::AtomString::to_cpp_type(GDK_NONE) to
109 replace the current empty string. This works on both Gtk2 and Gtk3.
162110
163commit 0cb7f7a903015e5e711fa6eb5b41748f797ce794111commit 8d299b17ba81d47f7f561479a688ab1843f904c8
164Author: Oliver Kurth <okurth@vmware.com>112Author: Oliver Kurth <okurth@vmware.com>
165Date: Tue Jan 29 14:03:19 2019 -0800113Date: Mon Aug 5 11:21:59 2019 -0700
166114
167 [10.3.10] Update copyright year to 2019.115 Fix gcc 9.1 build error in vmblocktest.c
168 116
169 Update the copyright year to 2019 for ALL open-vm-tools destined files117 GCC 9.1 in Ubuntu eoan (19.10) failed to build open-vm-tools:
170 modified since the release of 10.3.5.118 error: '__builtin_strncpy' specified bound 4096 equals destination
119 size [-Werror=stringop-truncation]
171120
172commit e569c47f85fa8520f0834148d6774c1cb66df68c121commit e8d08518353295527e635f666c0d3146dcc698cb
173Author: Oliver Kurth <okurth@vmware.com>122Author: Oliver Kurth <okurth@vmware.com>
174Date: Tue Jan 29 14:03:19 2019 -0800123Date: Sat Jul 20 17:10:07 2019 -0700
175124
176 Don't send a backup manifest when aborting a Linux quiesced snapshot.125 version 11.0.0
177 126
178 When taking a Linux quiesced snapshot, communication failures between127commit 82ef6f896c99212c9366e3e52d7767e86d9677c3
179 VMX and VMTools may result in VMTools sending a genericManifest event128Author: Oliver Kurth <okurth@vmware.com>
180 message after the quiesced snapshot operation has been aborted. If129Date: Sat Jul 20 17:03:42 2019 -0700
181 this happens, VMX will send an error back to VMTools, which in turn130
182 causes VMTools not to send genericManifest messages on subsequent131 Fix the memory leak in procMgr library.
183 quiesced snapshots even if the host supports such messages.
184 132
185 One aspect of the implementation that gives rise to this behavior is133 In a specific code path, procCmdAbsPath attribute is ovewritten
186 the use of the sync provider's snapshotDone function to undo a134 with the new memory. This leads to a memory leak for the previously
187 quiescing operation. Specifically, if VMTools aborts a quiesced135 allocated memory.
188 snapshot when the file system is quiesced, the quiescing must be136
189 undone. Currently, this is handled by calling the sync provider's137commit 003ed9e082dd10c67aa022514ad0c662c7e1a6a4
190 snapshotDone function. This is the same function that is called to138Author: Oliver Kurth <okurth@vmware.com>
191 complete the quiescing snapshot protocol when it is successful. In139Date: Sat Jul 20 17:03:42 2019 -0700
192 some respects this makes sense, since in either case snapshotDone140
193 unquiesces the file system. However, architecturally and conceptually,141 GuestInfo: fix memory leak in GuestInfoGetPrimaryIP()
194 it seems useful to distinguish between the action to be taken in the
195 successful case versus the aborting case. It's also useful to do so
196 in practice, because the successful case sends the genericManifest
197 event to notify the host there is a backup manifest file, while the
198 aborting case should not do that.
199 142
200 To address the issue, add an "undo" function for the Linux sync143 "ipstr" was not free'ed when it was not being used.
201 provider. The undo function is called instead of snapshotDone as
202 part of aborting a quiesced snapshot in which the file system is
203 quiesced at the time of the abort.
204144
205commit 81835cd72369b5b75fc5b0bed761f3b75cb7146b145commit 3d60252dc25705841c4afb49e766be2bd7815acd
206Author: Oliver Kurth <okurth@vmware.com>146Author: Oliver Kurth <okurth@vmware.com>
207Date: Tue Jan 29 14:03:18 2019 -0800147Date: Sat Jul 20 17:03:42 2019 -0700
208148
209 Special-case profile loading for StartProgram149 Avoid emitting a trailing comma in the GuestInfoSendDiskInfoV1 JSON RPC
210 150
211 Keep the user's profile loaded for the life of the151 Although currently accepted by the JSON library that we are using
212 program, to avoid races where its unloaded too quickly.152 in VMX, that superfluous comma is strictly invalid according to the
153 JSON standard - ECMA-404.
213154
214commit d3515adb2a1617dcde4b65a6a9ab72ee8624454b155commit f65edaec32d2e1c7c14d69f4f2af669805cfd4b4
215Author: Oliver Kurth <okurth@vmware.com>156Author: Oliver Kurth <okurth@vmware.com>
216Date: Tue Jan 29 14:03:18 2019 -0800157Date: Sat Jul 20 17:03:42 2019 -0700
217158
218 Changes to common source files not applicable to open-vm-tools.159 [Tools/dndcp] Fix two coverity issues reported by a customer.
219160
220commit 4d3e3183bc04517cf75ab590a12e14224207eb6d161commit 74fe39c2abac9da4d45188eec8b389be421f7c8f
221Author: Oliver Kurth <okurth@vmware.com>162Author: Oliver Kurth <okurth@vmware.com>
222Date: Tue Jan 29 14:03:18 2019 -0800163Date: Sat Jul 20 17:03:42 2019 -0700
223164
224 Bump up the SYSIMAGE_VERSION for VMware tools 10.3.10165 Add the SLEDGEHAMMER code name to the 11.0.0 release version defines.
225
226 The last released deploypkg version for 'VMware Tools' 10.3.5 is 8.4.1.
227 Bumping up the CBS version to 8.4.10.
228166
229commit 8f3630e77bcf647c22c40093bb37500f3032e578167commit 0c6ad5edceca60dc05eb9f3b1ee6ac42dc0455ef
230Author: Oliver Kurth <okurth@vmware.com>168Author: Oliver Kurth <okurth@vmware.com>
231Date: Tue Jan 29 14:03:18 2019 -0800169Date: Wed Jul 3 14:28:56 2019 -0700
232170
233 Deploypkg log files of linux should not be world readable.171 Fix a Coverity issue reported in vgauth/serviceImpl/verify.c
234172
235commit 4470d99e5eaf19cea741e6fa6f46c72acd57b3e1173commit 47c8f75e4516552615c070c6920633f7e8e572a0
236Author: Oliver Kurth <okurth@vmware.com>174Author: Oliver Kurth <okurth@vmware.com>
237Date: Tue Jan 29 14:03:18 2019 -0800175Date: Wed Jul 3 14:28:56 2019 -0700
238176
239 General code clean-up.177 Fix process command name for special linux processes.
240 178
241 bora/lib/misc/posixPosix.c:179 While listing down the processes in a linux guest, the existing
242 Treat local variables "len" consistently as "size_t" type in180 procMgr library reads /proc/<PID>/cmdline file and parses the
243 Posix_Getmntent_r()181 content. While reading this, an assumption is made that there is
182 a null terminating character at the end of the file content.
183 This holds true for most of the processes. But for few special processes,
184 the cmdline file doesn't have the terminating null character.
244 185
245 bora-vmsoft/apps/toolbox-cmd/toolboxcmd-shrink.c:186 Proper content from cmdline file:
246 Improve readability of error handling logic in ShrinkDoWipeAndShrink()
247 and remove another line of dead code.
248 187
249 bora-vmsoft/lib/procMgr/procMgrPosix.c:188 /usr/lib/systemd/systemd\0--switched-root\0--system\0--deserialize\021\0
250 Recent discussions about setting "errno" to ENOENT when either189 /usr/sbin/vmtoolsd\0
251 getpwuid_r() or getpwnam_r() return 0 (success) if there is no passwd190 sshd: root@pts/2\0\0\0
252 entry for the user have vacillated.191
192 Example cmdline file where NUL terminator is missing:
253 193
254 Since none of the current callers of the routines in procMgrPosix.c194 avahi-daemon: running [linux.local]
255 query the contents of "errno", the current consensus is to simply log195 avahi-daemon: chroot helper
256 a warning message along with reason for the failure.
257196
258commit 5f3f6ccd3ad143d64f2927bd19791a6148e1e2ba197commit 2660d40ca4f5beca0ba3a4c68a66f8c7dcf77a67
259Author: Oliver Kurth <okurth@vmware.com>198Author: Oliver Kurth <okurth@vmware.com>
260Date: Tue Jan 29 14:03:18 2019 -0800199Date: Wed Jul 3 14:28:56 2019 -0700
261200
262 Fix NULL pointer dereference and remove three lines of dead code.201 Fix the command name for few linux processes.
263 202
264 QbitLogic has run [Code]Ai on the open-vm-tools source code and203 ProcMgr library publishes the 'command name' attribute for
265 and notified VMware of a potential NULL pointer reference and four204 each process while listing down all the processes. For doing this,
266 pieces of dead code.205 the commandline is first parsed from /proc/<PID>/cmdline file
206 and the part starting from the right-most '/' is considered as the
207 command name. This is OK only if we have an absolute path for the
208 command binary. Other wise, this may result in incorrect results.
267 209
268 See https://github.com/vmware/open-vm-tools/pull/247210 For example:
211 sshd: root@pts/1
212 gdm-session-worker [pam/gdm-autologin]
269 213
270 bora-vmsoft/services/vmtoolsd/pluginMgr.c214 Fixed the code to ignore the parsing if we do not have an absolute
271 The proposed fix conditionally emitted a log message. That fix has215 path.
272 been reworked to consistently emit a log message with conditional
273 content.
274 216
275 bora/lib/misc/posixPosix.c217 Note: There are two ways how the command name is retrieved for each
276 bora-vmsoft/apps/toolbox-cmd/toolboxcmd-shrink.c218 process.
277 Remove one line of dead code from each source file.
278 219
279 bora-vmsoft/lib/procMgr/procMgrPosix.c:220 1. /proc/<PID>/cmdline is parsed.
280 Suggested dead code fix actually pointed to a bug where errno
281 was not getting updated as intended.
282 221
283 bora-vmsoft/services/plugins/guestInfo/perfMonLinux.c:222 If (1) fails for some reason, then
284 Suggested dead code is no longer dead; change not applicable.223
224 2. /proc/<PID>/status is parsed.
225
226 There is no issue with (2). This changeset fixes the parsing issue only
227 with (1) approach mentioned above.
285228
286commit f10780bc3d7119d90bf72c0cf2f07066955d7d98229commit 7aaf580b14f44a994100ede098e0ced5d60ba484
287Author: Oliver Kurth <okurth@vmware.com>230Author: Oliver Kurth <okurth@vmware.com>
288Date: Tue Jan 29 14:03:18 2019 -0800231Date: Wed Jul 3 14:28:56 2019 -0700
289232
290 Bump VMware Tools version to 10.3.10 for the next scheduled update release233 Add support for NVMe disks; IDE and SATA disk devices in 3.x Linux kernels
291 234
292 Set the VMware Tools version as TOOLS_VERSION_JACKHAMMER_UPDATE2 = 10.3.10235 Support has been added for virtual disks attached to an NVMe
236 controller. The device "label" will provide the "nvme<n>" for the
237 controller. The disk unit is provided in the device "nsid" file.
238 An earlier implementation (Linux 2.6 kernels) provided the unit
239 number as the final digit group in the device node name.
240
241 The Linux 3.x kernel has some differences in the layout of IDE and
242 SATA disk devices in the sysfs filesystem. The differences from the
243 sysfs in a 2.6 Linux kernel are:
244 - The IDE "class" file and SATA "class" and "label" files are in a
245 different directory.
246 - IDE controller and SATA device nodes begin with "ata" where "host"
247 was used in earlier kernel sysfs filesystems.
248
249 GuestInfoGetDevClass() has been modfied to check in two possible
250 locations for the "class" file. The directory located will also
251 contain the "label" file for SCSI, SAS, and SATA disk devices.
252
253 GuestInfoGetIdeSataDev() has been modified to search for either
254 ata<n> or host<n> directories in the sysfs tree for the disk device.
293255
294commit f2ff192717375b95a6b7e278fb47dbb3d3bc56d1256commit 193a5f93d6678b2ebfec1cf365a84bfd8533650d
295Author: Oliver Kurth <okurth@vmware.com>257Author: Oliver Kurth <okurth@vmware.com>
296Date: Wed Nov 7 15:00:09 2018 -0800258Date: Wed Jul 3 14:26:55 2019 -0700
297259
298 release notes for 10.3.5260 Common header file change not applicable to open-vm-tools.
299261
300commit 8f98dbc87304546cbb75756bbad8ba0dbc0221a4262commit 2657373a9321ad4090af75d84beac00836170e27
301Author: Oliver Kurth <okurth@vmware.com>263Author: Oliver Kurth <okurth@vmware.com>
302Date: Wed Nov 7 14:13:03 2018 -0800264Date: Wed Jul 3 14:26:55 2019 -0700
303265
304 add 10.3.5 changes to ChangeLog266 Truncate oversize partition names
305commit 583fc02dbee4ba88a20c67a0f5e5a9b023b551ea267
268 Truncate disk partition names if they are too large, rather than just
269 skipping all the disk information for the guest. Closes
270 https://github.com/vmware/open-vm-tools/issues/346 .
271
272commit 6b8ffb7199159ab3a306646bc572f6a83a8ce7f6
306Author: Oliver Kurth <okurth@vmware.com>273Author: Oliver Kurth <okurth@vmware.com>
307Date: Tue Nov 6 17:14:40 2018 -0800274Date: Wed Jul 3 14:26:55 2019 -0700
308275
309 bump version and build number276 Common header file change not applicable to open-vm-tools.
310277
311commit d51ec15038c43472e9bc48de7081b0954a122f97278commit fe04b4263ae90af524fe51e124e206df737e974b
312Author: Oliver Kurth <okurth@vmware.com>279Author: Oliver Kurth <okurth@vmware.com>
313Date: Tue Nov 6 17:13:04 2018 -0800280Date: Wed Jul 3 14:26:55 2019 -0700
314281
315 sync deploypkg files282 Suppress possible NULL pointer deref in a debug message.
316283
317commit b4b07f53c71a83beed8fdc11f2dfeeb43aa20fda284commit 130334ca6f1cf6d696b0fe36d54b83f1f7d7bc2e
318Author: Oliver Kurth <okurth@vmware.com>285Author: Oliver Kurth <okurth@vmware.com>
319Date: Fri Oct 5 13:55:27 2018 -0700286Date: Wed Jul 3 14:26:55 2019 -0700
320287
321 Use bitwise AND operation while fetching current IOPL.288 Common header file change not applicable to open-vm-tools.
322
323 Iopl_Get() was using logical AND operation which could result
324 in wrong IOPL value. We should be using bitwise AND instead.
325289
326commit 87593b29e5c337141be65e4430fb95a4f1741afb290commit ace8b9e3c13a0b320835d36f569d2c7e5c6513a7
327Author: Oliver Kurth <okurth@vmware.com>291Author: Oliver Kurth <okurth@vmware.com>
328Date: Fri Oct 5 13:55:27 2018 -0700292Date: Wed Jul 3 14:26:55 2019 -0700
329293
330 Optional override for short and long OS names sent from Tools294 Changes to common header files not applicable to open-vm-tools.
331
332 Added support for customers to override the returned long and short OS
333 names through the tools config file. If the setting is present, then names
334 gathered by hostinfo will be ignored. The user is responsible for setting
335 the appropriate names.
336
337 The override will be ignored if the short-name setting is not present in
338 tools.conf.
339
340 An empty string will be sent for the long OS name if only the short-name
341 setting is present.
342
343 Appropriate warning msg will be generated in both cases.
344
345 Example of the conf setting:
346
347 [guestosinfo]
348 short-name = centos6-64
349 long-name = some long name
350295
351commit b08cd0da457263f80e84ca95348c2a97cb7e22a5296commit eda7db540bb048ac406e6624786c300cb17968c2
352Author: Oliver Kurth <okurth@vmware.com>297Author: Oliver Kurth <okurth@vmware.com>
353Date: Mon Sep 17 16:41:19 2018 -0700298Date: Wed Jul 3 14:26:55 2019 -0700
354299
355 Hgfs Server Linux: fix the share permissions on a file rename or delete300 Common header file change not applicable to open-vm-tools.
356
357 Coverity found that the argumeents to obtain the share permissions
358 on a file rename were swapped. Even though they are tested together
359 in an if statement which is not an issue, it could be in the future.
360
361 Reverse arguments so the share read and write permissions are correct.
362301
363commit bdde701699212ca7fb118f3a49a9bbc7fb06df68302commit 7b17b7265ad31f2ed3dc6d6d28c5a4caf4c12e5c
364Author: Oliver Kurth <okurth@vmware.com>303Author: Oliver Kurth <okurth@vmware.com>
365Date: Mon Sep 17 16:41:18 2018 -0700304Date: Wed Jul 3 14:26:55 2019 -0700
366305
367 Hgfs FUSE Client: fix missing pthread_mutex_unlock call306 Common header file change not applicable to open-vm-tools.
368
369 Fix missing pthread_mutex_unlock call in HgfsSetAttrCache when
370 updating the cached attributes on a file and a memory allocation
371 fails.
372307
373commit 01376aca4d4bee5efed9b4b2597d141722a7feb5308commit 59d4eda2fc89e43ac092d82866c42c9692ebca68
374Author: Oliver Kurth <okurth@vmware.com>309Author: Oliver Kurth <okurth@vmware.com>
375Date: Mon Sep 17 16:41:18 2018 -0700310Date: Wed Jul 3 14:26:54 2019 -0700
376311
377 Bump up the SYSIMAGE_VERSION for VMware Tools 10.3.5312 Common header file change not applicable to open-vm-tools.
378313
379commit 7fc13e2b58dc91627d4ff78fd532b77898adf2d2314commit 8fe237da4894488e9cb0fccdec1f0d8180998a24
380Author: Oliver Kurth <okurth@vmware.com>315Author: Oliver Kurth <okurth@vmware.com>
381Date: Mon Sep 17 16:41:18 2018 -0700316Date: Wed Jul 3 14:26:54 2019 -0700
382317
383 Update the copyright year for OVT bundled files modified since 10.3.2318 Common header file change not directly applicable to open-vm-tools.
384319
385commit c7a186e204cdff46b5e02bcb5208ef8979eaf261320commit e266c0bb1879792f24b29d38af9f9f833475f228
386Author: Oliver Kurth <okurth@vmware.com>321Author: Oliver Kurth <okurth@vmware.com>
387Date: Mon Sep 17 16:41:18 2018 -0700322Date: Wed Jul 3 14:26:54 2019 -0700
388323
389 Handle Linux kernel /proc FS uint32 type stat overflow when calculating324 Changes to common source files not directly applicable to open-vm-tools.
390 tools rate stats.
391 325
392 On both 32-bit and 64-bit Linux, tools always parses Linux kernel /proc326 Reduce malloc/free overheads in the VMX for HGFS over VMCI
393 FS stats as uint64 values. For rate stats, current - previous can handle
394 uint64 type stat overflow, but not uint32 type.
395327
396commit 064d0a3458991f0c34a397664b6b5cd8cc00e5b3328commit 9c30be3448c743e51718480543142bf833ea553a
397Author: Oliver Kurth <okurth@vmware.com>329Author: Oliver Kurth <okurth@vmware.com>
398Date: Mon Sep 17 16:41:18 2018 -0700330Date: Mon Jun 17 11:41:38 2019 -0700
399331
400 nicinfo: skip loopback devices332 copyPasteCompatX11.c code generating unnecessary Coverity warning
401 333
402 When libdnet isn't used, loopback devices were reported. This change334 This patch aims to fix an issue found by Coverity Scan.
403 skips these interfaces. Also skip interfaces that are down.
404 335
405 The interface was visible with vim-cmd, but not in the VC or336 This issue is a False Positive, the outBuf is only freed in specific
406 ESX UI. It did not contain any IP addresses.337 scenario, so there is no 'BAD FREE'. But it's better to reconstruct the
338 related code to clear the SCA error.
407339
408commit 8979f11f78ef7fdbb51afa298896e06b4d874e5b340commit a72b4c2513b8faf4e5b08b085583a43b1b6149a1
409Author: Oliver Kurth <okurth@vmware.com>341Author: Oliver Kurth <okurth@vmware.com>
410Date: Mon Sep 17 16:41:18 2018 -0700342Date: Mon Jun 17 11:41:38 2019 -0700
411343
412 Allow only a single instance of vmusr when multiple users are logged into a VM344 Common header file change not applicable to open-vm-tools.
413 345
414 When a vmusr process gets the "channel conflict" error while attempting346commit 680c9d4a412a099efde6382a0a4e5f300bc4fc4e
415 to open the toolbox-dnd channel, a channel reset is triggered. That347Author: Oliver Kurth <okurth@vmware.com>
416 reset results in the channel being restarted and a subsequent conflict348Date: Mon Jun 17 11:41:38 2019 -0700
417 and reset occurs - every second until the channel becomes available.349
418 350 linuxDeployment.c: Suppress the telinit error if the first telinit commands
419 For *nix guests:351 has made VM reboot.
420 The fix is making use of the repetitive channel resets where the only
421 RpcIn message received is a "reset" to catch this channel "permanently"
422 unavailable state. If other RpcIn messages are received, a channel
423 is considered to be working and the cumulative error count is cleared..
424
425 lib/rpcin/rpcin.c:
426 - struct RpcIn: Added error status boolean and callback function to
427 notify the dependent layer that a channel error has been
428 resolved.
429 - RpcInLoop(): If a non "reset" message is received, clear any channel
430 error status. This will also notify the dependent layer
431 that the channel is functioning.
432 - RpcIn_start(): Added additional argument for new callback; NULL if
433 not needed.
434
435 lib/rpcChannel/rpcChannel.c:
436 - struct rpcChannelInt:
437 - Renamed "rpcErrorCount" to "rpcResetErrorCount" since it is actually
438 a count of the consecutive channel reset failures and not a count
439 of RpcChannel errors.
440 - Added counter "rpcFailureCount" for the cumulative channel errors.
441 - Added "rpcFailureCb" for optional callback to notify the app of a
442 "permanent" channel failure.
443 - New function RpcChannelClearError() for RpcIn to notify when the
444 channel is working; to clear the rpcFailureCount .
445 - RpcChannel_Setup() - added two arguments for (1) an optional function
446 to be called when there is a channel failure
447 and (2) a failure count threshold.
448 These optional values are stored in the
449 RpcChannel structure being created.
450 - RpcChannelError(): Added logic to notify the calling app if the error
451 threshold has been reached and notify the app if a
452 callback was provided. A zero threshold signifies
453 the single vmusr limit should not be enforced.
454 (fix disable switch).
455
456 services/vmtoolsd/mainLoop.c:
457 - New function ToolsCore_GetVmusrLimit() to retrieve the channel error
458 threshold default or over-ride from tools.conf.
459 352
460 services/vmtoolsd/toolsRpc.c:353 The code executes '/sbin/telinit 6' repeatedly to reboot VM. VM will be
461 - Added ToolsCoreAppChannelFail(): Callback for "permanent" channel354 rebooting if the telinit command executed successfully(exitcode==0).
462 connection failure. A warning is logged based on whether another355 Observed the repeated telinit command might get error(exitcode==1) on some
463 "vmtoolsd -n vmusr" is running or not and the process is terminated.356 GOSes, ex: Ubuntu18.04, RHEL7.4/7.5 and Fedora 29.
464 On Mac OS, the process is terminated with exit(1) as an indication357 Observed no such error on older GOSes, ex: Ubuntu14.04, RHEL6.6
465 to launchd that the vmusr process should not automatically be
466 restarted.
467 358
468 The current implementation uses the error callback only for the vmusr359 The error telinit log is confusing, actually it does NOT mean customization
469 server on Linux (*nix).360 failed.
470 The default channel error limit is 5 (approx. 5 second), but is user
471 configurable in tools.conf.
472 361
473 [vmusr]362 This change does NOT log telinit error, and returns deployPkg status to
474 maxChannelAttempts = n # where allowed n = 0, 3-15363 make sure the log is consistent with customization result when the first
364 'telinit 6' succeeded but one of the following 'telinit 6' command failed.
475 365
476 When "maxChannelAttempts = 0" is used, the restriction to a single366 The following actions are unchanged with or without this change:
477 running vmusr process is not enforced. The existing behavior is367 1. log telinit error, stop loop and exit 127 if the first 'telinit 6' fails.
478 restored with all the accompanying VMX log spew. This is essentially368 2. repeatedly execute 'telinit 6' if previous one executed successfully
479 a user configurable feature disablement switch.369 (exitcode==0).
480370
481commit 0c34a86b232a9904941f825ce8b16320cadaace1371commit 37d8b16e2cc1a21919cb6974c2a87071a345e232
482Author: Oliver Kurth <okurth@vmware.com>372Author: Oliver Kurth <okurth@vmware.com>
483Date: Mon Sep 17 16:41:17 2018 -0700373Date: Mon Jun 17 11:41:37 2019 -0700
484374
485 Changes to common header files not directly applicable to open-vm-tools375 Common header file change not applicable to open-vm-tools.
486 376
487 VGAuth Windows: fix file properties product version and file version377commit 8c87c985179a7a152c9a36aa83edd2b02fc7894d
488 378Author: Oliver Kurth <okurth@vmware.com>
489 Product name of the VGAuth binaries are set to VMware Workstation and379Date: Mon Jun 17 11:41:37 2019 -0700
490 the Product version set to experimental (e.x.p).380
491 381 Common header file change not applicable to open-vm-tools.
492 Experimental version has the e.x.p build number in the Product Version382
493 field of each of the shipped binaries. Now that we are WHQL signing a DLL too383commit 9e1d3be7c075e8ca4c7ff07b8dadeab8a14953b3
494 for security it does make sense for the feature to use an official version.384Author: Oliver Kurth <okurth@vmware.com>
385Date: Mon Jun 17 11:41:37 2019 -0700
386
387 HgfsServer: Fix coverity issue - uninitialized variable "requestId"
495 388
496 This changes the Product name and version fields from389 Fix coverity uninitialized variable "requestId" by zeroing it
497 Product name -> VMware Workstation390 in HgfsServerGetRequest before passing to the request packet
498 Product version -> e.x.p build-4013326391 HgfsUnpackPacketParams extraction function which will use it
392 in a log message.
499 393
500 to394 Also moved an assert useful for testing protocol changes which was
501 Product name -> VMware Guest Authentication395 incorrect in its placement.
502 Product version -> 1.0.0 build-4013326
503396
504commit 5f5a7f4a0984ee35ce79d736426a5335c91da332397commit d2213fb32a1357305e72cbd6856f5e5ea9e151da
505Author: Oliver Kurth <okurth@vmware.com>398Author: Oliver Kurth <okurth@vmware.com>
506Date: Fri Sep 7 15:53:28 2018 -0700399Date: Mon Jun 17 11:41:37 2019 -0700
507400
508 Remove vmxnet and vmxnet3 drivers from FreeBSD builds and open-vm-tools401 Changes to common header files not applicable to open-vm-tools.
509
510 The vmxnet (version 1) network driver is not supported by any currently
511 supported VMware virtualization platform. Removing the FreeBSD
512 specific vmxnet source and deleting the vmxnet.ko driver build from
513 the tools and the open-vm-tools builds.
514 402
515 FreeBSD has their own vmxnet3 network driver based on community source403 Remove checks for GCC 4.1 in xsave, xrstor, etc. instructions
516 and has never made use of the vmxnet3 source code or drivers from
517 VMware. Removing the unneeded FreeBSD vmxnet3 source and builds
518404
519commit 1a413064fee53ac3e334e96c546886e60724d07a405commit 83dbe8ed5bf6f9e770e22c670c5617bc93e48e55
520Author: Oliver Kurth <okurth@vmware.com>406Author: Oliver Kurth <okurth@vmware.com>
521Date: Fri Sep 7 15:53:27 2018 -0700407Date: Mon Jun 17 11:41:37 2019 -0700
522408
523 Update SSL configuration with more secure settings.409 Determine Linux OS disk devices associated with mounted filesystems.
524 410
525 Due to SSL issues in the past, The preference is to have default411 For each filesystem for which disk guestInfo is currently collected,
526 settings to be more secure than compatible. This change mainly412 determine the virtual hardware device being used. This is currently
527 inherits the default settings from ssl.c.413 represented as <cntrl class><cntrl #>:<device #>, eg. scsi0:0,
414 scsi1:0, ide0:0 or sata1:4 and matches the virtual device label seen
415 in VMX.
416
417 A Linux logical volume based filesystem can reside on multiple disks.
418 In order to handle LVMs, the disk devices for each filesystem are
419 maintained as a variable array of disk device names.
420 For Linux guests, disk device names are passed as a json array.
528421
529commit 450aca9f244b5e56bcef130df1a06137fd1f07e0422commit 9bfd01b26e7d22aa847d6282e9b814b05a41e80e
530Author: Oliver Kurth <okurth@vmware.com>423Author: Oliver Kurth <okurth@vmware.com>
531Date: Fri Sep 7 15:53:27 2018 -0700424Date: Mon Jun 17 11:41:37 2019 -0700
532425
533 Add virbr* interfaces on RHEL to the default exclude-nics.426 Common header file change not applicable to open-vm-tools.
534427
535commit 5a6e8bc0ef8af2eedbbc4dc1973cb7fe18afa939428commit f456a5938662175b914ffcb53c6284835476268f
536Author: Oliver Kurth <okurth@vmware.com>429Author: Oliver Kurth <okurth@vmware.com>
537Date: Fri Sep 7 15:53:27 2018 -0700430Date: Mon Jun 17 11:41:37 2019 -0700
538431
539 Fix a gcc-8 compiler warning in lib/misc/vthreadBase.c432 Fix 'Using uninitialized value' issue reported by Coverity.
540 433
541 gcc-8 generates a stringop-truncation warning when it's possible434 * In a error code path, 'exitCode' variable is used without
542 for strncpy to exclude the trailing nul. The code was fine, we never435 any initialization. This issue was reported by the Coverity.
543 touch the last byte in the buffer and it's a static, but explicitly436 Fixed it by initializing the 'exitCode' to -1.
544 set a nul at the end of the buffer so gcc sees it.
545 437
546 This is needed for open-vm-tools to build on Suse Tumbleweed.438 * While fixing this, moved the variables to the if block where
439 they are acutally used.
547440
548commit 5200ba3a770463e5c6a9e9d7e7a6a949857332ec441commit 2b3de798522314545b00297f1ece86b223dbeb6f
549Author: Oliver Kurth <okurth@vmware.com>442Author: Oliver Kurth <okurth@vmware.com>
550Date: Fri Sep 7 15:53:27 2018 -0700443Date: Mon Jun 17 11:41:36 2019 -0700
551444
552 Return proper vix error code when guest op VIX_COMMAND_DELETE_GUEST_DIRECTORY_EX fails.445 Common header file change not applicable to open-vm-tools.
553446
554commit 8ffda7dbae4b916b28e3f903554bc37db1d5f974447commit 7cf4c83d4a0b580209184bb4d5ac6c26cd5734f4
555Author: Oliver Kurth <okurth@vmware.com>448Author: Oliver Kurth <okurth@vmware.com>
556Date: Fri Sep 7 15:53:27 2018 -0700449Date: Mon Jun 17 11:41:36 2019 -0700
557450
558 Make Tools logfiles readable only by owner and root451 Fix leak in error path reported by Coverity.
559452
560commit b0e2fab2787fbc511d240c4ce0f52a74b55152fe453commit 1b32002d84c1dbb6dbe34586c04b84d26224c5ee
561Author: Oliver Kurth <okurth@vmware.com>454Author: Oliver Kurth <okurth@vmware.com>
562Date: Fri Sep 7 15:53:27 2018 -0700455Date: Mon Jun 17 11:41:36 2019 -0700
563456
564 Reduce quiesced snapshot warning messages when running on older hosts.457 Common source file change not directly applicable to open-vm-tools.
565
566 vSphere 6.7 added a new interface on the host side that allows tools
567 to send a "generic" backup manifest during a quiesced snapshot on
568 Linux guests. VMTools 10.2.0 or later will try to send the manifest
569 file and if the host is unable to field it, then VMTools logs this
570 information and continues with the quiesced snapshot in the older
571 fashion. This change reduces the logging that is done in this case.
572458
573commit a4b4c338f1202d161e8cad2eb7cf78d44f2fd302459commit 5260daab25ee9afdd5267531516b45f5006d57d1
574Author: Oliver Kurth <okurth@vmware.com>460Author: Oliver Kurth <okurth@vmware.com>
575Date: Fri Sep 7 15:53:27 2018 -0700461Date: Mon Jun 17 11:41:36 2019 -0700
576462
577 Common source file change not directly applicable to open-vm-tools463 Improvements for ProcMgr library.
578 464
579 Verify existence of the returned path, retry the guest OP465 * This changeset fixes various issues related to ProcMgr library.
580 CreateTemporaryFileInGuest/CreateTemporaryDirectoryInGuest using system466
581 temp folder if the path disappears.467 == Retrieve the absolute path of the image for each process ==
468 * When listing down the processes, it is useful to retrieve the
469 absolute path of the process binary.
470
471 === For Linux ===:
472 * In /proc filesystem, /proc/{PID}/exe is a symlink to the binary
473 and we can make use of it to figure out the absolute path.
474
475 * If /proc/{PID}/exe is not a valid symlink, then the 'cmdline'
476 is parsed and aboslute path is calculated accordingly.
477
478 * Note: This changeset tries its best to figure out the absolute path.
479 If it can't, then the attribute is set to NULL.
480
481 == Misc issues fixed. ==
482 === Linux ===
483 * Fixed a memory leak with 'procCmdName' while looping through the
484 /proc/ directory entries.
485
486 * Fixed another memory leak with cmdLineTemp and cmdStatTemp variables
487 while listing down the processes in linux guests.
488
489 * In few cases, /proc/{PID}/cmdline file contains multiple NUL
490 characters at the end. In that case, the existing code converts them
491 into 'whitespaces'. Fixed the code to chop of all the trailing
492 whitespaces in the command line.
582493
583commit b6c450d123141a752bd4805263b7d476f5b1f26b494commit ffdf5a69fa3654dc3a16bf9951171290f48561b8
584Author: Oliver Kurth <okurth@vmware.com>495Author: Oliver Kurth <okurth@vmware.com>
585Date: Fri Sep 7 15:53:27 2018 -0700496Date: Mon Jun 17 11:41:35 2019 -0700
586497
587 Fix coverity complaint; not a real bug498 Skip loading/unloading user profile for VMXI_HGFS_SEND_PACKET_COMMAND.
499
500 This command is used repeatedly to transfer file to/from the guest.
588501
589commit 23bd37544bb9ae4069002d73cb1c1b40e221d36a502commit e858e40d2beb08880e62ccac3f9dcf3661f3e093
590Author: Oliver Kurth <okurth@vmware.com>503Author: Oliver Kurth <okurth@vmware.com>
591Date: Fri Sep 7 15:53:27 2018 -0700504Date: Mon Jun 17 11:41:35 2019 -0700
592505
593 Common source file change not directly applicable to open-vm-tools.506 Common header file change not applicable to open-vm-tools.
594507
595commit c2dd430ea5c8c9309700d25548513469dae68c9b508commit 653248aaff38309a1660f84a347b7eff70e64701
596Author: Oliver Kurth <okurth@vmware.com>509Author: Oliver Kurth <okurth@vmware.com>
597Date: Fri Sep 7 15:53:26 2018 -0700510Date: Mon Jun 17 11:41:35 2019 -0700
598511
599 Disable hgfsServer plugin when not running in a VMware VM.512 Common header file change not applicable to open-vm-tools.
600
601 VmCheck_GetVersion() accesses Backdoor in an unsafe manner
602 which is not expected to work on non-VMware environments
603 including physical machines. So, we need to make sure that
604 VmCheck_GetVersion() is called only when we are running in
605 a VMware VM.
606513
607commit 31a60ab3529a8dad8d602a524d194013d90abeec514commit 2ca144aceda2bae479f3b67eb0d60e4ef7e439dc
608Author: Oliver Kurth <okurth@vmware.com>515Author: Oliver Kurth <okurth@vmware.com>
609Date: Fri Sep 7 15:53:26 2018 -0700516Date: Mon Jun 17 11:41:35 2019 -0700
610517
611 Expose more guest stats for vROPS to report the exact physical memory518 Common header file change not applicable to open-vm-tools.
612 stats as the guest OS UI does.
613
614 Windows:
615 guest.mem.modifiedPages (Win32_PerfRawData_PerfOS_Memory#ModifiedPageListBytes)
616 guest.mem.standby.core (Win32_PerfRawData_PerfOS_Memory#StandbyCacheCoreBytes)
617 guest.mem.standby.normal (Win32_PerfRawData_PerfOS_Memory#StandbyCacheNormalPriorityBytes)
618 guest.mem.standby.reserve (Win32_PerfRawData_PerfOS_Memory#StandbyCacheReserveBytes)
619
620 Linux:
621 guest.mem.total (/proc/meminfo#MemTotal)
622 guest.mem.buffers (/proc/meminfo#Buffers)
623 guest.mem.cached (/proc/meminfo#Cached)
624 guest.mem.slabReclaim (/proc/meminfo#SReclaimable)
625 guest.mem.available (/proc/meminfo#MemAvailable since Linux 3.14, emulated by VMTools for kernels 2.6.27+)
626519
627commit 0b01aefe3ee960c6035863bcf4fd7e2ff654b99b520commit 3583ad84072c618064dfea742faa763b5f8207f0
628Author: Oliver Kurth <okurth@vmware.com>521Author: Oliver Kurth <okurth@vmware.com>
629Date: Fri Sep 7 15:53:26 2018 -0700522Date: Mon Jun 17 11:41:35 2019 -0700
630523
631 Update the tools version to 10.3.5524 Common header file change not applicable to open-vm-tools.
632 525
633 Set the tools version in vm_tools_version.h to be526commit 4e06bc447106be090fefdb6ea057482152390d73
634 TOOLS_VERSION_JACKHAMMER_UPDATE1 = 10.3.5.527Author: Oliver Kurth <okurth@vmware.com>
528Date: Mon Jun 17 11:41:33 2019 -0700
529
530 Common header file change not applicable to open-vm-tools.
635531
636commit 2147df6aabe639fc5ff423ed791a8e7f02bf8d0a532commit be8b98cda2d3149966b73d91cc76e77bf19d8228
637Author: Oliver Kurth <okurth@vmware.com>533Author: Oliver Kurth <okurth@vmware.com>
638Date: Fri Jul 13 11:54:23 2018 -0700534Date: Mon Jun 3 13:39:45 2019 -0700
535
536 Common source file change not applicable to open-vm-tools.
639537
640 prepare for 10.3.0 release538commit 61c51b4e4ac091f066e5e0efa22cc39d00b05d6d
641commit a30d7aaa4d10fbce4b7d262487fffaf1dc32d949
642Author: Oliver Kurth <okurth@vmware.com>539Author: Oliver Kurth <okurth@vmware.com>
643Date: Fri Jul 6 14:31:55 2018 -0700540Date: Mon Jun 3 13:39:45 2019 -0700
644541
645 Common source file change, not directly applicable to open-vm-tools.542 Fix memory leak in SNEBuildHash function.
646 543
647 Enforce monotonic behavior for the value returned by times() on Mac.544 In a specific code path, if a key already exists in the hashtable,
545 the memory allocated for 'value' variable is not being freed. This
546 leads to a memory leak. Fixed.
648547
649commit 12e5559e4dcf3968dd45131077b68364578f3bef548commit 0d5e8c618131e3899f3c30c91722e1df4e1162e9
650Author: Oliver Kurth <okurth@vmware.com>549Author: Oliver Kurth <okurth@vmware.com>
651Date: Fri Jul 6 14:31:55 2018 -0700550Date: Mon Jun 3 13:39:44 2019 -0700
652551
653 Update the Tools-10.3.0 OSL.552 Common header file change not applicable to open-vm-tools.
553
554commit f37292f0a8524783888d55f57fa30bb828e2408b
555Author: Oliver Kurth <okurth@vmware.com>
556Date: Mon Jun 3 13:39:44 2019 -0700
557
558 Crash during File_WalkDirectoryNext
654 559
655 Update the Tools-10.3.0 open source license files.560 In the rewrite of File_WalkDirectoryNext, a bug was introduced in the
561 invalid Unicode path. Invalid Unicode occurs very rarely... and the
562 bug finally turned up. Fix this... the bug is rather obvious.
656563
657commit c80bb3fc7960bc78a6d39c89b6952218a401b0cf564commit 1749604dc3481d0cc670e97945b915821c1039d3
658Author: Oliver Kurth <okurth@vmware.com>565Author: Oliver Kurth <okurth@vmware.com>
659Date: Fri Jul 6 14:31:55 2018 -0700566Date: Mon Jun 3 13:39:44 2019 -0700
660567
661 [tools-plugin] Potential solution for reported desktopEvent crash568 Fix asianux identification.
662 569
663 On several distros like RHEL, CentOS and Fedora, plugin desktopEvents.so570 Add asianux to distroArray and change how asianux releases 7 and 8
664 crashes have been reported. However, neither development or QE can571 are identified.
665 reproduce this issue in local environments.
666 572
667 The XFetchName document states that it may generate BadWindow error. That573 This came in as a pull request on github for open-vm-tools:
668 means that the value for a Window argument does not name a defined Window.574 https://github.com/vmware/open-vm-tools/pull/325 . Apparently
669 X FAQ also suggests handling badwindow error after finding it. Since575 the OS identification in /etc/asianux-release changed with Asianux
670 the window does not exist when XFetchName is run on it, the name is not576 7, and as a result tools does not identify it correctly.
671 needed. Suppress this error to avoid a crash.577
578commit 19969734d2a64e52cccf8f04669b55ad13f9c61c
579Author: Oliver Kurth <okurth@vmware.com>
580Date: Mon Jun 3 13:39:44 2019 -0700
581
582 Fallback to /proc/mounts.
672 583
673 After grabbing the X server, use XSetErrorHandler to temporarily define584 Use /proc/mounts on systems where /etc/mtab may not be there.
674 a local error handler to intercept and cleanly handle any BadWindow585 This change is targeted for guestInfo reporting at the moment.
675 errors. XSetErrorHandler returns the current error handler, so it is
676 straightforward to reinstate GDK's original handler.
677586
678commit 6172812c021469704c51817693c6c8f6bf226509587commit f78a6801a8ec0f549fc3aa3817215f91cf6607af
679Author: Oliver Kurth <okurth@vmware.com>588Author: Oliver Kurth <okurth@vmware.com>
680Date: Fri Jul 6 14:31:55 2018 -0700589Date: Mon Jun 3 13:39:44 2019 -0700
681590
682 Remove the new guest metrics feature switch, permanently enabling the591 Common source file change not applicable to open-vm-tools.
683 collection of new guest metrics for vROps..
684592
685commit 6e6285ec690a13ff8ba894ee463a5aa0fd034269593commit e3f8ffec4a1de47cb62e4d8b2ba175a03da13246
686Author: Oliver Kurth <okurth@vmware.com>594Author: Oliver Kurth <okurth@vmware.com>
687Date: Tue Jun 19 11:07:46 2018 -0700595Date: Mon Jun 3 13:39:44 2019 -0700
688596
689 Previous change to configure.ac and vmtools.m4 caused a regression597 Common source file change not directly applicable to open-vm-tools.
690
691 Backing out of 10.3.0.
692598
693commit 699cda01fab8b1ad8a1e912d650aa92f7ffdf0e6599commit 70596395cf892d07321ddd9ee8f947c06973e565
694Author: Oliver Kurth <okurth@vmware.com>600Author: Oliver Kurth <okurth@vmware.com>
695Date: Tue Jun 19 11:07:46 2018 -0700601Date: Mon Jun 3 13:39:44 2019 -0700
696602
697 [OVT] Update copyright year to 2018 for few files.603 Common header file change not applicable to open-vm-tools.
698
699 Updated the copyright year to 2018 for few files changed in the last
700 few days.
701604
702commit cecbaf6b16f5fd1ecbfe4419310352353b047ba2605commit a652f6e7c2c14310e2f6f030660b73e48aeeba80
703Author: Oliver Kurth <okurth@vmware.com>606Author: Oliver Kurth <okurth@vmware.com>
704Date: Tue Jun 19 11:07:46 2018 -0700607Date: Mon Jun 3 13:39:44 2019 -0700
705608
706 open-vm-tools: use AC_CHECK_TOOL for pkg-config609 Common source file change not directly applicable to open-vm-tools.
610
611commit c209a5619fa74f6b76171420c57fd65303331a0f
612Author: Oliver Kurth <okurth@vmware.com>
613Date: Mon Jun 3 13:39:44 2019 -0700
614
615 Update to common source code; does not affect open-vm-tools.
707 616
708 AC_CHECK_TOOL honors the --host setting to configure, and searches617 Allow an asyncWebSocket to connect through an existing socket descriptor
709 for tools with the cross compile prefix thus allowing for cross
710 compile specific tools.
711 618
712 Fixes issue #26 in github.619 Because Windows does not allow unprivileged processes to specify
620 DSCP (formerly ToS) values on TCP traffic, in order to support
621 DSCP for Blast WebSockets we must obtain a preconfigured socket
622 descriptor from a privileged process and then build the WebSocket
623 connection over that socket.
624
625 This changeset extends the asyncWebSocket API by adding a Connect
626 function that can accept and use an existing socket descriptor in
627 addition to the usual collection of WebSocket Connect parameters.
628
629 Because the asyncWebSocket is built over an asyncTCPSocket, this
630 change ripples down into the asyncTCPSocket API which also gets a
631 new Connect variant with a socket descriptor parameter.
632
633 To avoid duplicating existing logic, the old Connect variants
634 are modified to do their work by invoking the new API with
635 a distinguished socket descriptor value of -1. This value
636 indicates that no existing socket descriptor is provided and
637 that a new socket should be created and used for the connection.
638
639 In this changeset, passing in an existing socket is supported
640 only on the Windows platform. The feature is not required on
641 other platforms, where unprivileged processes are permitted to
642 define DSCP values for their connections. Attempting to create
643 a connection over an existing socket on other platforms will
644 result in a Connect failure.
713645
714commit f2c8d02161569c96ac452f9d1063756d133562ba646commit 20e8a3d4213019202241d766ba3c7c660c4b74c2
715Author: Oliver Kurth <okurth@vmware.com>647Author: Oliver Kurth <okurth@vmware.com>
716Date: Tue Jun 19 11:07:45 2018 -0700648Date: Mon Jun 3 13:39:44 2019 -0700
717649
718 open-vm-tools: build dndcp with thread libs650 Round out Log functions to all levels
719 651
720 Recent changes in the dndcp plugin made it necessary to make sure that652 Logs would be measurably more useful for debugging if the available
721 it links against pthread libs.653 levels were used correctly and consistently. As a step towards
654 encouraging such use, define Log_Warning() and Log_Info() as synonyms
655 for Warning() and Log() (which, for historical reasons, are not
656 declared in log.h). Also remove all the conflicting private definitions.
722657
723commit 99df5712ba7b8910c3db138c64aab6957f31c914658commit e45c4e3da624187d83f25681cf25b67ae059b6ed
724Author: Oliver Kurth <okurth@vmware.com>659Author: Oliver Kurth <okurth@vmware.com>
725Date: Tue Jun 19 11:07:45 2018 -0700660Date: Mon Jun 3 13:39:44 2019 -0700
726661
727 Clipboard content on the host gets loaded to tmp on Linux guest with a right click on Guest662 Common header file change not applicable to open-vm-tools.
728
729 Root Cause:
730 Dndcp plugin creates a sub thread to monitor if there is other application
731 access the specific file. The root cause for this bug is the main thread
732 doesn't update its field before wakeup the sub thread, this cause the sub
733 thread get a wrong value.
734
735 Solution:
736 Main thread should update the field before wakeup the sub thread.
737663
738commit 99af79200f91c246580197b5698995fba4dc47af664commit 94ffa684475ea998347b4c6e25626d099eb8315c
739Author: Oliver Kurth <okurth@vmware.com>665Author: Oliver Kurth <okurth@vmware.com>
740Date: Tue Jun 19 11:07:45 2018 -0700666Date: Mon Jun 3 13:39:44 2019 -0700
741667
742 open-vm-tools: build for FreeBSD fails in fakeMouseWayland668 Linux DeployPkg configurable timeout.
743
744 Root Cause:
745 In the file fakeMouseWayland.cpp, several Linux related header files
746 are included:
747 <linux/input.h>
748 <linux/ioctl.h>
749 <linux/uinput.h>
750
751 These header files do not exist for FreeBSD and Solaris.
752 669
753 Solution:670 Update to descriptive comments for function DeployPkg_SetProcessTimeout().
754 Lib fakeMouse is not needed by FreeBSD and Solaris, so update the makefile
755 to build the fakemouse related code only on Linux.
756671
757commit 104cab14e08b93a2525992e09f0d13ff26d52d9d672commit 4bd043870ec94332aa8b3794449a2144847cad33
758Author: Oliver Kurth <okurth@vmware.com>673Author: Oliver Kurth <okurth@vmware.com>
759Date: Tue Jun 19 11:07:45 2018 -0700674Date: Mon Jun 3 13:39:44 2019 -0700
760675
761 Use "/var/run" or "/run" instead of "/tmp" in Linux guest for imc package copy676 Common header file change not applicable to open-vm-tools.
762
763 1. check if /var/run is a directory in VM
764 2. if Yes, use /var/run/XXXXXX
765 3. check if /run is a directory in VM
766 4. if Yes, use /run/XXXXXX
767 5. if both No, use /tmp/XXXXXX as before
768677
769commit 8f93d803066032a738b9d9a6990e32ed17b589e1678commit 46cb6aa361cc8b1d287e3b9b77bf86819b4b1fc5
770Author: Oliver Kurth <okurth@vmware.com>679Author: Oliver Kurth <okurth@vmware.com>
771Date: Tue Jun 19 11:07:45 2018 -0700680Date: Wed May 22 13:09:37 2019 -0700
772681
773 Build open-vm-tools with xmlsec1 by default.682 Fix [RH Covscan] Coverity reported memory leaks in toolboxcmd-stat.c.
774
775 Build open-vm-tools with xmlsec1 by default, rather than with
776 xml-security-c as is done currently. This requires modifications
777 to configure.ac to change the default for use_xmlsec1, plus
778 modifications to bora-vmsoft/install/Source/tools-pkg.make to
779 initialize flags for xmlsec1 and xml2 now needed by the OVT build
780 that is done during tools builds.
781
782 Another change that surfaced during this was that the symbol that
783 configure checks for the xmlsec library was wrong. It should be
784 xmlSecCheckVersionExt rather than xmlSecCheckVersion. The latter
785 is a header-defined macro but not a library symbol.
786683
787commit 7313fdc5b2b14ac83340b2e59752b934494c2ae9684commit d0f0af3e62d065492b29791556c39c27eb97c751
788Author: Oliver Kurth <okurth@vmware.com>685Author: Oliver Kurth <okurth@vmware.com>
789Date: Tue Jun 19 11:07:45 2018 -0700686Date: Wed May 22 13:09:37 2019 -0700
790687
791 [Wayland Copy & Paste] Part2: Uses VMBlock notification mechanism for Copy & Paste688 Common header file change not applicable to open-vm-tools.
792
793 This patch is part of the new feature for Workstation 15: \[P0\] Wayland
794 support in Linux guest - Copy & Paste.
795
796 In the first patch, the notification mechanism is added to the VMBlock module.
797 In this patch, the notification mechanism is used,
798689
799commit c04b9987786901f544c4df04f7701b48ac8f6475690commit 873db0841a17a530cabe6b6e6e473647da685c17
800Author: Oliver Kurth <okurth@vmware.com>691Author: Oliver Kurth <okurth@vmware.com>
801Date: Tue Jun 19 11:07:45 2018 -0700692Date: Wed May 22 13:09:37 2019 -0700
802693
803 [Wayland Copy & Paste] Part1: Add notification mechanism to the VMBlock module694 Common source file change not applicable to open-vm-tools.
804
805 This patch is part of the new feature for Workstation 15: [P0] Wayland support
806 in Linux guest - Copy & Paste.
807
808 In the implementation of current VMTools, there is a restriction, in the first
809 second after grab into the guest, the CopyPasteUIX11::LocalGetFileRequestCB,
810 which is a callback from a file paste request from another guest application
811 and begins copying the files from host to guest and return the file list,
812 will return none directly.
813
814 The Wayland file explorer will request the content in the clipboard after the
815 user clicks on the file explorer, and the request will get nothing since the
816 restriction in the VMTools, so the following ‘Paste’ operation will fail.
817
818 Solution:
819 This solution is only used for the Linux guest with Wayland. The behavior
820 for Linux guest with X11 will not change.
821
822 The restriction, the CopyPasteUIX11::LocalGetFileRequestCB returns directly
823 in the first second after grab into the guest, will be removed.
824
825 And, the notification mechanism will be added into the VM block file system.
826 This mechanism is similar with the inotify module.
827
828 Take the VMBlock Fuse File System as an example, currently, the mount point contains below contents:
829
830 * /blockdir/
831
832 * /dev
833
834 /blockdir/ contains the symlinks to the contents of the target directory.
835
836 /dev is the control file for VMBlock Fuse File System.
837
838 In this new solution, a new folder /notifydir/ will be added, each file in this folder is a special file, read from this file will be blocked until any other process read from the corresponding file in target directory or the block on the target directory is removed.
839
840 This patch only focus on the notification mechanism.
841695
842commit 6c0b2130e7ee103ece06eb674c5f5dfea66c26f1696commit 403dc83d2040d386b2c6c04756b289f277657e41
843Author: Oliver Kurth <okurth@vmware.com>697Author: Oliver Kurth <okurth@vmware.com>
844Date: Tue Jun 19 11:07:45 2018 -0700698Date: Wed May 22 13:09:37 2019 -0700
845699
846 FreeBSD: clang compiler related changes to configure.ac700 Common header file change not applicable to open-vm-tools.
847
848 On FreeBSD, the unwind.h header is available in the libunwind
849 package (/usr/ports/devel/libunwind) which may or may not be installed
850 on a system. The libunwind functions to determine the call-chain in a
851 program are defined only if " __GNU_SOURCE" is defined to enable "all"
852 GCC extensions. Avoid the unwind.h header if seen on FreeBSD.
853
854 The "clang" compiler will issue warnings if the address of a member
855 of a packed structure is taken. Since warnings are errors with -Wall,
856 add --Wno-address-of-packed-member to CFLAGS when compiling with
857 "clang".
858701
859commit bba52bfa5b29c8860f18200022db5b8b250d326b702commit af0a4979c7bcaba6a913e686609f99c1245db384
860Author: Oliver Kurth <okurth@vmware.com>703Author: Oliver Kurth <okurth@vmware.com>
861Date: Tue Jun 19 11:07:45 2018 -0700704Date: Wed May 22 13:09:37 2019 -0700
862705
863 open-vm-tools: build with tirpc706 Change to common header file not applicable to open-vm-tools.
864
865 Newer distros (Fedora, OpenSuSE Tumblweed) no longer ship rpcgen with glibc,
866 so we need to build with libtirpc (see
867 https://bugzilla.redhat.com/show_bug.cgi?id=1531540 and
868 https://bugzilla.suse.com/show_bug.cgi?id=1089181).
869 With this change, configure will check for the presence of libtirpc and
870 if found, sets flags to build with it. configure will also exit with an
871 error if rpcgen is not found.
872707
873commit 5c0b9496db96af9ea5e4b3b1321f0612a3f62d99708commit 7c1e69708bc3bbdbf9dc66b039ab40f9767b29c1
874Author: Oliver Kurth <okurth@vmware.com>709Author: Oliver Kurth <okurth@vmware.com>
875Date: Tue Jun 19 11:07:44 2018 -0700710Date: Wed May 22 13:09:37 2019 -0700
876711
877 Changes to build CAF with VS 2015; not applicable to open-vm-tools.712 Change to common header file not directly applicable to open-vm-tools.
878713
879commit 3961588fcce58090c249f4a65ad8cc109efecc5c714commit da3efa69411c5fe8897e6295927dc4b8eacaff04
880Author: Oliver Kurth <okurth@vmware.com>715Author: Oliver Kurth <okurth@vmware.com>
881Date: Tue Jun 19 11:07:44 2018 -0700716Date: Wed May 22 13:09:36 2019 -0700
882717
883 Log full version of Tools in vmware.log.718 Changes to common source files not directly applicable to open-vm-tools.
884
885 Currently, only the Tools build number is logged in vmware.log.
886 It will be very handy to have the full version logged in
887 there and avoid the need to manually lookup the build.
888719
889commit bf494fd02a77a4f34ff420c03c0c5a19e43218d3720commit 8017efa7e941561274088d27e32883f6c1965abf
890Author: Oliver Kurth <okurth@vmware.com>721Author: Oliver Kurth <okurth@vmware.com>
891Date: Tue Jun 19 11:07:44 2018 -0700722Date: Wed May 22 13:09:36 2019 -0700
892723
893 Tools 10.3.0 L10n drop2724 Pick up filesystem (fsType) name for Linux disks.
894 725
895 This is to integrate the final L10n drop for VMware Tools 10.3.726 Building upon the OS Volume Disk Mapping changes added for Windows
727 guests, pick up and propogate the filesystem type for Linux disks.
728 Move fsType related code and declaration out of the _WIN32 specific
729 source code.
730
731 Diskwiper code (for Linux) modified to pass along filesystem type
732 obtained from the MNTINFO structure from the non-Windows guest.
733 Also passing along the mount point for device-based mapping to be done
734 in the guestInfo plugin.
896735
897commit 065f09b94e09f1127901db29e73cc9b9f36df4fc736commit 82d42ead6fc14eed2bc1670352f5fb8f62413230
898Author: Oliver Kurth <okurth@vmware.com>737Author: Oliver Kurth <okurth@vmware.com>
899Date: Tue Jun 19 11:07:44 2018 -0700738Date: Wed May 22 13:09:35 2019 -0700
900739
901 Add two switches for max IPv4/6 routes to gather740 Change to common header file not applicable to open-vm-tools.
741
742commit 744fe0bec43f7e242f1353c767c613180512000d
743Author: Oliver Kurth <okurth@vmware.com>
744Date: Wed May 8 15:27:20 2019 -0700
745
746 Common header file change not applicable to open-vm-tools.
747
748commit 5b0e339cde98dce03ec5046c04ded329f61dc5ef
749Author: Oliver Kurth <okurth@vmware.com>
750Date: Wed May 8 15:27:20 2019 -0700
751
752 Fix the 'procCmdName' attribute of process information.
902 753
903 Gathering nic info in a Linux guest OS which is configured with large754 * When listing down the processes, /proc/{PID}/cmdline file is read
904 number(60000+) of ipv6 routes could result in vmtoolsd process taking a755 and parsed to figure out the command name. While doing this parsing,
905 long time and rock solid 100% CPU of a core. Though tools only exports756 the terminating NUL character is not parsed. Due to this, if any
906 at most NICINFO_MAX_ROUTES(100) routes, it tries to read all the contents757 process doesn't have any command line arguments, the 'command name' is
907 of /proc/net/ipv6_route which costs too much time because:758 retrieved as NULL.
908 1. IPv6 route table is not efficient natively compared to ipv4 due to
909 its implementation.
910 2. The g_io library can aggravate the performance.
911 759
912 On the other hand, when gathering routes, IPv4 comes first, and IPv6 second.760 Note: This issue doesn't happen if the cmdLine has any arguments.
913 And the routes reported to VMX has an overall limitation of serializing
914 (NICINFO_MAX_ROUTES). If there's more than NICINFO_MAX_ROUTES IPv4 routes
915 in system, no IPv6 will get reported.
916 761
917 Added two switches "max-ipv4-routes" and "max-ipv6-routes"762 Ex:
918 (NICINFO_MAX_ROUTES by default) in tools.conf and let SlashProcNet_GetRoute*()763 /usr/bin/vmtoolsd -> 'cmdName' is retrieved as NULL
919 only read the first max ipv4/6 routes lines of /proc/net/[ipv6_]route to avoid764 /usr/bin/vmtoolsd -n vmusr -> 'cmdName' is retrieved properly as 'vmtoolsd'
920 performance problem. Users can disable ipv4/ipv6 routes gathering765
921 separately if they want ipv6 or ipv4 only.766 * Fixed the code to include the trailing NUL character also while parsing.
922767
923commit bf86c612a8ffe1d20b98c20b76f0c34840a7a2a3768commit 7b096ae277428efd8f550c1bbb35e98bb0cdf565
924Author: Oliver Kurth <okurth@vmware.com>769Author: Oliver Kurth <okurth@vmware.com>
925Date: Tue Jun 19 11:07:44 2018 -0700770Date: Wed May 8 15:27:20 2019 -0700
926771
927 Not checking symbols when building open-vm-tools772 Hgfs fuse Client: fix max name length setting for statvfs
928 773
929 Using a hard-coded mangled name is not a good idea because C++ does not774 Detected internally with Fedora 29 and reported in
930 have any standard for name mangling. Remove these mangled names introduced775 https://github.com/vmware/open-vm-tools/issues/337,
931 in an earlier fix.776 the statvfs structure must provide a valid max name length field. Setting
777 to NAME_MAX. This allows the GUI Files application to create new folders
778 and rename existing ones correctly.
932779
933commit d36ed6e5b4784a36cb93f50e05d6a49b5d76b86e780commit 9876844113a4f6b538f131d61b61c994264f7caf
934Author: Oliver Kurth <okurth@vmware.com>781Author: Oliver Kurth <okurth@vmware.com>
935Date: Tue Jun 19 11:07:44 2018 -0700782Date: Wed May 8 15:27:19 2019 -0700
936783
937 [OVT] Update copyright year to 2018 for files modified since 10.2.5 GA784 Plumb through filesystemType
785
786 Implement the filesystemType property in the vim.vm.guestInfo.DiskInfo.
938787
939commit 8086ead225faf3a051952773c0b98b2c751b1e84788commit 79c7f28781fc38eb2e2ec691c907822dd1259bc4
940Author: Oliver Kurth <okurth@vmware.com>789Author: Oliver Kurth <okurth@vmware.com>
941Date: Tue Jun 19 11:07:44 2018 -0700790Date: Wed May 8 15:27:19 2019 -0700
942791
943 Hgfs Win Client: fix bad illegal character escaping; not applicable to open-vm-tools.792 Common header file change not applicable to open-vm-tools.
944793
945commit 7efc7b70a57cf734012a069fabab19e96f8cf16d794commit 000856aea0bd78c581888c3e3771cf79c6fdb7e9
946Author: Oliver Kurth <okurth@vmware.com>795Author: Oliver Kurth <okurth@vmware.com>
947Date: Tue Jun 19 11:07:43 2018 -0700796Date: Wed May 8 15:27:19 2019 -0700
948797
949 Add the JACKHAMMER code name to the 10.3.0 release version defines.798 Fix copy/paste on Ubuntu 19.04 guest
950 799
951 Adding the code name JACKHAMMER to the 10.3.x series version notation800 Ubuntu 19.04 chooses Nautilus 3.32 as the default file browser. From
952 for the public source release and use by future 10.3.x patches or801 3.30, Nautilus checks mime type when pasting files from the clipboard,
953 updates.802 and the target type is also changed to UTF8_STRING instead of
803 x-special/gnome-copied-files. To support Ubuntu 19.04, apply this
804 change into our guest code.
954805
955commit d71381445f6c3b986e263435006428a44be0451a806commit 7bbb1521360bd140a56d1fbf6a9663d297277901
956Author: Oliver Kurth <okurth@vmware.com>807Author: Oliver Kurth <okurth@vmware.com>
957Date: Tue Jun 19 11:07:43 2018 -0700808Date: Wed May 8 15:27:19 2019 -0700
958809
959 Hgfs Server Plugin: only handle the shared folders client in hosted products810 Add a comment in vmci_sockets.h about why a file handle is "leaked"
960 811
961 Only initialize the Shared Folders client redirector in hosted product812 Let's add a comment in vmci_sockets.h explaining why we intentionally "leak"
962 environments.813 a file handle in VMCISock_GetAFValueFd.
963 814
964 Details: Check if the tools system service started in a non-hosted product815 fd is intentionally left open when outFd is NULL. Closing it
965 and if so do not start the shared folders client redirector.816 will break applications running on Linux without a fixed AF for
966 Check if the tools user service started in a non-hosted product product and if817 vSockets. In such cases, the fd will be closed during cleanup when
967 so then skip reconnecting any Shared Folders mapped drives.818 the application exits.
968819
969commit ad7c68780a773d6d456687aff0d27f9cff808370820commit a5823224051da0318facf10e0732baa9f55334fc
970Author: Oliver Kurth <okurth@vmware.com>821Author: Oliver Kurth <okurth@vmware.com>
971Date: Thu May 10 16:47:16 2018 -0700822Date: Wed May 8 15:27:19 2019 -0700
972823
973 update version number824 Fix a trivial Coverity-reported memory leak.
825
826 If AuthLoadPAM doesn't find all the needed symbols from the pam
827 library, then dlclose the library, as is already done for
828 the same-named funtion in bora/lib/auth/authPosix.c.
974829
975commit cac0f086ffcc00da73dd7dd80fef6956962f4dd6830commit 47766e511be85410f5afc0bf8b0f05776fb66ece
976Author: Oliver Kurth <okurth@vmware.com>831Author: Oliver Kurth <okurth@vmware.com>
977Date: Thu May 10 16:38:11 2018 -0700832Date: Wed May 8 15:27:19 2019 -0700
978833
979 Remove debug display of CPUID vendor string seen in VmCheck_IsVirtualWorld834 Record Tools version 10.3.11 as Hot Patch for PR 2328829
835
836commit 801df14f0e2b32aea17771bbd33d65140ff2361c
837Author: Oliver Kurth <okurth@vmware.com>
838Date: Wed May 8 15:27:19 2019 -0700
839
840 Fix Coverity-reported double memory free errors.
980 841
981 The "Debug" message containing vendor string returned by the CPUID842 Similar double memory free errors were reported in each of two
982 instruction will appear on STDERR for stand-alone programs such843 functions, VixToolsListAuthAliases and VixToolsListMappedAliases.
983 as vmware-checkvm. This unexpected output is at best noise and may844 The fixes for each function are similar: be consistent in using
984 adversely affect existing scripts.845 tmpBuf2 (renamed tmpBuf) as the pointer to the overall buffer being
846 computed and tmpBuf (renamed nextBuf) as the "next" version of the
847 buffer. Specifically, in the computation of recordBuf following exit
848 from the for loop, use the variable formerly known as tmpBuf2 rather
849 than the one formerly known as tmpBuf.
850
851 The variables were renamed in an attempt to distinguish more clearly
852 between them and how they are used. Also, with these changes in
853 place, it's evident that there's no need to free nextBuf in the abort
854 case and as a result its scope can be limited.
985855
986commit 7ddbe3c9df400dfdf7d67d259ae3942d157dedb4856commit 2031724154177a3f5ce28d3c608709c7ad6153dc
987Author: Oliver Kurth <okurth@vmware.com>857Author: Oliver Kurth <okurth@vmware.com>
988Date: Mon Apr 30 15:42:54 2018 -0700858Date: Wed May 8 15:27:19 2019 -0700
989859
990 sync deploypkg files860 Common header file change not applicable to open-vm-tools.
991861
992commit 80a23d71a281493071668fd45b77d7f8248fad68862commit 8634350c330318eaf8f333c49f405e20b71ca813
993Author: Oliver Kurth <okurth@vmware.com>863Author: Oliver Kurth <okurth@vmware.com>
994Date: Mon Apr 30 14:04:14 2018 -0700864Date: Wed May 8 15:27:19 2019 -0700
995865
996 Changes to common header files:866 Common header file change not directly applicable to open-vm-tools.
997 - Add Amazon Linux 2 to the known guest OS list.
998 - Other change not application to open-vm-tools.
999867
1000commit 48dc7a57ff3fe5cb1441040876f74b69772c1ea5868commit 2bbd56da4314856dfc1a8fed2db5b55cd9ef8860
1001Author: Oliver Kurth <okurth@vmware.com>869Author: Oliver Kurth <okurth@vmware.com>
1002Date: Mon Apr 30 14:04:13 2018 -0700870Date: Wed May 8 15:27:18 2019 -0700
1003871
1004 [DeployPkg] Replace Log() references with g_log()872 Fixes for few leaks and improved error handling.
1005 873
1006 * Modified the code to replace a couple of Log() references with g_debug()874 Fix a memory leak detected by coverity scan. It is not critical,
1007 so that they are properly logged with 'deplogPkg' domain instead of the875 but it is real in an error case when there is no end mark. While
1008 generic 'vmsvc' domain in the tools log files.876 fixing it, also enhanced code to handle different error cases
877 properly because we would want valid content to be decoded even
878 when there are invalid marks in the log file. Invalid log marks
879 are possible when vmware.log gets rotated in the middle of guest
880 logging.
881
882 While verifying the fix using valgrind, found a couple of more
883 leaks in panic and warning stubs. Addressed those as well.
1009884
1010commit 9cb12223b4da529df043d95ab025f22c6ee00c39885commit 544cf1363c78d1d8c75e57d560b3650b5f667c64
1011Author: Oliver Kurth <okurth@vmware.com>886Author: Oliver Kurth <okurth@vmware.com>
1012Date: Mon Apr 23 17:08:18 2018 -0700887Date: Wed May 8 15:27:18 2019 -0700
1013888
1014 [oss] Upgrade GTK+ and its dependent libraries for VMtools889 Fix a trivial Coverity-reported memory leak in vgauth/cli/main.c.
1015 890
1016 GTK+ and its dependent libraries are upgraded to:891 Call Pref_Shutdown to close the PrefHandle.
1017 gtk+ 2.24.32
1018 atk 2.28.1
1019 gdk-pixbuf 2.36.11
1020 pango 1.40.13
1021 cairo 1.14.12
1022 fontconfig 2.13.0
1023 freetype 2.9
1024892
1025commit a5c03957c95ec78c92246b87cdf60a90b2eca7f7893commit 4a2c4645a363c705e66cdb81847f579d8ff30e04
1026Author: Oliver Kurth <okurth@vmware.com>894Author: Oliver Kurth <okurth@vmware.com>
1027Date: Mon Apr 23 17:08:18 2018 -0700895Date: Tue Apr 30 13:24:25 2019 -0700
1028896
1029 Common header file change not applicable to open-vm-tools.897 Add garbage collection for vix process handles.
898
899 This closely follows the model used for hgfs session cleanup.
1030900
1031commit f87d177acab33f00229234ed51722504e2f7afc7901commit ea2ee4789fd0db5451752ea98af55a3c6b47f1d2
1032Author: Oliver Kurth <okurth@vmware.com>902Author: Oliver Kurth <okurth@vmware.com>
1033Date: Mon Apr 23 17:08:18 2018 -0700903Date: Tue Apr 30 13:24:25 2019 -0700
1034904
1035 Changes to common header files not directly applicable to open-vm-tools.905 Common header file change not applicable to open-vm-tools.
1036906
1037commit ba65905dfc7e6c07d1aeea37db885284e54b02fa907commit 4ee0255f2f7a32a76095de8c02a869e78f7ec765
1038Author: Oliver Kurth <okurth@vmware.com>908Author: Oliver Kurth <okurth@vmware.com>
1039Date: Mon Apr 23 17:08:18 2018 -0700909Date: Tue Apr 30 13:24:25 2019 -0700
1040910
1041 Set perms on Tools script logs.911 Common header file change not applicable to open-vm-tools.
1042
1043 Make the network script logs secure; set log file perms to 0600.
1044912
1045commit aa59d16e0b5968efc298065ef50ece282d406265913commit 9e6e3afa5b5c3dc11c7aa79454ca4c8184c87bdf
1046Author: Oliver Kurth <okurth@vmware.com>914Author: Oliver Kurth <okurth@vmware.com>
1047Date: Mon Apr 23 17:08:18 2018 -0700915Date: Tue Apr 30 13:24:25 2019 -0700
1048916
1049 [Wayland DnD] Part2: Open the uinput device file with root permission.917 Fix a memory leak in the unicode library.
1050 918
1051 The device file /dev/uinput (or /dev/input/uinput) can only be accessed919 Ensure that allocated strings are freed before returning a failure.
1052 by root account, so the dndcp plugin may failed to open this device file
1053 if the current user is not root account.
1054
1055 A way to fix this issue is opening this device file with root account,
1056 then pass the file descriptor to the sub task which is started with the
1057 current account. An example for this solution is blockVM file system
1058 device file.
1059 920
1060 This patch is part of the new feature 'Wayland support in Linux guest'.921 The ASSERTs have never been known to fire; a warning in a obj
922 build will help with debugging. The warning should "never" happen.
1061923
1062commit b3899c91d348d23c2e6c22944b8ac1a06e4e3988924commit d1de801b4b490aeecd982f19274e46485f156f79
1063Author: Oliver Kurth <okurth@vmware.com>925Author: Oliver Kurth <okurth@vmware.com>
1064Date: Mon Apr 23 17:08:18 2018 -0700926Date: Tue Apr 30 13:24:25 2019 -0700
1065927
1066 [Wayland DnD] Part1: Add 'fakeMouse' module which is used to simulate the928 Common header file change not applicable to open-vm-tools.
1067 mouse motion under Wayland929
1068 930commit b2a6fdafed0bef27a77d549e4ffbed9a09b9f0bd
1069 For Linux guest with X11, the VMTools uses the X system APIs to simulate931Author: Oliver Kurth <okurth@vmware.com>
1070 the mouse motion, but these X11 System APIs do not work in Wayland. Need932Date: Tue Apr 30 13:24:25 2019 -0700
1071 to pick up another method to simulate the mouse motion.933
934 Common header file change not applicable to open-vm-tools.
935
936commit a63fe3472895c9394ee8c3f2d0d2a496c3ccab6f
937Author: Oliver Kurth <okurth@vmware.com>
938Date: Tue Apr 30 13:24:25 2019 -0700
939
940 Common header file change not applicable to open-vm-tools.
941
942commit 9bec96154c23462f2c6f80dd660f41bba38d4614
943Author: Oliver Kurth <okurth@vmware.com>
944Date: Tue Apr 30 13:24:25 2019 -0700
945
946 Provide a shutdown function for users of the unicode library to free memory
947 allocated by Unicode_Init().
1072 948
1073 Another way to simulate the mouse motion is using uinput module.949 Most applications using the unicode library do not free related memory
950 since they are about to terminate. A Unicode_Shutdown() function is
951 provided which will explicitly free the memory allocated by Unicode_Init().
952
953commit 5614d61a2b8353cd48095210afbcc89f66228ae7
954Author: Oliver Kurth <okurth@vmware.com>
955Date: Tue Apr 30 13:24:25 2019 -0700
956
957 Changes to common header files not applicable to open-vm-tools.
958
959commit 4ae954db584b7e3287a97f44d0eeb96d09ba2c68
960Author: Oliver Kurth <okurth@vmware.com>
961Date: Tue Apr 30 13:24:25 2019 -0700
962
963 Common header file change not directly applicable to open-vm-tools.
964
965commit 35570e72d3833b73db653c89c84223c959856467
966Author: Oliver Kurth <okurth@vmware.com>
967Date: Tue Apr 30 13:24:25 2019 -0700
968
969 Changes to common source files not directly applicable to open-vm-tools.
1074 970
1075 uinput is a kernel module that makes it possible to emulate input devices971 Added the function Random_FastStream64() to provide a 64-bit random number
1076 from userspace. By writing to /dev/uinput (or /dev/input/uinput) device,972 if needed.
1077 a process can create a virtual input device with specific capabilities.973
1078 Once this virtual device is created, the process can send events through974commit e89c751f0045f163c468c49b71db70478581c85c
1079 it, that will be delivered to userspace and in-kernel consumers.975Author: Oliver Kurth <okurth@vmware.com>
976Date: Tue Apr 30 13:24:25 2019 -0700
977
978 vm_basic_defs.h: include stddef.h
1080 979
1081 Here is the link which contains more information about the uinput module:980 The stddef.h header has existed since C89. It includes interesting
981 things like an offsetof definition, and a definition of NULL.
1082 982
1083 https://www.kernel.org/doc/html/v4.12/input/uinput.html983 Let's stop re-inventing this long-standardized header. Except
984 in vmkernel, where bogus __FreeBSD__ values break gcc's <stddef.h>.
985 (Detail: vmkernel networking likes to define __FreeBSD__ to empty
986 or 1, whereas ABI requires "FreeBSD major version".
1084 987
1085 This patch adds a new module named 'fakeMouse' which is used to simulate the mouse motion under Wayland.988 This change is deliberately minimal as touching headers included
989 everywhere is inherently fragile. Further cleanups (like removing
990 vmw_offsetof) can be done in follow-up changes.
1086 991
1087 This patch is part of the new feature 'Wayland support in Linux guest'.992 The stddef.h header is a 'freestanding' header, which means it's
993 part of the language and not a "system" header. It is thus safe
994 to include (modulo vmkernel-networking problem above).
1088995
1089commit 995befcb0d6156fb47773c96db6d478173d1bc89996commit 642d7a61db13969f9fb654ad1cc0d879bf680612
1090Author: Oliver Kurth <okurth@vmware.com>997Author: Oliver Kurth <okurth@vmware.com>
1091Date: Mon Apr 23 17:08:18 2018 -0700998Date: Tue Apr 30 13:24:25 2019 -0700
1092999
1093 Add new guest metrics to be consumed by vROps.1000 Fix Coverity reported issues in i18n.c code - VMTools & VGAuth
1094 1001
1095 Windows:1002 bora-vmsoft/apps/vmtoolsbib/i18n.c: MsgLoadCatalog()
1096 * ProcessorQueueLength1003 - Coverity reported memory leak when an error is encountered parsing a
1097 * CurrentDiskQueueLength1004 line from a message catalog.
1098 * AvgDiskQueueLength1005 - Second memory leak on error missed.
1099 1006
1100 Linux:1007 bora-vmsoft/vgauth/common/i18n.c: MsgLoadCatalog()
1101 * CPU run queue size1008 - Coverity reported some dead code.
1102 * Current disk queue size1009 - Missed reporting memory leak when error is encountered parsing a
1103 * Average disk queue size1010 line from a message catalog.
11041011
1105commit 9d6cfe650cd15095e65024fbb5d9cd6944e1cf141012commit 0f7b4b275aaf20bebf8d4739cf283fade05c3dcb
1106Author: Oliver Kurth <okurth@vmware.com>1013Author: Oliver Kurth <okurth@vmware.com>
1107Date: Mon Apr 23 17:08:17 2018 -07001014Date: Tue Apr 30 13:24:25 2019 -0700
11081015
1109 Historical: Recording version numbers assigned for 10.2.x patches.1016 Common header file change not applicable to open-vm-tools.
1017
1018commit 9e0ccaa3bf2805674fd882362427aa2d3376a3a8
1019Author: Oliver Kurth <okurth@vmware.com>
1020Date: Tue Apr 30 13:24:24 2019 -0700
1021
1022 Common header file change not applicable to open-vm-tools.
1023
1024commit 3cf1df758ba64cb6aebe81bf3a430ad536221c19
1025Author: Oliver Kurth <okurth@vmware.com>
1026Date: Tue Apr 30 13:24:24 2019 -0700
1027
1028 Toolsd uses log.text RPC only when the useLogTextRpc is set to TRUE.
1110 1029
1111 Define TOOLS_VERSION_CHAINSAW_PATCH1 as 10.2.1.1030 This allows the tools installer to start use the log.text RPC without
1112 Define TOOLS_VERSION_CHAINSAW_PATCH2 as 10.2.6.1031 worrying about that toolsd has not completed the work of scrubbing its logs
1032 for security and privacy issues.
11131033
1114commit ba6c319f18d294b36c0e989f851fbfdbc8a629b71034commit 1b755d3e619ed40d8750532f10af5a1df6de6cda
1115Author: Oliver Kurth <okurth@vmware.com>1035Author: Oliver Kurth <okurth@vmware.com>
1116Date: Mon Apr 23 17:08:17 2018 -07001036Date: Tue Apr 30 13:24:24 2019 -0700
11171037
1118 Bump up the version requirement for glib and friends to 2.34.01038 Fix memory leak in SNEBuildHash function.
1119 1039
1120 For open-vm-tools, we are bumping up the minimum version requirement1040 In a specific code path of the SNEBuildHash function, when the
1121 to 2.34.0 for glib and its friends. Modified the configure.ac1041 environment variable is of the format VMWARE_*=[0|1], the value
1122 with the proper new version checks. Also, updated the1042 is not freed. Fixed the memory leak.
1123 error message with the proper version.
11241043
1125commit 26d03ad8075913cb869b814462b7285c023672521044commit 0957e9c46476f8eab435576e7094b125e102f6ce
1126Author: Oliver Kurth <okurth@vmware.com>1045Author: Oliver Kurth <okurth@vmware.com>
1127Date: Mon Apr 23 17:08:17 2018 -07001046Date: Tue Apr 30 13:24:24 2019 -0700
11281047
1129 Common header file change not applicable to open-vm-tools.1048 Common header file change not applicable to open-vm-tools.
11301049
1131commit ce1ed002f5e05f09678e15b4021bac8155edb1eb1050commit bbefe8051a56b3cf834bf71c8f55fdfd88802b9d
1132Author: Oliver Kurth <okurth@vmware.com>1051Author: Oliver Kurth <okurth@vmware.com>
1133Date: Mon Apr 23 17:08:17 2018 -07001052Date: Mon Apr 15 11:33:00 2019 -0700
11341053
1135 Common source file changes that are not directly related to open-vm-tools.1054 Common header file change not applicable to open-vm-tools.
1136
1137 Build vmtools and vgauth for Windows with xmlsec instead of
1138 xml-security-c. It will still be possible to build with xml-security-c
1139 either by commenting out the definition of USE_XMLSEC_FOR_WINDOWS in
1140 bora-vmsoft/vgauth/make/inc/defs.mk or adding a make command line
1141 argument of USE_XMLSEC_FOR_WINDOWS=0.
11421055
1143commit d5c0bcea04aae65484ba3c2756b64acf6f6388d01056commit a0b825b2251bf9d30fb29d5deb1d269ec361428c
1144Author: Oliver Kurth <okurth@vmware.com>1057Author: Oliver Kurth <okurth@vmware.com>
1145Date: Mon Apr 23 17:08:17 2018 -07001058Date: Mon Apr 15 11:33:00 2019 -0700
11461059
1147 Update bora-vmsoft/install/Source/README1060 Common header file change not applicable to open-vm-tools.
1148
1149 The content is stale. Since the file is used internally and is
1150 not published, rather than maintain it in two places, point to
1151 the current README file and Release Notes on github.
11521061
1153commit 512d5475520ec5e0525633cd47530faaae774b5e1062commit abd87bf17c9869900dad292a458b871de90c4c7d
1154Author: Oliver Kurth <okurth@vmware.com>1063Author: Oliver Kurth <okurth@vmware.com>
1155Date: Mon Apr 23 17:08:17 2018 -07001064Date: Mon Apr 15 11:33:00 2019 -0700
11561065
1157 Common header file change not applicable to open-vm-tools.1066 Common header file change not applicable to open-vm-tools.
11581067
1159commit 982998c9a6a3ec8664f9c4c08ff9ef30f52a9ae21068commit 85bc2e71dd7a855d3c533965859c1756deecc314
1160Author: Oliver Kurth <okurth@vmware.com>1069Author: Oliver Kurth <okurth@vmware.com>
1161Date: Mon Apr 23 17:08:17 2018 -07001070Date: Mon Apr 15 11:33:00 2019 -0700
11621071
1163 Common header file change not applicable to open-vm-tools.1072 Fix minor leak in FileRotateByRenumber - Coverity scan
11641073
1165commit ab36b3227275a5beded8a5115929e2d649c6aad31074commit 82169f198925c9aa27bd04fd665eac67396adbe7
1166Author: Oliver Kurth <okurth@vmware.com>1075Author: Oliver Kurth <okurth@vmware.com>
1167Date: Mon Apr 23 17:08:17 2018 -07001076Date: Mon Apr 15 11:33:00 2019 -0700
11681077
1169 Common header file changes not applicable to open-vm-tools.1078 Fix a leak if VGAuth setup fails. Coverity issue
11701079
1171commit 0527d5c5f14f626a5129231778ec433dfff55c2a1080commit 555f28c7d07161a5bcd0a90fe46869bc6be4ba21
1172Author: Oliver Kurth <okurth@vmware.com>1081Author: Oliver Kurth <okurth@vmware.com>
1173Date: Mon Apr 23 17:08:17 2018 -07001082Date: Mon Apr 15 11:33:00 2019 -0700
1083
1084 Common source file change not applicable to open-vm-tools.
1085
1086commit b9993b990ea7dc077c6e625137802492245fb31b
1087Author: Oliver Kurth <okurth@vmware.com>
1088Date: Mon Apr 15 11:33:00 2019 -0700
11741089
1175 Common header file change not applicable to open-vm-tools.1090 Common header file change not applicable to open-vm-tools.
11761091
1177commit 571dc1fbadd962d91dcb7a44652b501de3f48e0e1092commit ca4be3d1bcb1d184eafb2c576dd7a127a95628fc
1178Author: Oliver Kurth <okurth@vmware.com>1093Author: Oliver Kurth <okurth@vmware.com>
1179Date: Mon Apr 23 17:08:16 2018 -07001094Date: Mon Apr 15 11:33:00 2019 -0700
11801095
1181 Common header file change not applicable to open-vm-tools.1096 Common header file change not applicable to open-vm-tools.
11821097
1183commit 998903d73496bf6080053f994c8410dc880db2f91098commit e6d24a37cdcd88624f66ad86f161e8576e7c6ec0
1184Author: Oliver Kurth <okurth@vmware.com>1099Author: Oliver Kurth <okurth@vmware.com>
1185Date: Mon Apr 23 17:08:16 2018 -07001100Date: Mon Apr 15 11:32:59 2019 -0700
11861101
1187 Common header file change not applicable to open-vm-tools.1102 Common header file change not applicable to open-vm-tools.
11881103
1189commit 3b814f9b4dcbf54893078a4ba187d8d0cbf23e311104commit da8c476be54bcd94c6b4f15a013dd02419b4ec29
1190Author: Oliver Kurth <okurth@vmware.com>1105Author: Oliver Kurth <okurth@vmware.com>
1191Date: Mon Apr 23 17:08:16 2018 -07001106Date: Mon Apr 15 11:32:59 2019 -0700
11921107
1193 lib/hashMap/hashMap.c:1108 Changes to common source files not directly applicable to open-vm-tools.
1194 Add new HashMap_Get() which uses a constant time memory comparison function.
1195 1109
1196 lib/misc/utilMem.c:1110 Add an error code to a debug message.
1197 Constant time memory and string comparison functions.
11981111
1199commit 5daceb4448834143d884b061f391c37aeaaad6831112commit 8eba31ddbf50a194acdd3eb30935a1fb3895bd50
1200Author: Oliver Kurth <okurth@vmware.com>1113Author: Oliver Kurth <okurth@vmware.com>
1201Date: Mon Apr 23 17:08:16 2018 -07001114Date: Mon Apr 15 11:32:59 2019 -0700
12021115
1203 Changes to common header files not applicable to open-vm-tools.1116 Common header file change not applicable to open-vm-tools.
12041117
1205commit 42d1e6b11c0b11c1b1f6f967cb5c4d7e2f3b39e01118commit b4a0d4c8137cdfbee073b456c71b731fa21e6ead
1206Author: Oliver Kurth <okurth@vmware.com>1119Author: Oliver Kurth <okurth@vmware.com>
1207Date: Mon Apr 23 17:08:16 2018 -07001120Date: Mon Apr 15 11:32:59 2019 -0700
12081121
1209 Change to common header file not applicable to open-vm-tools.1122 Common header file change not applicable to open-vm-tools.
12101123
1211commit f4b7b227119712c90be4a3583d4430a3fcc1d0931124commit e53f942615313e5d209f49d9c4da4227671c38d8
1212Author: Oliver Kurth <okurth@vmware.com>1125Author: Oliver Kurth <okurth@vmware.com>
1213Date: Mon Apr 23 17:08:16 2018 -07001126Date: Mon Apr 15 11:32:59 2019 -0700
12141127
1215 Change to common header file not applicable to open-vm-tools.1128 Common header file change not applicable to open-vm-tools.
12161129
1217commit 874b8b4801a5bba439401db8e624e3e3d1989ca71130commit c0ec4f8294ec6428ee2a7f7284b37f79f4661bf3
1218Author: Oliver Kurth <okurth@vmware.com>1131Author: Oliver Kurth <okurth@vmware.com>
1219Date: Mon Apr 23 17:08:16 2018 -07001132Date: Mon Apr 15 11:32:59 2019 -0700
12201133
1221 Common header file change not applicale to open-vm-tools.1134 Add a DynBuf_InitWithString() function to the dynamic buffer routines.
12221135
1223commit ff2616a657c32bbb5e6799f8b8cd0a470d0e52021136commit 2dc55af11451712b05a0c85a9c2ba1e5619b4841
1224Author: Oliver Kurth <okurth@vmware.com>1137Author: Oliver Kurth <okurth@vmware.com>
1225Date: Mon Apr 23 17:08:16 2018 -07001138Date: Mon Apr 15 11:32:59 2019 -0700
12261139
1227 Common header file changes not applicable to open-vm-tools.1140 Common header file change not applicable to open-vm-tools.
12281141
1229commit 5d9cc73f1c7979466d55f7897f98c0888d2fb15d1142commit f35313969af9bd2815709930f054171d7ebbcbc9
1230Author: Oliver Kurth <okurth@vmware.com>1143Author: Oliver Kurth <okurth@vmware.com>
1231Date: Mon Apr 23 17:08:15 2018 -07001144Date: Mon Apr 15 11:32:58 2019 -0700
12321145
1233 Header file change in preparation for C++11 compilation. Also updating1146 Common header file change not applicable to open-vm-tools.
1234 copyright dates.
12351147
1236commit 29fb30f6d1956ccd4ad803b1b7f0430e4ef28ceb1148commit c864f9e015a25864b952210796458e77c1f5726f
1237Author: Oliver Kurth <okurth@vmware.com>1149Author: Oliver Kurth <okurth@vmware.com>
1238Date: Mon Apr 23 17:08:15 2018 -07001150Date: Mon Apr 15 11:32:58 2019 -0700
12391151
1240 FreeBSD vmmemctl: Fold in open-vm-tools pull requests #125 and #1401152 Common header file change not directly applicable to open-vm-tools.
1241
1242 This change incorporates two open-vm-tools pull requests that provide
1243 code changes that allows the existing vmmemctl.ko driver to be compiled
1244 on FreeBSD 10, 11 or 12.
1245
1246 Pull request #125:
1247 An optional argument has been added to the sysctl_add_oid() function
1248 in FreeBSD 12.x. All releases have a SYSCTL_ADD_OID() macro that does
1249 not require the additional argument.
1250
1251 Pull request #140:
1252 Functions and macros to lock and unlock memory pages and objects have
1253 changed between the FBSD 10 & 11. The pull request provides a set C
1254 preprocessor directives to select the appropriate code based on the
1255 FreeBSD release being targeted.
1256
1257 The code change as been tidied up by using the release version checks
1258 to define LOCK and UNLOCK macros for memory pages and objects at the
1259 beginning of the source file. The code logic is easier to follow
1260 without the abundance of #if, #else and #endif statements scattered
1261 about.
1262
1263 Ed Schouten: https://github.com/vmware/open-vm-tools/pull/125
1264 Steve Wills: https://github.com/vmware/open-vm-tools/pull/140
12651153
1266commit 2a34b181de524b3f0d01cad90d3da184bde7ad991154commit 6de2df2c43c412c048f666277eaa48d8bb0c0321
1267Author: Oliver Kurth <okurth@vmware.com>1155Author: Oliver Kurth <okurth@vmware.com>
1268Date: Mon Apr 23 17:08:15 2018 -07001156Date: Wed Apr 10 14:14:57 2019 -0700
12691157
1270 Common source file changes not directly applicable to open-vm-tools.1158 Common header file change not applicable to open-vm-tools.
12711159
1272commit fab45e62a1468b86d2097a6a0784c4f259d6b0ef1160commit 306f0f7b507486795c0d726288ceb7145dcf3c00
1273Author: Oliver Kurth <okurth@vmware.com>1161Author: Oliver Kurth <okurth@vmware.com>
1274Date: Mon Apr 23 17:08:15 2018 -07001162Date: Wed Apr 10 14:14:57 2019 -0700
12751163
1276 Common header file change not applicable to open-vm-tools.1164 Common header file change no applicable to open-vm-tools.
12771165
1278commit 357e8418e5441c2c5fc75a19f7b6529d6bce74521166commit 6219e245c5e42479f4aef36ab8ee49db3c368f83
1279Author: Oliver Kurth <okurth@vmware.com>1167Author: Oliver Kurth <okurth@vmware.com>
1280Date: Mon Apr 23 17:08:15 2018 -07001168Date: Wed Apr 10 14:14:57 2019 -0700
12811169
1282 Common header file change not applicable to open-vm-tools.1170 Remove use of "-Wno-address-of-packed-member" option for OVT builds on FBSD
1171
1172 With the HGFS source code refactor to avoid taking the address of a
1173 packed structure memberuse of "-Wno-address-of-packed-member"
1174 is no longer needed to build OVT on FBSD 11.x and FBSD 12.x.
12831175
1284commit fad97e4a7c756b3b297e0fe9e68a1a4674c4fdcc1176commit 8b2bbbd8c2b647592a2f444a678fe93552fb0d22
1285Author: Oliver Kurth <okurth@vmware.com>1177Author: Oliver Kurth <okurth@vmware.com>
1286Date: Mon Apr 23 17:08:15 2018 -07001178Date: Wed Apr 10 14:14:56 2019 -0700
12871179
1288 Common header file change not applicable to open-vm-tools.1180 Add a 64 bit pseudo random number generator
1181
1182 This change adds a 64 bit pseudo random number generator to the public
1183 library by calling the existing 32 bit Random_Fast function twice.
1184 Since the period of Random_Fast is 2^64, this should be sufficient.
12891185
1290commit 357d9139342c19a98ed12f5961f415d099df32871186commit 5f9bd0c6a39a266854fad680d2251c024c309425
1291Author: Oliver Kurth <okurth@vmware.com>1187Author: Oliver Kurth <okurth@vmware.com>
1292Date: Fri Mar 23 15:05:36 2018 -07001188Date: Wed Apr 10 14:14:56 2019 -0700
12931189
1294 Common source file changes that are not applicable to open-vm-tools.1190 Remove some "always TRUE" comparisons reported by clang 6.0 on FBSD.
1191
1192 A recent refactoring of HGFS fuse code to avoid taking the address of
1193 a field in a packed structure introduced a comparision of an array
1194 address != NULL which will always evaluate to "true". Removing the
1195 unnecessary "if" statements.
12951196
1296commit 6c3261d152442fa11fc2b928490d74846f23465d1197commit 67b66d0ff13324413deac6c522bd382ee450125e
1297Author: Oliver Kurth <okurth@vmware.com>1198Author: Oliver Kurth <okurth@vmware.com>
1298Date: Fri Mar 23 15:05:36 2018 -07001199Date: Wed Apr 10 14:14:56 2019 -0700
1200
1201 Common source file change not applicable to open-vm-tools.
1202
1203commit 86bf8de08dbb28e8902411b8a9bc0e64f972f74d
1204Author: Oliver Kurth <okurth@vmware.com>
1205Date: Wed Apr 10 14:14:56 2019 -0700
12991206
1300 Common header file change not applicable to open-vm-tools.1207 Common header file change not applicable to open-vm-tools.
13011208
1302commit 3747daca8efbfe8e709687b97c874a29f183b7171209commit 3bc7907533c45544fcfb24906a0e4b7de61718e7
1303Author: Oliver Kurth <okurth@vmware.com>1210Author: Oliver Kurth <okurth@vmware.com>
1304Date: Fri Mar 23 15:05:36 2018 -07001211Date: Wed Apr 10 14:14:55 2019 -0700
13051212
1306 Backout previous change to lib/include/vm_basic_math.h.1213 Changes to common header files not applilcable to open-vm-tools.
13071214
1308commit f9414d19532a9664e6c260a8644ee09200e324291215commit 6576ad0d7b28bd1ddab2fce8a0f34695aa57a774
1309Author: Oliver Kurth <okurth@vmware.com>1216Author: Oliver Kurth <okurth@vmware.com>
1310Date: Fri Mar 23 15:05:36 2018 -07001217Date: Wed Apr 10 14:14:55 2019 -0700
13111218
1312 Common header file change: lib/include/vm_basic_math.h1219 Common source file change not applicable to open-vm-tools.
1313
1314 Define portability macros for Inf and Nan tests.
13151220
1316commit de2010a1a45a9e515b932a1a83374539661a2b391221commit 8c69b930a826aad87c692d516fd77d1a4cbed0fb
1317Author: Oliver Kurth <okurth@vmware.com>1222Author: Oliver Kurth <okurth@vmware.com>
1318Date: Fri Mar 23 15:05:35 2018 -07001223Date: Wed Apr 10 14:14:55 2019 -0700
13191224
1320 Add missing memory constraints for vm_atomic RMW (Read/Modify/Write) instructions1225 DnD Phase II] - Avoid potential memory overflow.
1321 1226
1322 There are two inseparable concepts involved when dealing with atomics:1227 In the case when dragging a format whose size is exactly the same as the
1323 1. Atomicity of the access itself1228 size threshold and plain text is provided, the plain text can't be added.
1324 2. Ordering of the access with respect to other reads&writes (from the view of1229 Current logic does not handle this case. Instead it will result in a
1325 other processors).1230 large unsigned number (0-1 = 0xffff_ffff) of bytes to be allocated to
1326 1231 store plain text which causes memory overflow.
1327 Our Read-Modify-Write functions are all meant to provide the highest level of
1328 ordering guarantee: Sequential Consistency, which means no reordering of reads
1329 or writes across the access. We properly implement that on ARM, and on
1330 x86/x64 at the hardware layer. But, on x86/x64 we needed to tell the compiler
1331 (it must flush out any pending reads/writes that are currently hiding in
1332 registers)
1333 1232
1334 Side Note: we do *not* change the pure Read and pure Write functions, only1233 Just return in the case that no more size left to add plain text or the
1335 the Read/Modify/Write ones. On both ARM and x86/x64, vm_atomic functions like1234 plain text is empty.
1336 Atomic_WriteN provide no (re)ordering guarantees today (at the hardware layer1235
1337 on ARM or at the compiler layer on x86/x64). This is because some callers1236commit 685aa3d0879aabde450ba0d6c79d256d6abaf3f5
1338 didn't need or want such guarantees - as such, Atomic_WriteN by itself is1237Author: Oliver Kurth <okurth@vmware.com>
1339 *not* sufficient to, say, release a lock. Making these remaining atomic1238Date: Wed Apr 10 14:14:55 2019 -0700
1340 weapons safe by default will require us to first1239
1341 1. add new unordered atomic equivalents of Atomic_ReadN/TestBitN and1240 Common header file change not applicable to open-vm-tools.
1342 Atomic_WriteN (in C11 terminology, acquire/release and relaxed)1241
1343 2. Scan the tree and switch appropriate callers to the new functions1242commit 71b41229ffe1f31711b35145ee1ab0bfbb763295
1243Author: Oliver Kurth <okurth@vmware.com>
1244Date: Wed Apr 10 14:14:54 2019 -0700
1245
1246 Common header file change not applicable to open-vm-tools.
1247
1248commit f2eb555cf6e9f8c779daf1dc9c2f7aff383d105a
1249Author: Oliver Kurth <okurth@vmware.com>
1250Date: Wed Apr 10 14:14:54 2019 -0700
1251
1252 Common header file change not applicable to open-vm-tools.
1253
1254commit 8046af84ee4aa1d271af4c1d2379fb3d88dba3ac
1255Author: Oliver Kurth <okurth@vmware.com>
1256Date: Wed Apr 10 14:14:54 2019 -0700
1257
1258 Common header file change not applicable to open-vm-tools.
1259
1260commit cf05c47b06af90a7bb7c5d561fb425ba2ebc0b47
1261Author: Oliver Kurth <okurth@vmware.com>
1262Date: Wed Apr 10 14:14:54 2019 -0700
1263
1264 Common source file change not directly applicable to open-vm-tools.
1265
1266commit 5a6ee8f90b90f42d24de1561ee94855c576933f3
1267Author: Oliver Kurth <okurth@vmware.com>
1268Date: Wed Apr 10 14:14:53 2019 -0700
1269
1270 Common header file change not applicable to open-vm-tools.
1271
1272commit d759ae5ecfcc6f1069decdb2511ec32bf12a1663
1273Author: Oliver Kurth <okurth@vmware.com>
1274Date: Wed Apr 10 14:14:53 2019 -0700
1275
1276 Asyncsocket in low latency send mode may write into freed memory
1344 1277
1345 *and only then*1278 Blast service encounters access violation exception during scale tests
1346 3. Strengthen the defaults, affecting only callers who needed the stronger1279 in AsyncTCPSocketSend() at bora\lib\asyncsocket\asyncsocket.c.
1347 defaults to be correct. ... but that would be a separate change in the
1348 future.
1349 1280
1350 Codegen differences (vmm.vmm64):1281 Root cause is asock refcount is not incremented before the inline
1351 --------------------------------1282 invocation of AsyncTCPSocketSendCallback() in the low latency send
1352 The function that uncovered this was ST_HandleCrossCall, which invoked1283 mode and asock is accessed right after this invocation to decrement
1353 Atomic_And64.1284 inLowLatencySendCb counter. AsyncTCPSocketSendCallback() on error
1285 would invoke error handler which in turn could close the asock
1286 leading to freeing of asock.
1354 1287
1355 original w/o explicit compiler mem barrier in ST_HandleCrossCall:1288 Issue wouldn't happen if AsyncWebSocket impl guarded all of its
1356 ...1289 transport->send(transport) calls with AsyncSocketAddRef(transport)
1357 lock and QWORD PTR [rdx+0x0],rax1290 and AsyncSocketRelease(transport) but isn't the case currently.
1358 movsxd rax,DWORD PTR [rip+offset] <-- load reordered after Atomic_And64
1359 lea rax,[rax+rax*2]
1360 lea rdi,[rax*8+0x0]
1361 1291
1362 with "memory" constraint, it's now identical to code w/an explicit1292 Fix is to add and release asock reference around the inline
1363 compiler mem barrier (which was the workaround):1293 invocation of AsyncTCPSocketSendCallback().
1364 ...1294
1365 mov edx,DWORD PTR [rip+offset] <-- load emitted prior to Atomic_And641295commit 325e244951790d7a848281fdb0236b0f6ee26996
1366 ...1296Author: Oliver Kurth <okurth@vmware.com>
1367 lock and QWORD PTR [rsi+0x0],rax1297Date: Wed Apr 10 14:14:53 2019 -0700
1368 movsxd rax,edx <-- ... and used after Atomic_And641298
1369 lea rax,[rax+rax*2]1299 Common header file change not applicable to open-vm-tools.
1370 lea rdi,[rax*8+0x0]1300
1301commit b90344ea3696506c7d2a8022c340b6aafb6f6a91
1302Author: Oliver Kurth <okurth@vmware.com>
1303Date: Wed Apr 10 14:14:52 2019 -0700
1304
1305 Common header file change not applicable to open-vm-tools.
1306
1307commit 13f457aa737d8bca27f09862cf2a45df8f4a425b
1308Author: Oliver Kurth <okurth@vmware.com>
1309Date: Wed Apr 10 14:14:52 2019 -0700
1310
1311 InitiateFileTransferToGuest fails when uploading file to root directory
1371 1312
1372 vmm.vmm64's .text section shrank 28 bytes1313 File upload to '/' on Linux fails the directory exists check.
1373 vmware-vmx's .text section shrank 16 bytes1314 This is caused by the file dirname being an empty string when parsed from
1315 the guest file path name per the documented behavior of File_GetPathName.
1374 1316
1375 Given that these are tiny fractions of the .text section, this suggests the1317 The caller of File_GetPathName needs to handle the expected empty dirname
1376 problem was quite rare, which is why it escaped our attention until now.1318 string when dealing with file path in the root ('/') filesystem on Linux.
1377 (Testing of vmx's lib/lock, lib/sync, lib/vprobe, and lib/misc saw no
1378 differences with GCC 4.4, 6.4, 7.1 or Clang)
1379 1319
1380 While in there: nuke some tabs1320 Proposed fix is to replace the dirname string with the root path ('/') when:
1321 A. dirname obtained from File_GetPathName call is an empty string AND
1322 B. the original file path name starts with the path separator ('/') on
1323 Linux (or *nix like) GOSes
1381 1324
1382 Slated for a future change: vmkapi_atomic.h1325 This allows for the directory checks to inspect the root folder before
1326 proceeding with the file transfer.
13831327
1384commit 333ac41076afff4e31ccb0d0688e1581e8c9019a1328commit 022121ce185662c05b3e1bf7166500f4f0f72bb2
1385Author: Oliver Kurth <okurth@vmware.com>1329Author: Oliver Kurth <okurth@vmware.com>
1386Date: Fri Mar 23 15:05:35 2018 -07001330Date: Wed Apr 10 14:14:51 2019 -0700
13871331
1388 Common header file change not applicable to open-vm-tools.1332 Common header file change not applicable to open-vm-tools.
13891333
1390commit 8671bd8d4f68a490a5b20f1876f05797f3057c4b1334commit 3de5e45099ae309b59f371e1d71c88c80815f92d
1391Author: Oliver Kurth <okurth@vmware.com>1335Author: Oliver Kurth <okurth@vmware.com>
1392Date: Fri Mar 23 15:05:35 2018 -07001336Date: Wed Apr 10 14:14:51 2019 -0700
13931337
1394 vmcheck.c VmCheck_IsVirtualWorld(): Always check for a working backdoor.1338 Backing out the previous change to vixTools.c
1395
1396 The specific checks for Xen and VirtualPC hypervisors currently happen
1397 only if the VMware hypervisor is not detected. The test for a working
1398 VMware backdoor is then done to avoid all other hypervisors.
1399 1339
1400 In the case where running on a VMware hypervisor and the backdoor1340 As the code committed was not the one reviewed but another version of the
1401 channel has been disabled such as with1341 fix under exploration, reverting the previous change.
1342
1343commit e38e881a04cdf1684913c0e65596f4965e8d0c32
1344Author: Oliver Kurth <okurth@vmware.com>
1345Date: Wed Apr 10 14:14:51 2019 -0700
1346
1347 Common header file change not applicable to open-vm-tools.
1348
1349commit f682261e7997aa440523af63369e4b99e4823af7
1350Author: Oliver Kurth <okurth@vmware.com>
1351Date: Wed Apr 10 14:14:49 2019 -0700
1352
1353 InitiateFileTransferToGuest fails when uploading file to root directory
1402 1354
1403 monitor_control.restrict_backdoor = "TRUE"1355 File upload to '/' on Linux fails the directory exists check.
1356 This is caused by the file dirname being an empty string when parsed from the guest file path name per the documented behavior of File_GetPathName.
1404 1357
1405 vmtoolsd, vmware-toolbox-cmd and vmware-checkvm will crash when1358 The caller of File_GetPathName needs to handle the expected empty dirname string when dealing with file path in the root ('/') filesystem on Linux.
1406 attempting to get the version number of the installed VMware Tools.
1407 1359
1408 Added an additional test to detect Linux KVM with the existing tests1360 Proposed fix is to replace the dirname string with the root path ('/') when:
1409 for the Xen hypervisor and Microsoft Virtual PC. Avoid checking for1361 A. dirname obtained from File_GetPathName call is an empty string AND
1410 a working backdoor if a non VMware hypervisor is seen.1362 B. the original file path name starts with the path separator ('/') on Linux (or *nix like) GOSes
1411 1363
1412 Microsoft Hv checking to be added later and is tracked in a separate PR.1364 This allows for the directory checks to inspect the root folder before proceedeing with the file transfer.
1413 Oracle VirtualBox provides no unique CPUID vendor signature string.
14141365
1415commit 09958952cc761075d5546b18bed0ce59260ec4db1366commit fcb7bb71a30f740b2d4bcfb8ae82733d044e6c00
1416Author: Oliver Kurth <okurth@vmware.com>1367Author: Oliver Kurth <okurth@vmware.com>
1417Date: Fri Mar 23 15:05:35 2018 -07001368Date: Thu Mar 28 12:43:00 2019 -0700
14181369
1419 FreeBSD open-vm-tools kernel modules compilations cannot locate <stdint.h>1370 Make building without ICU the default for Linux.
1420
1421 With the change for VMware headers to utilize the standard types
1422 defined in C99 standard headers, the compilation of FreeBSD kernel
1423 modules must specifically add /usr/include to the compilation
1424 options.
1425
1426 CFLAGS += -isystem /usr/include
1427
1428 This change updates the Makefiles's for FreeBSD kernel modules and
1429 drivers.
14301371
1431commit cdf0406dc669f2284e1e810ac5820f123d46a50e1372commit bd84c8a35c7aedb2638bba087bc1756cfb9ccf9d
1432Author: Oliver Kurth <okurth@vmware.com>1373Author: Oliver Kurth <okurth@vmware.com>
1433Date: Fri Mar 23 15:05:35 2018 -07001374Date: Thu Mar 28 12:43:00 2019 -0700
14341375
1435 FreeBSD: Improper use of sysconf() for getpwent buffer size leads to1376 Query disks for UUID
1436 vmtoolsd crash.
1437
1438 On FreeBSD, sysconf(_SC_GETPW_R_SIZE_MAX) can return -1 if it has
1439 no hard limit ultimately resulting in an incorrect buffer size.
1440
1441 This change is adapting the sysconf() ifixes done elsewhere to
1442 bora-vmsoft/services/plugins/vix/vixTools.c and updating the
1443 open-vm-tools AUTHORS file to share credit for the pull request.
1444 1377
1445 https://github.com/vmware/open-vm-tools/pull/2381378 As part of identifying a guest disk so it can be associated with a vmdk,
1379 query its serial number, which is the same as the vmdk's ddb.uuid
14461380
1447commit e20e9bd49d244749ee6bcd4ea7d57a26d891afbe1381commit 076e7e10f24b53fcbd7b21d95ee4763f5f527e45
1448Author: Oliver Kurth <okurth@vmware.com>1382Author: Oliver Kurth <okurth@vmware.com>
1449Date: Fri Mar 23 15:05:35 2018 -07001383Date: Thu Mar 28 12:43:00 2019 -0700
14501384
1451 Common header file change not applicable to open-vm-tools.1385 Common header file change not applicable to open-vm-tools.
14521386
1453commit 7e03f0676a8d1a8667d7d6aeda968a74c8708c0e1387commit b9939819756514c7ebe71059e0323cde8bb44c68
1454Author: Oliver Kurth <okurth@vmware.com>1388Author: Oliver Kurth <okurth@vmware.com>
1455Date: Fri Mar 23 15:05:35 2018 -07001389Date: Thu Mar 28 12:43:00 2019 -0700
14561390
1457 Common header file change not applicable to open-vm-tools.1391 Common header file change not applicable to open-vm-tools.
14581392
1459commit 0c4420178932c1879f402ece689e5cfaf5f37d841393commit 59a7e9e1c5e8e6883740ec43371cbe7076ee6bc0
1460Author: Oliver Kurth <okurth@vmware.com>1394Author: Oliver Kurth <okurth@vmware.com>
1461Date: Fri Mar 23 15:05:35 2018 -07001395Date: Thu Mar 28 12:43:00 2019 -0700
14621396
1463 CAF changes for Windows; not applicable to open-vm-tools.1397 Bug fix for DnD performance tuning for Mac and Windows clients; not
1398 directly applicable to open-vm-tools.
14641399
1465commit e9463abdc0d56d0612237faf01a5736c9998b4991400commit 176aa26ae63050e7d10c8413230c566069cb06d9
1466Author: Oliver Kurth <okurth@vmware.com>1401Author: Oliver Kurth <okurth@vmware.com>
1467Date: Fri Mar 23 14:57:12 2018 -07001402Date: Thu Mar 28 12:43:00 2019 -0700
14681403
1469 sysconf() usage leads to crashes in BSD tools1404 Common source file changes not applicable to open-vm-tools.
1470
1471 Not using the sysconf interface properly when determinining the
1472 getpwent buffer size. Fix this.
1473 1405
1474 Problem was identified and proposed fix was submitted in pull request1406 Security fix for dll load paths in Tools and vgauth.
1475 https://github.com/vmware/open-vm-tools/pull/238
14761407
1477commit 4eff69adab058331a1e93aee17ed9a4e13fa87141408commit f2e134e40bd7fab478f4f1545db8f09b39e2d3dc
1478Author: Oliver Kurth <okurth@vmware.com>1409Author: Oliver Kurth <okurth@vmware.com>
1479Date: Fri Mar 23 14:57:12 2018 -07001410Date: Thu Mar 28 12:43:00 2019 -0700
14801411
1481 [lib/file]: remove useless heap allocation1412 Common header file change not directly applicable to open-vm-tools.
1482
1483 FileIO_AtomicUpdateEx allocates the argument to the "swap" ioctl
1484 on the heap. This argument is a struct which contains a single int
1485 fd... there is no need to heap-allocate it, the stack is just fine.
14861413
1487commit 6de42f7d96fb5c70d70ae3b68011477f8b93aef21414commit c65bb4057bbd8d4b96f8b1bedfc273669357cfd8
1488Author: Oliver Kurth <okurth@vmware.com>1415Author: Oliver Kurth <okurth@vmware.com>
1489Date: Fri Mar 23 14:57:12 2018 -07001416Date: Thu Mar 28 12:43:00 2019 -0700
14901417
1491 bora/lib: Use _exit when in the context of a signal handler1418 GOS Table: Add Linux 5.x
1492
1493 There are a few cases in bora/lib where exit(3) is used in the
1494 context of a signal handler. It was recently noticed that exit(3) is
1495 not async-signal-safe, and _exit(2) should be used instead.
1496 1419
1497 This patch changes a call from exit(3) to _exit(2) in bora/lib.1420 Linux 5.x is here! Add it to our supported guests list.
14981421
1499commit 54415a34a372388374bf322d8118ef47c7b0f9f71422commit 9f05b0bca42039eb6de0f16441d3a6edc4093264
1500Author: Oliver Kurth <okurth@vmware.com>1423Author: Oliver Kurth <okurth@vmware.com>
1501Date: Fri Mar 23 14:57:12 2018 -07001424Date: Thu Mar 28 12:43:00 2019 -0700
15021425
1503 Hgfs FUSE Client: enable the FUSE client for RHEL 7, Ubuntu 14.04 and others1426 Common header file change not directly applicable to open-vm-tools.
1427
1428commit d28bb53aeeb425502de7a90175482c5abf16b8ee
1429Author: Oliver Kurth <okurth@vmware.com>
1430Date: Thu Mar 28 12:43:00 2019 -0700
1431
1432 Remove the /etc/security directory from the guest vm-support bundle.
1504 1433
1505 The RHEL 7.x releases are all kernel 3.10 based. Currently the Hgfs FUSE1434 This directory contains sensitive guest side data that we should not
1506 client will not be enabled for these earlier kernel versions, enabled only1435 expose to the host side.
1507 for 4.0 kernels and later. This means for default tools install on plaftorms
1508 running those kernel versions the Hgfs kernel client must be installed and
1509 used for Shared Folders. The consequence of this means that the tar tools
1510 installer must be run to provide the Hgfs kernel client on top of the OVT
1511 install.
1512 1436
1513 To remove the need to install the tar tools we must enable support for the1437 Although running the vm-support requires the root privilege in the guest,
1514 Hgfs FUSE client, which just requires the kernel version check to be modified1438 the guest admin might not be aware of the ramification of running the script.
1515 from 4.0.0 to 3.10.0.1439 Therefore, better be cautious.
1440
1441 No file from the /etc/security has been needed in the past. If any file is
1442 needed in the future, that need will be evaluated case-by-case at that time.
15161443
1517commit 84977ad9a0ca964d5873516c42efec328bac23c91444commit b87bf1b5a1fb93f348d311086c335c0e14e44469
1518Author: Oliver Kurth <okurth@vmware.com>1445Author: Oliver Kurth <okurth@vmware.com>
1519Date: Fri Mar 23 14:57:12 2018 -07001446Date: Thu Mar 28 12:43:00 2019 -0700
15201447
1521 Changes to common header files; not applicable to open-vm-tools.1448 Common header file change not applicable to open-vm-tools.
15221449
1523commit 587d95eeadbdab2f20020ef24686bd989af6d8b01450commit c760135f46eaf246612bc8632374966ed79ce9b2
1524Author: Oliver Kurth <okurth@vmware.com>1451Author: Oliver Kurth <okurth@vmware.com>
1525Date: Fri Mar 23 14:57:11 2018 -07001452Date: Thu Mar 28 12:43:00 2019 -0700
15261453
1527 lib/misc/hostinfoPosix.c: Fix sscanf format string case typo.1454 DnD performance tuning for Mac and Windows clients; not directly applicable
1455 to open-vm-tools.
15281456
1529commit 8e22cb4da06036b71a06698da3377ed72cfef4401457commit 477bc19fac47a71369bf5872c8ff9b366d51ca1a
1530Author: Oliver Kurth <okurth@vmware.com>1458Author: Oliver Kurth <okurth@vmware.com>
1531Date: Fri Mar 23 14:57:11 2018 -07001459Date: Thu Mar 28 12:42:59 2019 -0700
15321460
1533 Changes to common header files; not applicable to open-vm-tools.1461 Fix a memory leak in vmbackup.
1462
1463 Note: vm_free() is called here because GuestApp_GetConfPath() is calling
1464 Util_SafeStrdup() to allocate the memory. Both GuestApp_GetConfPath and
1465 vm_free are implemented inside libvmtools.so.
15341466
1535commit 9e3738b457eba1d9f8302fa449e9521da59f2dfd1467commit 8f1e76f97989009fa44cbbfc1ac48e3e0083b9e7
1536Author: Oliver Kurth <okurth@vmware.com>1468Author: Oliver Kurth <okurth@vmware.com>
1537Date: Fri Mar 23 14:57:11 2018 -07001469Date: Thu Mar 28 12:42:59 2019 -0700
15381470
1539 Changes to common header files; not applicable to open-vm-tools.1471 Common source file change not applicable to open-vm-tools.
15401472
1541commit 18358aecd27f7d77b71d5ab31250edc600b7bfbc1473commit d93219282ff7e89e3f581bf757dfd807c7568452
1542Author: Oliver Kurth <okurth@vmware.com>1474Author: Oliver Kurth <okurth@vmware.com>
1543Date: Fri Mar 23 14:57:11 2018 -07001475Date: Thu Mar 28 12:42:59 2019 -0700
15441476
1545 Changes to common header files; not applicable to open-vm-tools.1477 Fix memory leak in GetFormattedCommandLine() function (linuxDeployment.c)
1478
1479 1. There are malloc() calls happening in a loop; this function returns
1480 NULL when one of malloc fails. If a malloc call fails in the loop,
1481 all memory allocated in previous iterations should be freed before
1482 the return NULL.
1483 2. Clear allocated resources before return NULL in this file.
1484 3. Add NULL check following malloc calls in this file.
1485 4. Encapsulate %s in () only if %s is strerror(errno), otherwise encapsulate
1486 %s in single quotes.
1487 5. End with \n in sLog.
15461488
1547commit 670dba44e90c64173a1f67e617a7193f18fc3a2c1489commit 85f0733565333335aac4c45851013e8e0901a9f5
1548Author: Oliver Kurth <okurth@vmware.com>1490Author: Oliver Kurth <okurth@vmware.com>
1549Date: Fri Mar 23 14:57:11 2018 -07001491Date: Wed Feb 27 14:39:58 2019 -0800
1492
1493 Remove dead code in vmtoolsConfig.c
1494
1495 There is a lot code in vmtoolsConfig.c that handles the 'tools upgrades'
1496 from legacy tools versions.
1497
1498 But as per
1499 https://docs.vmware.com/en/VMware-Tools/10.1/rn/vmware-tools-1010-release-notes.html#installupgrade,
1500 legacy tools versions (prior to 9.4.x) must be first upgraded to 10.1.0 before
1501 upgrading to the latest tools versions. Hence, removed all the code which is
1502 no longer applicable for the 'latest tools version'.
1503
1504commit 449b8d4aa6ca1fbd34ac1f5aa5324c141075ab0a
1505Author: Oliver Kurth <okurth@vmware.com>
1506Date: Wed Feb 27 14:39:58 2019 -0800
15501507
1551 Common header file change not applicable to open-vm-tools.1508 Common header file change not applicable to open-vm-tools.
15521509
1553commit 5fe941cd27194495811036667d312f14aece19751510commit 23dec2833bc0961b7623672deb9971f4ae0ec385
1554Author: Oliver Kurth <okurth@vmware.com>1511Author: Oliver Kurth <okurth@vmware.com>
1555Date: Fri Mar 23 14:57:11 2018 -07001512Date: Wed Feb 27 14:39:58 2019 -0800
15561513
1557 Common header file change not applicable to open-vm-tools.1514 Common header file change not applicable to open-vm-tools.
15581515
1559commit 03faa87192b23354a996b4d62282c002de002c591516commit fa94fcf10c3fd0fe8a327cb27de72830ce615257
1560Author: Oliver Kurth <okurth@vmware.com>1517Author: Oliver Kurth <okurth@vmware.com>
1561Date: Fri Mar 23 14:57:11 2018 -07001518Date: Wed Feb 27 14:39:58 2019 -0800
1519
1520 Log guest OP results to guest side only.
1521
1522commit aaa29bf9e9a59a25b009949bc688166615e983ae
1523Author: Oliver Kurth <okurth@vmware.com>
1524Date: Wed Feb 27 14:39:57 2019 -0800
15621525
1563 Common header file change not applicable to open-vm-tools.1526 Common header file change not applicable to open-vm-tools.
15641527
1565commit 2438cefba37d37de65bf2003b1880f47b529ef471528commit c88df96c3c8aab080bb79ad8ece5b558cf49bbe1
1566Author: Oliver Kurth <okurth@vmware.com>1529Author: Oliver Kurth <okurth@vmware.com>
1567Date: Tue Mar 6 10:38:43 2018 -08001530Date: Wed Feb 27 14:39:57 2019 -0800
15681531
1569 Enhancements for rpcChannel library.1532 Common header file change not applicable to open-vm-tools.
1570 1533
1571 rpcChannel.c file contains the code for building rpcChannel library. A good1534commit 89dcc97adf9ed58ed3f2f89ca354ee55353e8317
1572 amount of the same code is duplicated in rpcChannelSimple.c file to1535Author: Oliver Kurth <okurth@vmware.com>
1573 build a simplified version (no glib dependency) of the rpcChannel library.1536Date: Wed Feb 27 14:39:57 2019 -0800
1574 It's recommended to remove the duplication and maintain only one single1537
1575 file which can be used to build both 'glib-dependent rpcChannel' and1538 Changes to common header files not applicable to open-vm-tools.
1576 'glib independent rpcChannel' library.1539
1540commit f23e764d01136eaf3aba5c91da2db334b4c9cb1a
1541Author: Oliver Kurth <okurth@vmware.com>
1542Date: Wed Feb 27 14:39:57 2019 -0800
1543
1544 Tools Vix Plugin: minor cleanup remove unnecessary undefs
1577 1545
1578 This changeset implements the following changes:1546 A minor cleanup remove unnecessary undefs and fixing a misspelling in
1579 * Removed rpcChannelSimple.c1547 a function header. The function header somehow got removed from the
1548 previous clean up so here it is again anyway, with the addition of the
1549 spelling correction.
1550
1551commit 13e4fd7c5be25fcf2a4243c2ca32cdf0fec44496
1552Author: Oliver Kurth <okurth@vmware.com>
1553Date: Wed Feb 27 14:39:57 2019 -0800
1554
1555 Linux DeployPkg should provide a configurable timeout for the spanning
1556 customization process.
1580 1557
1581 * Renamed I_USE_SIMPLE_RPC make variable to USE_RPCI_ONLY. If this1558 Change the upper limit of the timeout value in tools.conf to 3600 instead
1582 flag is specified, rpcChannel library will be built using only RPCI.1559 of MAX_UINT16. Revise the log message displayed when an invalid value
1583 No dependencies on rpcIn will be added. This inturn will remove1560 is configured in tools.conf.
1584 dependencies on dynxdr, xdr and glib.1561
1562commit 6b6a4c8d2262036fec01d894819b8ac8c764e05b
1563Author: Oliver Kurth <okurth@vmware.com>
1564Date: Wed Feb 27 14:39:57 2019 -0800
1565
1566 Remove some redundant code in lib/poll/poll.c detected by cppcheck.
1567
1568commit bd4bd92bab5339dc29ad042295e218b68c35f974
1569Author: Oliver Kurth <okurth@vmware.com>
1570Date: Wed Feb 27 14:39:56 2019 -0800
1571
1572 Tools Vix Plugin: remove unused hgfs rpc channel
1585 1573
1586 * Modified the RpcChannelInt structure to have only the necessary1574 This change removes the unused VIX_BACKDOORCOMMAND_SEND_HGFS_PACKET
1587 attributes when USE_RPCI_ONLY is defined.1575 rpc handler from the Vix plugin.
1588
1589 * Modified a bunch of functions into '#if defined(NEED_RPCIN)' block
1590 to make available only when necessary.
1591
1592 * Modified guestrpc.h to provide the declarations for few RpcChannel_*
1593 functions only when needed.
1594
1595 * Modified rpcChannel library to implement necessary stub files / functions
1596 when it has to be built 'with rpci only' setting.
1597
1598 * Removed various copies of 'glib_stubs.c' maintained by different
1599 consumers of rpcChannel (appmonitorlib, vmGuestLib, 'imgcust' components).
1600
1601 * Modified the make files of various consumers (vmGuestLib, appmonitorlib,
1602 imgcust components [linux-pkg-deployer, guestcustutil, UnitTest]) to
1603 remove the dependencies for dynxdr library.
1604
1605 * Did some code refactoring.
1606 - Removed some dead code in some make files.
16071576
1608commit 87be66f17bf7911a8ec59ce9917778f7f653a3981577commit df108dbfeb08dcf1c9ac0b6dd0026048c6c007a8
1609Author: Oliver Kurth <okurth@vmware.com>1578Author: Oliver Kurth <okurth@vmware.com>
1610Date: Tue Mar 6 10:38:43 2018 -08001579Date: Wed Feb 27 14:39:56 2019 -0800
16111580
1612 Implement a new function VMTools_GetTimeAsString.1581 Changes to common header files not applicable to open-vm-tools.
1613
1614 * Implemented a new function VMTools_GetTimeAsString in
1615 vmtools library which returns a properly formatted UTC timestamp
1616 information. This function can be used by different modules / plugins
1617 in 'VMware Tools' to add the timestamp information in log files.
1618
1619 Example of UTC timestamp information: "2018-02-22T21:17:38.517Z"
1620
1621 * Modified vmtools logging module to call the new function and
1622 prepend the UTC timestamp information in every log message.
1623
1624 * Modified deployPkgLog.c to use the new function.
1625
1626 * Removed references / definition of System_GetTimeAsString since
1627 it is no longer used anywhere in the code.
16281582
1629commit acbf7d90add72d9d3aa70bb8677179e7b3d28e231583commit 3cd64dd8b345194c277dfbfe7361db115294a40c
1630Author: Oliver Kurth <okurth@vmware.com>1584Author: Oliver Kurth <okurth@vmware.com>
1631Date: Tue Mar 6 10:38:43 2018 -08001585Date: Wed Feb 27 14:39:56 2019 -0800
16321586
1633 Common header file change; not applicable to open-vm-tools.1587 Common header file change not applicable to open-vm-tools.
16341588
1635commit 87ddd2684bff33836db5667718449f42642c76e21589commit 1875839fe260d7093e8170ef079b6c6875a1c99d
1636Author: Oliver Kurth <okurth@vmware.com>1590Author: Oliver Kurth <okurth@vmware.com>
1637Date: Tue Mar 6 10:38:43 2018 -08001591Date: Wed Feb 27 14:39:56 2019 -0800
16381592
1639 GOS Table: The official Amazon Linux 2 string is "amazonlinux2-64"1593 Common header file change not applicable to open-vm-tools.
1640
1641 The hosted UI isn't creating an Amazon 2 VM with the correct guest OS
1642 identifier string. Fix this.
16431594
1644commit 91b42f829a0ddc13a1657610700332dad7a9e3621595commit 705dea9434a9e2b4db2163e6cf9bdd5451f4e4d6
1645Author: Oliver Kurth <okurth@vmware.com>1596Author: Oliver Kurth <okurth@vmware.com>
1646Date: Tue Mar 6 10:38:43 2018 -08001597Date: Wed Feb 27 14:39:55 2019 -0800
16471598
1648 Fix vgauth log timestamps to have zone and use UTC1599 Common header file change not applicable to open-vm-tools.
16491600
1650commit d225ed26cca556f559c035234d11bd7d380c6d7f1601commit 0230f00147774547cd72e62a805db511234bbf8e
1651Author: Oliver Kurth <okurth@vmware.com>1602Author: Oliver Kurth <okurth@vmware.com>
1652Date: Tue Mar 6 10:38:42 2018 -08001603Date: Wed Feb 27 14:39:55 2019 -0800
16531604
1654 Common header file change; not applicable to open-vm-tools1605 Common header file change not applicable to open-vm-tools.
16551606
1656commit d585ee8fcc4135d6d52fdc38ec2e0ca747663bf71607commit 1703710a2706527748ec7be6767c14f2fcf63fc2
1657Author: Oliver Kurth <okurth@vmware.com>1608Author: Oliver Kurth <okurth@vmware.com>
1658Date: Tue Mar 6 10:38:42 2018 -08001609Date: Wed Feb 27 14:39:55 2019 -0800
16591610
1660 Compilation fixes to build Tools with VS20151611 Common source file changes not directly applicable to open-vm-tools.
1612
1613commit c68172ef7f2d4f116078e2aba82986a8cab0b16e
1614Author: Oliver Kurth <okurth@vmware.com>
1615Date: Wed Feb 27 14:39:55 2019 -0800
1616
1617 GCC 9 caught several misaligned accesses and a format overflow.
1661 1618
1662 This change consists of fixing warnings/errors as a result of building Tools with VS2015.1619 GCC 9 generated several instances of "Werror=address-of-packed-member"
1620 in HGFS Fuse support code and hgfsmounter. There is also one instance of
1621 "Werror=format-overflow" generated in util_misc.c.
1622
1623 According to stackoverflow discussion -
1624 https://stackoverflow.com/questions/8568432/is-gccs-attribute-packed-pragma-pack-unsafe,
1625 x86 hardware handles misaligned access and does not exhibit any real
1626 issues. However, GCC 9 generates misaligned access warning
1627 ("Werror=address-of-packed-member) for all architectures. In case of
1628 open-vm-tools build we treat warnings as errors and also we want code
1629 to be as portable as possible in general unless there is a reason not
1630 to do so.
16631631
1664commit 03c98a1fb30513b223e3d6eafb21b5f4d4c6c5bc1632commit 577bc573f875ad5fe0e932cc58f2d607c422ea92
1665Author: Oliver Kurth <okurth@vmware.com>1633Author: Oliver Kurth <okurth@vmware.com>
1666Date: Tue Mar 6 10:38:42 2018 -08001634Date: Wed Feb 27 14:39:54 2019 -0800
16671635
1668 Add timestamp information to each deploypkg log message.1636 Common source file changes not applicable to open-vm-tools.
1637
1638commit 17a318fbde8df0b7aaa222acf944d319397fa42c
1639Author: Oliver Kurth <okurth@vmware.com>
1640Date: Wed Feb 27 14:39:54 2019 -0800
1641
1642 Common header file change not applicable to open-vm-tools.
1643
1644commit 9a013addd657dda0d6671b7ea64c4a0793f57d18
1645Author: Oliver Kurth <okurth@vmware.com>
1646Date: Tue Feb 19 12:51:33 2019 -0800
1647
1648 Bump up the SYSIMAGE_VERSION to be same as the VMTools version.
1649
1650commit 34e9b02de740562802680ab43b8dfd3e741b0658
1651Author: Oliver Kurth <okurth@vmware.com>
1652Date: Tue Feb 19 12:51:33 2019 -0800
1653
1654 Hgfs Server Manager Tools: fix a memory leak
1669 1655
1670 * Modified deployPkgLog.c file to prepend UTC timestamp information1656 The Hgfs server manager interface assumes that it is called only once
1671 to each log message coming from 'deploypkg' module in 'VMware Tools'.1657 for each application that uses it. However, in the tools services there
1658 are multiple clients. Hence, the initialization is done multiple times
1659 and causes the previous initializations which allocate resources to be
1660 overwritten and lost. Thus memory is being leaked.
1672 1661
1673 * Used bunch of glib functions to get the current UTC time. As per1662 Initialize the policy shares once on the first register and cleanup
1674 the glib manual, these glib functions are available since 2.26. 2.26 was1663 the policy shares on final unregister by introducing a reference count.
1675 released around 8 years ago which is kind of very old. Having the glib
1676 dependency on 2.26 is OK.
1677 1664
1678 * Did some minor code refactoring. In DeployPkg.c file, at all1665 The channel is already reference counted and initializes the channel once.
1679 call sites for DeployPkgLog_Log, replaced the hard coded values with1666 However it is necessary to call the channel init on each register
1680 the proper LogLevel enums.1667 and exit on each unregister as it saves a channel reference in the data manager
1668 object passed to it by the caller for subsequent retrieval.
1669
1670 Add an additional log to the policy init and cleanup calls for tracking purposes.
16811671
1682commit 73a21a057dc23cf428b5fa1799eb0c5945732fee1672commit 19609ecdf97dbdbfa116eb3129689850fbf3e528
1683Author: Oliver Kurth <okurth@vmware.com>1673Author: Oliver Kurth <okurth@vmware.com>
1684Date: Tue Mar 6 10:38:42 2018 -08001674Date: Tue Feb 19 12:51:33 2019 -0800
16851675
1686 Common header file change; not applicable to open-vm-tools.1676 Common header file change not applicable to open-vm-tools.
16871677
1688commit 3eb8434aebde9a2eebc65d57044d8ea6367d685f1678commit 05fb961e2c5fcb0e3be0353171f3f2b5d945d0dd
1689Author: Oliver Kurth <okurth@vmware.com>1679Author: Oliver Kurth <okurth@vmware.com>
1690Date: Tue Mar 6 10:38:42 2018 -08001680Date: Tue Feb 19 12:51:33 2019 -0800
16911681
1692 Common header file change; not applicable to open-vm-tools.1682 Common source file change not directly applicable to open-vm-tools.
16931683
1694commit 24e9d211752210abb94bd1e76bec8be20d8abef81684commit 393476a4ccab5dbf1afe1ac5ced9f71be0d25cff
1695Author: Oliver Kurth <okurth@vmware.com>1685Author: Oliver Kurth <okurth@vmware.com>
1696Date: Tue Mar 6 10:38:42 2018 -08001686Date: Tue Feb 19 12:51:33 2019 -0800
16971687
1698 vm_basic_types.h: enable stdint.h for c991688 Common header file change not applicable to open-vm-tools.
1699
1700 C99 mode (a.k.a. __STDC_VERSION__ >= 199901L) guarantees
1701 the stdint.h header will be present, which means we can use it
1702 for standard types instead of rolling our own.
17031689
1704commit b4016c210e7cb6c0407d40dba5edfa64d550bef31690commit 4746cfffa7f4334438f4f0b219033b33d079f970
1705Author: Oliver Kurth <okurth@vmware.com>1691Author: Oliver Kurth <okurth@vmware.com>
1706Date: Tue Mar 6 10:38:41 2018 -08001692Date: Tue Feb 19 12:51:33 2019 -0800
17071693
1708 Don't lose errno/lastError when logging1694 Common header file change not applicable to open-vm-tools.
1709
1710 guestOps need to see errno/lastError in order to return the proper
1711 error to VIX/guestOps APIs. Logging (at any layer) can cause these
1712 to be overwritten, so make sure they're preserved.
17131695
1714commit 14a0ffe23be6437c9ee656ccf2d516ead6265dfd1696commit 68b2d39547222badd73cdbc6eecdec57e8e5e45e
1715Author: Oliver Kurth <okurth@vmware.com>1697Author: Oliver Kurth <okurth@vmware.com>
1716Date: Mon Feb 26 19:23:18 2018 -08001698Date: Tue Feb 19 12:51:33 2019 -0800
17171699
1718 Enhancing CAF listener preconfigured check logic to update the preconfigured flag at runtime1700 Common header file change not applicable to open-vm-tools.
1719
1720 1. Preconfigure listener and start listener upon tunnel enabled logic are
1721 invoked in two different threads.
1722 2. There is a case where preconfigure logic is performed after the
1723 pre-configured flag is computed in the enable-listener thread.
1724
1725 The current patch invalidates the flag in the start listener thread and
1726 should guarantee the preconfigured status is up-to-date.
17271701
1728commit 60f7afc97264435e1c04c2e70fe39397261b52b41702commit 188df13c0a30c4612c074b7c805926f9a35120d0
1729Author: Oliver Kurth <okurth@vmware.com>1703Author: Oliver Kurth <okurth@vmware.com>
1730Date: Mon Feb 26 19:22:04 2018 -08001704Date: Tue Feb 19 12:51:33 2019 -0800
17311705
1732 CAF MA Performance Issues1706 Common header file change not applicable to open-vm-tools.
1733
1734 CAF MA Performance Issues
1735
1736 Vmware CAF ManagementAgentHost service was polling every 5 secs to check if Guest Network "Tunnel(port 6672)" was enabled to preconfigure & bring up Vmware CAF CommAmqpListener service.
1737 This resulted in more CPU Utilization as opposed to previous release in CAF & caused regression in vmtools 10.2.0.
1738 We are increasing the Poll rate to 5 mins, which fixed the issue & is giving us the same CPU/memory utilizations as in vmtools 10.1.0.
1739
1740 We were checking for the different stages of listener preconfiguration status from the listenerpreConfigure.txt files in the polling time interval, which caused increased IO operations.
1741 To fix that we have stored the value of listener preconfiguration status from the files into a variable locally & using the same at all places instead of file access.
17421707
1743commit 872baeed3fd1e79f89143baa0b9c47077b6555671708commit 7b88dd52f7d3f70664282f9546230f40dbabc694
1744Author: Oliver Kurth <okurth@vmware.com>1709Author: Oliver Kurth <okurth@vmware.com>
1745Date: Mon Feb 26 12:29:08 2018 -08001710Date: Tue Feb 19 12:51:33 2019 -0800
17461711
1747 lib/file: add File_MakeSafeTempSubdir1712 Changes to common header files not applicable to open-vm-tools.
1748
1749 File_MakeSafeTempDir and File_GetSafeTmpDir are typically used to create
1750 "safe" temp dirs on Windows and Linux. These are dirs in a known-secure
1751 location with known-secure security attributes that only allow access to
1752 the current user. These APIs work fine. However, on Windows if one creates
1753 a subdir inside the safe dir, the subdir may be given an unexpected
1754 (and overly restrictive) set of default DACLs on it in unusual situations.
1755 The solution is to introduce a new API specifically to allow a caller to
1756 create a subdir within an existing safe dir that ensures the DACLs
1757 are exactly what are needed.
17581713
1759commit bdbab22ec42544dbfff657b811d695e5b5a6d4291714commit 91c3366719fad3546d705ccb8000fef12ab8e284
1760Author: Oliver Kurth <okurth@vmware.com>1715Author: Oliver Kurth <okurth@vmware.com>
1761Date: Mon Feb 26 12:29:08 2018 -08001716Date: Tue Feb 19 12:51:33 2019 -0800
17621717
1763 Remove the header file safetime.h1718 Common header file change not applicable to open-vm-tools.
1764
1765 This removes the file itself.
17661719
1767commit 047f05f379eb73530ac943d35cda5c162e045fa21720commit 41d328a9b1119f6078948fdb619d66940eae2a9b
1768Author: Oliver Kurth <okurth@vmware.com>1721Author: Oliver Kurth <okurth@vmware.com>
1769Date: Mon Feb 26 12:29:08 2018 -08001722Date: Tue Feb 19 12:51:32 2019 -0800
17701723
1771 Common source file change; not applicable to open-vm-tools.1724 Common header file change not applicable to open-vm-tools.
17721725
1773commit 2c927bb65029cb89ba0c4b7ba9b341890166823d1726commit c9863b19f32c20a6ca38cdb6244ef48e5f51dcc2
1774Author: Oliver Kurth <okurth@vmware.com>1727Author: Oliver Kurth <okurth@vmware.com>
1775Date: Mon Feb 26 12:29:07 2018 -08001728Date: Tue Feb 19 12:51:32 2019 -0800
17761729
1777 Skip specified file systems when doing a quiesced snapshot on Linux1730 Common header file change not applicable to open-vm-tools.
1778
1779 Add a tools.conf setting "excludedFileSystems" that specifies one or
1780 more file system mount points to be skipped over when performing a
1781 quiesced snapshot on Linux guests. The value of excludedFileSystems
1782 is a comma-separated list of glob-style patterns as recognized by the
1783 glib routines described here:
1784
1785 https://developer.gnome.org/glib/stable/glib-Glob-style-pattern-matching.html
1786
1787 With this change, when performing a quiesced snapshot, the sync driver
1788 freeze routine removes from the list of mount points it is to process
1789 any path that matches a pattern in the excludedFileSystems list.
1790
1791 In the course of testing the change, a bug was found in SyncDriverFreeze
1792 in which it returned SD_ERROR rather than FALSE when the path list is
1793 empty.
1794
1795 This change also includes some whitespace cleanup in syncDriverWin32.c.
17961731
1797commit 9fb904dbdbd12952f2743d1463cda56a72c50c901732commit fdcd728a0b9c21f6017f7a4aef55553a88a6f9ee
1798Author: Oliver Kurth <okurth@vmware.com>1733Author: Oliver Kurth <okurth@vmware.com>
1799Date: Mon Feb 26 12:29:07 2018 -08001734Date: Tue Feb 19 12:51:32 2019 -0800
18001735
1801 lib/file: Paranoid clear of old cached values1736 Changes to common header files not directly applicable to open-vm-tools.
1802
1803 Rare, but an app might toggle addPid; cover this. Also optimize the
1804 cache update.
18051737
1806commit d244dac08f07cbbcba3f66eab7d78c16150edfba1738commit 46ce56518e018c98d5f2c2dfcbda6df039cb548f
1807Author: Oliver Kurth <okurth@vmware.com>1739Author: Oliver Kurth <okurth@vmware.com>
1808Date: Mon Feb 26 12:29:07 2018 -08001740Date: Tue Feb 19 12:51:32 2019 -0800
18091741
1810 lib/file: File_GetSafeTmpDir is not aware of credentials changes1742 Common header file change not applicable to open-vm-tools.
1743
1744commit 35eae094a31571d806ffdb82c479a425a865bfda
1745Author: Oliver Kurth <okurth@vmware.com>
1746Date: Tue Feb 19 12:51:32 2019 -0800
1747
1748 Common header file change not applicable to open-vm-tools.
1749
1750commit 43ba436554ee51d8d7e40a7e86618bd634292356
1751Author: Oliver Kurth <okurth@vmware.com>
1752Date: Tue Feb 19 12:51:32 2019 -0800
1753
1754 Common source file changes not applicable to open-vm-tools.
1755
1756commit a62dd61cc798cf311fa23449534eb22470997ee7
1757Author: Oliver Kurth <okurth@vmware.com>
1758Date: Tue Feb 19 12:51:32 2019 -0800
1759
1760 Changes to common source files not directly applicable to open-vm-tools.
1761
1762commit 9877ed7ad678fa77028c6f4c8a285c82d7fbcb9e
1763Author: Oliver Kurth <okurth@vmware.com>
1764Date: Tue Feb 19 12:51:32 2019 -0800
1765
1766 Common header file change not applicable to open-vm-tools.
1767
1768commit 364684e1ce5fba483682f91c7fc27ee0fdcc2a93
1769Author: Oliver Kurth <okurth@vmware.com>
1770Date: Tue Feb 19 12:51:32 2019 -0800
1771
1772 Fix the missing IP aliases in the guest info.
1811 1773
1812 Some applications may masquerade their use (change their EUID).1774 IP aliases were missing in the guest info when libdnet is not used.
1813 Futhermore, each thread in an application can have a separate EUID.
1814 1775
1815 Anytime a application or thread asked for its safe temporary directory,1776 Previously tried to use the MAC address as the key to identify the IP aliases
1816 it needs to get the same result regardless of how many times it asks.1777 on Linux. However, that didn't work for vlan devices which share the same
1778 MAC as the parent NIC. The previous attempt was backed out.
1817 1779
1818 Change File_GetSafeTmpDir to cache the EUID associated with the cached1780 Ideally, need to find a way to map the label name to the NIC name, but
1819 values. If there is an EUID change, invalidate the existing cache1781 have not been able to find a simple solution for this. There might be a
1820 entries and recompute them. The recomputation process is stable, in1782 netlink based solution but it is way too costly to do.
1821 that it will obtain the same return any time it is called.
1822 1783
1823 This way we get the benefit of the cache (performance), ensured1784 After more investigation, found out that a valid IP alias name must start
1824 correctness (for applications that do not masquerade), and correctness1785 with the original NIC name followed by a colon. Even though the ip addr allows
1825 for those applications that do masquerade.1786 any string as the start of the NIC name, configuration file requires the colon.
1787 In addition, ifconfig would error out when the name is not of the standard:
1788 ens192wwwww: error fetching interface information: Device not found
1789
1790 Therefore, a correctly configured system should use eth0:1, ens192:2 etc.
1791
1792 A lookup of libdnet source revealed the same assumption in the libdnet code.
1793
1794 /* Get addresses for this interface. */
1795 for (ifr = intf->ifc.ifc_req; ifr < lifr && (ap + 1) < lap;
1796 ifr = NEXTIFR(ifr)) {
1797 /* XXX - Linux, Solaris ifaliases */
1798 if ((p = strchr(ifr->ifr_name, ':')) != NULL)
1799 *p = '\0';
1800
1801 Therefore, doing just the same. Look for the colon, then trim it, and then
1802 compare it with the NIC name.
18261803
1827commit f9177b133f7f683fcc0f85770712d8069ec524211804commit 47943dec30e3b98259c1dc0d48fb4f669fb02e99
1828Author: Oliver Kurth <okurth@vmware.com>1805Author: Oliver Kurth <okurth@vmware.com>
1829Date: Mon Feb 26 12:29:07 2018 -08001806Date: Tue Feb 19 12:51:32 2019 -0800
18301807
1831 Common header file change; not applicable to open-vm-tools.1808 Update copyright year to 2019 for OVT 10.3.10 files.
18321809
1833commit 4da56779c42a55ce1b872748f9d6fd90bd10d2811810commit 0c18ef48a57aeb73c7ac970336c3a7c199744de1
1834Author: Oliver Kurth <okurth@vmware.com>1811Author: Oliver Kurth <okurth@vmware.com>
1835Date: Mon Feb 26 12:29:07 2018 -08001812Date: Tue Feb 19 12:51:32 2019 -0800
18361813
1837 lib/file: Clean up POSIX File_GetSafeTempDir() in fileTempPosix.c1814 Back out the previous change to bump up the SYSIMAGE_VERSION to be the same
1838 1815 with VMTools version.
1839 Make things clearer.
18401816
1841commit f608f63948520ab2088870a800bcc62c67a416ab1817commit 8ae36f730d8a7460e5cc139019c8b583abf9677a
1842Author: Oliver Kurth <okurth@vmware.com>1818Author: Oliver Kurth <okurth@vmware.com>
1843Date: Mon Feb 26 12:29:07 2018 -08001819Date: Tue Feb 19 12:51:32 2019 -0800
18441820
1845 Common header file change; not applicable to open-vm-tools.1821 Back out the previous change to fix the missing IP aliases in the guest info.
18461822
1847commit 5d98c8b5183e236dc8fb548647574f4b24e87d231823commit b2976af2553c758cfd871b4d9b7593a92c867e9d
1848Author: Oliver Kurth <okurth@vmware.com>1824Author: Oliver Kurth <okurth@vmware.com>
1849Date: Mon Feb 26 12:29:07 2018 -08001825Date: Tue Feb 19 12:51:32 2019 -0800
18501826
1851 Common header file change; not applicable to open-vm-tools.1827 Bump up the SYSIMAGE_VERSION to be the same with VMTools version.
18521828
1853commit 65a35ec640223e4455e016c883261f514eb214921829commit e9512d13665b8d7f9bed2712b0a92a4ebc03f785
1854Author: Oliver Kurth <okurth@vmware.com>1830Author: Oliver Kurth <okurth@vmware.com>
1855Date: Mon Feb 26 12:29:06 2018 -08001831Date: Tue Feb 19 12:51:32 2019 -0800
18561832
1857 Common header file change; not applicable to open-vm-tools.1833 Common header file change not applicable to open-vm-tools.
18581834
1859commit aefcbec68487e14de8938fafbf0606a9ce37b2b91835commit 7f5a754e197ff4f1159f3d8c793de1fc8d3a19de
1860Author: Oliver Kurth <okurth@vmware.com>1836Author: Oliver Kurth <okurth@vmware.com>
1861Date: Mon Feb 26 12:29:06 2018 -08001837Date: Tue Feb 19 12:51:32 2019 -0800
18621838
1863 Skip davfs mount points during quiescing (part 2)1839 GuestOS: Improve the guest OS identification code
1864 1840
1865 Refactor the change to skip davfs mount points. Capture the length1841 Now that we often have an explicit, unambiguous version string for
1866 of the static URL prefixes at compile time and avoid repetitive1842 a distro, use it. In the rare case we don't have one, search the
1867 strlen() calls when checking each active mount point.1843 distro string for a digit and use that. If we can't find anything,
1844 note this and let the code fall into the default appropriate to the
1845 distro.
1846
1847 With this change, we stop using strings and so are no longer confused
1848 by things like "7.5". For a few of the distros, we now no longer care
1849 about the upper bound, we can report what we find. Anything above what
1850 the release supports will be fixed by the GuestMapper.
18681851
1869commit f459a325c4eec2e31eddc7f74901623b30ea05251852commit 50a8517abc36af4963c9c29b1127b7652829e410
1870Author: Oliver Kurth <okurth@vmware.com>1853Author: Oliver Kurth <okurth@vmware.com>
1871Date: Mon Feb 26 12:29:06 2018 -08001854Date: Tue Feb 19 12:51:32 2019 -0800
1872
1873 Skip davfs mount points during quiescing
1874
1875 The davfs2 is a Linux filesystem that allows mounting a Web Distributed
1876 Authoring and Versioning (WebDAV) network resource as a local filesystem.
1877 On some Linux releases, the FREEZE ioctl() is rejected and quiescing
1878 these filesystems is not attempted. On others, however, the FREEZE is
1879 not rejected and there exists the potential of a quiescing deadlock
1880 if the davfs2 attempts to write to its cache in /var which has already
1881 been quiesced.
1882
1883 This fix is to avoid a potential deadlock by excluding davfs2 mounts
1884 as the networking filesystem they are. Since davfs2 may be implemented
1885 on the Linux fuse (default) or coda filesystem kernel module,
1886 the detection of these network mounts must be based upon detection
1887 of the URL prefix of the mounted device name.
1888
1889 The static function SyncDriverIsRemoteFSType() is being updated to
1890 not only exclude remote filesystems based on filesystem type but also
1891 to exclude davfs2 remote filesystems by the "http://" or "https://"
1892 URL prefix on the device name. The function name is being changed
1893 to SyncDriverIsRemoteFS().
1894
1895commit 3af8139cfcb4578dd9d7cd9a85301ed808775eb4
1896Author: Oliver Kurth <okurth@vmware.com>
1897Date: Mon Feb 26 12:29:06 2018 -0800
18981855
1899 vm_basic_types.h: scrub FMTxx specifiers1856 Common header file change not applicable to open-vm-tools.
1900
1901 Reduce the amount of magic in vm_basic_types.h... nowadays, any
1902 system we support (including Tools) DEFINITELY supports C99-style
1903 specifiers, with two exceptions: pre-vs2015 MSVC, and pre-10.13
1904 macOS kernels.
1905
1906 Rip out all the pre-C99 junk. Add a few comments explaining exactly
1907 what the caveats here are.
19081857
1909commit 442683ac70f1f1c8665feb347be40cac5c8edd651858commit b6d001fd7b45c5b9414c5642503ad91a5ab279c8
1910Author: Oliver Kurth <okurth@vmware.com>1859Author: Oliver Kurth <okurth@vmware.com>
1911Date: Mon Feb 26 12:29:06 2018 -08001860Date: Tue Feb 19 12:51:32 2019 -0800
19121861
1913 amazonlinux2-64 should use OVT only, not tar tools linux.iso.1862 Common header file change not applicable to open-vm-tools.
19141863
1915commit b4e66d7ac1f29b4d81877741c0dc85b8eeb683651864commit dd38338c0bfe8a4778a29a53819e3b5aac683381
1916Author: Oliver Kurth <okurth@vmware.com>1865Author: Oliver Kurth <okurth@vmware.com>
1917Date: Mon Feb 26 12:29:06 2018 -08001866Date: Tue Feb 19 12:51:32 2019 -0800
19181867
1919 Common header file change; not applicable to open-vm-tools.1868 Fix the missing IP aliases in the guest info.
1869
1870 IP aliases were missing in the guest info when the libdnet is not used.
1871 ESX does not seem to support IP aliases, so the ESX code path is kept logically
1872 the same as before.
1873
1874 On Linux, for each IP entry, get the label name, and use ioctl to get its MAC.
1875 Use the MAC to match the current device MAC.
1876
1877 The getifaddrs() call ensures that the ifa_name is not NULL, so there is no
1878 need to check for NULL pointers.
19201879
1921commit 16e63100ba9aeb419d22d8ade3af1eda2e3f02c01880commit e689b1996788de4e8b9e3dd896a593dad4ca4520
1922Author: Oliver Kurth <okurth@vmware.com>1881Author: Oliver Kurth <okurth@vmware.com>
1923Date: Mon Feb 26 12:29:05 2018 -08001882Date: Tue Feb 19 12:51:31 2019 -0800
19241883
1925 Changes to common header files; not applicable to open-vm-tools.1884 Common header file change not applicable to open-vm-tools.
19261885
1927commit f5b05ca724708bd54b5c5b7dc3f9d0d9591347731886commit bda2908d861cbfae99119340d22c09aae99df51e
1928Author: Oliver Kurth <okurth@vmware.com>1887Author: Oliver Kurth <okurth@vmware.com>
1929Date: Mon Feb 26 12:29:05 2018 -08001888Date: Tue Feb 19 12:51:31 2019 -0800
19301889
1931 Common header file change; not applicable to open-vm-tools.1890 Include vmware/tools/log.h to define g_info.
1891
1892 A recent change added a call to g_info from syncManifest.c. This
1893 in turn is causing open-vm-tools builds to fail because g_info is
1894 not available on SLES 12sp1.
1895
1896 To fix the problem, include vmware/tools/log.h in syncManifest.c.
1897 log.h defines g_info as a macro.
19321898
1933commit 783e87e2a465d28db5233e7d1e284fa9410ffec41899commit eb1b69ce8a677025cde23c5913719c5103c6a186
1934Author: Oliver Kurth <okurth@vmware.com>1900Author: Oliver Kurth <okurth@vmware.com>
1935Date: Mon Feb 26 12:29:05 2018 -08001901Date: Tue Feb 19 12:51:31 2019 -0800
19361902
1937 Remove uses of header file safetime.h1903 Common header file change not directly applicable to open-vm-tools.
1938
1939 - (many places) replace "safetime.h" with <time.h> and/or <sys/stat.h>,
1940 occasionally re-ordering this header to top of file
1941 - (many places) remove "safetime.h" as no time functions are used
19421904
1943commit bf31e9478b99b5713f2c330e48d2e40c5091d3bc1905commit cf60bf56b021452e7a92c42a767156b2a64e1ac0
1944Author: Oliver Kurth <okurth@vmware.com>1906Author: Oliver Kurth <okurth@vmware.com>
1945Date: Mon Feb 26 12:29:04 2018 -08001907Date: Tue Feb 19 12:51:31 2019 -0800
19461908
1947 Common header file change; not applicable to open-vm-tools.1909 Back out the previous change to remove support for building with
1910 xml-security-c and xerces-c.
19481911
1949commit cbdbeef4b6c3454f58e9733079140edcc30fdb2a1912commit a9db8091cbc5286086ccddf7b78560f05fe90fb6
1950Author: Oliver Kurth <okurth@vmware.com>1913Author: Oliver Kurth <okurth@vmware.com>
1951Date: Mon Feb 26 12:29:03 2018 -08001914Date: Tue Feb 19 12:51:31 2019 -0800
19521915
1953 Remove GLIBC_VERSION_NN macros1916 Remove support for building with xml-security-c and xerces-c
1954 1917
1955 No existing usages. Astute observers will note we currently1918 Remove support for building VMTools with xml-security-c. Since
1956 use glibc-2.5 minimum (so all but one of these macros are ALWAYS1919 xml-security-c is the only requirement for xerces-c, xerces-c
1957 defined).1920 is dropped as well.
1921
1922 There is also some cleanup of the handling of some configure
1923 options related to vgauth, ssl, xmlsec1, and xml2.
19581924
1959commit eec6e2798def2e9ff6da5e73b092cfe92e60b7631925commit 3a023fad437c1ee576c4e9802f94f208243a9bb8
1960Author: Oliver Kurth <okurth@vmware.com>1926Author: Oliver Kurth <okurth@vmware.com>
1961Date: Wed Feb 7 16:39:26 2018 -08001927Date: Tue Feb 19 12:51:31 2019 -0800
19621928
1963 Common header file change not applicable to open-vm-tools.1929 Common header file change not applicable to open-vm-tools.
19641930
1965commit 5170db44c1c7b814d0d2bd4131e1895dbd999db71931commit 8a60e9573885f1ef339cf1bfc19cfb7bc1912122
1966Author: Oliver Kurth <okurth@vmware.com>1932Author: Oliver Kurth <okurth@vmware.com>
1967Date: Wed Feb 7 16:39:26 2018 -08001933Date: Tue Feb 19 12:51:31 2019 -0800
19681934
1969 Use a unique random temp directory for vmtoolsd on Linux.1935 Always send VMBACKUP_EVENT_GENERIC_MANIFEST during quiesced snapshots.
1970 1936
1971 The temporay directory currently used by vmtoolsd and its plugins1937 vSphere 6.7 added a host-side interface that allows VMTools to send
1972 on Linux is of the form /tmp/vmware-<user>. Since it is used to1938 a "generic" backup manifest during a quiesced snapshot on Linux guests.
1973 upload VMware Tools upgrade and GOS customization scripts and commands,1939 VMTools 10.2.0 or later tries to notify the host of the backup manifest
1974 that name predictability may make it susceptible to attack. This1940 file through a vmbackup event message VMBACKUP_EVENT_GENERIC_MANIFEST.
1975 change adds a new function File_GetSafeRandomTmpDir() in1941 If the host is unable to field the message, then VMTools logs the
1976 bora/lib/file/fileTempPosix.c to both add the PID to the user name1942 failure and then continues with the quiesced snapshot in the older
1977 and add a random number suffix to the temp directory path.1943 fashion, without the backup manifest.
1978 1944
1979 /tmp/vmware-<user>_<pid>-nnnnnn1945 An earlier change attempted to reduce the amount of logging done when
1946 running on older hosts that don't support VMBACKUP_EVENT_GENERIC_MANIFEST
1947 by detecting when sending VMBACKUP_EVENT_GENERIC_MANIFEST fails and
1948 not sending the message again for subsequent quiesced snapshots.
1949 However, subsequent stress testing has uncovered problems with this
1950 approach when running on newer hosts; specifically, errors may sometimes
1951 be encountered on newer hosts when sending VMBACKUP_EVENT_GENERIC_MANIFEST.
1952 Therefore this change backs out that earlier change.
1980 1953
1981 VMware Tools commands and plugins are being updated to use this random1954 Note that the need to solve the problem that that earlier change was
1982 temp directory.1955 intended to solve has been reduced because support for
1956 VMBACKUP_EVENT_GENERIC_MANIFEST has been backported to vSphere 6.5
1957 P03, which is available, and vSphere 6.0 P08, which is scheduled for
1958 release later this year. ESXi 5.5 is out of general support.
1959
1960 This change also addresses an issue that surfaced when testing on a
1961 host without support for VMBACKUP_EVENT_GENERIC_MANIFEST.
1962 If VMTools fails to send VMBACKUP_EVENT_GENERIC_MANIFEST, the quiesced
1963 snapshot operation will be aborted rather than continuing as it should.
1964 To address this, create a new function, VmBackup_SendEventNoAbort,
1965 which does not abort the quiesced snapshot on failure, and call that
1966 function rather than VmBackup_SendEvent when sending
1967 VMBACKUP_EVENT_GENERIC_MANIFEST.
19831968
1984commit 9bc56af5d0cb7dcc6f079ff4ab4d3456535365b21969commit 1b7769909f3269f681e530acc413201c8d6facf0
1985Author: Oliver Kurth <okurth@vmware.com>1970Author: Oliver Kurth <okurth@vmware.com>
1986Date: Wed Feb 7 16:39:26 2018 -08001971Date: Tue Feb 19 12:51:31 2019 -0800
19871972
1988 Changes to common header files not applicable to open-vm-tools.1973 Common header file change not applicable to open-vm-tools.
19891974
1990commit 3e4091698461c0a5c36f9025410941f189c5af691975commit 480dd20016ed0517b31b78735d50ee3630790e07
1991Author: Oliver Kurth <okurth@vmware.com>1976Author: Oliver Kurth <okurth@vmware.com>
1992Date: Wed Feb 7 16:39:26 2018 -08001977Date: Tue Feb 19 12:51:31 2019 -0800
19931978
1994 Fix two comment typos in hostinfoPosix.c.1979 Add disk UUID to GuestDiskInfo
1980
1981 Add UUID/Serial number to the GuestDiskInfo.
19951982
1996commit cf4f582e5b3c2df25aa775d77d458a15583a05ad1983commit 119c9df55c2265460fc7eb6fad5d87226435e276
1997Author: Oliver Kurth <okurth@vmware.com>1984Author: Oliver Kurth <okurth@vmware.com>
1998Date: Wed Feb 7 16:39:26 2018 -08001985Date: Tue Feb 19 12:51:31 2019 -0800
19991986
2000 open-vm-tools: ignore with/without gtk2/3 options when building without X1987 Linux DeployPkg should provide a configurable timeout for the spanning
1988 customization process. Right now it is hard-coded to 100 seconds.
2001 1989
2002 When building without X support, we should ignore the options to enable/disable1990 Sources to provide "timeout" value:
2003 gtk2 and gtk3. This was reported in gthub issue1991 1. Clients such as vCenter and SRM can pack timeout value in cab header
2004 https://github.com/vmware/open-vm-tools/issues/228 .1992 via API func "DeployPkg_SetProcessTimeout(uint16 timeout)". this timeout
1993 value will be implemented during the package deployment process.
1994 2. Package deployment engines:
1995 - tools deployPkg plugin:
1996 Add "process-timeout" in tools.conf. The tools deployPkg plugin will use
1997 that value to control the time period of the package deployment.
1998 - linuxDeployPkg:
1999 Add "-t <timeout>" as optional argument in linuxDeployPkg
2000 Usage: ./linuxDeployPkg -d <cabfile> -t <timeout> --skip-reboot
2001 3. Default value in deployPkg is 100s. If both the client and package
2002 deployment engines don't provid this value, then the default value of
2003 100s will be used.
2004 4. The "timeout" value from clients will overwrite the value from the
2005 deployment engines when both of them provid this value.
20052006
2006commit 0a099c6f4949a05d1400dc147ab68ad15ebf152a2007commit fde5e1e4fade4bc3672a94cbae7b20d063057540
2007Author: Oliver Kurth <okurth@vmware.com>2008Author: Oliver Kurth <okurth@vmware.com>
2008Date: Wed Feb 7 16:39:26 2018 -08002009Date: Tue Feb 19 12:51:31 2019 -0800
20092010
2010 Common header file change not applicable to open-vm-tools.2011 Common header file change not applicable to open-vm-tools.
20112012
2012commit 7be0019e01c7d473deffb8b8646fce1dff22e11a2013commit ee25e6a05996b9beda0c07361d44d4e30fdbe3f2
2013Author: Oliver Kurth <okurth@vmware.com>2014Author: Oliver Kurth <okurth@vmware.com>
2014Date: Wed Feb 7 16:39:25 2018 -08002015Date: Tue Feb 19 12:51:31 2019 -0800
20152016
2016 Common header file changes not applicable to open-vm-tools.2017 Common header file change not applicable to open-vm-tools.
20172018
2018commit f838807d08b9c4e72d4887642d4181dea25b6c352019commit 4caacb6a4fba771d2d416505ec3c3014fac3cb82
2019Author: Oliver Kurth <okurth@vmware.com>2020Author: Oliver Kurth <okurth@vmware.com>
2020Date: Wed Feb 7 16:39:25 2018 -08002021Date: Tue Feb 19 12:51:31 2019 -0800
20212022
2022 Common header file change not applicable to open-vm-tools.2023 Common source file changes not directly applicable to open-vm-tools.
20232024
2024commit 25d00050c8009dd74e3bbcf1883fdd408411a6932025commit c8fa72b1b3e3f0ecf725faf77cc747d804dc0ae1
2025Author: Oliver Kurth <okurth@vmware.com>2026Author: Oliver Kurth <okurth@vmware.com>
2026Date: Wed Feb 7 16:39:25 2018 -08002027Date: Tue Feb 19 12:51:31 2019 -0800
20272028
2028 Common header file change not applicable to open-vm-tools.2029 Common header file change not directly applicable to open-vm-tools.
20292030
2030commit 6b6038522ed24ea134eb4e4a2752288f6f42fcd52031commit 7d4ddf5c1a1160720f89f1a7f79fdb2f98b9b49b
2031Author: Oliver Kurth <okurth@vmware.com>2032Author: Oliver Kurth <okurth@vmware.com>
2032Date: Wed Feb 7 16:39:25 2018 -08002033Date: Tue Feb 19 12:51:30 2019 -0800
20332034
2034 Header file change not applicable to open-vm-tools.2035 Common header file change not applicable to open-vm-toold.
20352036
2036commit ee4bd450c4449f8905dbca2e4759660fda5c58dc2037commit 799401f69d0ee47d475b201254a2fa65bdfe7b81
2037Author: Oliver Kurth <okurth@vmware.com>2038Author: Oliver Kurth <okurth@vmware.com>
2038Date: Tue Feb 6 16:32:40 2018 -08002039Date: Tue Feb 19 12:51:30 2019 -0800
20392040
2040 fix buffer overrun in AsyncTCPSocketConnect()2041 Common header file change not directly applicable to open-vm-tools.
2041
2042 Callers may pass a struct smaller than sockaddr_storage, but a
2043 sockaddr_storage-sized chunk gets copied to asock->remoteAddr.
2044 memcpy() should be used.
2045
2046 One such caller is AsyncSocket_ConnectUnixDomain(). It passes sockaddr_un.
2047 sizeof(sockaddr_un) == 110, sizeof(sockaddr_storage) == 128.
2048
2049 Caught by AddressSanitizer.
20502042
2051commit 13df0e2fc2f68aeab0380761eb0c5ab1297307102043commit 69dc92cfb5397399385e7fa67bab3ef685d51c3e
2052Author: Oliver Kurth <okurth@vmware.com>2044Author: Oliver Kurth <okurth@vmware.com>
2053Date: Tue Feb 6 16:32:40 2018 -08002045Date: Tue Feb 19 12:51:30 2019 -0800
20542046
2055 open-vm-tools: use pkg-config for building with icu2047 Use the LSB and os-release data to find the best guest identification
2056 2048
2057 icu uses pkg-config in recent versions, and no longer ships with2049 Historically, we have the LSB to describe a Linux distro. More
2058 icu-config in most recent versions. Make the configure script2050 recently, the os-release standard was added. Change our guest
2059 use pkg-config for icu if available, and icu-config if not. For2051 identification code to attempt to use both data - when available - and
2060 pkg-config we need to specify 'icui18n' which returns the same result2052 make a value judgement as to which is better.
2061 as icu-config did to link with icui18n.
20622053
2063commit 3a8221c7e4b149efacf87658ac239d815c56adba2054commit 7c4d548c5f6dfc3a0d24e11bf53c834487df9067
2064Author: Oliver Kurth <okurth@vmware.com>2055Author: Oliver Kurth <okurth@vmware.com>
2065Date: Tue Feb 6 16:32:40 2018 -08002056Date: Tue Feb 19 12:51:30 2019 -0800
20662057
2067 Ignore ENXIO errors with SyncDriver2058 Send diskInfo as a json document. Modernize diskInfo RPC.
2059
2060commit 6143662e1b1e89671c4b4812bdbed76d12cff14e
2061Author: Oliver Kurth <okurth@vmware.com>
2062Date: Tue Feb 19 12:51:30 2019 -0800
2063
2064 [Part 2] GuestLib support for 64bit memory shares.
2068 2065
2069 A quiesced snapshot fails when the target VM has a bind mount. The2066 MEMSCHED_SHARES_MAX is currently set to MAX_PPN and will not fit in
2070 problem is that the syncDriver gets an ENXIO error when it tries to2067 32-bit soon. 'memshares' property which is currently available in GuestSDK
2071 open the mount point. To fix the problem, let the quiesce operation2068 is an unsigned 32bit value. Starting from ESX 7.0, this value is available
2072 skip a mount point when opening it results in an ENXIO error.2069 only if it can be fit in an unsigned 32-bit data type.
2073 2070
2074 This change is based on pull request2071 'memShares64' is the new unsigned 64-bit property added in GuestSDK for the
2075 https://github.com/vmware/open-vm-tools/pull/218 .2072 memory shares.
2073
2074 Added necessary APIs to retrieve the memshares64 value. The new API
2075 VMGuestLib_GetMemShares64 will first try to retrieve the memShares64 property.
2076 If the underlying host is an older one, then the API will return the memShares
2077 property.
2078
2079 Updated the vmGuestLibTest code to retrieve and print the new memShares64 value.
20762080
2077commit ff754c8a99bffe92b07c933898c7d9d20c02873f2081commit b1f9a9656e20d4e6f1cb74bc07b75d936346d96a
2078Author: Oliver Kurth <okurth@vmware.com>2082Author: Oliver Kurth <okurth@vmware.com>
2079Date: Tue Feb 6 16:32:40 2018 -08002083Date: Tue Feb 19 12:51:30 2019 -0800
20802084
2081 Refinement for memory corruption bug fix in StdIO_ReadNextLine2085 Common header file change not applicable to open-vm-tools.
20822086
2083commit 7b45a62730624c711fb4eb63a0bfd125a2befa572087commit e639a33061a85ec70aded35429b9d634de17ac74
2084Author: Oliver Kurth <okurth@vmware.com>2088Author: Oliver Kurth <okurth@vmware.com>
2085Date: Tue Feb 6 16:32:40 2018 -08002089Date: Tue Feb 19 12:51:30 2019 -0800
20862090
2087 lib/file: Style clean up in the public file.h2091 Update seamless window's copyright year as 1998-2019
2092
2093 1. Changing the COPYRIGHT_YEARS in vm_legal.h to 1998-2019
2094 2. COPYRIGHT_YEARS is used by UTF8_COPYRIGHT_STRING_BASE and
2095 UTF16_COPYRIGHT_STRING for win32 UTF-16 version.
20882096
2089commit 3a7dc2f92e6cb61c9ca8e57c367c9726833552782097commit 5260d3b532c436d2b3be825876359f9c6682578d
2090Author: Oliver Kurth <okurth@vmware.com>2098Author: Oliver Kurth <okurth@vmware.com>
2091Date: Tue Feb 6 16:32:40 2018 -08002099Date: Tue Feb 19 12:51:30 2019 -0800
20922100
2093 Common header file changes not applicable to open-vm-tools.2101 Common header file change not applicable to open-vm-tools.
20942102
2095commit c52bb302a181d4bdd0b2b61d6e901339b61d2dab2103commit bf62073f69e496a83529e6acf3b33300a50ad991
2096Author: Oliver Kurth <okurth@vmware.com>2104Author: Oliver Kurth <okurth@vmware.com>
2097Date: Tue Feb 6 16:32:40 2018 -08002105Date: Tue Feb 19 12:51:30 2019 -0800
20982106
2099 Common header file change not applicable to open-vm-tools.2107 Common header file change not directly applicable to open-vm-tools.
21002108
2101commit 035765d487f8ab9b2222ad239b278e4725aa5a222109commit 8c2911145026ddc7bd1fdfab97e1af3fefab5dae
2102Author: Oliver Kurth <okurth@vmware.com>2110Author: Oliver Kurth <okurth@vmware.com>
2103Date: Tue Feb 6 16:32:39 2018 -08002111Date: Tue Feb 19 12:51:30 2019 -0800
21042112
2105 Changes to common header files; not applicable to open-vm-tools.2113 Common header file change not directly applicable to open-vm-tools.
21062114
2107commit 3011466e0f59471292a58ba5124238898d18945a2115commit 070ef6fd44b6a0095ec51faebf2e0c5c0151efb7
2108Author: Oliver Kurth <okurth@vmware.com>2116Author: Oliver Kurth <okurth@vmware.com>
2109Date: Tue Feb 6 16:32:39 2018 -08002117Date: Tue Feb 19 12:51:30 2019 -0800
21102118
2111 open-vm-tools: use ENV{DEVTYPE}=="disk" in udev scsi rule2119 [Part 1] GuestLib support for 64bit memory shares.
2112 2120
2113 Fix udev scsi rule to not print warnings on boot.2121 MEMSCHED_SHARES_MAX is currently set to MAX_PPN and will not fit in 32-bit soon.
2114 The rule now checks for the device type. The previous fix by2122
2115 trying to check for a valid timeout field did not work as expected.2123 Changed the datatype of 'memshares' property to uint64 for the future support.
2116 This change uses the rule from Mike Latimer at2124
2117 https://github.com/vmware/open-vm-tools/pull/2162125 'memshares' is exposed in GuestLib as unsigned 32-bit value.
2126 Modified the ESX code to set this property only if the vaulue can be fit in
2127 a uint32 type. Else, the value is not set and 'valid' bit set is set to FALSE.
2128
2129 Added a new property "memShares64" (as uint64) in GuestLib for the new
2130 64-bit memory shares.
2131
2132 This CLN implements only the necessary changes on ESX side.
21182133
2119commit 9da6562e0c04fa79fad726513508a628f29f48122134commit f14ba86d12e158c2ad1bac2d41082054d2154127
2120Author: Oliver Kurth <okurth@vmware.com>2135Author: Oliver Kurth <okurth@vmware.com>
2121Date: Tue Feb 6 16:32:39 2018 -08002136Date: Tue Feb 19 12:51:30 2019 -0800
21222137
2123 Common header file change not applicable to open-vm-tools.2138 Changes to common header files not applicable to open-vm-tools.
21242139
2125commit 6ccc073a58e1822dc4eb8c20e10dc89791643e9c2140commit c9cf0614fdb1dd9bbea572f37c1543d8852c7f37
2126Author: Oliver Kurth <okurth@vmware.com>2141Author: Oliver Kurth <okurth@vmware.com>
2127Date: Tue Feb 6 16:32:39 2018 -08002142Date: Tue Feb 19 12:51:30 2019 -0800
21282143
2129 Fix memory corruption bug in StdIO_ReadNextLine2144 Common header file change not applicable to open-vm-tools.
21302145
2131commit 4f729b61b908c82318b8dcfc16264c15b58817c82146commit ba975b71a38b96f19f06ed2dc6dd37acd421e99e
2132Author: Oliver Kurth <okurth@vmware.com>2147Author: Oliver Kurth <okurth@vmware.com>
2133Date: Tue Feb 6 16:32:39 2018 -08002148Date: Tue Feb 19 12:51:30 2019 -0800
21342149
2135 Common header file changes not applicable to open-vm-tools.2150 [Asyncsocket] Avoid ASSERT failure when removing recv callback if fd has POLL_FLAG_ACCEPT_INVALID_FDS flag set.
21362151
2137commit 9fa726051f7efe1b7e0bab745b7bad85d1fb3efb2152commit ec4e32afe179db8cf514177b08d9ab69696a2450
2138Author: Oliver Kurth <okurth@vmware.com>2153Author: Oliver Kurth <okurth@vmware.com>
2139Date: Tue Feb 6 16:32:39 2018 -08002154Date: Tue Feb 19 12:51:29 2019 -0800
21402155
2141 Common header file changes not applicable to open-vm-tools.2156 Security issue with the intermediate staging directory used for DnD and CnP
2157
2158 Problem:
2159 /tmp/VMwareDnD is a staging directory used for DnD and CnP. It should be
2160 a regular directory, but malicious code or user may create the /tmp/VMwareDnD
2161 as a symbolic link which points to the home directory of the current desktop
2162 user before the staging directory is created. Later when the desktop user
2163 initiates a DnD or CnP operation, the permission of that user's home directory
2164 will be changed allowing the malicious user full access to the desktop user's
2165 home directory.
2166
2167 Solution:
2168 Do not set the permission of the staging directory if that directory already
2169 exists and has the wrong permission. The permission of the directory will
2170 be 1777 if it is created by VMTools. If that is not the case, the directory
2171 has been created or modified by malicious code or user; just cancel the host
2172 to guest DnD or CnP operation.
21422173
2143commit 378c193d4a57cfed14045ffed6ea641957ed18c72174commit 1a39495618c1573c0fb16dd15368d0f2e606372c
2144Author: Oliver Kurth <okurth@vmware.com>2175Author: Oliver Kurth <okurth@vmware.com>
2145Date: Tue Feb 6 16:32:39 2018 -08002176Date: Wed Jan 16 14:53:06 2019 -0800
21462177
2147 Common header file change not applicable to open-vm-tools.2178 Common header file change not applicable to open-vm-tools.
21482179
2149commit ba83dcff6214190f8ed545401f2bfa27650bbf072180commit 4b9d0560bbeb50a395ffcfa7f1114d0c0246f207
2150Author: Oliver Kurth <okurth@vmware.com>2181Author: Oliver Kurth <okurth@vmware.com>
2151Date: Tue Feb 6 16:32:39 2018 -08002182Date: Wed Jan 16 14:53:06 2019 -0800
21522183
2153 Common header file change not directly applicable to open-vm-tools.2184 Add WarningToHost() and WarningToGuest() functions
2185
2186 This change is needed to address the privacy and security changes that
2187 are required so that vmware library warnings can be forwarded to the
2188 host side selectively.
2189
2190 For instance, if a warning message is sent to VMX, the user name must be
2191 stripped from the message.
21542192
2155commit fc922804318de417578fd08fab2e07c1d58e8de82193commit f16f911678e8075ba8422de3f2b70de9a7859974
2156Author: Oliver Kurth <okurth@vmware.com>2194Author: Oliver Kurth <okurth@vmware.com>
2157Date: Tue Feb 6 16:32:39 2018 -08002195Date: Wed Jan 16 14:53:05 2019 -0800
21582196
2159 Update copyright year to 2018.2197 Fix CONSTANT_EXPRESSION_RESULT in TimeUtil_StringToDate().
2198
2199 Red Hat ran coverity scan on open-vm-tools and found an occurrence
2200 of CONSTANT_EXPRESSION_RESULT in TimeUtil_StringToDate().
21602201
2161commit ca39511ceb8e88254cad71e98cba5cbfff08a99d2202commit 96da61e5aba3f97907477734b0a830a1338cd48b
2162Author: Oliver Kurth <okurth@vmware.com>2203Author: Oliver Kurth <okurth@vmware.com>
2163Date: Tue Feb 6 16:32:39 2018 -08002204Date: Wed Jan 16 14:53:05 2019 -0800
21642205
2165 UUID: Clean up UUID_PackText2206 [10.3.10] Update copyright year to 2019.
2166 2207
2167 Use size_t, not int.2208 Update the copyright year to 2019 for ALL open-vm-tools destined files
2209 modified since the release of 10.3.5.
21682210
2169commit c358e5e181b95d872da9ffcc943cc147ae0584f82211commit 3f5711d996598a625252cdcc77404fbb09cbb3d0
2170Author: Oliver Kurth <okurth@vmware.com>2212Author: Oliver Kurth <okurth@vmware.com>
2171Date: Tue Feb 6 16:32:39 2018 -08002213Date: Wed Jan 16 14:53:05 2019 -0800
21722214
2173 Changes to common header files; not applicable to open-vm-tools.2215 Bail out of vmtoolsd early when there are RPC errors.
2216
2217 VMX state machine could give up quiescing operation for various
2218 reasons when vmtoolsd is busy performing necessary state transitions.
2219 Once VMX gives up quiescing operation, there is no point in
2220 vmtoolsd continuing with it. vmtoolsd should also give up the
2221 operation asap. The vmtoolsd process can detect VMX state machine
2222 change when it gets errors sending VMBACKUP_PROTOCOL_EVENT_SET RPC.
2223
2224 RPC errors are only used as a trigger to abort the operation.
2225 We ignore the RPC errors that might occur after aborting the
2226 operation.
21742227
2175commit 0ccc8b1a79bf76b9826c37b2133e5dbd4b9904dc2228commit f2d053bb4b7fca870ed3e4aacc26fdd92907d008
2176Author: Oliver Kurth <okurth@vmware.com>2229Author: Oliver Kurth <okurth@vmware.com>
2177Date: Tue Feb 6 16:32:38 2018 -08002230Date: Wed Jan 16 14:53:05 2019 -0800
21782231
2179 Common header file change not applicable to open-vm-tools.2232 Don't send a backup manifest when aborting a Linux quiesced snapshot.
2233
2234 When taking a Linux quiesced snapshot, communication failures between
2235 VMX and VMTools may result in VMTools sending a genericManifest event
2236 message after the quiesced snapshot operation has been aborted. If
2237 this happens, VMX will send an error back to VMTools, which in turn
2238 causes VMTools not to send genericManifest messages on subsequent
2239 quiesced snapshots even if the host supports such messages.
2240
2241 One aspect of the implementation that gives rise to this behavior is
2242 the use of the sync provider's snapshotDone function to undo a
2243 quiescing operation. Specifically, if VMTools aborts a quiesced
2244 snapshot when the file system is quiesced, the quiescing must be
2245 undone. Currently, this is handled by calling the sync provider's
2246 snapshotDone function. This is the same function that is called to
2247 complete the quiescing snapshot protocol when it is successful. In
2248 some respects this makes sense, since in either case snapshotDone
2249 unquiesces the file system. However, architecturally and conceptually,
2250 it seems useful to distinguish between the action to be taken in the
2251 successful case versus the aborting case. It's also useful to do so
2252 in practice, because the successful case sends the genericManifest
2253 event to notify the host there is a backup manifest file, while the
2254 aborting case should not do that.
2255
2256 To address the issue, add an "undo" function for the Linux sync
2257 provider. The undo function is called instead of snapshotDone as
2258 part of aborting a quiesced snapshot in which the file system is
2259 quiesced at the time of the abort.
21802260
2181commit 5c6f7b09d6865496036653360301092b8672675f2261commit d2386efc9b8d66e44b87d21db71fb1fc39cf00f1
2182Author: Oliver Kurth <okurth@vmware.com>2262Author: Oliver Kurth <okurth@vmware.com>
2183Date: Tue Feb 6 16:32:38 2018 -08002263Date: Wed Jan 16 14:53:04 2019 -0800
21842264
2185 guestOS identification: Tweak handling the LSB2265 Common header file change not applicable to open-vm-tools.
2186
2187 The multi-standard handing code dealt with the LSB strictly. This
2188 causes some issues with older distros that are not LSB compliant but
2189 happened to work due to a specific behavior.
2190
2191 Return the LSB to "LSB and old way" and provide some specific coverage
2192 of detaults to ensure coverage.
21932266
2194commit 2516f528e47722faa38868d99939c825f13c2bdb2267commit 7c7371304783928cbd8fafeae682de46a1e64b4f
2195Author: Oliver Kurth <okurth@vmware.com>2268Author: Oliver Kurth <okurth@vmware.com>
2196Date: Tue Feb 6 16:32:38 2018 -08002269Date: Wed Jan 16 14:53:04 2019 -0800
21972270
2198 Restore "ufs" to the list of known filesystems2271 Common source file change not applilcable to open-vm-tools.
2199
2200 Removing extraneous #ifdef VMX86_TOOLS - #endif
22012272
2202commit 3c453912325ead3f19b84fced65217608069ddfa2273commit 0ab701192d0f5cdbb38525b1cd507bc56962651d
2203Author: Oliver Kurth <okurth@vmware.com>2274Author: Oliver Kurth <okurth@vmware.com>
2204Date: Tue Feb 6 16:32:38 2018 -08002275Date: Wed Jan 16 14:53:04 2019 -0800
22052276
2206 Restore "ufs" to the list of known filesystems2277 Common source file change not directly applicable to open-vm-tools.
2207
2208 A previous change, 5074636, to remove "ufs" from the kernel also removed
2209 "ufs" from the known list of Linux filesystems. As a result, the "ufs"
2210 filesystems on FreeBSD and Solaris VMs cannot be seen and therefore
2211 no disk information is available in vmsvc/get.guest output.
22122278
2213commit aa6502a057aec571a72b971cb13cf0e9d713cddc2279commit 5e957b0af978d7ba5106c1ae6a4e98e39cedd01c
2214Author: Oliver Kurth <okurth@vmware.com>2280Author: Oliver Kurth <okurth@vmware.com>
2215Date: Tue Feb 6 16:32:38 2018 -08002281Date: Wed Jan 16 14:53:04 2019 -0800
22162282
2217 Update tools copyright to 20182283 Common header file change not applicable to open-vm-tools.
22182284
2219commit 5af33281a66ebf0c30ad15074f931f33bda0bc9d2285commit 6af2b0bb4ba3d77d94cf61643803282198c7c68e
2220Author: Oliver Kurth <okurth@vmware.com>2286Author: Oliver Kurth <okurth@vmware.com>
2221Date: Tue Feb 6 16:32:38 2018 -08002287Date: Wed Jan 16 14:53:04 2019 -0800
22222288
2223 Common header file change not applicable to open-vm-tools.2289 Common header file change not applicable to open-vm-tools.
22242290
2225commit dc028e7bbb63865e1ae1c6262872e74c47c80d612291commit eed75f0ab178cceeabb761661cecaf636b595bdb
2226Author: Oliver Kurth <okurth@vmware.com>2292Author: Oliver Kurth <okurth@vmware.com>
2227Date: Tue Feb 6 16:32:38 2018 -08002293Date: Wed Jan 16 14:53:04 2019 -0800
22282294
2229 Common header file change that is not applicable to open-vm-tools.2295 Common header file change not applicable to open-vm-tools
22302296
2231commit d55cc529267b0b385fc9d4453075d023c789e46f2297commit 87d1ca65dc4f0d0fa53a2fb5e1411c104aaa84d3
2232Author: Oliver Kurth <okurth@vmware.com>2298Author: Oliver Kurth <okurth@vmware.com>
2233Date: Tue Feb 6 16:32:38 2018 -08002299Date: Wed Jan 16 14:53:04 2019 -0800
22342300
2235 Hgfs Server: replace duplicate function usage with a common function.2301 Common header file change not applicable to open-vm-tools.
2236
2237 This change simply replaces a duplicate function usage with a common
2238 function and removes the duplicate one.
22392302
2240commit ccdef7096a4782dd00b6f55695aff9c3f01cf4b52303commit 51dd95f05655e6d6c84aa0622cb48aeaf2880180
2241Author: Oliver Kurth <okurth@vmware.com>2304Author: Oliver Kurth <okurth@vmware.com>
2242Date: Tue Feb 6 16:32:38 2018 -08002305Date: Wed Jan 16 14:53:04 2019 -0800
22432306
2244 hostinfoPosix.c: Change a warning to a log message.2307 Record VMware Tools version 10.3.7 used for a patch.
22452308
2246commit 2321ff31fa671658ad0af3af22eef27e5d9af0502309commit 01d4d19cc0f638ef119fb0b23801c66acd634920
2247Author: Oliver Kurth <okurth@vmware.com>2310Author: Oliver Kurth <okurth@vmware.com>
2248Date: Tue Feb 6 16:32:38 2018 -08002311Date: Wed Jan 16 14:53:04 2019 -0800
22492312
2250 Switch IMC to use RpcChannel_SendOne instead of deprecated RpcOut_sendOne2313 Common header file change not applicable to open-vm-tools.
2251
2252 Modify ./libDeployPkg/Makefile.am to build deploypkg module for
2253 open-vm-tools correctlly.
22542314
2255commit d9f7c825cfbe075c3b643632419ff26a72628e412315commit e57c49e1a8504620acc87d5d64304d76c5cab804
2256Author: Oliver Kurth <okurth@vmware.com>2316Author: Oliver Kurth <okurth@vmware.com>
2257Date: Tue Feb 6 16:32:38 2018 -08002317Date: Wed Jan 16 14:53:04 2019 -0800
22582318
2259 lib/file: Clean up a few things.2319 Modernize diskInfo RPC
2320
2321 Rewrite diskInfo RPC to allow it to be backwards and forwards compatible.
2322 step 1 -- re-org existing code.
22602323
2261commit b4ee6678c9dd8cdf4e144056545dd41ba06360852324commit 94ba58e23bda8f2cc74041c3c9cd2e8365a1b431
2262Author: Oliver Kurth <okurth@vmware.com>2325Author: Oliver Kurth <okurth@vmware.com>
2263Date: Tue Feb 6 16:32:37 2018 -08002326Date: Wed Jan 16 14:53:04 2019 -0800
22642327
2265 hostinfoPosix.c: Pick up some review comments2328 Common header file change not applicable to open-vm-tools.
22662329
2267commit ce060ca498defdf08da4fac899dc623328d47a5d2330commit c2a852b98c01b61b0a73be2aaa77ca334e44e902
2268Author: Oliver Kurth <okurth@vmware.com>2331Author: Oliver Kurth <okurth@vmware.com>
2269Date: Tue Feb 6 16:32:37 2018 -08002332Date: Wed Jan 16 14:53:04 2019 -0800
22702333
2271 GuestOS: Support the os-release standard2334 Special-case profile loading for StartProgram
2272
2273 While bringing up Amazon Linux as a guest, it was discovered that
2274 Amazon Linux was not LSB compilant. The LSB standard defines a way
2275 to uniquely determine which distro one is running on. Since our code
2276 was based on the LSB standard, we made some changes to explicitly
2277 detect Amazon Linux and handle it as a special case.
2278
2279 Amazon let us know that there is a "new" standard - os-release - which
2280 they are compliant with. One must explicitly install Amazon Linux in a
2281 special way to obtain the LSB compliance.
2282
2283 Researching the "new" standard, it turned out to not be that different
2284 than the LSB standard. Further research showed that some distros (e.g.
2285 Ubuntu) are releasing with both standards.
2286 2335
2287 This change refactors the existing code, removes the explicit Amazon2336 Keep the user's profile loaded for the life of the
2288 Linux checking, and accepts the os-release standard. Amazon Linux then2337 program, to avoid races where its unloaded too quickly.
2289 "just falls out".
22902338
2291commit 6bd88d82e943d691c4312e3f2e7cef1038af7a9c2339commit 68e81d11ead52350a6be0ab383a65d2b11884345
2292Author: Oliver Kurth <okurth@vmware.com>2340Author: Oliver Kurth <okurth@vmware.com>
2293Date: Tue Feb 6 16:32:37 2018 -08002341Date: Wed Jan 16 14:53:03 2019 -0800
22942342
2295 Reduce Vigor transport socket draining overhead2343 Switch some stringxx headers to use angle brackets instead of double quotes
2296
2297 A previous change in VigorPollImpl and asyncsocket to fix a memory
2298 leak that causes a performance regression for parallel reconfiguration of
2299 running VMs (the kind requiring FSR). During an FSR, the connection
2300 between hostd and the source vmx would drop and hostd would then
2301 reconnect to the destination vmx. One source of regression is that
2302 the buffer has to be drained when a disconnect happens and the draining
2303 logic may potentially unregister and re-register the recv callback
2304 multiple times. This change adds an asyncsocket function specifically
2305 for draining recv that reduces the manipulation of callback. It
2306 reduces the regression by up to ~50% (the effect is more pronounced with
2307 more VMs).
23082344
2309commit de9b602664d91c54288b91a81f6a01d7cb927fce2345commit ff766a3e0dae726cf1d171a150633d9e995f2c08
2310Author: Oliver Kurth <okurth@vmware.com>2346Author: Oliver Kurth <okurth@vmware.com>
2311Date: Tue Feb 6 16:32:37 2018 -08002347Date: Wed Jan 16 14:53:03 2019 -0800
23122348
2313 atomic: add TestSetBitVector and TestClearBitVector functions2349 Code clean-up - bora-vmsoft/lib/procMgr/procMgrPosix.c
2314 2350
2315 Implement atomic set/clear bit from a byte array.2351 Recent discussions about setting "errno" to ENOENT when either
2352 getpwuid_r() or getpwnam_r() return 0 (success) if there is no passwd
2353 entry for the user have vacillated.
2316 2354
2317 Also add missing "memory" constraint to non-atomic ClearBitVector()2355 Since none of the current callers of the routines in procMgrPosix.c
2318 and ComplementBitVector().2356 query the contents of "errno", the current consensus is to simply log
2357 a warning message along with reason for the failure.
23192358
2320commit 17e9209aeb4f6d3a3535b7064916f3a25b9853952359commit b2e0ca7c6a8a9fd7ad33cbc950f63c14ab205718
2321Author: Oliver Kurth <okurth@vmware.com>2360Author: Oliver Kurth <okurth@vmware.com>
2322Date: Tue Feb 6 16:32:37 2018 -08002361Date: Wed Jan 16 14:53:03 2019 -0800
23232362
2324 Tools Hgfs Server Plugin: fix logging of client redirector handling functions2363 Common header file change not applicable to open-vm-tools.
2325
2326 Modify logging of client redirector handling functions for starting the client
2327 redirector kernel component and reconnecting mapped drives at services start
2328 up. This changes the level from warning to info as these messages are purely
2329 informational and not warnings of unexpected events or conditions.
23302364
2331commit 076b7201b61af9f3dcb36050ff37a8145a05d4042365commit 9aef5870bc7dc439bfa422662403369dfdd7f1d3
2332Author: Oliver Kurth <okurth@vmware.com>2366Author: Oliver Kurth <okurth@vmware.com>
2333Date: Tue Feb 6 16:32:37 2018 -08002367Date: Wed Jan 16 14:53:03 2019 -0800
23342368
2335 Fix error reported by clang 6.0.0 - comparison 'int' <= 4294967295 is always true2369 Common header file change not applicable to open-vm-tools.
2336
2337 Fix the logical constant compare warning/error in vixTools.c of the
2338 vix plugin. Rewrite the continuous for loop to simply iterate from
2339 zero to MAX_INT32.
23402370
2341commit 7a58576e98e5bdb47fbe101c43b106ba77f2e8112371commit e74e440279d402c5d81a1b6f75e0760d91c4eb88
2342Author: Oliver Kurth <okurth@vmware.com>2372Author: Oliver Kurth <okurth@vmware.com>
2343Date: Tue Feb 6 16:32:37 2018 -08002373Date: Wed Jan 16 14:53:03 2019 -0800
23442374
2345 Add VMware Tools 10.2.5 to vm_tools_version.h2375 Changes to common header files not directly appilcable to open-vm-tools.
2346
2347 - Add tools version 10.2.5 as the first scheduled tools 10.2.x
2348 update - TOOLS_VERSION_CHAINSAW_UPDATE1
2349 - Corrected a typo in a macro name in an earlier tools version
2350 definition.
23512376
2352commit 13c49b85cebacea847d30c4e5a0b92fa7ea9dba82377commit f8817830c0c41c6e5f7acf77555f9b1be2677b08
2353Author: Oliver Kurth <okurth@vmware.com>2378Author: Oliver Kurth <okurth@vmware.com>
2354Date: Tue Feb 6 16:32:37 2018 -08002379Date: Wed Jan 16 14:53:03 2019 -0800
23552380
2356 hostinfo: Identify Amazon Linux2381 Style: Fix parameter alignment.
2357
2358 Amazon Linux is not LSB compliant. Add a small amount of code such that
2359 Amazon Linux can differentiated from all of other Linuxen and correctly
2360 report its identifying data.
23612382
2362commit c5bc784da611ee929e0da7c20a410e03e65406132383commit 4b3f4bc4878aa9eec15d29e8a5a177186a07292c
2363Author: Oliver Kurth <okurth@vmware.com>2384Author: Oliver Kurth <okurth@vmware.com>
2364Date: Fri Jan 26 15:04:36 2018 -08002385Date: Wed Jan 16 14:53:02 2019 -0800
23652386
2366 Set X11 as the backend for gtk3 of open-vm-tools2387 Changes to common header files not applicable to open-vm-tools.
2367
2368 Open-vm-tools defaults to gtk3. For distros like Fedora 27, Wayland is
2369 the default display server. With no restriction on the backend, plugins
2370 will try to use Wayland as the backend of Gtk+3. As a result,
2371 gdk_display_get_default() returns a Wayland display;
2372 gdk_display_get_default_group() also returns a Wayland window. Applying
2373 GDK_WINDOW_XID() on the Wayland window will result in the crash reported
2374 on recent Linux releases that default to a Wayland display server.
2375
2376 As X11-specific code is widely used in tools plugins, a migratation to
2377 Wayland in the short term is not possible. So, as a compromised solution,
2378 plugins can be forced to run on XWayland, which is the compatible mode
2379 of Wayland for legacy X11 clients.
2380
2381 gdk_set_allowed_backends() only applies when flag GTK3 is defined, and Gtk
2382 version cwgreater than 3.10.
23832388
2384commit 98e0ab52c86b3a1d4fd38cec6913b1f5ba0f336c2389commit e5f79d1591677fd83173203e552e5a495109137f
2385Author: Oliver Kurth <okurth@vmware.com>2390Author: Oliver Kurth <okurth@vmware.com>
2386Date: Fri Jan 26 15:04:36 2018 -08002391Date: Tue Dec 18 14:12:19 2018 -0800
23872392
2388 hostinfo: More cleanup2393 Updates to the DeployPkg guest customization source code.
2389
2390 Continue the prep for Amazon Linux.
23912394
2392commit ce769ae4aa3a14810b418c044629f2d9dcb72a372395commit 401cf6d23667a66cd8f5ed5b5d6644305cb9180c
2393Author: Oliver Kurth <okurth@vmware.com>2396Author: Oliver Kurth <okurth@vmware.com>
2394Date: Fri Jan 26 15:04:36 2018 -08002397Date: Tue Dec 18 13:19:48 2018 -0800
23952398
2396 hostinfo: More prep work for Amazon Linux support2399 Changes to common header files; not applicable to open-vm-tools.
2397
2398 Amazon Linux is not LSB compliant but it does have a file that is
2399 much like an LSB compliant release (name=value pairs). Make the names
2400 of the structures generic... the logic can be reused for Amazon Linux
2401 in a follow up change.
2402
2403 Fix up some function headers.
24042400
2405commit 7fce1b8f9ec60c27865717f536a4e440587500ad2401commit 78c8c4c2e83a6d24e0302e55f21912d7ebee9a2e
2406Author: Oliver Kurth <okurth@vmware.com>2402Author: Oliver Kurth <okurth@vmware.com>
2407Date: Fri Jan 26 15:04:36 2018 -08002403Date: Tue Dec 18 13:19:48 2018 -0800
24082404
2409 Refactor HostinfoOSData...2405 Changes to common header files not applicable to open-vm-tools.
2406
2407commit 6c3d03d6ef32edffa882ce1816f344f4e1db4d8a
2408Author: Oliver Kurth <okurth@vmware.com>
2409Date: Tue Dec 18 13:19:48 2018 -0800
2410
2411 Header file guestcust-events.h moved to a new location.
2412
2413commit dafeb935f81a7c10946f359b0753de2ea74befda
2414Author: Oliver Kurth <okurth@vmware.com>
2415Date: Tue Dec 18 13:19:48 2018 -0800
2416
2417 Common header file change not applicable to open-vm-tools.
2418
2419commit 6009a6c1d3c7e72880541b0e4ca2a39e09e6d4e3
2420Author: Oliver Kurth <okurth@vmware.com>
2421Date: Tue Dec 18 13:19:48 2018 -0800
2422
2423 General code clean-up.
2410 2424
2411 Refactor the HostinfoOsData in several smaller and simpler routines.2425 bora/lib/misc/posixPosix.c:
2412 This will make it easier to maintain in the future (it was pretty2426 Treat local variables "len" consistently as "size_t" type in
2413 unwieldy already) and easier to add the logic for a non-LSB Linux.2427 Posix_Getmntent_r()
2414 2428
2415 More refactoring and actually adding the Amazon recognition code will2429 bora-vmsoft/apps/toolbox-cmd/toolboxcmd-shrink.c:
2416 follow.2430 Improve readability of error handling logic in ShrinkDoWipeAndShrink()
2431 and remove another line of dead code.
24172432
2418commit b2b71c7995f4389cd7a9899dca8aa29bd9fa9c6a2433commit a2ecb98683ee8edabddd47cfdd4bf37eb043cc17
2419Author: Oliver Kurth <okurth@vmware.com>2434Author: Oliver Kurth <okurth@vmware.com>
2420Date: Fri Jan 26 15:04:36 2018 -08002435Date: Tue Dec 18 13:19:48 2018 -0800
24212436
2422 Common header file change not applicable to open-vm-tools.2437 Common header file change not applicable to open-vm-tools.
24232438
2424commit 40bcee40c892cc7de92825cce1226576d6eab66c2439commit 767aaab78492854f178ebc7b16f0bf34b71c832b
2425Author: Oliver Kurth <okurth@vmware.com>2440Author: Oliver Kurth <okurth@vmware.com>
2426Date: Fri Jan 26 15:04:35 2018 -08002441Date: Tue Dec 18 13:19:48 2018 -0800
24272442
2428 Changes to common source files:2443 Record VMware Tools version 10.3.10 as TOOLS_VERSION_JACKHAMMER_UPDATE2
2429
2430 lib/asyncsocket/asyncsocket.c: Use ASSERT instead of VERIFY when removings
2431 poll callback in AsyncSocketCancelRecv.
2432 lib/include/vm_product_versions.h: Change not applicable to open-vm-tools.
24332444
2434commit 757833d601541e9bde24571fa22e669900e98a7e2445commit 3b40e2629e84abf2c3176264142fae54ac4431f0
2435Author: Oliver Kurth <okurth@vmware.com>2446Author: Oliver Kurth <okurth@vmware.com>
2436Date: Fri Jan 26 15:04:35 2018 -08002447Date: Tue Dec 18 13:19:48 2018 -0800
24372448
2438 Change the glibc constraint to 2.11 from 2.12.2449 Back out previous change to plugins/vix/vixTools.c.
2439 2450
2440 Earlier, we made a change to stop building open-vm-tools2451 Too many subtle issues to trust this one without more testing.
2441 for LINUX systems with glibc < 2.12 But SLES 11 SP4 which is
2442 supported comes with glibc 2.11.3 The check will
2443 block SLES 11 SP4 from moving to OVT 10.2.x To fix it, this change
2444 relaxes the glibc constraint to 2.11.
24452452
2446commit 75825dcc7548d779f23c4c93429736d690d86a452453commit 601b399538796cc1692c65f30686140c20b0ba33
2447Author: Oliver Kurth <okurth@vmware.com>2454Author: Oliver Kurth <okurth@vmware.com>
2448Date: Fri Jan 26 15:04:35 2018 -08002455Date: Tue Dec 18 13:19:48 2018 -0800
24492456
2450 Hgfs: remove Hgfs VMCI transport header from linux open-vm-tools2457 Cleanup -Wno-incompatible-pointer-types-discards-qualifiers
2451 2458
2452 Linux Hgfs clients do not use the VMCI module for a transport and have2459 Details
2453 since migrated to a FUSE implementation. Therefore we do not need to
2454 include the Hgfs VMCI transport header file.
2455
2456commit 09b6621863ece170e4fc6b617f0bc1e3d17867f2
2457Author: Oliver Kurth <okurth@vmware.com>
2458Date: Fri Jan 26 15:04:35 2018 -0800
2459
2460 Hgfs Server: fix error result for new dir creation in the virtual folder
2461 2460
2462 The Hgfs server code detects when a client tries to create a new folder in the2461 Both gcc and clang (on Mac) warn for pointer-incompatible
2463 virtual folder containing the VMware Shares. This is not allowed as only the2462 assignments. It appears that gcc's -Wwarn-strings isn't working
2464 host can add new Shares which appears in this folder. The current error code2463 properly, because it produces no warnings for the following
2465 returned to the client in these cases is access denied. This is only correct2464 assignment:
2466 when the new folder does not collide with an existing share. This stops clients
2467 treating the virtual folder as a regular read/write physical folder. However,
2468 for the case where the name collides, the access denied error is not correct,
2469 as it does not tell the client the folder already exists. This causes some
2470 applications to fail as they expect to see this error if the path component
2471 exists as that is okay and expected. At this point the application will continue
2472 to traverse the path and ensure the next component exists or if not create that.
2473 2465
2474 To ensure that applications don't prematurely fail and can test that the share2466 char *potentialSegV = ".rodata-based string";
2475 still exists in the path the Hgfs server should return HGFS_ERROR_FILE_EXIST
2476 and leave HGFS_ERROR_ACCESS_DENIED for all other cases.
2477
2478commit fb3630fb0d7846b9f06f0c506c38eadf0cfbfa81
2479Author: Oliver Kurth <okurth@vmware.com>
2480Date: Fri Jan 26 15:04:35 2018 -0800
2481
2482 Hgfs: get rid of vmware_pack_begin and vmware_pack_end header files
2483 2467
2484 Get rid of vmware_pack_begin and vmware_pack_end header files and2468 However, clang does.
2485 replace with the pragma pack and pop. This code currently only
2486 affects Windows clients and the VMX HGFS VMCI transport.
2487
2488commit f7c551253400e7f153cc696b5b121cd6e0d4ebd8
2489Author: Oliver Kurth <okurth@vmware.com>
2490Date: Fri Jan 26 15:04:35 2018 -0800
2491
2492 GOSTable: Amazon Linux 2
2493 2469
2494 Add the basic support for Amazon Linux 2. The distro identification2470 This change addresses three problems in bora/lib that produce build
2495 code will follow in a separate change.2471 failures when -Wincompatible-pointer-types-discards-qualifiers is
2472 enabled when using clang (one wonders how many other such potential
2473 problems exist?)
2474
2475 o bsd_vsnprintf.c
2476
2477 The 'cp' pointer is assigned the address of a constant string.
2478 Since there are writes through 'cp', the quickest solution is to
2479 declare a local, non-const, array variable that holds the string
2480 "(null)".
2481
2482 o unicodeSimpleTypes.c
2483
2484 This change, the easiest of the three, marks the 'char *' field as
2485 'const'.
24962486
2497commit c8f7c09d106884c19100077fdffe8f11b80d6bdb2487commit 07877933b3b2890f1111d07c92cff54e839ff8c6
2498Author: Oliver Kurth <okurth@vmware.com>2488Author: Oliver Kurth <okurth@vmware.com>
2499Date: Fri Jan 5 14:47:15 2018 -08002489Date: Tue Dec 18 13:19:48 2018 -0800
25002490
2501 Changes to common header files not applicable to open-vm-tools2491 Common header file change not applicable to open-vm-tools.
25022492
2503commit 5939eaefbad529e811c64b46d93ddcce56615db82493commit 8b5f6fa802d60aa8bb1855843b395c3851363cce
2504Author: Oliver Kurth <okurth@vmware.com>2494Author: Oliver Kurth <okurth@vmware.com>
2505Date: Fri Jan 5 14:47:15 2018 -08002495Date: Tue Dec 18 13:19:47 2018 -0800
25062496
2507 Common header file change not applicable to open-vm-tools2497 Backout previous change to vm_basic_asm.h; not applicable to open-vm-tools.
25082498
2509commit 55f323265bb7aee605a40f289f9c1a8ba7be56c62499commit d8e831e22912d7f2a285c16af1824dafc072cd3a
2510Author: Oliver Kurth <okurth@vmware.com>2500Author: Oliver Kurth <okurth@vmware.com>
2511Date: Fri Jan 5 14:47:15 2018 -08002501Date: Tue Dec 18 13:19:47 2018 -0800
25122502
2513 Common header file change not applicable to open-vm-tools2503 Common header file change not applicable to open-vm-tools.
25142504
2515commit d42e5bf76689c820dfb84d681c007c96197f61822505commit 05209f64dcc5eb253b18b3969582749039a835c5
2516Author: Oliver Kurth <okurth@vmware.com>2506Author: Oliver Kurth <okurth@vmware.com>
2517Date: Fri Jan 5 14:47:15 2018 -08002507Date: Tue Dec 18 13:19:47 2018 -0800
25182508
2519 Common header file change not applicable to open-vm-tools.2509 Common header file change not applicable to open-vm-tools.
25202510
2521commit 90819beef53238ba108be35cba93329b9d160de72511commit 3fef292a16fd27c83e3dd690e3a2a3bc5e74f2b1
2522Author: Oliver Kurth <okurth@vmware.com>2512Author: Oliver Kurth <okurth@vmware.com>
2523Date: Fri Jan 5 14:47:15 2018 -08002513Date: Tue Dec 18 13:19:47 2018 -0800
25242514
2525 Get rid of convertutf and bsd_printf for all non-Win VMware Tools2515 Revert previous change to vmci_sockets.h.
2526
2527 The MsgFmt_* functions are referenced in a few utilities
2528 related to VMware Tools. This change replaces the MsgFmt_*
2529 with a stub. This also affects the Windows version.
25302516
2531commit e5e478d46f047aa8f22b427b9d4505581af9915a2517commit f91f7355619ad0ed7afcbe0b7161be3680b88688
2532Author: Oliver Kurth <okurth@vmware.com>2518Author: Oliver Kurth <okurth@vmware.com>
2533Date: Fri Jan 5 14:47:15 2018 -08002519Date: Tue Dec 18 13:19:47 2018 -0800
25342520
2535 Fix the SSL/AsyncSocket "SSL_shutdown:shutdown while in init" problem2521 Fix NULL pointer dereference and remove three lines of dead code.
2536 2522
2537 QE regression tests have caught a bug in the bora SSL/AsyncSocket2523 QbitLogic has run [Code]Ai on the open-vm-tools source code and
2538 layer. A normal SSL connection could be abnormally terminated by some2524 and notified VMware of a potential NULL pointer reference and four
2539 other random connections.2525 pieces of dead code.
2540 2526
2541 Seems a common bug of the SSL usage according to the link below.2527 See https://github.com/vmware/open-vm-tools/pull/247
2542 VMware is not the first one to hit it. :-)
2543 https://marc.info/?l=openssl-users&w=4&r=1&s=shutdown+while+in+init&q=b
2544 2528
2545 The cause is that the SSL error queue was not cleared before2529 bora-vmsoft/services/vmtoolsd/pluginMgr.c
2546 calling the SSL IO functions like SSL_write,read,connect,accept.2530 The proposed fix conditionally emitted a log message. That fix has
2547 Refer to the man page of SSL_get_error, Paragraph 2 of the Description.2531 been reworked to consistently emit a log message with conditional
2548 Fixed the problem by adding addtional call to clear the error queue.2532 content.
2549 2533
2550 Found another problem that the system error is not preserved between2534 bora/lib/misc/posixPosix.c
2551 where it is set after the SSL IO call and the use of it to determine2535 bora-vmsoft/apps/toolbox-cmd/toolboxcmd-shrink.c
2552 whether to retry the SSL IO. This is probably due to tools has its2536 Remove one line of dead code from each source file.
2553 own logging which does not preserve the system error number.2537
2554 Fixed the logging.2538 bora-vmsoft/lib/procMgr/procMgrPosix.c:
2539 Suggested dead code fix actually pointed to a bug where errno
2540 was not getting updated as intended.
2541
2542 bora-vmsoft/services/plugins/guestInfo/perfMonLinux.c:
2543 Suggested dead code is no longer dead; change not applicable.
25552544
2556commit 8a9c43698ebcc858314ec1c041d24b8e8d1372cf2545commit bbcb8a46876352e120d22ee07bae26be29ec27c3
2557Author: Oliver Kurth <okurth@vmware.com>2546Author: Oliver Kurth <okurth@vmware.com>
2558Date: Fri Jan 5 14:47:15 2018 -08002547Date: Tue Dec 18 13:19:47 2018 -0800
25592548
2560 vm_basic_types.h: use stdint.h a little more.2549 Remove erroneous defines of __FreeBSD__ & __VMKTCPIP__ from vmci_sockets.h
2561
2562 Now that enough of the builds are C++11, let's make the common case
2563 use the <stdint.h> header to define the intNN types directly
2564 from language-standard intNN_t types, and treat pre-C99/C++98
2565 code as the special case.
2566
2567 This also provides some clarity about the last __STRICT_ANSI__
2568 macros in this file. One was related to usage of 'long long' in
2569 strict c90 mode and has been replaced with a comment indicating that
2570 64-bit-variable compiler extensions are mandatory (strict c90 mode is
2571 not allowed via the headers). The other related to X11 headers; those
2572 headers have been examined to understand the workarounds needed and
2573 the exact scenario(s) that are problematic have been commented (turns
2574 out FreeBSD had nothing to do with the problem).
2575
2576 Finally, all the Bool-related definitions have been moved and merged
2577 to a single location NOT at the top of the file.
2578
2579 Net effects of this change:
2580 - non-linux C++11 (so Windows+Mac) now uses stdint.h
2581 - exact set of macros involved in declaring Bool is reduced
2582 - compiling with c90 mode really will break now (use gnu90 instead).
25832550
2584commit 2674b02449875b04889be00400f52351105ab25f2551commit 56d568396910f2af7408517b75b0a6e387bf69ef
2585Author: Oliver Kurth <okurth@vmware.com>2552Author: Oliver Kurth <okurth@vmware.com>
2586Date: Fri Jan 5 14:47:15 2018 -08002553Date: Tue Dec 18 13:19:47 2018 -0800
25872554
2588 Consume vmx headear files in bora tree instead of gosc's own copy2555 Add VMware Tools version 10.3.6 to vm_tools_version.h
2589
2590 1. Consuming header files from bora/vmx instead of gosc/vmx
2591 2. Deprecated "gosc/vmx/public/toolsdDeployPkg.h",
2592 use "bora/guestABI/include/vmware/guestrpc/deploypkg.h" instead.
2593 Combined macro definition to the new header file and modified
2594 reference accordingly.
2595 3. Modified makefile for open-vm-tools to consume new header file,
2596 removed old header file staging in open-vm-tools.stage
25972556
2598commit bd018012a08579e89209e23b69963937210e51822557commit e843a034b7ea9e32959512d39ca1d046968c575e
2599Author: Oliver Kurth <okurth@vmware.com>2558Author: Oliver Kurth <okurth@vmware.com>
2600Date: Fri Jan 5 14:47:15 2018 -08002559Date: Tue Dec 18 13:19:47 2018 -0800
26012560
2602 Common header file change not applicable to open-vm-tools2561 Common header file change not applicable to open-vm-tools.
26032562
2604commit 36929119b9e28df8e267c49b56613542534392152563commit f32fde16f226a67b42fe095aea33bf7b5e8040c0
2605Author: Oliver Kurth <okurth@vmware.com>2564Author: Oliver Kurth <okurth@vmware.com>
2606Date: Fri Jan 5 14:47:15 2018 -08002565Date: Tue Dec 18 13:19:47 2018 -0800
26072566
2608 Remove some __STRICT_ANSI__ guards in vm_basic_types.h2567 special case profile loading for StartProgram
2609 2568
2610 Some time in the distant past, these guards were needed to2569 For StartProgram, we need to be sure there's no race in the profile
2611 work around... something. (Probably, it was that 'long long'2570 unloading. So keep it open through the life of the started program.
2612 is not a valid type in strict c90 mode). Note that we don't
2613 use c90 mode, we only use gnu90 or c99.
2614
2615 This ends up being relevant because for C++ we are indeed
2616 using -std=c++11 (which implies __STRICT_ANSI__). The Linux/C++
2617 section of this file thus had duplicate definitions (which I am
2618 now removing) to work around the gap.
2619 2571
2620 Quick cheat sheet for -std= values:2572 See related vgauth change.
2621 - c90 := __STRICT_ANSI__, no long long type
2622 - gnu90 := c90 + gcc extensions, has long long type
2623 - c99 := __STRICT_ANSI__, has long long type (defined in c99)
2624 - c++11 := __STRICT_ANSI__, has long long type (defined in C++11)
26252573
2626commit 6b1ef0ef99f34011da3f5383414eeedf81c59d3b2574commit 150483202fdd5b3c447e4547bee00d18b918bb31
2627Author: Oliver Kurth <okurth@vmware.com>2575Author: Oliver Kurth <okurth@vmware.com>
2628Date: Fri Jan 5 14:47:15 2018 -08002576Date: Tue Dec 18 13:19:47 2018 -0800
26292577
2630 open-vm-tools: fix finding C++ compiler for cross-compiling2578 Common header file change not applicable to open-vm-tools
2631
2632 Patch contributed by Andrew Stormont (andy-js) on github:
2633 https://github.com/vmware/open-vm-tools/pull/206 and
2634 https://github.com/vmware/open-vm-tools/issues/92.
26352579
2636commit df18c2c2c3e7dde4478ee68a5f4a96600a3d07a22580commit 1997a49deaed475d44ef4eece6c592e51115a8b0
2637Author: Oliver Kurth <okurth@vmware.com>2581Author: Oliver Kurth <okurth@vmware.com>
2638Date: Fri Jan 5 14:47:14 2018 -08002582Date: Tue Dec 18 13:19:47 2018 -0800
26392583
2640 Allow copying of object policy within the same container2584 Fix the issue that Deploypkg log files of linux should not be world readable.
2641 2585
2642 ObjLib_CloneExtParams is currently not allowing copying of policy from2586commit f16590d1b721112f7841283ed03912c3837f120d
2643 parent to child/clone object on VSAN. This is because the copy policy2587Author: Oliver Kurth <okurth@vmware.com>
2644 check is based on unique filesystem ID, which will be different for2588Date: Tue Dec 18 13:19:47 2018 -0800
2645 parent and child on VSAN because they will mostly be created on same2589
2646 container but different namespace. This change uses VCFS root instead2590 lib/file: Memory leak in File_ListDirectory when directory is empty
2647 of namespace UUID to make the comparison on VSAN.
2648 2591
2649 Bonus fix: File_FullPath is now fixed to work for any combination of2592 If the directory is empty, calloc of zero still succeeds and a memory
2650 ancestor path being present. Currently it only works if either the2593 leak results.
2651 given path exists, or when only the last component of the path does
2652 not exist. And since this fix relies on finding the VCFS root of both
2653 parent and child (parent is present but child is not),
2654 ObjLibPathToVCFSRoot has been modified to rely on File_FullPath in
2655 addition to Util_GetCanonicalPath if the path does not exist.
26562594
2657commit a678f3ea9f6de366b3b3de2f99956d93d2216b082595commit 1a685809609906464f90f2a2a2e2c5299bb8cb4e
2658Author: Oliver Kurth <okurth@vmware.com>2596Author: Oliver Kurth <okurth@vmware.com>
2659Date: Fri Jan 5 14:47:14 2018 -08002597Date: Tue Dec 18 13:19:47 2018 -0800
26602598
2661 Correction to previous change for Solaris11_64 GOS.2599 Common header file change not applicable to open-vm-tools.
26622600
2663commit 74eb0c942f78f775c9de2bfd0e4f9970a8cded512601commit e03c5b88c6e42a3bf395ad647544ae113e83779c
2664Author: Oliver Kurth <okurth@vmware.com>2602Author: Oliver Kurth <okurth@vmware.com>
2665Date: Fri Jan 5 14:47:14 2018 -08002603Date: Tue Dec 18 13:19:46 2018 -0800
26662604
2667 Properly classify Solaris 11-64 as 64-bit2605 Changes to common source files not applicable to open-vm-tools.
26682606
2669commit 47e604c2dba131c13300fe15bf4ad69d5b9966742607commit 74561dc19faf9a44fffc0676c27c16176b35d3af
2670Author: Oliver Kurth <okurth@vmware.com>2608Author: Oliver Kurth <okurth@vmware.com>
2671Date: Mon Dec 4 16:27:21 2017 -08002609Date: Tue Dec 18 13:19:46 2018 -0800
26722610
2673 Common header file change; not applicable to open-vm-tools.2611 lib/file: Improve File_ListDirectory and File_WalkDirectory*
2612
2613 The File_WalkDirectory implementation has an initial latency (before
2614 file names are available) that is unnecessary. Using the unicode
2615 library, when not necessary, adds a huge amount of memory usage and
2616 wastes CPU time.
2617
2618 These routines duplicate quite a bit of code.
2619
2620 Rewrite File_ListDirectory to use File_WalkDirectory*.
2621
2622 Rewrite File_WalkDirectory*:
2623 - Return files as they are discovered, not after the entire directory
2624 contents are parsed. If one decides to stop early, they don't have
2625 to pay the price for the entire directory contents.
2626 - Preserve the protection from duplicate file names. While Windows
2627 locks a directory during a content tranverse, POSIXen does nott. Code
2628 is here in the lib/file for quite some time so that the numerous
2629 callers do not have to handle dealing with dups.
2630 - Avoid using the unicode library on platforms where we can, this avoid
2631 most of the eggregious memory usage.
2632 - Don't use Dynbuf... Handling things directly is more efficient.
26742633
2675commit 584aa9f307c85b07fa8adaf113e87cc3c200cca9
The diff has been truncated for viewing.

Subscribers

People subscribed via source and target branches