webbrowser-app

Merge lp:~osomon/webbrowser-app/better-ua-override-for-twitter into lp:webbrowser-app

  1. better-ua-override-for-twitter
  2. Merge into trunk
Proposed by Olivier Tilloy
Status: Merged
Approved by: Günter Schwann
Approved revision: 373
Merged at revision: 374
Proposed branch: lp:~osomon/webbrowser-app/better-ua-override-for-twitter
Merge into: lp:webbrowser-app
Diff against target: 12 lines (+1/-1)
1 file modified
src/Ubuntu/Components/Extras/Browser/ua-overrides.js (+1/-1)
To merge this branch: bzr merge lp:~osomon/webbrowser-app/better-ua-override-for-twitter
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Günter Schwann (community) Approve
Review via email: mp+189540@code.launchpad.net

Commit message

Better UA override rule for mobile twitter (don’t pretend to be an android).
Thanks Adnane Belmadiaf for the tip!

To post a comment you must log in.
Revision history for this message
Günter Schwann (schwann) wrote :

lgtm

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:373
http://10.97.0.26:8080/job/webbrowser-app-ci/468/
Executed test runs:
    SUCCESS: http://10.97.0.26:8080/job/generic-mediumtests-saucy/4687
    SUCCESS: http://10.97.0.26:8080/job/generic-mediumtests-touch/2497
    SUCCESS: http://10.97.0.26:8080/job/webbrowser-app-saucy-amd64-ci/352
    SUCCESS: http://10.97.0.26:8080/job/webbrowser-app-saucy-armhf-ci/351
        deb: http://10.97.0.26:8080/job/webbrowser-app-saucy-armhf-ci/351/artifact/work/output/*zip*/output.zip
    SUCCESS: http://10.97.0.26:8080/job/webbrowser-app-saucy-i386-ci/351
    SUCCESS: http://10.97.0.26:8080/job/autopilot-testrunner-otto-saucy/873
    SUCCESS: http://10.97.0.26:8080/job/generic-mediumtests-builder-saucy-amd64/562
        deb: http://10.97.0.26:8080/job/generic-mediumtests-builder-saucy-amd64/562/artifact/work/output/*zip*/output.zip
    SUCCESS: http://10.97.0.26:8080/job/generic-mediumtests-builder-saucy-armhf/2499
        deb: http://10.97.0.26:8080/job/generic-mediumtests-builder-saucy-armhf/2499/artifact/work/output/*zip*/output.zip
    SUCCESS: http://10.97.0.26:8080/job/generic-mediumtests-runner-maguro/2057
    SUCCESS: http://10.97.0.26:8080/job/generic-mediumtests-runner-mako/2070

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/webbrowser-app-ci/468/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Ubuntu/Components/Extras/Browser/ua-overrides.js'
--- src/Ubuntu/Components/Extras/Browser/ua-overrides.js 2013-10-03 17:38:29 +0000
+++ src/Ubuntu/Components/Extras/Browser/ua-overrides.js 2013-10-07 08:11:26 +0000
@@ -56,7 +56,7 @@
5656
57 "m.youtube.com": [/Mobile\) WebKit\/[.0-9]*/, "Android 4.3) AppleWebKit Mobile Safari"],57 "m.youtube.com": [/Mobile\) WebKit\/[.0-9]*/, "Android 4.3) AppleWebKit Mobile Safari"],
5858
59 "mobile.twitter.com": [/Mobile\) WebKit\/[.0-9]*/, "Android 4.3) AppleWebKit Mobile Safari"],59 "twitter.com": ["Mobile)", "Mobile) Firefox"],
6060
61 // while this issue gets resolved (https://bugs.launchpad.net/ubuntu/+source/ubuntu-keyboard/+bug/1233207)61 // while this issue gets resolved (https://bugs.launchpad.net/ubuntu/+source/ubuntu-keyboard/+bug/1233207)
62 "login.ubuntu.com": [/Mobile\) WebKit\/[.0-9]*/, "Android 4.3) AppleWebKit Mobile Safari"],62 "login.ubuntu.com": [/Mobile\) WebKit\/[.0-9]*/, "Android 4.3) AppleWebKit Mobile Safari"],

Subscribers

People subscribed via source and target branches

to status/vote changes: