Merge lp:~osomon/oxide/pa-context-app-name into lp:~oxide-developers/oxide/oxide.trunk

[Olivier Tilloy]

Use the application name for the pulse audio context.

Note: unfortunately I haven’t been able to verify that this actually works, as it seems the behaviour of the trust store on ubuntu touch devices has changed, I don’t get prompted for microphone permission access from unconfined apps like the browser (this used to be the case, see the description of bug #1486645).

I don’t know of a way to list open pulse audio contexts, which I guess would prove that the right name is being used.

[Chris Coulson (chrisccoulson)]

review: Approve

=== added file 'patches/pa-context-application-name.patch'
--- patches/pa-context-application-name.patch	1970-01-01 00:00:00 +0000
+++ patches/pa-context-application-name.patch	2015-09-10 17:54:23 +0000
@@ -0,0 +1,16 @@
+# Description: Use the application name for the pulse audio context
+# Bug: https://launchpad.net/bugs/1486645
+# Author: Olivier Tilloy <[e-mail]>
+
+diff --git a/media/audio/pulse/audio_manager_pulse.cc b/media/audio/pulse/audio_manager_pulse.cc
+--- a/media/audio/pulse/audio_manager_pulse.cc
++++ b/media/audio/pulse/audio_manager_pulse.cc
+@@ -248,7 +248,7 @@
+ 
+   pa_mainloop_api* pa_mainloop_api =
+       pa_threaded_mainloop_get_api(input_mainloop_);
+-  input_context_ = pa_context_new(pa_mainloop_api, "Chrome input");
++  input_context_ = pa_context_new(pa_mainloop_api, GetGlobalAppName().c_str());
+   if (!input_context_)
+     return false;
+ 
 
=== modified file 'patches/series'
--- patches/series	2015-09-01 21:41:24 +0000
+++ patches/series	2015-09-10 17:54:23 +0000
@@ -35,3 +35,4 @@
 enable-optional-neon-for-skia.patch
 add-suggested-filename-to-download-starting-resource-delegate.patch
 always-define-angle-commit-hash.patch
+pa-context-application-name.patch
 
=== modified file 'shared/browser/oxide_browser_main_parts.cc'
--- shared/browser/oxide_browser_main_parts.cc	2015-07-27 16:40:33 +0000
+++ shared/browser/oxide_browser_main_parts.cc	2015-09-10 17:54:23 +0000
@@ -25,6 +25,7 @@
 #include "EGL/egl.h"
 #include "gpu/config/gpu_driver_bug_workaround_type.h"
 #include "gpu/config/gpu_info_collector.h"
+#include "media/audio/audio_manager.h"
 #include "net/base/net_module.h"
 #include "third_party/WebKit/public/platform/WebScreenInfo.h"
 #include "ui/gfx/display.h"
@@ -259,6 +260,9 @@
 }
 
 void BrowserMainParts::PreMainMessageLoopRun() {
+  media::AudioManager::SetGlobalAppName(
+      BrowserPlatformIntegration::GetInstance()->GetApplicationName());
+
   // With in-process GPU, nothing calls CollectContextGraphicsInfo, so we do
   // this now. Note that this will have no effect on driver bug workarounds
   // (those are added to the command line from the basic info found in