Merge lp:~openerp-dev/openobject-addons/6.1-opw-580021-rgo into lp:openobject-addons/6.1

Proposed by Ravi Gohil (OpenERP)
Status: Approved
Approved by: Naresh(OpenERP)
Approved revision: 7024
Proposed branch: lp:~openerp-dev/openobject-addons/6.1-opw-580021-rgo
Merge into: lp:openobject-addons/6.1
Diff against target: 21 lines (+2/-2)
1 file modified
warning/warning.py (+2/-2)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/6.1-opw-580021-rgo
Reviewer Review Type Date Requested Status
Don Kirkby (community) Approve
Rifakat Husen (OpenERP) (community) Approve
Naresh(OpenERP) Pending
Review via email: mp+128864@code.launchpad.net

Description of the change

Hello,

Steps to reproduce:
1) Create new db with demo data and install purchase and warning modules,
2) open any record in Purchase/Purchase Management/Request for Quotation,
3) open purchase order line and change the product uom,

Traceback will faced saying "TypeError: onchange_product_id() got an unexpected keyword argument 'fiscal_position_id'"

This MP contains fix for this issue.

Thanks.

To post a comment you must log in.
Revision history for this message
Rifakat Husen (OpenERP) (rha-openerp) :
review: Approve
Revision history for this message
Don Kirkby (donkirkby) :
review: Approve
Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hello,

This bug was qualified as Already Fixed on Trunk (means that it was already fixed and merged in Trunk). If this Merge Proposal could not be merged in v6.1 at the release of v7.0, it will be closed.

Thanks,
Naresh Soni

Unmerged revisions

7024. By Ravi Gohil (OpenERP)

[FIX] warning: Fixed the traceback faced saying 'unexpected keyword argument fiscal_position_id' when changing UOM in purchase order line : (Maintenance Case : 580021)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'warning/warning.py'
--- warning/warning.py 2012-09-06 10:32:09 +0000
+++ warning/warning.py 2012-10-10 06:37:23 +0000
@@ -231,7 +231,7 @@
231class purchase_order_line(osv.osv):231class purchase_order_line(osv.osv):
232 _inherit = 'purchase.order.line'232 _inherit = 'purchase.order.line'
233 def onchange_product_id(self,cr, uid, ids, pricelist, product, qty, uom,233 def onchange_product_id(self,cr, uid, ids, pricelist, product, qty, uom,
234 partner_id, date_order=False, fiscal_position=False, date_planned=False,234 partner_id, date_order=False, fiscal_position_id=False, date_planned=False,
235 name=False, price_unit=False, notes=False, context=None):235 name=False, price_unit=False, notes=False, context=None):
236 warning = {}236 warning = {}
237 if not product:237 if not product:
@@ -250,7 +250,7 @@
250 warning['message'] = message250 warning['message'] = message
251251
252 result = super(purchase_order_line, self).product_id_change(cr, uid, ids, pricelist, product, qty, uom,252 result = super(purchase_order_line, self).product_id_change(cr, uid, ids, pricelist, product, qty, uom,
253 partner_id, date_order, fiscal_position)253 partner_id, date_order, fiscal_position_id)
254254
255 if result.get('warning',False):255 if result.get('warning',False):
256 warning['title'] = title and title +' & '+result['warning']['title'] or result['warning']['title']256 warning['title'] = title and title +' & '+result['warning']['title'] or result['warning']['title']