Merge lp:~openerp-dev/openobject-addons/6.1-opw-574713-skh into lp:openobject-addons/6.1

[Somesh Khare]

Hello Sir,

[Fix]: Idea: Count of comments and Count of votes in Idea should start from 0.

When you create new Idea, Count of Comments and Count of Vote fields are automatically become 1( See From Statistics tab of Idea), Even the Idea is in New state(No votes or comments Done). Counter for both the fields should be 0 when no comments or votes or if the state of the idea is New.

This branch fixes this issue.

Kindly review the branch and please share your views on it.

Thanks,
Somesh Khare

[Vinay Rana (OpenERP) (vra-openerp)]

the propose patch fixes the default value.

review: Approve

[Naresh(OpenERP) (nch-openerp)]

Hello,

This bug was qualified as Not Relevant on Trunk (means that architecture on trunk has changed and so this bug has no meaning anymore). If this Merge Proposal could not be merged in v6.1 at the release of v7.0, it will be closed.

Thanks,
Naresh

Unmerged revisions

6795. By Somesh Khare on 2012-05-11

[FIX] Idea: Count of comments and Count of votes in Idea should start from 0(Case: Ref 574713)

=== modified file 'idea/idea.py'
--- idea/idea.py	2011-12-31 07:57:20 +0000
+++ idea/idea.py	2012-05-11 06:35:22 +0000
@@ -105,7 +105,7 @@
         if not ids:
             return {}
 
-        sql = """SELECT i.id, COUNT(1)
+        sql = """SELECT i.id, COUNT(v.idea_id)
            FROM idea_idea i LEFT OUTER JOIN idea_vote v ON i.id = v.idea_id
             WHERE i.id IN %s
             GROUP BY i.id
@@ -125,7 +125,7 @@
         if not ids:
             return {}
 
-        sql = """SELECT i.id, COUNT(1)
+        sql = """SELECT i.id, COUNT(c.idea_id)
            FROM idea_idea i LEFT OUTER JOIN idea_comment c ON i.id = c.idea_id
             WHERE i.id IN %s
             GROUP BY i.id