Merge lp:~openerp-dev/openobject-addons/6.1-opw-572802-skh into lp:openobject-addons/6.1

Proposed by Somesh Khare
Status: Approved
Approved by: Naresh(OpenERP)
Approved revision: 6721
Proposed branch: lp:~openerp-dev/openobject-addons/6.1-opw-572802-skh
Merge into: lp:openobject-addons/6.1
Diff against target: 15 lines (+2/-2)
1 file modified
product/product.py (+2/-2)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/6.1-opw-572802-skh
Reviewer Review Type Date Requested Status
Naresh(OpenERP) (community) Approve
Olivier Dony (Odoo) Approve
Somesh Khare (community) Needs Resubmitting
Review via email: mp+100146@code.launchpad.net

Description of the change

Hello Sir,

[Fix]: On the stock move filter "Product" when you search the product the limit into the name_search() goes "None".
 Current Result : No move for the search product
 Expected Result: Should show all move for the Product

Kindly review the branch and please share your view on it,

Thanks

To post a comment you must log in.
Revision history for this message
Somesh Khare (somesh.khare) :
review: Needs Resubmitting
6718. By Olivier Dony (Odoo)

[FIX] Trunk backport: properly record UTC login date, courtesy of Ian Beardslee

6719. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

6720. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

Revision history for this message
Somesh Khare (somesh.khare) :
review: Needs Resubmitting
6721. By Somesh Khare

[Fix] Product : removed the print statement (Case Ref: 572802)

Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

Looks good to me now. See also related bug 971627 and the patch similar that was applied there.

review: Approve
Revision history for this message
Naresh(OpenERP) (nch-openerp) :
review: Approve
Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hello,

This bug was qualified as Confirmed on Trunk (means still existing and reproducible). A Merge Proposal for trunk was created to fix it. Here is the link to follow the MP on Launchpad https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-opw-572802-port-mma/+merge/132657 and be informed once it's been merged in trunk: ... If this Merge Proposal could not be merged in v6.1 at the release of v7.0, it will be closed.

Thanks,
Naresh Soni

Unmerged revisions

6721. By Somesh Khare

[Fix] Product : removed the print statement (Case Ref: 572802)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'product/product.py'
--- product/product.py 2012-02-14 14:34:20 +0000
+++ product/product.py 2012-04-02 05:06:20 +0000
@@ -611,9 +611,9 @@
611 # Performing a quick memory merge of ids in Python will give much better performance611 # Performing a quick memory merge of ids in Python will give much better performance
612 ids = set()612 ids = set()
613 ids.update(self.search(cr, user, args + [('default_code',operator,name)], limit=limit, context=context))613 ids.update(self.search(cr, user, args + [('default_code',operator,name)], limit=limit, context=context))
614 if len(ids) < limit:614 if not limit or len(ids) < limit:
615 # we may underrun the limit because of dupes in the results, that's fine615 # we may underrun the limit because of dupes in the results, that's fine
616 ids.update(self.search(cr, user, args + [('name',operator,name)], limit=(limit-len(ids)), context=context))616 ids.update(self.search(cr, user, args + [('name',operator,name)], limit=(limit-len(ids) if limit else limit) , context=context))
617 ids = list(ids)617 ids = list(ids)
618 if not ids:618 if not ids:
619 ptrn = re.compile('(\[(.*?)\])')619 ptrn = re.compile('(\[(.*?)\])')