Merge ~ondrak/ubuntu/+source/linux/+git/xenial:dtb-update into ~ubuntu-kernel/ubuntu/+source/linux/+git/xenial:snapdragon

Proposed by Ondrej Kubik
Status: Needs review
Proposed branch: ~ondrak/ubuntu/+source/linux/+git/xenial:dtb-update
Merge into: ~ubuntu-kernel/ubuntu/+source/linux/+git/xenial:snapdragon
Diff against target: 38 lines (+4/-4)
1 file modified
arch/arm64/boot/dts/qcom/apq8016-sbc-snappy.dtsi (+4/-4)
Reviewer Review Type Date Requested Status
Paolo Pisati (community) Disapprove
Review via email: mp+346754@code.launchpad.net

Commit message

UBUNTU: SAUCE: dtb: updating custom apq8016 for snappy to fix LED functionality

  Updating dragonboard 410c device tree LED definition to work properly on Ubuntu Core
  Use rfkill(0/1) for bluetooth and wifi LEDs
  setting LED1 as heartbeat
  setting LED4 as default-on

To post a comment you must log in.
Revision history for this message
Paolo Pisati (p-pisati) wrote :

I don't have write access to the kernel repository, only the stable team has it: resend it to the ubuntu kernel ml for review.

Plus, it's missing an LB bug and the Buglink.

review: Disapprove

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-snappy.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc-snappy.dtsi
index 68b3c75..56c63ce 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc-snappy.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-snappy.dtsi
@@ -218,7 +218,7 @@
218218
219 led@1 {219 led@1 {
220 label = "apq8016-sbc:green:user1";220 label = "apq8016-sbc:green:user1";
221 gpios = <&msmgpio 21 GPIO_ACTIVE_HIGH>;221 gpios = <&msmgpio 95 GPIO_ACTIVE_HIGH>;
222 linux,default-trigger = "heartbeat";222 linux,default-trigger = "heartbeat";
223 default-state = "off";223 default-state = "off";
224 };224 };
@@ -240,21 +240,21 @@
240 led@4 {240 led@4 {
241 label = "apq8016-sbc:green:user4";241 label = "apq8016-sbc:green:user4";
242 gpios = <&pm8916_gpios 2 GPIO_ACTIVE_HIGH>;242 gpios = <&pm8916_gpios 2 GPIO_ACTIVE_HIGH>;
243 linux,default-trigger = "none";243 linux,default-trigger = "default-on";
244 default-state = "off";244 default-state = "off";
245 };245 };
246246
247 led@5 {247 led@5 {
248 label = "apq8016-sbc:yellow:wlan";248 label = "apq8016-sbc:yellow:wlan";
249 gpios = <&pm8916_mpps 2 GPIO_ACTIVE_HIGH>;249 gpios = <&pm8916_mpps 2 GPIO_ACTIVE_HIGH>;
250 linux,default-trigger = "wlan";250 linux,default-trigger = "rfkill1";
251 default-state = "off";251 default-state = "off";
252 };252 };
253253
254 led@6 {254 led@6 {
255 label = "apq8016-sbc:blue:bt";255 label = "apq8016-sbc:blue:bt";
256 gpios = <&pm8916_mpps 3 GPIO_ACTIVE_HIGH>;256 gpios = <&pm8916_mpps 3 GPIO_ACTIVE_HIGH>;
257 linux,default-trigger = "bt";257 linux,default-trigger = "rfkill0";
258 default-state = "off";258 default-state = "off";
259 };259 };
260 };260 };

Subscribers

People subscribed via source and target branches