Merge lp:~neokore/ubuntu-weather-app/LoadingComponent into lp:ubuntu-weather-app/obsolete.trunk

[Raúl Yeguas]

Added a 'Loading Component' to show an animation while app is loading data. This component is included into default Tab in ubuntu-weather-app.qml.

Added a 'Loading Component' to show an animation while app is loading data.

[Martin Borho (martin-borho)]

Looks great!

review: Approve

[Martin Borho (martin-borho)]

When all locations are removed, the circle should not be visible anymore.

review: Needs Fixing

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:17
http://91.189.93.125:8080/job/ubuntu-weather-app-ci/10/
Executed test runs:
    SUCCESS: http://91.189.93.125:8080/job/ubuntu-weather-app-quantal-amd64-ci/10
    SUCCESS: http://91.189.93.125:8080/job/ubuntu-weather-app-raring-amd64-ci/10

Click here to trigger a rebuild:
http://91.189.93.125:8080/job/ubuntu-weather-app-ci/10/rebuild

review: Approve (continuous-integration)

[lp:~neokore/ubuntu-weather-app/LoadingComponent]

18. By Raúl Yeguas on 2013-05-01

Fixed LoadingComponent not being destroyed after data is loaded.

[Martin Borho (martin-borho)]

review: Approve

=== added file 'components/LoadingComponent.qml'
--- components/LoadingComponent.qml	1970-01-01 00:00:00 +0000
+++ components/LoadingComponent.qml	2013-05-01 16:39:24 +0000
@@ -0,0 +1,31 @@
+import QtQuick 2.0
+import Ubuntu.Components 0.1
+
+Rectangle {
+    Image {
+        id: image1
+        anchors.rightMargin: units.gu(10)
+        anchors.leftMargin: units.gu(10)
+        anchors.bottomMargin: units.gu(10)
+        anchors.topMargin: units.gu(10)
+        anchors.fill: parent
+        source: "../resources/images/ubuntu-logo.png"
+        fillMode: Image.PreserveAspectFit
+    }
+
+    RotationAnimation {
+        running: true
+        targets: image1
+        properties: "rotation"
+        from: 0
+        to: 360
+        loops: Animation.Infinite
+        duration: 5000
+    }
+
+    Text {
+        color: "#ffffff"
+        anchors.centerIn: parent
+        text: i18n.tr("Loading")
+    }
+}
 
=== added file 'resources/images/ubuntu-logo.png'
 Binary files resources/images/ubuntu-logo.png	1970-01-01 00:00:00 +0000 and resources/images/ubuntu-logo.png	2013-05-01 16:39:24 +0000 differ
=== modified file 'ubuntu-weather-app.qml'
--- ubuntu-weather-app.qml	2013-04-27 14:49:15 +0000
+++ ubuntu-weather-app.qml	2013-05-01 16:39:24 +0000
@@ -52,6 +52,8 @@
             tabsString += "Components.LocationTabEmpty { }"
         }
         tabsString += "}"; // END Tabs componen
+        if(loading != null)
+            loading.destroy();
         tabsObject = Qt.createQmlObject(tabsString, tabPage, "tabs")
     }
 
@@ -102,7 +104,7 @@
             id: tabs
             objectName: "Tabs"
             anchors.fill: parent
-            Tab {}
+            Tab {Components.LoadingComponent{id:loading; anchors.fill: parent}}
         }
     }
 }