Merge lp:~mwhudson/livecd-rootfs/lp-1743643 into lp:livecd-rootfs

[Michael Hudson-Doyle]

This is obviously vile but is it too vile? See https://bugs.launchpad.net/subiquity/+bug/1743643

[Ryan Harper (raharper)]

I'm +1 on this;

It could be useful to examine the original use-case for this feature; but generally it seems like a bad idea; if you don't have enough memory to run the live environment, swapping isn't going to give you a great experience and certainly going to cause issues when we swapoff and then trigger OOM.

[Steve Langasek (vorlon)]

Discussed with Michael on IRC various options that might be "cleaner" than removing a file belonging to a package, and none of them are so clean that I care to stand on ceremony - considering this bit of the casper code will only successfully run once at image build time, and the casper package will never be upgraded within the installer squashfs. +1.

review: Approve

=== modified file 'debian/changelog'
--- debian/changelog	2018-03-15 01:10:02 +0000
+++ debian/changelog	2018-03-15 07:28:30 +0000
@@ -1,3 +1,10 @@
+livecd-rootfs (2.511) UNRELEASED; urgency=medium
+
+  * In the live-server build, prevent casper from mounting any existing swap
+    partitions from drives we might later be installing to.
+
+ -- Michael Hudson-Doyle <[e-mail]>  Thu, 15 Mar 2018 20:23:27 +1300
+
 livecd-rootfs (2.510) bionic; urgency=medium
 
   * Rename the directory containing the systemd override file for subiquity to
 
=== modified file 'live-build/ubuntu-server/hooks/032-installer-squashfs.binary'
--- live-build/ubuntu-server/hooks/032-installer-squashfs.binary	2018-02-23 01:58:03 +0000
+++ live-build/ubuntu-server/hooks/032-installer-squashfs.binary	2018-03-15 07:28:30 +0000
@@ -53,6 +53,10 @@
 chroot $SQUASH_ROOT apt-get update
 chroot $SQUASH_ROOT apt-get -y install user-setup curtin lupin-casper
 
+# For bug #1743643 "Install to dirty disk with swap fails" remove the
+# "helpful" casper script that mounts any swap partitions it finds.
+rm -f $SQUASH_ROOT/usr/share/initramfs-tools/scripts/casper-bottom/*swap
+
 # Installing casper means we need a new initramfs
 UPDATE_INITRAMFS_OPTIONS=CASPER_GENERATE_UUID=1 recreate_initramfs $SQUASH_ROOT