Merge lp:~mvo/python-apt/mvo into lp:~ubuntu-core-dev/python-apt/ubuntu
Proposed by
Michael Vogt
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jason Conti (community) | Approve | ||
Ubuntu Core Development Team | Pending | ||
Review via email: mp+129630@code.launchpad.net |
Description of the change
The work from Jason Conti to fix leaking FDs
To post a comment you must log in.
Looks good to me overall. My only concern is that test_cache_ delete_ leasks_ fds() may fail in certain circumstances, and it happened to fail in my test rebuild. Python does eventually get around to deleting the records instance.
I like the other additional tests, and actually had a very similar test to test_cache_ close_download_ fails() but it didn't occur to me to include it for some reason. It also appears I completely missed the case about leaking fds on cache reopen, thanks for fixing it.