Merge lp:~mterry/unity8/less-ubuntucolors into lp:unity8
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Michael Terry | ||||
Approved revision: | 2332 | ||||
Merged at revision: | 2426 | ||||
Proposed branch: | lp:~mterry/unity8/less-ubuntucolors | ||||
Merge into: | lp:unity8 | ||||
Prerequisite: | lp:~unity-team/unity8/uitkPageHeader | ||||
Diff against target: |
211 lines (+17/-17) 15 files modified
plugins/Dash/AudioProgressBar.qml (+1/-1) plugins/Dash/ScopeStyle.qml (+1/-1) qml/Components/Dialogs.qml (+2/-2) qml/Components/ModeSwitchWarningDialog.qml (+1/-1) qml/Components/WindowControlButtons.qml (+1/-1) qml/Dash/DashPageHeader.qml (+1/-1) qml/Dash/Previews/PreviewActions.qml (+1/-1) qml/Dash/Previews/PreviewPayments.qml (+1/-1) qml/Launcher/LauncherDelegate.qml (+2/-2) qml/Panel/Panel.qml (+1/-1) qml/Stages/DecoratedWindow.qml (+1/-1) qml/Stages/DesktopSpread.qml (+1/-1) qml/Stages/DesktopSpreadDelegate.qml (+1/-1) qml/Stages/SpreadDelegate.qml (+1/-1) tests/plugins/Dash/tst_ScopeStyle.qml (+1/-1) |
||||
To merge this branch: | bzr merge lp:~mterry/unity8/less-ubuntucolors | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Unity8 CI Bot | continuous-integration | Pending | |
Andrea Cimitan | Pending | ||
Review via email: mp+294969@code.launchpad.net |
This proposal supersedes a proposal from 2016-05-16.
Commit message
Change some dash button colors from orange to green.
And switch other colors from hardcoded values to the same semantic theme value.
Description of the change
UbuntuColors should be avoided when possible. Instead we should use semantic color names from the theme. These are future-proof and potentially locale-proof (for locales where green and red mean different things -- which I heard was a thing, but can't find anything on it in a quick search).
Half this branch simply replaces some color names with the correct theme color. So no visual change there. But it also changes some colors:
plugins/
plugins/
qml/Dash/
qml/Dash/
qml/Dash/
I didn't change any uses of the various "grey" colors (slate, jet, charcoal, etc). That seemed a bit more fiddly and less user visible. But they should in theory be fixed down the road.
* Are there any related MPs required for this MP to build/function as expected? Please list.
Just the pre-req (lp:~cimi/unity8/uitkPageHeader)
* Did you perform an exploratory manual test run of your code change and any related functionality?
Not yet.. will do in a bit
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
NA
* If you changed the UI, has there been a design review?
No... Do we need one for just using the correct theme colors? The only border case I'd see is the purchase button -- maybe that's supposed to be branding-colored?
FAILED: Continuous integration, rev:2396 /unity8- jenkins. ubuntu. com/job/ lp-unity8- ci/1203/ /unity8- jenkins. ubuntu. com/job/ test-0- autopkgtest/ label=amd64, release= vivid+overlay, testname= qmluitests. sh/740 /unity8- jenkins. ubuntu. com/job/ test-0- autopkgtest/ label=amd64, release= xenial+ overlay, testname= qmluitests. sh/740 /unity8- jenkins. ubuntu. com/job/ build-0- fetch/1612 /unity8- jenkins. ubuntu. com/job/ build-1- sourcepkg/ release= vivid+overlay/ 1567 /unity8- jenkins. ubuntu. com/job/ build-1- sourcepkg/ release= xenial+ overlay/ 1567 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= vivid+overlay/ 1560 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= vivid+overlay/ 1560/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= xenial+ overlay/ 1560 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=amd64, release= xenial+ overlay/ 1560/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= vivid+overlay/ 1560 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= vivid+overlay/ 1560/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= xenial+ overlay/ 1560 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=armhf, release= xenial+ overlay/ 1560/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= vivid+overlay/ 1560 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= vivid+overlay/ 1560/artifact/ output/ *zip*/output. zip /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= xenial+ overlay/ 1560 /unity8- jenkins. ubuntu. com/job/ build-2- binpkg/ arch=i386, release= xenial+ overlay/ 1560/artifact/ output/ *zip*/output. zip
https:/
Executed test runs:
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild: /unity8- jenkins. ubuntu. com/job/ lp-unity8- ci/1203/ rebuild
https:/