Merge lp:~mterry/powerd/ussd-turn-on-screen-for-notification into lp:powerd

Proposed by Michael Terry
Status: Needs review
Proposed branch: lp:~mterry/powerd/ussd-turn-on-screen-for-notification
Merge into: lp:powerd
Diff against target: 11 lines (+1/-1)
1 file modified
src/powerd.cpp (+1/-1)
To merge this branch: bzr merge lp:~mterry/powerd/ussd-turn-on-screen-for-notification
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+267197@code.launchpad.net

Commit message

Use the NOTIFICATION reason when asking Unity System Compositor to wake up the screen for a UUSD message. This means the screen will only be on 15s instead of 60s.

This is a follow-on from using the NOTIFICATION reason for SMS messages [1]. But USSD messages should also be treated as notifications, right?

(I've left the CallAdded notification alone, since incoming rings last longer than 15s and it's a higher priority notification.)

[1] https://code.launchpad.net/~afrantzis/powerd/sms-turn-on-screen-for-notification/+merge/265271

Description of the change

Use the NOTIFICATION reason when asking Unity System Compositor to wake up the screen for a UUSD message. This means the screen will only be on 15s instead of 60s.

This is a follow-on from using the NOTIFICATION reason for SMS messages [1]. But USSD messages should also be treated as notifications, right?

(I've left the CallAdded notification alone, since incoming rings last longer than 15s and it's a higher priority notification.)

[1] https://code.launchpad.net/~afrantzis/powerd/sms-turn-on-screen-for-notification/+merge/265271

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Unmerged revisions

177. By Michael Terry

Use NOTIFICATION reason when waking the screen for a USSD message

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/powerd.cpp'
--- src/powerd.cpp 2015-07-20 14:53:30 +0000
+++ src/powerd.cpp 2015-08-06 14:13:35 +0000
@@ -300,7 +300,7 @@
300 (!strcmp(signal_name, "RequestReceived"))) && 300 (!strcmp(signal_name, "RequestReceived"))) &&
301 (call_added == 0)) {301 (call_added == 0)) {
302 powerd_debug("Waking up the device - Incoming USSD");302 powerd_debug("Waking up the device - Incoming USSD");
303 turn_display_on(TRUE, UNITY_SCREEN_REASON_NORMAL);303 turn_display_on(TRUE, UNITY_SCREEN_REASON_NOTIFICATION);
304 }304 }
305}305}
306306

Subscribers

People subscribed via source and target branches