BAMF

Merge lp:~mterry/bamf/no-show-indicators into lp:bamf/0.4

  1. no-show-indicators
  2. Merge into 0.4
Proposed by Michael Terry
Status: Rejected
Rejected by: Michal Hruby
Proposed branch: lp:~mterry/bamf/no-show-indicators
Merge into: lp:bamf/0.4
Diff against target: 20 lines (+0/-4)
1 file modified
src/bamf-application.c (+0/-4)
To merge this branch: bzr merge lp:~mterry/bamf/no-show-indicators
Reviewer Review Type Date Requested Status
Jason Smith (community) Disapprove
Review via email: mp+43293@code.launchpad.net

Description of the change

This fixes bug 685634, which is about applications that run as only indicators (not windows) still showing up in the launcher.

To post a comment you must log in.
Revision history for this message
Jason Smith (jassmith) wrote :

This would break Tomboy/Rhythmbox/Banshee/Gwibber interactions

review: Disapprove

Unmerged revisions

369. By Michael Terry

don't show indicators in unity launcher

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/bamf-application.c'
--- src/bamf-application.c 2010-09-22 14:45:03 +0000
+++ src/bamf-application.c 2010-12-09 21:10:22 +0000
@@ -22,7 +22,6 @@
22#include "bamf-application-glue.h"22#include "bamf-application-glue.h"
23#include "bamf-window.h"23#include "bamf-window.h"
24#include "bamf-matcher.h"24#include "bamf-matcher.h"
25#include "bamf-indicator.h"
26#include "bamf-legacy-window.h"25#include "bamf-legacy-window.h"
27#include "bamf-legacy-screen.h"26#include "bamf-legacy-screen.h"
28#include <string.h>27#include <string.h>
@@ -321,9 +320,6 @@
321320
322 running = TRUE;321 running = TRUE;
323 322
324 if (BAMF_IS_INDICATOR (view))
325 visible = TRUE;
326
327 if (!BAMF_IS_WINDOW (view))323 if (!BAMF_IS_WINDOW (view))
328 continue;324 continue;
329325

Subscribers

People subscribed via source and target branches