Merge lp:~milo/linaro-image-tools/pep8-fixes into lp:linaro-image-tools/11.11

Proposed by Milo Casagrande
Status: Merged
Approved by: Georgy Redkozubov
Approved revision: no longer in the source branch.
Merged at revision: 626
Proposed branch: lp:~milo/linaro-image-tools/pep8-fixes
Merge into: lp:linaro-image-tools/11.11
Diff against target: 68 lines (+7/-7)
5 files modified
linaro_image_tools/hwpack/tests/test_config.py (+3/-3)
linaro_image_tools/hwpack/tests/test_hardwarepack.py (+1/-1)
linaro_image_tools/media_create/boards.py (+1/-1)
linaro_image_tools/media_create/tests/test_media_create.py (+1/-1)
linaro_image_tools/tests/test_utils.py (+1/-1)
To merge this branch: bzr merge lp:~milo/linaro-image-tools/pep8-fixes
Reviewer Review Type Date Requested Status
Georgy Redkozubov Approve
Review via email: mp+171742@code.launchpad.net

Description of the change

Some PEP8 fixes.

To post a comment you must log in.
Revision history for this message
Georgy Redkozubov (gesha) wrote :

Looks good

review: Approve
626. By Milo Casagrande

PEP8 fixes.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'linaro_image_tools/hwpack/tests/test_config.py'
--- linaro_image_tools/hwpack/tests/test_config.py 2013-02-18 09:40:15 +0000
+++ linaro_image_tools/hwpack/tests/test_config.py 2013-06-27 09:08:30 +0000
@@ -304,9 +304,9 @@
304 def test_validate_partition_layout(self):304 def test_validate_partition_layout(self):
305 partition_layout = 'apafs_bananfs'305 partition_layout = 'apafs_bananfs'
306 config = self.get_config(self.valid_start_v2 + "u_boot_package = "306 config = self.get_config(self.valid_start_v2 + "u_boot_package = "
307 "u-boot-linaro-s5pv310\nu_boot_file = "307 "u-boot-linaro-s5pv310\nu_boot_file = "
308 "u-boot.bin\npartition_layout = %s\n" %308 "u-boot.bin\npartition_layout = %s\n" %
309 partition_layout)309 partition_layout)
310 self.assertValidationError(310 self.assertValidationError(
311 "Undefined partition layout %s in the [%s] section. "311 "Undefined partition layout %s in the [%s] section. "
312 "Valid partition layouts are %s."312 "Valid partition layouts are %s."
313313
=== modified file 'linaro_image_tools/hwpack/tests/test_hardwarepack.py'
--- linaro_image_tools/hwpack/tests/test_hardwarepack.py 2013-02-17 13:53:41 +0000
+++ linaro_image_tools/hwpack/tests/test_hardwarepack.py 2013-06-27 09:08:30 +0000
@@ -443,7 +443,7 @@
443 self.assertThat(443 self.assertThat(
444 tf,444 tf,
445 HardwarePackHasFile("pkgs/%s" % package1.filename,445 HardwarePackHasFile("pkgs/%s" % package1.filename,
446 content=package1.content.read()))446 content=package1.content.read()))
447 self.assertThat(447 self.assertThat(
448 tf,448 tf,
449 HardwarePackHasFile("pkgs/%s" % package2.filename,449 HardwarePackHasFile("pkgs/%s" % package2.filename,
450450
=== modified file 'linaro_image_tools/media_create/boards.py'
--- linaro_image_tools/media_create/boards.py 2013-05-23 17:29:29 +0000
+++ linaro_image_tools/media_create/boards.py 2013-06-27 09:08:30 +0000
@@ -1169,7 +1169,7 @@
1169 self.delete_file(toc_filename)1169 self.delete_file(toc_filename)
1170 if self.delete_startupfiles:1170 if self.delete_startupfiles:
1171 self.delete_file(os.path.join(config_files_dir,1171 self.delete_file(os.path.join(config_files_dir,
1172 self.snowball_startup_files_config))1172 self.snowball_startup_files_config))
11731173
1174 def snowball_config(self, chroot_dir):1174 def snowball_config(self, chroot_dir):
1175 # We will find the startupfiles in the target boot partition.1175 # We will find the startupfiles in the target boot partition.
11761176
=== modified file 'linaro_image_tools/media_create/tests/test_media_create.py'
--- linaro_image_tools/media_create/tests/test_media_create.py 2013-05-23 17:57:10 +0000
+++ linaro_image_tools/media_create/tests/test_media_create.py 2013-06-27 09:08:30 +0000
@@ -2987,7 +2987,7 @@
2987 self.linux_offsets_and_sizes = [2987 self.linux_offsets_and_sizes = [
2988 (16384 * SECTOR_SIZE, 15746 * SECTOR_SIZE),2988 (16384 * SECTOR_SIZE, 15746 * SECTOR_SIZE),
2989 (32768 * SECTOR_SIZE, (self.linux_image_size -2989 (32768 * SECTOR_SIZE, (self.linux_image_size -
2990 32768 * SECTOR_SIZE))2990 32768 * SECTOR_SIZE))
2991 ]2991 ]
2992 self.android_image_size = 256 * 1024 ** 22992 self.android_image_size = 256 * 1024 ** 2
2993 # Extended partition info takes 32 sectors from the first ext partition2993 # Extended partition info takes 32 sectors from the first ext partition
29942994
=== modified file 'linaro_image_tools/tests/test_utils.py'
--- linaro_image_tools/tests/test_utils.py 2013-02-25 18:31:26 +0000
+++ linaro_image_tools/tests/test_utils.py 2013-06-27 09:08:30 +0000
@@ -280,7 +280,7 @@
280 else:280 else:
281 self.assertEqual(281 self.assertEqual(
282 ['apt-get -s install dosfstools',282 ['apt-get -s install dosfstools',
283 '%s apt-get --yes install dosfstools' % sudo_args],283 '%s apt-get --yes install dosfstools' % sudo_args],
284 fixture.mock.commands_executed)284 fixture.mock.commands_executed)
285285
286 def test_package_installation_refused(self):286 def test_package_installation_refused(self):

Subscribers

People subscribed via source and target branches