Merge lp:~milo/linaro-image-tools/bug1095747 into lp:linaro-image-tools/11.11

Proposed by Milo Casagrande
Status: Merged
Approved by: James Tunnicliffe
Approved revision: 617
Merged at revision: 618
Proposed branch: lp:~milo/linaro-image-tools/bug1095747
Merge into: lp:linaro-image-tools/11.11
Diff against target: 26 lines (+3/-2)
2 files modified
linaro_image_tools/media_create/boards.py (+1/-0)
linaro_image_tools/media_create/tests/test_media_create.py (+2/-2)
To merge this branch: bzr merge lp:~milo/linaro-image-tools/bug1095747
Reviewer Review Type Date Requested Status
James Tunnicliffe (community) Approve
Review via email: mp+156815@code.launchpad.net

Description of the change

As reported on bug 1095747 comment #3, it should be sufficient to change the
MMC option for Snowball EMMC board to '0:2'.

Branch does that, and fixed a test.

To post a comment you must log in.
Revision history for this message
James Tunnicliffe (dooferlad) wrote :

Looks good. Thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'linaro_image_tools/media_create/boards.py'
--- linaro_image_tools/media_create/boards.py 2013-03-26 09:08:58 +0000
+++ linaro_image_tools/media_create/boards.py 2013-04-03 11:48:23 +0000
@@ -1089,6 +1089,7 @@
1089 # puts the MBR, so the boot loader skips that address.1089 # puts the MBR, so the boot loader skips that address.
1090 self.supports_writing_to_mmc = False1090 self.supports_writing_to_mmc = False
1091 self.snowball_startup_files_config = 'startfiles.cfg'1091 self.snowball_startup_files_config = 'startfiles.cfg'
1092 self.mmc_option = '0:2'
10921093
1093 def get_v1_sfdisk_cmd(self, should_align_boot_part=None):1094 def get_v1_sfdisk_cmd(self, should_align_boot_part=None):
1094 """Return the sfdisk command to partition the media.1095 """Return the sfdisk command to partition the media.
10951096
=== modified file 'linaro_image_tools/media_create/tests/test_media_create.py'
--- linaro_image_tools/media_create/tests/test_media_create.py 2013-03-26 08:59:38 +0000
+++ linaro_image_tools/media_create/tests/test_media_create.py 2013-04-03 11:48:23 +0000
@@ -2102,8 +2102,8 @@
2102 'mem_modem=32M@96M mem=44M@128M pmem=22M@172M '2102 'mem_modem=32M@96M mem=44M@128M pmem=22M@172M '
2103 'mem=30M@194M mem_mali=32M@224M pmem_hwb=54M@256M '2103 'mem=30M@194M mem_mali=32M@224M pmem_hwb=54M@256M '
2104 'hwmem=48M@302M mem=152M@360M',2104 'hwmem=48M@302M mem=152M@360M',
2105 'bootcmd': 'fatload mmc 1:1 0x00100000 uImage; '2105 'bootcmd': 'fatload mmc 0:2 0x00100000 uImage; '
2106 'fatload mmc 1:1 0x08000000 uInitrd; '2106 'fatload mmc 0:2 0x08000000 uInitrd; '
2107 'bootm 0x00100000 0x08000000',2107 'bootm 0x00100000 0x08000000',
2108 'fdt_high': '0xffffffff',2108 'fdt_high': '0xffffffff',
2109 'initrd_high': '0xffffffff'}2109 'initrd_high': '0xffffffff'}

Subscribers

People subscribed via source and target branches