Merge lp:~milo/lava-tool/integration-tests-fixes into lp:~linaro-validation/lava-tool/trunk

Proposed by Milo Casagrande
Status: Merged
Merged at revision: 189
Proposed branch: lp:~milo/lava-tool/integration-tests-fixes
Merge into: lp:~linaro-validation/lava-tool/trunk
Diff against target: 44 lines (+4/-5)
3 files modified
integration-tests.d/lava-job-new-with-config.sh (+2/-2)
integration-tests.d/lava-job-submit.sh (+1/-1)
integration-tests.d/lib/server.py (+1/-2)
To merge this branch: bzr merge lp:~milo/lava-tool/integration-tests-fixes
Reviewer Review Type Date Requested Status
Antonio Terceiro Approve
Linaro Validation Team Pending
Review via email: mp+177637@code.launchpad.net

Description of the change

The merge proposal fixes two integration tests failing.
Changes are explained in more detail in the commits:
- Enabled non "interactiveness" of the command line
- Renamed a parameter
- Changed how the server and rpc_endpoint parameters are treated (this might change again though, since to me it's not clear how they should really be used and the parameter names are generic enough).

To post a comment you must log in.
191. By Milo Casagrande

Corrected server/rpc_endpoint usage.

Revision history for this message
Milo Casagrande (milo) wrote :

Pushed a new change since there is another MP that fixes the logic of the server/rpc_endpoint parameters in the actual lava-tool code.

192. By Milo Casagrande

Added trailing slash support for flask URL.

Revision history for this message
Antonio Terceiro (terceiro) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'integration-tests.d/lava-job-new-with-config.sh'
--- integration-tests.d/lava-job-new-with-config.sh 2013-05-28 22:08:12 +0000
+++ integration-tests.d/lava-job-new-with-config.sh 2013-07-31 13:28:30 +0000
@@ -3,8 +3,8 @@
3device_type = panda3device_type = panda
44
5[device_type=panda]5[device_type=panda]
6prebuilt_image = file:///path/to/panda.img6image = file:///path/to/panda.img
7EOF7EOF
8LAVACONFIG="${tmpdir}/config" lava job new "${tmpdir}/job.json"8LAVACONFIG="${tmpdir}/config" lava job new "${tmpdir}/job.json" -n
9cat "${tmpdir}/job.json"9cat "${tmpdir}/job.json"
10grep "device_type.*panda" "${tmpdir}/job.json" && grep "image.*path.to.panda.img" "${tmpdir}/job.json"10grep "device_type.*panda" "${tmpdir}/job.json" && grep "image.*path.to.panda.img" "${tmpdir}/job.json"
1111
=== modified file 'integration-tests.d/lava-job-submit.sh'
--- integration-tests.d/lava-job-submit.sh 2013-06-03 18:06:49 +0000
+++ integration-tests.d/lava-job-submit.sh 2013-07-31 13:28:30 +0000
@@ -8,5 +8,5 @@
8rpc_endpoint = http://localhost:5000/ok8rpc_endpoint = http://localhost:5000/ok
9CONFIG9CONFIG
1010
11lava job submit integration-tests.d/sample/nexus.json > $tmpdir/output11lava job submit integration-tests.d/sample/nexus.json -n > $tmpdir/output
12grep "Job submitted with job ID 999" $tmpdir/output12grep "Job submitted with job ID 999" $tmpdir/output
1313
=== modified file 'integration-tests.d/lib/server.py'
--- integration-tests.d/lib/server.py 2013-06-03 18:06:49 +0000
+++ integration-tests.d/lib/server.py 2013-07-31 13:28:30 +0000
@@ -1,5 +1,4 @@
1import os1import os
2import sys
3import yaml2import yaml
43
5from flask import (4from flask import (
@@ -25,7 +24,7 @@
25 request.environ['werkzeug.server.shutdown']()24 request.environ['werkzeug.server.shutdown']()
26 return ""25 return ""
2726
28@app.route('/<status_code>', methods=['GET', 'POST'])27@app.route('/<status_code>/', methods=['GET', 'POST'])
29def reply(status_code):28def reply(status_code):
3029
31 status = int(aliases.get(status_code, status_code))30 status = int(aliases.get(status_code, status_code))

Subscribers

People subscribed via source and target branches