Merge lp:~milo/launchpad-work-items-tracker/bug996948 into lp:~linaro-automation/launchpad-work-items-tracker/linaro

[Milo Casagrande]

Merge proposal in order to fix the integrity error we receive from status.l.o.

Changes done:
- catch the integrity error and print warning with name of duplicated Blueprint
- skip the Blueprint and continue, otherwise script will fail later in the code due to variable not being set

[Paul Sokolovsky (pfalcon)]

I'm not sure this should be a warning. This condition is clearly makes the application not worked as intended (not to process its work items), so this should be an error. Definitely not a fatal, so continuing is nice. "Needs fixing"

Other thing I was thinking about was showing both old and new blueprints - while the current patch is nice and easy, in real world situation, I guess a stakeholder would like to know both offending blueprints. I'd defer to stakeholders though (would definitely require more time to implement).

review: Needs Fixing

[Milo Casagrande (milo)]

> I'm not sure this should be a warning. This condition is clearly makes the
> application not worked as intended (not to process its work items), so this
> should be an error. Definitely not a fatal, so continuing is nice. "Needs
> fixing"

Sure, not a problem.
Am not sure about including the error too though.

> Other thing I was thinking about was showing both old and new blueprints -
> while the current patch is nice and easy, in real world situation, I guess a
> stakeholder would like to know both offending blueprints. I'd defer to
> stakeholders though (would definitely require more time to implement).

Something more can be written, for sure. Getting also the "old" Blueprint means we will have to perform another DB lookup though, since we only have the "new-duplicated" Blueprint, not the one already in the DB. I can easily add the Blueprint URL, at least for the new one, since it should be the one to be modified at least.

[lp:~milo/launchpad-work-items-tracker/bug996948]

344. By Milo Casagrande on 2012-10-09

Used error logger, added URL to Blueprint.

[Milo Casagrande (milo)]

Ok, I fixed the logger usage, and manage also to retrieve the URL of at least the "new-duplicated" Blueprint.

[Paul Sokolovsky (pfalcon)]

Great, thanks for investigating that!

review: Approve

=== modified file 'collect'
--- collect	2012-08-08 12:38:10 +0000
+++ collect	2012-10-09 13:12:22 +0000
@@ -15,6 +15,7 @@
 import sys
 import urllib
 import urlparse
+import sqlite3
 
 from email.mime.text import MIMEText
 
@@ -223,8 +224,15 @@
     in_complexity_block = False
     work_items = []
 
-    model_bp = collector.store.find(
-        Blueprint, Blueprint.name == bp.name).one()
+    try:
+        model_bp = collector.store.find(Blueprint,
+                                        Blueprint.name == bp.name).one()
+    except sqlite3.IntegrityError:
+        logger.error('Duplicated Blueprint found: %s. It will not be '
+                     'considered. Blueprint URL is: %s' % bp.name)
+        logger.error('Blueprint URL is: %s' % bp.specification_url)
+        return
+
     assert model_bp is not None, \
         "Asked to process workitems of %s when it is not in the db" % bp.name