Merge lp:~midori/midori/preferences-headerbar into lp:midori

Proposed by Cris Dywan
Status: Needs review
Proposed branch: lp:~midori/midori/preferences-headerbar
Merge into: lp:midori
Prerequisite: lp:~midori/midori/webKit2Gtk3only
Diff against target: 58 lines (+16/-0)
2 files modified
katze/katze-preferences.c (+13/-0)
midori/midori-preferences.c (+3/-0)
To merge this branch: bzr merge lp:~midori/midori/preferences-headerbar
Reviewer Review Type Date Requested Status
Midori Devs Pending
Review via email: mp+333296@code.launchpad.net

This proposal supersedes a proposal from 2017-10-05.

Commit message

Use HeaderBar in preferences dialog

To post a comment you must log in.

Unmerged revisions

7167. By Cris Dywan

Merge lp:~midori/midori/webKit2Gtk3only

7166. By Cris Dywan

Use HeaderBar in preferences dialog

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'katze/katze-preferences.c'
--- katze/katze-preferences.c 2017-11-07 01:26:47 +0000
+++ katze/katze-preferences.c 2017-11-07 01:26:47 +0000
@@ -71,6 +71,8 @@
71 g_free (dialog_title);71 g_free (dialog_title);
7272
73 #if !HAVE_OSX73 #if !HAVE_OSX
74 if (g_strcmp0 (g_getenv ("GTK_CSD"), "1"))
75 {
74 gtk_dialog_add_buttons (GTK_DIALOG (preferences),76 gtk_dialog_add_buttons (GTK_DIALOG (preferences),
75 GTK_STOCK_HELP, GTK_RESPONSE_HELP,77 GTK_STOCK_HELP, GTK_RESPONSE_HELP,
76 NULL);78 NULL);
@@ -80,6 +82,7 @@
80 gtk_dialog_add_buttons (GTK_DIALOG (preferences),82 gtk_dialog_add_buttons (GTK_DIALOG (preferences),
81 GTK_STOCK_CLOSE, GTK_RESPONSE_CLOSE,83 GTK_STOCK_CLOSE, GTK_RESPONSE_CLOSE,
82 NULL);84 NULL);
85 }
83 #endif86 #endif
8487
85 g_object_connect (preferences,88 g_object_connect (preferences,
@@ -154,6 +157,16 @@
154 priv->toolbar = gtk_stack_switcher_new ();157 priv->toolbar = gtk_stack_switcher_new ();
155 gtk_stack_switcher_set_stack (GTK_STACK_SWITCHER (priv->toolbar), GTK_STACK (priv->notebook));158 gtk_stack_switcher_set_stack (GTK_STACK_SWITCHER (priv->toolbar), GTK_STACK (priv->notebook));
156 gtk_widget_set_halign (priv->toolbar, GTK_ALIGN_CENTER);159 gtk_widget_set_halign (priv->toolbar, GTK_ALIGN_CENTER);
160 if (!g_strcmp0 (g_getenv ("GTK_CSD"), "1"))
161 {
162 GtkWidget* headerbar = gtk_header_bar_new ();
163 gtk_header_bar_set_show_close_button (GTK_HEADER_BAR (headerbar), TRUE);
164 gtk_header_bar_set_custom_title (GTK_HEADER_BAR (headerbar), priv->toolbar);
165 gtk_widget_show (headerbar);
166 gtk_window_set_titlebar (GTK_WINDOW (preferences), headerbar);
167 gtk_widget_show (priv->toolbar);
168 }
169 else
157 gtk_box_pack_start (GTK_BOX (gtk_dialog_get_content_area (GTK_DIALOG (preferences))),170 gtk_box_pack_start (GTK_BOX (gtk_dialog_get_content_area (GTK_DIALOG (preferences))),
158 priv->toolbar, FALSE, FALSE, 0);171 priv->toolbar, FALSE, FALSE, 0);
159 #endif172 #endif
160173
=== modified file 'midori/midori-preferences.c'
--- midori/midori-preferences.c 2015-07-06 21:26:46 +0000
+++ midori/midori-preferences.c 2017-11-07 01:26:47 +0000
@@ -262,6 +262,8 @@
262262
263 g_object_get (preferences, "transient-for", &parent, NULL);263 g_object_get (preferences, "transient-for", &parent, NULL);
264 icon_name = parent ? gtk_window_get_icon_name (parent) : NULL;264 icon_name = parent ? gtk_window_get_icon_name (parent) : NULL;
265 if (g_strcmp0 (g_getenv ("GTK_CSD"), "1"))
266 {
265 if ((header = sokoke_xfce_header_new (icon_name,267 if ((header = sokoke_xfce_header_new (icon_name,
266 gtk_window_get_title (GTK_WINDOW (preferences)))))268 gtk_window_get_title (GTK_WINDOW (preferences)))))
267 {269 {
@@ -269,6 +271,7 @@
269 gtk_box_pack_start (GTK_BOX (vbox), header, FALSE, FALSE, 0);271 gtk_box_pack_start (GTK_BOX (vbox), header, FALSE, FALSE, 0);
270 gtk_widget_show_all (header);272 gtk_widget_show_all (header);
271 }273 }
274 }
272 _preferences = KATZE_PREFERENCES (preferences);275 _preferences = KATZE_PREFERENCES (preferences);
273276
274 #define PAGE_NEW(__icon, __label) \277 #define PAGE_NEW(__icon, __label) \

Subscribers

People subscribed via source and target branches

to all changes: