Merge lp:~michael-sheldon/ubuntu-system-settings/fix-wallpaper-preview into lp:ubuntu-system-settings

Proposed by Michael Sheldon
Status: Merged
Approved by: Ken VanDine
Approved revision: 1775
Merged at revision: 1775
Proposed branch: lp:~michael-sheldon/ubuntu-system-settings/fix-wallpaper-preview
Merge into: lp:ubuntu-system-settings
Diff against target: 40 lines (+8/-3)
2 files modified
plugins/background/Preview.qml (+8/-2)
tests/autopilot/ubuntu_system_settings/tests/ofono.py (+0/-1)
To merge this branch: bzr merge lp:~michael-sheldon/ubuntu-system-settings/fix-wallpaper-preview
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Approve
Ubuntu Touch System Settings Pending
Review via email: mp+321234@code.launchpad.net

Commit message

Stop wallpaper preview overlapping buttons and fix flake8 test.

Description of the change

Stop wallpaper preview overlapping buttons and fix flake8 test.

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

PASSED: Continuous integration, rev:1775
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/26/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build/2364
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2364
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2181
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2181/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2181
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2181/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2181
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2181/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2181
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2181/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2181
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2181/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2181
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2181/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/26/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'plugins/background/Preview.qml'
--- plugins/background/Preview.qml 2017-01-12 12:38:45 +0000
+++ plugins/background/Preview.qml 2017-03-28 23:45:02 +0000
@@ -70,7 +70,12 @@
7070
71 Image {71 Image {
72 id: previewImage72 id: previewImage
73 anchors.fill: parent73 anchors {
74 top: parent.top
75 left: parent.left
76 right: parent.right
77 bottom: divider.top
78 }
74 source: uri79 source: uri
75 sourceSize.height: height80 sourceSize.height: height
76 sourceSize.width: 081 sourceSize.width: 0
@@ -78,8 +83,9 @@
78 }83 }
7984
80 ListItem.ThinDivider {85 ListItem.ThinDivider {
86 id: divider
81 anchors.bottom: previewButtons.top87 anchors.bottom: previewButtons.top
82 anchors.bottomMargin: units.gu(1)88 anchors.bottomMargin: units.gu(2)
83 }89 }
8490
85 ListItem.Base {91 ListItem.Base {
8692
=== modified file 'tests/autopilot/ubuntu_system_settings/tests/ofono.py'
--- tests/autopilot/ubuntu_system_settings/tests/ofono.py 2015-08-10 11:01:34 +0000
+++ tests/autopilot/ubuntu_system_settings/tests/ofono.py 2017-03-28 23:45:02 +0000
@@ -357,7 +357,6 @@
357 'LineIdentification': dbus.String(number, variant_level=1),357 'LineIdentification': dbus.String(number, variant_level=1),
358 'Name': dbus.String('', variant_level=1),358 'Name': dbus.String('', variant_level=1),
359 'Multiparty': dbus.Boolean(False, variant_level=1),359 'Multiparty': dbus.Boolean(False, variant_level=1),
360 'Multiparty': dbus.Boolean(False, variant_level=1),
361 'RemoteHeld': dbus.Boolean(False, variant_level=1),360 'RemoteHeld': dbus.Boolean(False, variant_level=1),
362 'RemoteMultiparty': dbus.Boolean(False, variant_level=1),361 'RemoteMultiparty': dbus.Boolean(False, variant_level=1),
363 'Emergency': dbus.Boolean(False, variant_level=1),362 'Emergency': dbus.Boolean(False, variant_level=1),

Subscribers

People subscribed via source and target branches