Merge lp:~michael-sheldon/ubuntu-system-settings/fix-language-panel-list-item-click into lp:ubuntu-system-settings

Proposed by Michael Sheldon
Status: Merged
Approved by: Ken VanDine
Approved revision: 1769
Merged at revision: 1774
Proposed branch: lp:~michael-sheldon/ubuntu-system-settings/fix-language-panel-list-item-click
Merge into: lp:ubuntu-system-settings
Diff against target: 14 lines (+4/-0)
1 file modified
plugins/language/KeyboardLayoutItem.qml (+4/-0)
To merge this branch: bzr merge lp:~michael-sheldon/ubuntu-system-settings/fix-language-panel-list-item-click
Reviewer Review Type Date Requested Status
Ken VanDine Approve
system-apps-ci-bot continuous-integration Approve
Review via email: mp+321174@code.launchpad.net

Commit message

Trigger checkbox when clicking listitems in the language panel

Description of the change

Trigger checkbox when clicking listitems in the language panel

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

PASSED: Continuous integration, rev:1769
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/23/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build/2361
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2361
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2178
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2178/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2178
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2178/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2178
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2178/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2178
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2178/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2178
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2178/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2178
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2178/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/23/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Nice catch, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'plugins/language/KeyboardLayoutItem.qml'
--- plugins/language/KeyboardLayoutItem.qml 2016-07-12 16:40:18 +0000
+++ plugins/language/KeyboardLayoutItem.qml 2017-03-28 12:31:14 +0000
@@ -33,6 +33,10 @@
33 signal dragStarted()33 signal dragStarted()
34 signal dragFinished()34 signal dragFinished()
3535
36 onClicked: {
37 checkBox.checked = !checkBox.checked
38 }
39
36 Rectangle {40 Rectangle {
37 id: icon41 id: icon
38 anchors {42 anchors {

Subscribers

People subscribed via source and target branches