Merge lp:~mgorven/ibid/setup-permissions-339470 into lp:~ibid-core/ibid/old-trunk-pack-0.92

Proposed by Michael Gorven
Status: Merged
Approved by: Jonathan Hitchcock
Approved revision: 595
Merged at revision: 598
Proposed branch: lp:~mgorven/ibid/setup-permissions-339470
Merge into: lp:~ibid-core/ibid/old-trunk-pack-0.92
Diff against target: None lines
To merge this branch: bzr merge lp:~mgorven/ibid/setup-permissions-339470
Reviewer Review Type Date Requested Status
Jonathan Hitchcock Approve
Stefano Rivera Approve
Review via email: mp+5675@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Michael Gorven (mgorven) wrote :

Adds eval permission to the default set granted to the bot owner. I haven't
added permissions which are granted to everyone by default (factoid, karma,
sendmemo, recvmemo, feeds). Should these go in?

Revision history for this message
Stefano Rivera (stefanor) wrote :

> Should these go in?

I can see arguments both ways. There's less maintenance hassle if we don't.

Revision history for this message
Stefano Rivera (stefanor) wrote :

Well, I approve it either way.

review: Approve
Revision history for this message
Jonathan Hitchcock (vhata) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'scripts/ibid-setup'
--- scripts/ibid-setup 2009-04-14 10:17:42 +0000
+++ scripts/ibid-setup 2009-04-17 23:12:45 +0000
@@ -91,7 +91,7 @@
91 u'accounts', u'sources', u'plugins',91 u'accounts', u'sources', u'plugins',
92 u'core', u'admin', u'config',92 u'core', u'admin', u'config',
93 u'saydo', u'factoid', u'factoidadmin',93 u'saydo', u'factoid', u'factoidadmin',
94 u'karma', u'karmaadmin'):94 u'karma', u'karmaadmin', u'eval'):
95 perm = Permission(permission, u'auth')95 perm = Permission(permission, u'auth')
96 account.permissions.append(perm)96 account.permissions.append(perm)
9797

Subscribers

People subscribed via source and target branches