Merge lp:~mcintire-evan/ubuntu-terminal-app/toggle_keyboard into lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot

Proposed by Evan McIntire
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 144
Merged at revision: 147
Proposed branch: lp:~mcintire-evan/ubuntu-terminal-app/toggle_keyboard
Merge into: lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot
Diff against target: 104 lines (+28/-12)
4 files modified
po/com.ubuntu.terminal.pot (+7/-3)
src/app/qml/SettingsPage.qml (+8/-0)
src/app/qml/TerminalPage.qml (+11/-9)
src/app/qml/TerminalSettings.qml (+2/-0)
To merge this branch: bzr merge lp:~mcintire-evan/ubuntu-terminal-app/toggle_keyboard
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Review via email: mp+281005@code.launchpad.net

Commit message

Added an option to toggle the visibility of the keyboard button.

Description of the change

Added an option to toggle the visibility of the keyboard button.

To post a comment you must log in.
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

This is great, thanks Evan!

review: Approve
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'po/com.ubuntu.terminal.pot'
--- po/com.ubuntu.terminal.pot 2015-08-09 14:03:25 +0000
+++ po/com.ubuntu.terminal.pot 2015-12-19 05:16:44 +0000
@@ -8,7 +8,7 @@
8msgstr ""8msgstr ""
9"Project-Id-Version: \n"9"Project-Id-Version: \n"
10"Report-Msgid-Bugs-To: \n"10"Report-Msgid-Bugs-To: \n"
11"POT-Creation-Date: 2015-08-09 16:01+0200\n"11"POT-Creation-Date: 2015-12-19 00:08-0500\n"
12"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"12"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
13"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"13"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
14"Language-Team: LANGUAGE <LL@li.org>\n"14"Language-Team: LANGUAGE <LL@li.org>\n"
@@ -161,11 +161,15 @@
161msgid "Show Keyboard Bar"161msgid "Show Keyboard Bar"
162msgstr ""162msgstr ""
163163
164#: ../src/app/qml/SettingsPage.qml:52164#: ../src/app/qml/SettingsPage.qml:50
165msgid "Show Keyboard Button"
166msgstr ""
167
168#: ../src/app/qml/SettingsPage.qml:60
165msgid "Font Size:"169msgid "Font Size:"
166msgstr ""170msgstr ""
167171
168#: ../src/app/qml/SettingsPage.qml:85172#: ../src/app/qml/SettingsPage.qml:93
169msgid "Color Scheme"173msgid "Color Scheme"
170msgstr ""174msgstr ""
171175
172176
=== modified file 'src/app/qml/SettingsPage.qml'
--- src/app/qml/SettingsPage.qml 2015-07-13 20:25:21 +0000
+++ src/app/qml/SettingsPage.qml 2015-12-19 05:16:44 +0000
@@ -46,6 +46,14 @@
46 }46 }
47 }47 }
4848
49 ListItem.Standard {
50 text: i18n.tr("Show Keyboard Button")
51 control: Switch {
52 onCheckedChanged: settings.showKeyboardButton = checked;
53 Component.onCompleted: checked = settings.showKeyboardButton;
54 }
55 }
56
49 ListItem.Empty {57 ListItem.Empty {
50 height: units.gu(10)58 height: units.gu(10)
51 Label {59 Label {
5260
=== modified file 'src/app/qml/TerminalPage.qml'
--- src/app/qml/TerminalPage.qml 2015-07-13 20:25:21 +0000
+++ src/app/qml/TerminalPage.qml 2015-12-19 05:16:44 +0000
@@ -210,20 +210,22 @@
210 }210 }
211 }211 }
212212
213 CircularTransparentButton {213 Loader {
214 id: keyboardButton214 id: keyboardButton
215215 active: settings.showKeyboardButton
216 anchors {right: parent.right; margins: units.gu(1)}216 anchors {right: parent.right; margins: units.gu(1)}
217217
218 y: parent.height - height - units.gu(1) - keyboardBarLoader.height218 y: parent.height - height - units.gu(1) - keyboardBarLoader.height
219219
220 innerOpacity: 0.6220 sourceComponent: CircularTransparentButton {
221 border {color: UbuntuColors.orange; width: units.dp(2)}221 innerOpacity: 0.6
222 action: Action {222 border {color: UbuntuColors.orange; width: units.dp(2)}
223 iconName: "input-keyboard-symbolic"223 action: Action {
224 onTriggered: {224 iconName: "input-keyboard-symbolic"
225 Qt.inputMethod.show();225 onTriggered: {
226 terminal.forceActiveFocus();226 Qt.inputMethod.show();
227 terminal.forceActiveFocus();
228 }
227 }229 }
228 }230 }
229 }231 }
230232
=== modified file 'src/app/qml/TerminalSettings.qml'
--- src/app/qml/TerminalSettings.qml 2015-11-12 12:33:24 +0000
+++ src/app/qml/TerminalSettings.qml 2015-12-19 05:16:44 +0000
@@ -9,6 +9,7 @@
9 property alias fontStyle: innerSettings.fontStyle9 property alias fontStyle: innerSettings.fontStyle
10 property alias colorScheme: innerSettings.colorScheme10 property alias colorScheme: innerSettings.colorScheme
11 property alias showKeyboardBar: innerSettings.showKeyboardBar11 property alias showKeyboardBar: innerSettings.showKeyboardBar
12 property alias showKeyboardButton: innerSettings.showKeyboardButton
1213
13 readonly property int defaultFontSize: units.gu(0.4)14 readonly property int defaultFontSize: units.gu(0.4)
14 readonly property int minFontSize: 215 readonly property int minFontSize: 2
@@ -39,6 +40,7 @@
39 property string fontStyle: "Ubuntu Mono"40 property string fontStyle: "Ubuntu Mono"
40 property string colorScheme: "Ubuntu"41 property string colorScheme: "Ubuntu"
41 property bool showKeyboardBar: true42 property bool showKeyboardBar: true
43 property bool showKeyboardButton: true
42 property string jsonVisibleProfiles: "[]"44 property string jsonVisibleProfiles: "[]"
43 }45 }
4446

Subscribers

People subscribed via source and target branches