Merge lp:~mc-return/nux/nux.merge-fix-deprecated-warnings into lp:nux
Status: | Work in progress | ||||
---|---|---|---|---|---|
Proposed branch: | lp:~mc-return/nux/nux.merge-fix-deprecated-warnings | ||||
Merge into: | lp:nux | ||||
Diff against target: |
26 lines (+2/-7) 1 file modified
Nux/MainLoopGLib.cpp (+2/-7) |
||||
To merge this branch: | bzr merge lp:~mc-return/nux/nux.merge-fix-deprecated-warnings | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Unity Team | Pending | ||
Review via email: mp+122408@code.launchpad.net |
Commit message
Fixed [-Wdeprecated-
Description of the change
Fixes [-Wdeprecated-
Unmerged revisions
- 656. By MC Return
-
Removed the static bool gthread_initialized
- 655. By MC Return
-
Fixed indentation
- 654. By MC Return
-
Hopefully fixed deprecated g_source_
get_current_ time correctly this time - 653. By MC Return
-
Hopefully fixed g_source_get_time
- 652. By MC Return
-
Fixed [-Wdeprecated-
declarations] warnings in MainLoopGLib.cpp and replaced 'void g_source_ get_current_ time(GSource* , GTimeVal*)' with 'void g_source_ get_time( GSource* , GTimeVal*)' and 'g_thread_init (NULL);' with 'g_type_init();'
Looks good to me. However, g_type_init() does not have the same semantics as g_thread_ init(NULL) , you *always* have to call it exactly once. So I suggest to drop the "static bool gthread_ initialized" bit as well. Does your configure.ac ensure you require at least glib 2.24 for this?