Merge lp:~mbp/udd/877827-blacklist into lp:udd

Proposed by Martin Pool
Status: Merged
Approved by: James Westby
Approved revision: 564
Merged at revision: 563
Proposed branch: lp:~mbp/udd/877827-blacklist
Merge into: lp:udd
Diff against target: 45 lines (+15/-0)
3 files modified
pkgimport.conf (+5/-0)
udd/iconfig.py (+5/-0)
udd/scripts/import_package.py (+5/-0)
To merge this branch: bzr merge lp:~mbp/udd/877827-blacklist
Reviewer Review Type Date Requested Status
James Westby Approve
Review via email: mp+88348@code.launchpad.net

Description of the change

This addresses bug 877827 by just giving a means to disable importing packages from particular distroseries. Obviously we don't want to do that too much, but in this case where the history is nonmonotonic, it's probably reasonable.

To post a comment you must log in.
Revision history for this message
James Westby (james-w) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'pkgimport.conf'
--- pkgimport.conf 2011-12-15 17:58:06 +0000
+++ pkgimport.conf 2012-01-12 11:23:27 +0000
@@ -11,3 +11,8 @@
11[nexuiz-data]11[nexuiz-data]
12# More than 24h is necessary, let's try 3 days12# More than 24h is necessary, let's try 3 days
13pi.max_duration=25920013pi.max_duration=259200
14
15[openldap]
16# Version numbers stepped backwards; let's just not import the old ones.
17# See https://bugs.launchpad.net/udd/+bug/877827
18pi.blacklist_distro_releases = woody
1419
=== modified file 'udd/iconfig.py'
--- udd/iconfig.py 2012-01-11 14:54:26 +0000
+++ udd/iconfig.py 2012-01-12 11:23:27 +0000
@@ -195,6 +195,11 @@
195register_option('pi.ubuntu_merges_dir', default='{pi.www_dir}/merges',195register_option('pi.ubuntu_merges_dir', default='{pi.www_dir}/merges',
196 help='Merges against Ubuntu versions.')196 help='Merges against Ubuntu versions.')
197197
198config.option_registry.register(
199 config.ListOption(
200 'pi.blacklist_distro_releases',
201 default=[],
202 help='Do not import from these distribution releases'))
198203
199# Used by categorize_failures.py:204# Used by categorize_failures.py:
200register_option('pi.web_status_dir', default = '{pi.www_dir}/status',205register_option('pi.web_status_dir', default = '{pi.www_dir}/status',
201206
=== modified file 'udd/scripts/import_package.py'
--- udd/scripts/import_package.py 2011-12-12 10:41:06 +0000
+++ udd/scripts/import_package.py 2012-01-12 11:23:27 +0000
@@ -657,7 +657,12 @@
657 imported_suites = set()657 imported_suites = set()
658 have_imported_old_debian = False658 have_imported_old_debian = False
659 last_target_info = None659 last_target_info = None
660 config = iconfig.PackageStack(name, possible_transports)
660 for importp in reversed(all_versions.plist):661 for importp in reversed(all_versions.plist):
662 if importp.release in config.get('pi.blacklist_distro_releases'):
663 trace.mutter('%s %s is blacklisted; skipping it' %
664 (name, importp.release))
665 continue
661 suite = icommon.make_suite(importp.release, importp.pocket)666 suite = icommon.make_suite(importp.release, importp.pocket)
662 if (importp.distro, suite) in imported_suites:667 if (importp.distro, suite) in imported_suites:
663 continue668 continue

Subscribers

People subscribed via source and target branches