Merge lp:~martin-borho/ubuntu-weather-app/toolbar-fix into lp:ubuntu-weather-app/obsolete.trunk

Proposed by Martin Borho
Status: Merged
Approved by: Michael Hall
Approved revision: 43
Merged at revision: 42
Proposed branch: lp:~martin-borho/ubuntu-weather-app/toolbar-fix
Merge into: lp:ubuntu-weather-app/obsolete.trunk
Diff against target: 16 lines (+4/-2)
1 file modified
components/AddLocationPage.qml (+4/-2)
To merge this branch: bzr merge lp:~martin-borho/ubuntu-weather-app/toolbar-fix
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Michael Hall Approve
Raúl Yeguas Approve
Review via email: mp+169814@code.launchpad.net

Commit message

Fix for Bug #1191808

Description of the change

fix for Bug #1191808

No device to test at the moment, SDK on raring says: "ToolbarActions.active property is DEPRECATED. Use opened instead."

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michael Hall (mhall119) wrote :

Looks good to me

review: Approve
Revision history for this message
Michael Hall (mhall119) wrote :

Looks good to me

review: Approve
Revision history for this message
Michael Hall (mhall119) wrote :

file:///home/mhall/projects/Ubuntu/sdk/pure-qml/ubuntu-weather-app/ubuntu-weather-app.qml:98 Type Components.AddLocationPage unavailable
file:///home/mhall/projects/Ubuntu/sdk/pure-qml/ubuntu-weather-app/components/AddLocationPage.qml:12 Cannot assign to non-existent property "active"

review: Needs Fixing
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Raúl Yeguas (neokore) wrote :

Fixed, good work Martin!

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Michael Hall (mhall119) wrote :

Works now

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'components/AddLocationPage.qml'
--- components/AddLocationPage.qml 2013-06-12 16:41:07 +0000
+++ components/AddLocationPage.qml 2013-06-17 15:25:34 +0000
@@ -7,8 +7,10 @@
7 objectName: "AddLocationrPage"7 objectName: "AddLocationrPage"
8 title: i18n.tr("Add city")8 title: i18n.tr("Add city")
9 visible: false9 visible: false
10 tools.locked: true10 tools: ToolbarActions{
11 tools.opened: true11 locked: true
12 opened: true
13 }
1214
13 WorkerScript {15 WorkerScript {
14 id: searchWorker16 id: searchWorker

Subscribers

People subscribed via source and target branches