Merge lp:~mardy/account-plugins/facebook-http into lp:account-plugins/12.10

Proposed by Alberto Mardegan
Status: Merged
Approved by: David King
Approved revision: 76
Merge reported by: Alberto Mardegan
Merged at revision: not available
Proposed branch: lp:~mardy/account-plugins/facebook-http
Merge into: lp:account-plugins/12.10
Diff against target: 20 lines (+10/-0)
1 file modified
src/facebook.vala (+10/-0)
To merge this branch: bzr merge lp:~mardy/account-plugins/facebook-http
Reviewer Review Type Date Requested Status
David King (community) Approve
Review via email: mp+150272@code.launchpad.net

Commit message

Allow Facebook authentication to happen via plain HTTP

For some reason, now Facebook redirects to a plain HTTP page:
http://developers.facebook.com/bugs/427626840651838

Description of the change

Allow Facebook authentication to happen via plain HTTP

For some reason, now Facebook redirects to a plain HTTP page:
http://developers.facebook.com/bugs/427626840651838

To post a comment you must log in.
Revision history for this message
David King (amigadave) wrote :

Sigh, I guess we have to do this. :-(

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/facebook.vala'
--- src/facebook.vala 2012-11-12 11:24:22 +0000
+++ src/facebook.vala 2013-02-25 07:27:22 +0000
@@ -42,6 +42,16 @@
42 "xmpp_login"42 "xmpp_login"
43 };43 };
44 oauth_params.insert ("Scope", scopes);44 oauth_params.insert ("Scope", scopes);
45
46 /* We must allow http as well:
47 * http://developers.facebook.com/bugs/427626840651838
48 */
49 string[] schemes = {
50 "https",
51 "http"
52 };
53 oauth_params.insert ("AllowedSchemes", schemes);
54
45 set_oauth_parameters (oauth_params);55 set_oauth_parameters (oauth_params);
46 }56 }
47}57}

Subscribers

People subscribed via source and target branches