Merge lp:~marcoceppi/pyjuju/ssh-key-opt into lp:pyjuju
Proposed by
Marco Ceppi
Status: | Needs review |
---|---|
Proposed branch: | lp:~marcoceppi/pyjuju/ssh-key-opt |
Merge into: | lp:pyjuju |
Diff against target: |
220 lines (+76/-12) 5 files modified
juju/control/__init__.py (+11/-4) juju/providers/common/tests/test_utils.py (+29/-0) juju/providers/common/utils.py (+17/-2) juju/state/sshclient.py (+10/-2) juju/state/tests/test_sshclient.py (+9/-4) |
To merge this branch: | bzr merge lp:~marcoceppi/pyjuju/ssh-key-opt |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Clint Byrum (community) | Needs Fixing | ||
Review via email: mp+125714@code.launchpad.net |
Description of the change
Allow for public and private key setting (depending on the nature of the subcommand) to be set via the command line and the -i --identitiy-file opt.
This also adds a generalized "create_parser" method to allow for buried, deep down methods to access command line options.
To post a comment you must log in.
Unmerged revisions
- 585. By Marco Ceppi
-
Remove ~ from 'args' for common provider test
- 584. By Marco Ceppi
-
Now with unit tests and code coverage
- 583. By Marco Ceppi
-
sshclient doesn't need argparse anymore
- 582. By Marco Ceppi
-
Allow uses to specify which 'public-key' to bootstrap with, -i overrides config options
- 581. By Marco Ceppi
-
Make create_parser method and use that instead of defining it each time
- 580. By Marco Ceppi
-
Allow for passing ssh private keys via -i flag
- 579. By Marco Ceppi
-
Added -i flag
making the provider code depend on sys.argv is quite odd. what's the goal/value add?