Merge lp:~lool/qtpowerd/misc-fixes into lp:~music-app-dev/qtpowerd/trunk
Status: | Merged |
---|---|
Merged at revision: | 5 |
Proposed branch: | lp:~lool/qtpowerd/misc-fixes |
Merge into: | lp:~music-app-dev/qtpowerd/trunk |
Diff against target: |
233 lines (+83/-47) 7 files modified
QtPowerd.cpp (+50/-23) QtPowerd.h (+12/-7) debian/changelog (+6/-0) plugin.cpp (+6/-6) plugin.h (+3/-4) qmldir (+2/-3) qtpowerd.pro (+4/-4) |
To merge this branch: | bzr merge lp:~lool/qtpowerd/misc-fixes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
David Planella | Needs Information | ||
Review via email: mp+188718@code.launchpad.net |
Commit message
Misc fixes allowing qtpowerd to function with music-app.
Description of the change
Hi there,
Misc fixes in here, but more importantly this fixes the requestSysState() and clearSysState() so that it basically works.
On the long run, I think we ought to:
* never use this from apps since some backgrond music service should do it for them
* allow for multiple locks or various types, even if apps should not take them most of the time, sometimes it makes sense; there are other reasons for bindings such as tracking display state changes (as unity8 Shell does)
* allow naming the locks (currently qtpowerd hardcodes "music-
* move this to powerd itself to provide; this would allow using the header
However I think this is good enough for music-app for 13.10 :-)
I might try to fix some of the other bits there if time allow.
I also wonder if the name Powerd 0.1 might break unity8's Powerd 0.1 plugin.
So indeed this clashed with Unity8 Shell's powerd plugin; fixed in r17/r18.