Notify OSD

Merge lp:~larsu/notify-osd/ignore-body-for-sync-bubbles into lp:notify-osd

  1. ignore-body-for-sync-bubbles
  2. Merge into trunk
Proposed by Lars Karlitski
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 497
Merged at revision: 500
Proposed branch: lp:~larsu/notify-osd/ignore-body-for-sync-bubbles
Merge into: lp:notify-osd
Diff against target: 11 lines (+0/-1)
1 file modified
src/bubble.c (+0/-1)
To merge this branch: bzr merge lp:~larsu/notify-osd/ignore-body-for-sync-bubbles
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+277855@code.launchpad.net

Commit message

Ignore body for synchronous notifications

It doesn't make sense to not show the notification at all when a body is set. Instead, simply ignore the body.

Description of the change

Ignore body for synchronous notifications

It doesn't make sense to not show the notification at all when a body is set. Instead, simply ignore the body.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Looks fine to me and fixes the issue, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/bubble.c'
--- src/bubble.c 2015-10-12 13:56:53 +0000
+++ src/bubble.c 2015-11-18 15:36:07 +0000
@@ -3715,7 +3715,6 @@
3715 /* icon + indicator layout-case, e.g. volume */3715 /* icon + indicator layout-case, e.g. volume */
3716 if ((priv->icon_pixbuf != NULL) &&3716 if ((priv->icon_pixbuf != NULL) &&
3717 (priv->title->len != 0) &&3717 (priv->title->len != 0) &&
3718 (priv->message_body->len == 0) &&
3719 (priv->value >= -1))3718 (priv->value >= -1))
3720 {3719 {
3721 priv->layout = LAYOUT_ICON_INDICATOR;3720 priv->layout = LAYOUT_ICON_INDICATOR;

Subscribers

People subscribed via source and target branches