Merge lp:~larsu/indicator-messages/lp956147 into lp:indicator-messages/0.3

Proposed by Lars Karlitski
Status: Merged
Approved by: Charles Kerr
Approved revision: 264
Merged at revision: 265
Proposed branch: lp:~larsu/indicator-messages/lp956147
Merge into: lp:indicator-messages/0.3
Diff against target: 21 lines (+3/-0)
1 file modified
src/messages-service.c (+3/-0)
To merge this branch: bzr merge lp:~larsu/indicator-messages/lp956147
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
Review via email: mp+100836@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Charles Kerr (charlesk) wrote :

I agree with you that this isn't a perfect patch, but doing things right would take more time than we have right now. It's better to put in this quick fix than to ship with the "broken" icons.

Considering the tradeoffs, this is the right fix for 12.04.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/messages-service.c'
--- src/messages-service.c 2012-04-04 14:48:53 +0000
+++ src/messages-service.c 2012-04-04 17:09:26 +0000
@@ -29,6 +29,7 @@
29#include <libindicator/indicator-service.h>29#include <libindicator/indicator-service.h>
30#include <gio/gio.h>30#include <gio/gio.h>
31#include <glib/gi18n.h>31#include <glib/gi18n.h>
32#include <gtk/gtk.h>
3233
33#include <libdbusmenu-glib/client.h>34#include <libdbusmenu-glib/client.h>
34#include <libdbusmenu-glib/server.h>35#include <libdbusmenu-glib/server.h>
@@ -664,7 +665,9 @@
664 g_debug("Application Shortcut added: %s", mi != NULL ? dbusmenu_menuitem_property_get(mi, DBUSMENU_MENUITEM_PROP_LABEL) : "none");665 g_debug("Application Shortcut added: %s", mi != NULL ? dbusmenu_menuitem_property_get(mi, DBUSMENU_MENUITEM_PROP_LABEL) : "none");
665 DbusmenuMenuitem * shell = DBUSMENU_MENUITEM(data);666 DbusmenuMenuitem * shell = DBUSMENU_MENUITEM(data);
666 if (mi != NULL) {667 if (mi != NULL) {
668#if GTK_CHECK_VERSION(3, 0, 0)
667 dbusmenu_menuitem_property_set (mi, DBUSMENU_MENUITEM_PROP_ICON_NAME, "");669 dbusmenu_menuitem_property_set (mi, DBUSMENU_MENUITEM_PROP_ICON_NAME, "");
670#endif
668 dbusmenu_menuitem_child_append(shell, mi);671 dbusmenu_menuitem_child_append(shell, mi);
669 }672 }
670 resort_menu(shell);673 resort_menu(shell);

Subscribers

People subscribed via source and target branches