Merge lp:~larsu/ido/revert-slider into lp:ido/13.10

Proposed by Lars Karlitski
Status: Merged
Approved by: Ted Gould
Approved revision: 147
Merged at revision: 147
Proposed branch: lp:~larsu/ido/revert-slider
Merge into: lp:ido/13.10
Diff against target: 22 lines (+4/-1)
1 file modified
src/idoscalemenuitem.c (+4/-1)
To merge this branch: bzr merge lp:~larsu/ido/revert-slider
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+185680@code.launchpad.net

Commit message

Reverse slider movement when scrolling by default

Description of the change

Revert slider movement when scrolling by default

This makes scroll direction for sliders in ido behave more like the expectation of most users (anecdotally), like it does for the sound indicator itself, and like the sliders in the sound panel.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ted Gould (ted) wrote :

Works. My argument would be that you should be able to use the scroll wheel the same on the slider as the icon. This makes them match up, which seems logical.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/idoscalemenuitem.c'
--- src/idoscalemenuitem.c 2013-07-03 02:13:03 +0000
+++ src/idoscalemenuitem.c 2013-09-15 18:27:00 +0000
@@ -307,7 +307,7 @@
307 g_param_spec_boolean ("reverse-scroll-events",307 g_param_spec_boolean ("reverse-scroll-events",
308 "Reverse scroll events",308 "Reverse scroll events",
309 "Reverses how up/down scroll events are interpreted",309 "Reverses how up/down scroll events are interpreted",
310 FALSE,310 TRUE,
311 G_PARAM_READWRITE));311 G_PARAM_READWRITE));
312312
313 /**313 /**
@@ -411,6 +411,9 @@
411static void411static void
412ido_scale_menu_item_init (IdoScaleMenuItem *self)412ido_scale_menu_item_init (IdoScaleMenuItem *self)
413{413{
414 IdoScaleMenuItemPrivate *priv = GET_PRIVATE (self);
415
416 priv->reverse_scroll = TRUE;
414}417}
415418
416static void419static void

Subscribers

People subscribed via source and target branches