Merge lp:~kroq-gar78/ubuntu/precise/mod-proxy-html/fix-1005425 into lp:ubuntu/precise/mod-proxy-html

Proposed by Aditya V
Status: Work in progress
Proposed branch: lp:~kroq-gar78/ubuntu/precise/mod-proxy-html/fix-1005425
Merge into: lp:ubuntu/precise/mod-proxy-html
Diff against target: 40 lines (+16/-5)
2 files modified
debian/changelog (+8/-0)
debian/postinst (+8/-5)
To merge this branch: bzr merge lp:~kroq-gar78/ubuntu/precise/mod-proxy-html/fix-1005425
Reviewer Review Type Date Requested Status
James Page Needs Fixing
Andrew Starr-Bochicchio (community) Needs Fixing
Ubuntu branches Pending
Review via email: mp+109766@code.launchpad.net

Description of the change

I fixed the path of libxml.so.2 by using the debian/postinst script.

To post a comment you must log in.
Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

As in the other merge request: I'm not sure we need to be using sed for this. Could you look at version 3.0.1-1.1 from Debian which is now in quantal?

It seems to fix this with:

diff -u mod-proxy-html-3.0.1/debian/conf/proxy_html.load mod-proxy-html-3.0.1/debian/conf/proxy_html.load
--- mod-proxy-html-3.0.1/debian/conf/proxy_html.load
+++ mod-proxy-html-3.0.1/debian/conf/proxy_html.load
@@ -1,2 +1,2 @@
-LoadFile /usr/lib/libxml2.so.2
+LoadFile libxml2.so.2
 LoadModule proxy_html_module /usr/lib/apache2/modules/mod_proxy_html.so

Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) :
review: Needs Fixing
Revision history for this message
James Page (james-page) wrote :

Andrew is correct but please see bug 988819 - this includes an apache2 change to make apache use dlopen as a fallback so that the .so file can be specificied without a full path.

Its currently in -proposed awaiting verification.

review: Needs Fixing

Unmerged revisions

8. By Aditya V

debian/postinst: use 'uname' instead of 'dpkg-architecture' for path configuration

7. By Aditya V

debian/postinst: replace the path for libxml2.so.2 in field
'LoadFile' in file 'debian/conf/proxy_html.load' with the multiarch-
friendly path using sed (LP: #1005425)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2008-08-20 12:06:58 +0000
+++ debian/changelog 2012-06-12 02:49:19 +0000
@@ -1,3 +1,11 @@
1mod-proxy-html (3.0.1-1ubuntu1) precise; urgency=low
2
3 * debian/postinst: replace the path for libxml2.so.2 in field
4 'LoadFile' in file 'debian/conf/proxy_html.load' with the multiarch-
5 friendly path using sed (LP: #1005425)
6
7 -- Aditya Vaidya <kroq.gar78@gmail.com> Mon, 28 May 2012 22:28:41 -0500
8
1mod-proxy-html (3.0.1-1) unstable; urgency=low9mod-proxy-html (3.0.1-1) unstable; urgency=low
210
3 * New upstream release11 * New upstream release
412
=== modified file 'debian/postinst'
--- debian/postinst 2007-10-16 11:38:11 +0000
+++ debian/postinst 2012-06-12 02:49:19 +0000
@@ -40,12 +40,15 @@
40 reload_apache40 reload_apache
41 fi41 fi
42 else 42 else
43 # Enable the module43 # Enable the module
44 if [ -e /etc/apache2/apache2.conf ]; then44 if [ -e /etc/apache2/apache2.conf ]; then
45 a2enmod proxy_html >/dev/null || true45 a2enmod proxy_html >/dev/null || true
46 reload_apache46 reload_apache
47 fi
47 fi48 fi
48 fi49
50 # Use multiarch-friendly paths for libxml.so.2 in proxy_html.load
51 sed -i "s/\/usr\/lib\/libxml2.so.2/\/usr\/lib\/`uname -i`-linux-gnu\/libxml2.so.2/g" /etc/apache2/mods-available/proxy_html.load
49 ;;52 ;;
5053
51 abort-upgrade|abort-remove|abort-deconfigure)54 abort-upgrade|abort-remove|abort-deconfigure)

Subscribers

People subscribed via source and target branches

to all changes: