Merge lp:~kirkland/upstart/no-scold into lp:ubuntu/raring/upstart

Proposed by Dustin Kirkland 
Status: Needs review
Proposed branch: lp:~kirkland/upstart/no-scold
Merge into: lp:ubuntu/raring/upstart
Diff against target: 67 lines (+9/-16)
2 files modified
debian/changelog (+9/-0)
debian/upstart-job (+0/-16)
To merge this branch: bzr merge lp:~kirkland/upstart/no-scold
Reviewer Review Type Date Requested Status
James Hunt Pending
Review via email: mp+148816@code.launchpad.net
To post a comment you must log in.

Unmerged revisions

1423. By Dustin Kirkland 

* debian/upstart-job:
  - there's really no need to scold users when they use /etc/init.d/*
    to start/stop/restart/status services

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2013-01-22 15:54:03 +0000
+++ debian/changelog 2013-02-15 20:48:25 +0000
@@ -1,3 +1,12 @@
1upstart (1.6.1-1ubuntu3) UNRELEASED; urgency=low
2
3 [ Dustin Kirkland ]
4 * debian/upstart-job:
5 - there's really no need to scold users when they use /etc/init.d/*
6 to start/stop/restart/status services
7
8 -- Dustin Kirkland <kirkland@ubuntu.com> Fri, 15 Feb 2013 14:39:00 -0600
9
1upstart (1.6.1-1ubuntu2) raring; urgency=low10upstart (1.6.1-1ubuntu2) raring; urgency=low
211
3 [ Stéphane Graber ]12 [ Stéphane Graber ]
413
=== modified file 'debian/upstart-job'
--- debian/upstart-job 2012-11-26 10:38:23 +0000
+++ debian/upstart-job 2013-02-15 20:48:25 +0000
@@ -38,9 +38,6 @@
38 ECHO_ERROR=:38 ECHO_ERROR=:
39fi39fi
4040
41$ECHO "Rather than invoking init scripts through /etc/init.d, use the service(8)"
42$ECHO "utility, e.g. service $INITSCRIPT $COMMAND"
43
44# Only check if jobs are disabled if the currently _running_ version of41# Only check if jobs are disabled if the currently _running_ version of
45# Upstart (which may be older than the latest _installed_ version)42# Upstart (which may be older than the latest _installed_ version)
46# supports such a query.43# supports such a query.
@@ -64,15 +61,9 @@
6461
65case $COMMAND in62case $COMMAND in
66status)63status)
67 $ECHO
68 $ECHO "Since the script you are attempting to invoke has been converted to an"
69 $ECHO "Upstart job, you may also use the $COMMAND(8) utility, e.g. $COMMAND $JOB"
70 $COMMAND "$JOB"64 $COMMAND "$JOB"
71 ;;65 ;;
72start|stop)66start|stop)
73 $ECHO
74 $ECHO "Since the script you are attempting to invoke has been converted to an"
75 $ECHO "Upstart job, you may also use the $COMMAND(8) utility, e.g. $COMMAND $JOB"
76 if status "$JOB" 2>/dev/null | grep -q ' start/'; then67 if status "$JOB" 2>/dev/null | grep -q ' start/'; then
77 RUNNING=168 RUNNING=1
78 fi69 fi
@@ -86,10 +77,6 @@
86 $COMMAND "$JOB"77 $COMMAND "$JOB"
87 ;;78 ;;
88restart)79restart)
89 $ECHO
90 $ECHO "Since the script you are attempting to invoke has been converted to an"
91 $ECHO "Upstart job, you may also use the stop(8) and then start(8) utilities,"
92 $ECHO "e.g. stop $JOB ; start $JOB. The restart(8) utility is also available."
93 if status "$JOB" 2>/dev/null | grep -q ' start/'; then80 if status "$JOB" 2>/dev/null | grep -q ' start/'; then
94 RUNNING=181 RUNNING=1
95 fi82 fi
@@ -106,9 +93,6 @@
106 start "$JOB"93 start "$JOB"
107 ;;94 ;;
108reload|force-reload)95reload|force-reload)
109 $ECHO
110 $ECHO "Since the script you are attempting to invoke has been converted to an"
111 $ECHO "Upstart job, you may also use the reload(8) utility, e.g. reload $JOB"
112 reload "$JOB"96 reload "$JOB"
113 ;;97 ;;
114*)98*)

Subscribers

People subscribed via source and target branches