Merge lp:~ken-vandine/unity-lens-friends/ftbfs_intltool into lp:unity-lens-friends

Proposed by Ken VanDine
Status: Merged
Approved by: Robert Bruce Park
Approved revision: 70
Merged at revision: 71
Proposed branch: lp:~ken-vandine/unity-lens-friends/ftbfs_intltool
Merge into: lp:unity-lens-friends
Diff against target: 105 lines (+40/-9)
5 files modified
Makefile.am (+2/-0)
autogen.sh (+33/-5)
configure.ac (+3/-4)
debian/control (+1/-0)
debian/rules (+1/-0)
To merge this branch: bzr merge lp:~ken-vandine/unity-lens-friends/ftbfs_intltool
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Robert Bruce Park Approve
Review via email: mp+193633@code.launchpad.net

Commit message

Fixed FTBFS with gnome-common 3.10, you can't use both IT_PROG_INTLTOOL and
AM_GNU_GETTEXT. Also cleaned up some automake depreciations.

Specify intltool version dependency in debian/control.

Description of the change

Fixed FTBFS with gnome-common 3.10, you can't use both IT_PROG_INTLTOOL and
AM_GNU_GETTEXT. Also cleaned up some automake depreciations.

Specify intltool version dependency in debian/control.

To post a comment you must log in.
Revision history for this message
Robert Bruce Park (robru) wrote :

lgtm, just waiting for jenkins.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Makefile.am'
--- Makefile.am 2012-10-17 20:13:50 +0000
+++ Makefile.am 2013-11-01 17:02:18 +0000
@@ -1,1 +1,3 @@
1ACLOCAL_AMFLAGS = -I m4
2
1SUBDIRS = src data po3SUBDIRS = src data po
24
=== modified file 'autogen.sh'
--- autogen.sh 2012-10-16 04:41:52 +0000
+++ autogen.sh 2013-11-01 17:02:18 +0000
@@ -1,11 +1,39 @@
1#!/bin/sh1#!/bin/sh
2# Run this to generate all the initial makefiles, etc.
3
4srcdir=`dirname $0`
5test -z "$srcdir" && srcdir=.
26
3PKG_NAME="unity-lens-friends"7PKG_NAME="unity-lens-friends"
48
5which gnome-autogen.sh || {9(test -f $srcdir/configure.ac \
6 echo "You need gnome-common from GNOME SVN"10 && test -f $srcdir/autogen.sh) || {
7 exit 111 echo -n "**Error**: Directory \`$srcdir' does not look like the"
12 echo " top-level $PKG_NAME directory"
13 exit 1
8}14}
915
10USE_GNOME2_MACROS=1 \16if which gnome-autogen.sh ; then
11. gnome-autogen.sh17 REQUIRED_AUTOMAKE_VERSION=1.9 . gnome-autogen.sh
18else
19 if which intltoolize && which gtkdocize && which autoreconf ; then
20 intltoolize --copy --force --automake || \
21 (echo "There was an error in running intltoolize." > /dev/stderr;
22 exit 1)
23 autoreconf --force --install || \
24 (echo "There was an error in running autoreconf." > /dev/stderr;
25 exit 1)
26 else
27 echo "No build script available. You have two choices:"
28 echo "1. You need to install the gnome-common module and make"
29 echo " sure the gnome-autogen.sh script is in your \$PATH."
30 echo "2. You need to install the following scripts:"
31 echo " * intltool"
32 echo " * libtool"
33 echo " * automake"
34 echo " * autoconf"
35 echo " Additionally, you need to make"
36 echo " sure that they are in your \$PATH."
37 exit 1
38 fi
39fi
1240
=== modified file 'configure.ac'
--- configure.ac 2013-07-25 03:01:50 +0000
+++ configure.ac 2013-11-01 17:02:18 +0000
@@ -1,8 +1,10 @@
1AC_PREREQ(2.65)
1AC_INIT([unity-lens-friends], 0.1)2AC_INIT([unity-lens-friends], 0.1)
2AM_INIT_AUTOMAKE3AM_INIT_AUTOMAKE
3AC_CONFIG_HEADERS([config.h])4AC_CONFIG_HEADERS([config.h])
45
5LT_INIT6LT_INIT
7AC_CONFIG_MACRO_DIR([m4])
68
7AM_PROG_VALAC([0.17])9AM_PROG_VALAC([0.17])
8AC_PROG_CC10AC_PROG_CC
@@ -16,10 +18,7 @@
16AC_DEFINE_UNQUOTED(GETTEXT_PACKAGE, "$GETTEXT_PACKAGE", [Name of the default get text domain])18AC_DEFINE_UNQUOTED(GETTEXT_PACKAGE, "$GETTEXT_PACKAGE", [Name of the default get text domain])
17localedir='$(prefix)/$(DATADIRNAME)/locale'19localedir='$(prefix)/$(DATADIRNAME)/locale'
18AC_SUBST(localedir)20AC_SUBST(localedir)
19AM_GNU_GETTEXT([external])21IT_PROG_INTLTOOL(0.50.0)
20AM_GNU_GETTEXT_VERSION([0.17])
21IT_PROG_INTLTOOL([0.40])
22
2322
24AC_DEFINE_UNQUOTED(LOCALE_DIR, "${PREFIX}/${DATADIRNAME}/locale",[Locale directory])23AC_DEFINE_UNQUOTED(LOCALE_DIR, "${PREFIX}/${DATADIRNAME}/locale",[Locale directory])
25AC_DEFINE_UNQUOTED(PKGDATADIR, "${PREFIX}/${DATADIRNAME}/${PACKAGE}", [Package data directory])24AC_DEFINE_UNQUOTED(PKGDATADIR, "${PREFIX}/${DATADIRNAME}/${PACKAGE}", [Package data directory])
2625
=== modified file 'debian/control'
--- debian/control 2013-07-11 16:59:44 +0000
+++ debian/control 2013-11-01 17:02:18 +0000
@@ -7,6 +7,7 @@
7 dh-autoreconf,7 dh-autoreconf,
8 dh-translations,8 dh-translations,
9 gnome-common,9 gnome-common,
10 intltool (>= 0.50.0),
10 libaccounts-glib-dev,11 libaccounts-glib-dev,
11 libdee-dev (>= 1.0.0),12 libdee-dev (>= 1.0.0),
12 libgee-dev,13 libgee-dev,
1314
=== modified file 'debian/rules'
--- debian/rules 2013-08-02 12:05:43 +0000
+++ debian/rules 2013-11-01 17:02:18 +0000
@@ -10,4 +10,5 @@
10 NOCONFIGURE=1 dh_autoreconf ./autogen.sh10 NOCONFIGURE=1 dh_autoreconf ./autogen.sh
1111
12override_dh_install:12override_dh_install:
13 rm -f debian/*/usr/lib/*/unity/*.la
13 dh_install --fail-missing -X.la14 dh_install --fail-missing -X.la

Subscribers

People subscribed via source and target branches

to all changes: