Merge lp:~ken-vandine/content-hub/rtm-lp1394211 into lp:content-hub/rtm-14.09

Proposed by Ken VanDine
Status: Merged
Approved by: Michael Sheldon
Approved revision: 139
Merged at revision: 142
Proposed branch: lp:~ken-vandine/content-hub/rtm-lp1394211
Merge into: lp:content-hub/rtm-14.09
Diff against target: 104 lines (+10/-8)
5 files modified
po/CMakeLists.txt (+1/-1)
src/com/ubuntu/content/detail/i18n.cpp (+1/-1)
src/com/ubuntu/content/detail/i18n.h (+1/-1)
src/com/ubuntu/content/detail/service.cpp (+5/-5)
src/com/ubuntu/content/detail/service.h (+2/-0)
To merge this branch: bzr merge lp:~ken-vandine/content-hub/rtm-lp1394211
Reviewer Review Type Date Requested Status
Michael Sheldon (community) Approve
Review via email: mp+242262@code.launchpad.net

Commit message

Fixed conflict with nih-dbus and our own i18n wrapper

Description of the change

Fixed conflict with nih-dbus and our own i18n wrapper

To post a comment you must log in.
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'po/CMakeLists.txt'
--- po/CMakeLists.txt 2014-08-14 11:49:28 +0000
+++ po/CMakeLists.txt 2014-11-19 19:53:41 +0000
@@ -20,7 +20,7 @@
20 -D ${CMAKE_SOURCE_DIR}20 -D ${CMAKE_SOURCE_DIR}
21 --from-code=UTF-821 --from-code=UTF-8
22 --c++ --qt --add-comments=TRANSLATORS22 --c++ --qt --add-comments=TRANSLATORS
23 --keyword=_23 --keyword=__
24 -j24 -j
25 --package-name=content-hub25 --package-name=content-hub
26 --copyright-holder='Canonical Ltd.'26 --copyright-holder='Canonical Ltd.'
2727
=== modified file 'src/com/ubuntu/content/detail/i18n.cpp'
--- src/com/ubuntu/content/detail/i18n.cpp 2014-05-01 17:03:40 +0000
+++ src/com/ubuntu/content/detail/i18n.cpp 2014-11-19 19:53:41 +0000
@@ -36,7 +36,7 @@
36 textdomain(domain);36 textdomain(domain);
37}37}
3838
39QString _(const char *text, const char *domain)39QString __(const char *text, const char *domain)
40{40{
41 return QString::fromUtf8(dgettext(domain, text));41 return QString::fromUtf8(dgettext(domain, text));
42}42}
4343
=== modified file 'src/com/ubuntu/content/detail/i18n.h'
--- src/com/ubuntu/content/detail/i18n.h 2014-05-01 17:03:40 +0000
+++ src/com/ubuntu/content/detail/i18n.h 2014-11-19 19:53:41 +0000
@@ -31,7 +31,7 @@
31{31{
3232
33void initTr(const char *domain, const char *localeDir);33void initTr(const char *domain, const char *localeDir);
34QString _(const char *text, const char *domain = 0);34QString __(const char *text, const char *domain = 0);
3535
36}36}
37}37}
3838
=== modified file 'src/com/ubuntu/content/detail/service.cpp'
--- src/com/ubuntu/content/detail/service.cpp 2014-08-04 17:56:09 +0000
+++ src/com/ubuntu/content/detail/service.cpp 2014-11-19 19:53:41 +0000
@@ -207,13 +207,13 @@
207 t->Charge(QVariantList());207 t->Charge(QVariantList());
208}208}
209209
210void download_notify (cucd::Transfer* t)210void cucd::Service::download_notify (cucd::Transfer* t)
211{211{
212 TRACE() << Q_FUNC_INFO;212 TRACE() << Q_FUNC_INFO;
213 notify_init(t->source().toStdString().c_str());213 notify_init(t->source().toStdString().c_str());
214 NotifyNotification* notification;214 NotifyNotification* notification;
215215
216 notification = notify_notification_new (_("Download Complete"),216 notification = notify_notification_new (__("Download Complete").toStdString().c_str(),
217 "",217 "",
218 "save");218 "save");
219219
@@ -231,14 +231,14 @@
231231
232 notify_notification_add_action (notification,232 notify_notification_add_action (notification,
233 "action_accept",233 "action_accept",
234 _("Open"),234 __("Open").toStdString().c_str(),
235 action_accept,235 action_accept,
236 t,236 t,
237 NULL);237 NULL);
238238
239 notify_notification_add_action (notification,239 notify_notification_add_action (notification,
240 "action_dismiss",240 "action_dismiss",
241 _("Dismiss"),241 __("Dismiss").toStdString().c_str(),
242 action_dismiss,242 action_dismiss,
243 t,243 t,
244 NULL);244 NULL);
@@ -256,7 +256,7 @@
256 notify_init("Download Manager");256 notify_init("Download Manager");
257 NotifyNotification* notification;257 NotifyNotification* notification;
258258
259 notification = notify_notification_new (_("Download Failed"),259 notification = notify_notification_new (__("Download Failed").toStdString().c_str(),
260 errorMessage.toStdString().c_str(),260 errorMessage.toStdString().c_str(),
261 "save");261 "save");
262262
263263
=== modified file 'src/com/ubuntu/content/detail/service.h'
--- src/com/ubuntu/content/detail/service.h 2014-08-04 17:56:09 +0000
+++ src/com/ubuntu/content/detail/service.h 2014-11-19 19:53:41 +0000
@@ -28,6 +28,7 @@
2828
29#include <com/ubuntu/applicationmanager/application_manager.h>29#include <com/ubuntu/applicationmanager/application_manager.h>
30#include "handler.h"30#include "handler.h"
31#include "transfer.h"
3132
32namespace com33namespace com
33{34{
@@ -78,6 +79,7 @@
78 void handle_exports(int);79 void handle_exports(int);
79 void handler_unregistered(const QString&);80 void handler_unregistered(const QString&);
80 QDBusObjectPath CreateTransfer(const QString&, const QString&, int, const QString&);81 QDBusObjectPath CreateTransfer(const QString&, const QString&, int, const QString&);
82 void download_notify (com::ubuntu::content::detail::Transfer*);
8183
82};84};
83}85}

Subscribers

People subscribed via source and target branches