dee

Merge lp:~kamstrup/dee/test-fixes into lp:dee

Proposed by Mikkel Kamstrup Erlandsen
Status: Rejected
Rejected by: Mikkel Kamstrup Erlandsen
Proposed branch: lp:~kamstrup/dee/test-fixes
Merge into: lp:dee
Diff against target: 75 lines (+45/-1)
2 files modified
configure.ac (+13/-0)
tests/Makefile.am (+32/-1)
To merge this branch: bzr merge lp:~kamstrup/dee/test-fixes
Reviewer Review Type Date Requested Status
Mikkel Kamstrup Erlandsen (community) Disapprove
Review via email: mp+83743@code.launchpad.net

Description of the change

Add a headless mode for the test suite. It is disabled by default, and can be enabled with --enable-headless-tests.

To post a comment you must log in.
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Rejected as this change is not necessary for Dee because it uses dbus-test-runner

review: Disapprove

Unmerged revisions

309. By Mikkel Kamstrup Erlandsen

Add a headless mode for the test suite. It is disabled by default, and can be enabled with --enable-headless-tests.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'configure.ac'
--- configure.ac 2011-11-19 22:20:23 +0000
+++ configure.ac 2011-11-29 09:43:24 +0000
@@ -141,6 +141,18 @@
141141
142AM_CONDITIONAL(ENABLE_TRACE_LOG, test "$enable_trace_log" = "yes")142AM_CONDITIONAL(ENABLE_TRACE_LOG, test "$enable_trace_log" = "yes")
143143
144dnl Headless tests ============================================================
145AC_ARG_ENABLE([headless-tests],
146 AS_HELP_STRING([--enable-headless-tests=@<:@no/yes@:>@],[enable headless test suite (requires Xvfb) @<:@default=no@:>@]),,
147 [enable_headless_tests=no])
148
149AM_CONDITIONAL([ENABLE_HEADLESS_TESTS],[test "x$enable_headless_tests" != "xno"])
150
151if test "x$enable_headless_tests" = "xyes"; then
152 AC_PATH_PROG([XVFB],[Xvfb])
153 AC_PATH_PROG([DBUS_LAUNCH],[dbus-launch])
154fi
155
144dnl ===========================================================================156dnl ===========================================================================
145157
146AC_PATH_PROG(GLIB_MKENUMS, glib-mkenums)158AC_PATH_PROG(GLIB_MKENUMS, glib-mkenums)
@@ -185,6 +197,7 @@
185197
186 Tests : ${enable_tests}198 Tests : ${enable_tests}
187 Extended Tests : ${enable_extended_tests}199 Extended Tests : ${enable_extended_tests}
200 Headless tests : ${enable_headless_tests}
188 Verbose logging: ${enable_trace_log}201 Verbose logging: ${enable_trace_log}
189202
190 Extra CFlags : ${CPPFLAGS} $MAINTAINER_CFLAGS203 Extra CFlags : ${CPPFLAGS} $MAINTAINER_CFLAGS
191204
=== modified file 'tests/Makefile.am'
--- tests/Makefile.am 2011-08-31 19:29:04 +0000
+++ tests/Makefile.am 2011-11-29 09:43:24 +0000
@@ -122,8 +122,39 @@
122 > test-dee-results.html ) \122 > test-dee-results.html ) \
123 && ( xdg-open test-dee-results.html )123 && ( xdg-open test-dee-results.html )
124124
125#run make test as part of make check125# Run tests as part of make check
126if ENABLE_HEADLESS_TESTS
127check-local: test-headless
128else
126check-local: test129check-local: test
130endif
127131
128clean-generic:132clean-generic:
129 rm -rf test-dee-results.xml test-dee-results.html dee-test-resource-manager133 rm -rf test-dee-results.xml test-dee-results.html dee-test-resource-manager
134
135# START HEADLESS TESTS
136if ENABLE_HEADLESS_TESTS
137DISPLAY = :27
138LOG_PATH = headless-logs
139test-headless:
140 set -e; \
141 export DISPLAY=$(DISPLAY); \
142 rm -rf $(LOG_PATH); \
143 mkdir $(LOG_PATH); \
144 $(XVFB) $(DISPLAY) -screen 0 1024x768x8 > $(LOG_PATH)/Xvfb.out 2>&1 & \
145 sleep 1; \
146 \
147 $(DBUS_LAUNCH) > $(LOG_PATH)/sessionbus.sh; \
148 source $(LOG_PATH)/sessionbus.sh; \
149 sleep 1; \
150 \
151 make test; \
152 sleep 1; \
153 \
154 kill `grep DBUS_SESSION_BUS_PID $(LOG_PATH)/sessionbus.sh | grep -oE '[0-9]+'`; \
155 pkill Xvfb;
156
157endif
158# END HEADLESS TESTS
159
160

Subscribers

People subscribed via source and target branches