Merge lp:~jsjgruber/ubuntu/natty/lernid/lernid.fix716937.fix727232 into lp:ubuntu/natty/lernid

Proposed by John S. Gruber
Status: Merged
Merged at revision: 3
Proposed branch: lp:~jsjgruber/ubuntu/natty/lernid/lernid.fix716937.fix727232
Merge into: lp:ubuntu/natty/lernid
Diff against target: 61 lines (+14/-5)
4 files modified
debian/changelog (+8/-0)
debian/control (+2/-1)
lernid/widgets/Classroom.py (+2/-2)
lernid/widgets/NativeChatroom.py (+2/-2)
To merge this branch: bzr merge lp:~jsjgruber/ubuntu/natty/lernid/lernid.fix716937.fix727232
Reviewer Review Type Date Requested Status
Luke Yelavich (community) Approve
Ubuntu branches Pending
Review via email: mp+55755@code.launchpad.net

Description of the change

Fix lp: 716937 -- text tag color setting, and lp: 727232 desktopcouch dependency

To post a comment you must log in.
Revision history for this message
Luke Yelavich (themuso) wrote :

Looks good, approved, and uploaded. I tweaked the version number, since the package is an Ubuntu native package.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2010-07-31 08:42:13 +0000
+++ debian/changelog 2011-03-31 14:05:49 +0000
@@ -1,3 +1,11 @@
1lernid (0.7ubuntu1) natty; urgency=low
2
3 * Fix Significant bugs
4 (LP: #716937) - Correct specification of text tags colors
5 (LP: #727232) - Add desktopcouch as dependency
6
7 -- John S Gruber <JohnSGruber@gmail.com> Tue, 29 Mar 2011 16:22:10 -0400
8
1lernid (0.7) maverick; urgency=low9lernid (0.7) maverick; urgency=low
210
3 * New upstream version, fixes bugs:11 * New upstream version, fixes bugs:
412
=== modified file 'debian/control'
--- debian/control 2010-07-31 08:42:13 +0000
+++ debian/control 2011-03-31 14:05:49 +0000
@@ -24,7 +24,8 @@
24 python-gobject,24 python-gobject,
25 python-vobject,25 python-vobject,
26 python-gtk2,26 python-gtk2,
27 python-poppler27 python-poppler,
28 desktopcouch
28Recommends:29Recommends:
29 telepathy-idle,30 telepathy-idle,
30 python-vte,31 python-vte,
3132
=== modified file 'lernid/widgets/Classroom.py'
--- lernid/widgets/Classroom.py 2010-07-31 08:42:13 +0000
+++ lernid/widgets/Classroom.py 2011-03-31 14:05:49 +0000
@@ -62,9 +62,9 @@
6262
63 self._buffer = self._textview.get_buffer()63 self._buffer = self._textview.get_buffer()
64 text_color = self._textview.get_style().text[gtk.STATE_INSENSITIVE]64 text_color = self._textview.get_style().text[gtk.STATE_INSENSITIVE]
65 self._buffer.create_tag('gray', foreground=text_color)65 self._buffer.create_tag('gray', foreground_gdk=text_color)
66 highlight = self._textview.get_style().bg[gtk.STATE_SELECTED]66 highlight = self._textview.get_style().bg[gtk.STATE_SELECTED]
67 self._buffer.create_tag('highlight', foreground=highlight)67 self._buffer.create_tag('highlight', foreground_gdk=highlight)
68 self._init_hyperlinks()68 self._init_hyperlinks()
6969
70 self.show_all()70 self.show_all()
7171
=== modified file 'lernid/widgets/NativeChatroom.py'
--- lernid/widgets/NativeChatroom.py 2010-07-31 08:42:13 +0000
+++ lernid/widgets/NativeChatroom.py 2011-03-31 14:05:49 +0000
@@ -58,9 +58,9 @@
5858
59 self._buffer = self._textview.get_buffer()59 self._buffer = self._textview.get_buffer()
60 text_color = self._textview.get_style().text[gtk.STATE_INSENSITIVE]60 text_color = self._textview.get_style().text[gtk.STATE_INSENSITIVE]
61 self._buffer.create_tag('gray', foreground=text_color)61 self._buffer.create_tag('gray', foreground_gdk=text_color)
62 highlight = self._textview.get_style().bg[gtk.STATE_SELECTED]62 highlight = self._textview.get_style().bg[gtk.STATE_SELECTED]
63 self._buffer.create_tag('highlight', foreground=highlight)63 self._buffer.create_tag('highlight', foreground_gdk=highlight)
6464
65 self._input = builder.get_object('input')65 self._input = builder.get_object('input')
66 self._input.connect('icon-press', self._send_text)66 self._input.connect('icon-press', self._send_text)

Subscribers

People subscribed via source and target branches