Juju Charms Collection
elasticsearch package

Merge lp:~jorge/charms/trusty/elasticsearch/remove-sets-metadata into lp:~charmers/charms/trusty/elasticsearch/trunk

  1. Trusty Tahr (14.04)
  2. remove-sets-metadata
  3. Merge into trunk
Proposed by Jorge Castro
Status: Merged
Merged at revision: 35
Proposed branch: lp:~jorge/charms/trusty/elasticsearch/remove-sets-metadata
Merge into: lp:~charmers/charms/trusty/elasticsearch/trunk
Diff against target: 11 lines (+0/-1)
1 file modified
metadata.yaml (+0/-1)
To merge this branch: bzr merge lp:~jorge/charms/trusty/elasticsearch/remove-sets-metadata
Reviewer Review Type Date Requested Status
Charles Butler (community) Approve
Whit Morriss (community) Approve
Review via email: mp+234358@code.launchpad.net

Description of the change

Remove old sets metadata to pass proof.

To post a comment you must log in.
Revision history for this message
Whit Morriss (whitmo) wrote :

LGTM +1

review: Approve
Revision history for this message
Michael Nelson (michael.nelson) wrote :

Hey Jorge and Whit. Is that old metadata? I'd thought it was new metadata for which charm proof hadn't yet been updated to handle?

Revision history for this message
Marco Ceppi (marcoceppi) wrote :

Sets is something that existed back in pyjuju days, it's not implemented by core and AFAIK won't be something core recognizes.

Revision history for this message
Charles Butler (lazypower) wrote :

+1 LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'metadata.yaml'
--- metadata.yaml 2014-06-06 06:24:31 +0000
+++ metadata.yaml 2014-09-11 18:35:50 +0000
@@ -13,7 +13,6 @@
13provides:13provides:
14 client:14 client:
15 interface: elasticsearch15 interface: elasticsearch
16 sets: [cluster-name, host, port]
17 nrpe-external-master:16 nrpe-external-master:
18 interface: nrpe-external-master17 interface: nrpe-external-master
19 scope: container18 scope: container

Subscribers

People subscribed via source and target branches