Merge lp:~jontai/openvista-gtm-integration/bug398084 into lp:openvista-gtm-integration

Proposed by Jon Tai
Status: Merged
Merged at revision: not available
Proposed branch: lp:~jontai/openvista-gtm-integration/bug398084
Merge into: lp:openvista-gtm-integration
Diff against target: None lines
To merge this branch: bzr merge lp:~jontai/openvista-gtm-integration/bug398084
Reviewer Review Type Date Requested Status
jeff.apple Approve
Review via email: mp+8604@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jon Tai (jontai) wrote :

Joel, I've made the change you suggested. Looking at the ^%ZOSV implemenations for the other platforms, I don't see any of them calling LOGOPT^XQ12, so I wonder if we should just remove this line altogether. In fact, the only place LOGOPT^XQ12 is called is in ^XQ. Thoughts?

Revision history for this message
jeff.apple (jeff-apple) :
review: Approve
76. By Jon Tai

Remove the call to LOGOPT^XQ12 entirely. None of the other ZOSV* implementations call it directly - it should already be called from XQ. Besides, we log all access in syslog, so we should be OK either way.

Revision history for this message
Jon Tai (jontai) wrote :

Joel and I discussed this and we agreed to remove the call to LOGOPT^XQ12 entirely.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'mumps/ZOSVGUX.m'
--- mumps/ZOSVGUX.m 2009-06-24 03:19:27 +0000
+++ mumps/ZOSVGUX.m 2009-07-11 07:17:26 +0000
@@ -1,4 +1,4 @@
1%ZOSV ;SFISC/AC,PUG/TOAD,HOU/DHW,MSC/JDA/JKT - View commands & special functions. ;23JUN20091%ZOSV ;SFISC/AC,PUG/TOAD,HOU/DHW,MSC/JDA/JKT - View commands & special functions. ;10JUL2009
2 ;;8.0;KERNEL;**275,MSC**;Jul 10, 19952 ;;8.0;KERNEL;**275,MSC**;Jul 10, 1995
3 ;3 ;
4ACTJ() ; # active jobs4ACTJ() ; # active jobs
@@ -54,7 +54,7 @@
54 S LOGTEXT=LOGTEXT_" logged in as "_$$GET1^DIQ(200,DUZ,.01) ; VistA user54 S LOGTEXT=LOGTEXT_" logged in as "_$$GET1^DIQ(200,DUZ,.01) ; VistA user
55 D LOG(LOGTEXT,"authpriv.info","OpenVista")55 D LOG(LOGTEXT,"authpriv.info","OpenVista")
56 I 'ISOK W "??",*7 Q56 I 'ISOK W "??",*7 Q
57 D LOGOPT^XQ12 ;keep in option audit.57 I $G(XQAUDIT) D LOGOPT^XQ12 ;keep in option audit.
58 K XMB,XMTEXT,XMY S XMB="XUPROGMODE",XMB(1)=DUZ,XMB(2)=$I D ^XMB:$L($T(^XMB)) D BYE^XUSCLEAN K ZTPAC,X,XMB58 K XMB,XMTEXT,XMY S XMB="XUPROGMODE",XMB(1)=DUZ,XMB(2)=$I D ^XMB:$L($T(^XMB)) D BYE^XUSCLEAN K ZTPAC,X,XMB
59 ;D UCI S XUCI=Y,XQZ="PRGM^ZUA[MGR]",XUSLNT=1 D DO^%XUCI59 ;D UCI S XUCI=Y,XQZ="PRGM^ZUA[MGR]",XUSLNT=1 D DO^%XUCI
60 F BREAK60 F BREAK

Subscribers

People subscribed via source and target branches