Merge lp:~jjed/software-center/spinner-fix into lp:software-center

Proposed by Jjed
Status: Merged
Merged at revision: 2219
Proposed branch: lp:~jjed/software-center/spinner-fix
Merge into: lp:software-center
Diff against target: 20 lines (+4/-0)
1 file modified
softwarecenter/ui/gtk3/panes/softwarepane.py (+4/-0)
To merge this branch: bzr merge lp:~jjed/software-center/spinner-fix
Reviewer Review Type Date Requested Status
Gary Lasker (community) Approve
Michael Vogt Pending
Review via email: mp+72966@code.launchpad.net

Description of the change

Fixes the gtk3 spinner view, making USC feel more responsive. The problem was incorrect Gtk.Notebook pagination.

To post a comment you must log in.
Revision history for this message
Gary Lasker (gary-lasker) wrote :

Thanks very much for your branch, Jacob! Looks good and I'll merge it now.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'softwarecenter/ui/gtk3/panes/softwarepane.py'
--- softwarecenter/ui/gtk3/panes/softwarepane.py 2011-08-25 18:51:39 +0000
+++ softwarecenter/ui/gtk3/panes/softwarepane.py 2011-08-25 22:14:39 +0000
@@ -211,12 +211,16 @@
211 if not "SOFTWARE_CENTER_DEBUG_TABS" in os.environ:211 if not "SOFTWARE_CENTER_DEBUG_TABS" in os.environ:
212 self.notebook.set_show_tabs(False)212 self.notebook.set_show_tabs(False)
213 self.notebook.set_show_border(False)213 self.notebook.set_show_border(False)
214 # an empty notebook, where the details view will eventually go
215 self.details_notebook = Gtk.Notebook()
216 self.details_notebook.set_show_border(False)
214 # make a spinner view to display while the applist is loading217 # make a spinner view to display while the applist is loading
215 self.spinner_view = SpinnerView()218 self.spinner_view = SpinnerView()
216 self.spinner_notebook = Gtk.Notebook()219 self.spinner_notebook = Gtk.Notebook()
217 self.spinner_notebook.set_show_tabs(False)220 self.spinner_notebook.set_show_tabs(False)
218 self.spinner_notebook.set_show_border(False)221 self.spinner_notebook.set_show_border(False)
219 self.spinner_notebook.append_page(self.notebook, None)222 self.spinner_notebook.append_page(self.notebook, None)
223 self.spinner_notebook.append_page(self.details_notebook, None)
220 self.spinner_notebook.append_page(self.spinner_view, None)224 self.spinner_notebook.append_page(self.spinner_view, None)
221 225
222 self.pack_start(self.spinner_notebook, True, True, 0)226 self.pack_start(self.spinner_notebook, True, True, 0)

Subscribers

People subscribed via source and target branches