Merge lp:~jincreator/ubuntu/precise/language-selector/korean into lp:ubuntu/precise/language-selector

Proposed by Jinkyu Yi
Status: Merged
Merged at revision: 184
Proposed branch: lp:~jincreator/ubuntu/precise/language-selector/korean
Merge into: lp:ubuntu/precise/language-selector
Diff against target: 21 lines (+1/-3)
1 file modified
data/pkg_depends (+1/-3)
To merge this branch: bzr merge lp:~jincreator/ubuntu/precise/language-selector/korean
Reviewer Review Type Date Requested Status
Martin Pitt Approve
Gunnar Hjalmarsson Approve
Sebastien Bacher Needs Information
Ubuntu branches Pending
Review via email: mp+93535@code.launchpad.net
To post a comment you must log in.
170. By Jinkyu Yi

remove nabi thus Unity can't support it

171. By Jinkyu Yi

merging

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your work, what do you mean "Unity can't support it"? do you have a bug reference?

review: Needs Information
Revision history for this message
Jinkyu Yi (jincreator) wrote :

As far as I know, Unity get Korean strings correctly from only IBus at now.
In latest Unity, it works as client of IBus(as result of fix bug ##880876).
So Unity depends on IBus and as result, Unity can't support nabi(which use XIM).

For now there is no bug report about using nabi at Unity, but I test it and notice this problem.

One more thing, does my patch need freeze exception to ship in precise?

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

As far as I can tell, the proposed changes make sense.

Jinkyu Yi: If Unity's inability to support nabi is of significance to Korean users, it would be great if you could file a bug about it.

review: Approve
Revision history for this message
Martin Pitt (pitti) wrote :

Thanks Yi, uploading.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'data/pkg_depends'
--- data/pkg_depends 2012-02-28 08:50:04 +0000
+++ data/pkg_depends 2012-03-02 15:08:31 +0000
@@ -153,8 +153,7 @@
153fn:kn::ttf-kannada-fonts153fn:kn::ttf-kannada-fonts
154fn:ko::fonts-nanum154fn:ko::fonts-nanum
155fn:ko::fonts-nanum-coding155fn:ko::fonts-nanum-coding
156fn:ko::fonts-nanum-extra156fn:ko::fonts-unfonts-core
157fn:ko::ttf-alee
158fn:lo::fonts-lao157fn:lo::fonts-lao
159fn:ml::ttf-malayalam-fonts158fn:ml::ttf-malayalam-fonts
160fn:mn::fonts-manchufont159fn:mn::fonts-manchufont
@@ -187,7 +186,6 @@
187# input methods186# input methods
188im:ja:ibus:ibus-anthy187im:ja:ibus:ibus-anthy
189im:ko:ibus:ibus-hangul188im:ko:ibus:ibus-hangul
190im:ko:ibus:nabi
191im:th:ibus:gtk-im-libthai189im:th:ibus:gtk-im-libthai
192im:vi:ibus:ibus-unikey190im:vi:ibus:ibus-unikey
193im:zh-hans:ibus:ibus-sunpinyin191im:zh-hans:ibus:ibus-sunpinyin

Subscribers

People subscribed via source and target branches

to all changes: