Merge lp:~jeremywootten/pantheon-files/fix-1659353-select-Chinese into lp:~elementary-apps/pantheon-files/trunk
Status: | Merged |
---|---|
Approved by: | Cody Garver |
Approved revision: | 2460 |
Merged at revision: | 2463 |
Proposed branch: | lp:~jeremywootten/pantheon-files/fix-1659353-select-Chinese |
Merge into: | lp:~elementary-apps/pantheon-files/trunk |
Diff against target: |
73 lines (+28/-9) 2 files modified
libwidgets/Chrome/BasicBreadcrumbsEntry.vala (+13/-4) src/View/Widgets/AbstractEditableLabel.vala (+15/-5) |
To merge this branch: | bzr merge lp:~jeremywootten/pantheon-files/fix-1659353-select-Chinese |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
elementary Apps team | Pending | ||
Review via email: mp+315755@code.launchpad.net |
Commit message
Do not trap Down and Up keys in pathbar; only exit rename with unmodified Enter
Description of the change
This branch stops the BreadcrumbsEntry trapping the unmodified down and up keys as these key is used to move down the list of choices of Chinese/Japanese characters in certain input methods.
It was also noticed that there is a problem with renaming using Chinese/Japanese input methods - pressing Enter when selecting a choice of characters causes rename to end without entering the character. It appears that the input method reacts to the character but does not trap it. To ameliorate this, the editable widget now only ends rename with unmodified Enter, allowing Ctrl-Enter to be used to enter the Chinese/Japanese character, at least when tested using the fcitx/mozc Japanese input method.