Merge lp:~jeremywootten/granite/remove-deprecated-resize-children-in-storagebar into lp:~elementary-pantheon/granite/granite

Proposed by Jeremy Wootten
Status: Merged
Approved by: Danielle Foré
Approved revision: 1038
Merged at revision: 1045
Proposed branch: lp:~jeremywootten/granite/remove-deprecated-resize-children-in-storagebar
Merge into: lp:~elementary-pantheon/granite/granite
Diff against target: 18 lines (+0/-2)
1 file modified
lib/Widgets/StorageBar.vala (+0/-2)
To merge this branch: bzr merge lp:~jeremywootten/granite/remove-deprecated-resize-children-in-storagebar
Reviewer Review Type Date Requested Status
Danielle Foré Approve
Review via email: mp+318805@code.launchpad.net

Commit message

StorageBar.vala: remove deprecated resize_children

Description of the change

This branch removes some deprecated and unnecessary lines from StorageBar.vala. These lines were causing critical terminal warnings from the PropertiesWindow in pantheon-files.

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

afaik works fine

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/Widgets/StorageBar.vala'
--- lib/Widgets/StorageBar.vala 2016-12-31 19:48:54 +0000
+++ lib/Widgets/StorageBar.vala 2017-03-02 17:07:43 +0000
@@ -79,7 +79,6 @@
7979
80 set {80 set {
81 _storage = value;81 _storage = value;
82 resize_children ();
83 update_size_description ();82 update_size_description ();
84 }83 }
85 }84 }
@@ -93,7 +92,6 @@
9392
94 set {93 set {
95 _total_usage = uint64.min (value, storage);94 _total_usage = uint64.min (value, storage);
96 resize_children ();
97 update_size_description ();95 update_size_description ();
98 }96 }
9997

Subscribers

People subscribed via source and target branches